ZooKeeper-trunk - Build # 485 - Still Failing

2019-04-18 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper-trunk/485/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2.78 KB...]
  inet6 addr: fe80::92b1:1cff:fe3a:f15e/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:1254628106 errors:0 dropped:17 overruns:0 frame:0
  TX packets:619761302 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:1388466720773 (1.3 TB)  TX bytes:553191413394 (553.1 GB)
  Interrupt:16 

eno2  Link encap:Ethernet  HWaddr 90:b1:1c:3a:f1:5f  
  BROADCAST MULTICAST  MTU:1500  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
  Interrupt:17 

loLink encap:Local Loopback  
  inet addr:127.0.0.1  Mask:255.0.0.0
  inet6 addr: ::1/128 Scope:Host
  UP LOOPBACK RUNNING  MTU:65536  Metric:1
  RX packets:3052426574 errors:0 dropped:0 overruns:0 frame:0
  TX packets:3052426574 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1 
  RX bytes:2296106484675 (2.2 TB)  TX bytes:2296106484675 (2.2 TB)

core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386407
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
6
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant clean
/tmp/jenkins6341320282218194223.sh: line 44: 
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or directory
/tmp/jenkins6341320282218194223.sh: line 21: 
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or directory
mv: cannot stat 'build/*.tar.gz': No such file or directory
mv: cannot stat 'build/*.jar': No such file or directory
mv: cannot stat 'build/test/findbugs': No such file or directory
mv: cannot stat 'build/docs/api': No such file or directory
mv: cannot stat 'build/test/logs': No such file or directory
Build Failed
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-3370) Remove SVN specific revision generation

2019-04-18 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3370:
--
Labels: pull-request-available  (was: )

> Remove SVN specific revision generation
> ---
>
> Key: ZOOKEEPER-3370
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3370
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
>  Labels: pull-request-available
>
> Continue the SVN to Git Port



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] TisonKun opened a new pull request #915: ZOOKEEPER-3370 Remove SVN specific revision generation

2019-04-18 Thread GitBox 
TisonKun opened a new pull request #915: ZOOKEEPER-3370 Remove SVN specific 
revision generation
URL: https://github.com/apache/zookeeper/pull/915
 
 
   As we don't maintain the SVN repo any more.
   
   ref 8771ffdaacb87126a485ae740558f6a288ab980b


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZOOKEEPER-3370) Remove SVN specific revision generation

2019-04-18 Thread TisonKun (JIRA) 
TisonKun created ZOOKEEPER-3370:
---

 Summary: Remove SVN specific revision generation
 Key: ZOOKEEPER-3370
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3370
 Project: ZooKeeper
  Issue Type: Improvement
  Components: build
Reporter: TisonKun
Assignee: TisonKun


Continue the SVN to Git Port



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3037) Add JvmPauseMonitor to ZooKeeper

2019-04-18 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821463#comment-16821463
 ] 

Hudson commented on ZOOKEEPER-3037:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #484 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/484/])
ZOOKEEPER-3037: Add JVMPauseMonitor (andor: rev 
e9adf6ee09ef18258653d65c851fa84c3cd1a51d)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/ServerConfigTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/JvmPauseMonitor.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/util/JvmPauseMonitorTest.java


> Add JvmPauseMonitor to ZooKeeper
> 
>
> Key: ZOOKEEPER-3037
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3037
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: contrib
>Affects Versions: 3.5.3, 3.4.12
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> After a ZK crash, or client timeout sometimes it's hard to determine from the 
> logs what happened. Knowing if ZK was responsive at the time would help a 
> lot. For example, ZK might spend a lot of time waiting on GC (there is still 
> some misconception that ZK is a storage). 
> To help detect this, HADOOP already has a great tool called JVM Pause 
> Monitor. (As the name suggest, it can be also used for monitoring, but it 
> also helps post-mortem in a lot of cases). Basically it has a daemon that 
> sleeps for one second, and if the sleep time exceeds the 1s by more than the 
> threshold (1s: INFO, 10s: WARN by default - this can be configurable in our 
> case, see below), it will alert/make a log entry. It can also monitor the 
> time GC took.
> The class implementing this is in HADOOP-common, but ZK should not depend on 
> this package. Since this is a straightforward implementation, and in the past 
> five years the few commits it had is nothing really serious, I think we could 
> just copy this class in ZooKeeper, and introduce it as a configurable 
> feature, by default it can be off.
> The class:
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
> Task:
> - Create a class in ZK (under zookeeper/server/util/) called JvmPauseMonitor. 
> - Make feature configurable, by default: OFF
> - Make sleep time and threshold time configurable
> - Update documentation
> - Add [current size of the heap OR % of heap used] in the log entry whenever 
> sleep threshold had exceeded by a lot (10s)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 484 - Failure

2019-04-18 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper-trunk/484/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 3.39 KB...]
  BROADCAST MULTICAST  MTU:1500  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
  Memory:c044-c046 

loLink encap:Local Loopback  
  inet addr:127.0.0.1  Mask:255.0.0.0
  inet6 addr: ::1/128 Scope:Host
  UP LOOPBACK RUNNING  MTU:65536  Metric:1
  RX packets:127910282 errors:0 dropped:0 overruns:0 frame:0
  TX packets:127910282 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0 
  RX bytes:109565022033 (109.5 GB)  TX bytes:109565022033 (109.5 GB)

veth9402366 Link encap:Ethernet  HWaddr c6:74:8b:96:45:e0  
  inet6 addr: fe80::c474:8bff:fe96:45e0/64 Scope:Link
  UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
  RX packets:16531 errors:0 dropped:0 overruns:0 frame:0
  TX packets:24309 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:0 
  RX bytes:1772525 (1.7 MB)  TX bytes:177567289 (177.5 MB)

core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386169
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
6
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant clean
/tmp/jenkins7560341788190910472.sh: line 44: 
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or directory
/tmp/jenkins7560341788190910472.sh: line 21: 
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or directory
mv: cannot stat 'build/*.tar.gz': No such file or directory
mv: cannot stat 'build/*.jar': No such file or directory
mv: cannot stat 'build/test/findbugs': No such file or directory
mv: cannot stat 'build/docs/api': No such file or directory
mv: cannot stat 'build/test/logs': No such file or directory
Build Failed
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
[JIRA] Updating issue ZOOKEEPER-3037
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-3037) Add JvmPauseMonitor to ZooKeeper

2019-04-18 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821415#comment-16821415
 ] 

Hudson commented on ZOOKEEPER-3037:
---

FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #318 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/318/])
ZOOKEEPER-3037: Add JVMPauseMonitor (andor: rev 
e9adf6ee09ef18258653d65c851fa84c3cd1a51d)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/util/JvmPauseMonitorTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/JvmPauseMonitor.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/ServerConfigTest.java


> Add JvmPauseMonitor to ZooKeeper
> 
>
> Key: ZOOKEEPER-3037
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3037
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: contrib
>Affects Versions: 3.5.3, 3.4.12
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> After a ZK crash, or client timeout sometimes it's hard to determine from the 
> logs what happened. Knowing if ZK was responsive at the time would help a 
> lot. For example, ZK might spend a lot of time waiting on GC (there is still 
> some misconception that ZK is a storage). 
> To help detect this, HADOOP already has a great tool called JVM Pause 
> Monitor. (As the name suggest, it can be also used for monitoring, but it 
> also helps post-mortem in a lot of cases). Basically it has a daemon that 
> sleeps for one second, and if the sleep time exceeds the 1s by more than the 
> threshold (1s: INFO, 10s: WARN by default - this can be configurable in our 
> case, see below), it will alert/make a log entry. It can also monitor the 
> time GC took.
> The class implementing this is in HADOOP-common, but ZK should not depend on 
> this package. Since this is a straightforward implementation, and in the past 
> five years the few commits it had is nothing really serious, I think we could 
> just copy this class in ZooKeeper, and introduce it as a configurable 
> feature, by default it can be off.
> The class:
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
> Task:
> - Create a class in ZK (under zookeeper/server/util/) called JvmPauseMonitor. 
> - Make feature configurable, by default: OFF
> - Make sleep time and threshold time configurable
> - Update documentation
> - Add [current size of the heap OR % of heap used] in the log entry whenever 
> sleep threshold had exceeded by a lot (10s)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] anmolnar commented on issue #904: ZOOKEEPER-3037 - Add JVMPauseMonitor

2019-04-18 Thread GitBox 
anmolnar commented on issue #904: ZOOKEEPER-3037 - Add JVMPauseMonitor
URL: https://github.com/apache/zookeeper/pull/904#issuecomment-484598443
 
 
   Merged to master. Thanks @nkalmar !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] asfgit closed pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor

2019-04-18 Thread GitBox 
asfgit closed pull request #904: ZOOKEEPER-3037 - Add JVMPauseMonitor
URL: https://github.com/apache/zookeeper/pull/904
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-484596741
 
 
   Travis is broken on jdk11
   
   ```
   Installing openjdk11
   $ export JAVA_HOME=~/openjdk11
   $ export PATH="$JAVA_HOME/bin:$PATH"
   $ ~/bin/install-jdk.sh --target "/home/travis/openjdk11" --workspace 
"/home/travis/.cache/install-jdk" --feature "11" --license "GPL" --cacerts
   install-jdk.sh 2019-04-17
   Couldn't determine a download url for 11-GPL on linux-x64
   The command "~/bin/install-jdk.sh --target "/home/travis/openjdk11" 
--workspace "/home/travis/.cache/install-jdk" --feature "11" --license "GPL" 
--cacerts" failed and exited with 1 during .
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-484596136
 
 
   closing and reopening in order to trigger travis


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli opened a new pull request #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli opened a new pull request #910: ZOOKEEPER-3364 Compile with strict 
options in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910
 
 
   - Add extra compiler arguments in order to achieve better code quality.
   - Fix some minor issues reported by javac
   - Extra checks are not enabled in "contrib" module.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli closed pull request #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli closed pull request #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

ZooKeeper_branch34_openjdk7 - Build # 2279 - Failure

2019-04-18 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2279/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 47.47 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.686 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.675 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.641 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.11 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.708 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.885 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.429 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.875 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.238 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.61 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.855 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.618 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.586 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.103 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.722 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.648 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.205 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.19 sec
[junit] Running org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.125 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1425:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1428:
 Tests failed!

Total time: 35 minutes 13 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Recording test results
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.SaslAuthTest.testZKOperationsAfterClientSaslAuthFailure

Error Message:
Did not connect

Stack Trace:
java.util.concurrent.TimeoutException: Did not connect
at 
org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:152)
at 
org.apache.zookeeper.SaslAuthTest.testZKOperationsAfterClientSaslAuthFailure(SaslAuthTest.java:174)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-484574332
 
 
   I have found the cause


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-484559347
 
 
   It seems that my change is breaking the test, the setup() method is 
setting/unsetting one system property.
   I have to dig into it


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-484543943
 
 
   Why doesn't it fail on other PR ? I didn't change that file, only the junit 
watchman rule


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-484543613
 
 
   @nkalmar I have got it, there is a failure on CI. I missed it


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

2019-04-18 Thread GitBox 
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options 
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-484540772
 
 
   > In CreateTTLTest.testDisabled()
   > @test(expected = KeeperException.UnimplementedException.class) no longer 
gets thrown due to the changes in ZKTestCase.
   > I'm not sure of the cause, but I reproduced the problem with only changing 
the ZKTestCase class. So this does not failed due to flakiness.
   
   @nkalmar is this comment related to this patch ? I didn't touch that class


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 4

2019-04-18 Thread Patrick Hunt 
On Thu, Apr 18, 2019 at 2:19 AM Norbert Kalmar 
wrote:

> Thanks Patrick, I created a Jira for the fixes:
> https://issues.apache.org/jira/browse/ZOOKEEPER-3369
> Should we modify the artifact name for the binary as well? Either to "
> apache-zookeeper-3.5.5-bin.tar.gz" or leave apache out of it: "
> zookeeper-3.5.5-bin.tar.gz"
> I think it would make sense to keep the two tarball name similar.
>
>
Yes sound right to me, you want the artifact and directories to all be
consistent - "Prepend apache to the binary name as well."

Patrick


> Regards,
> Norbert
>
> On Wed, Apr 17, 2019 at 8:28 PM Patrick Hunt  wrote:
>
> > -1 currently. On the plus side things seem to be functional and I tested
> > 3.4 against this release in a mixed ensemble and it seemed fine.
> >
> > I would recommend changing the name
> > from zookeeper-3.5.5-source-package.tar.gz to
> apache-zookeeper-3.5.5.tar.gz
> > - this is _the_ artifact. Everything else is a convenience (e.g. the
> > binary). Prepend apache to the binary name as well.
> >
> > When I unpack the binary archive it has the same toplevel directory name
> as
> > the source, do we want that or should it have binary in the name?
> Principle
> > of least surprise seems to say the directory name should match the
> archive
> > name.
> >
> > Where are the api docs? I did a "mvn install" and I see the
> user/admin/...
> > html docs, but I can't find the api docs. The readme doesn't shed much
> > light, and specifically says "Full documentation for this release can
> also
> > be found in docs/index.html" which seems to be incorrect at this point,
> as
> > docs is in the binary but not the source. Perhaps we should have a
> general
> > README and a binary specific readme?
> >
> > also inaccurate "The release artifact contains the following jar files in
> > "dist-maven" directory" which doesn't exist for the source distro.
> >
> > netty-all-4.1.29.Final.jar does not include a license file, nor are we
> > including one in h the lib directory.
> >
> > In the binary I don't see an api either. shouldn't we be including that
> > along with the regular docs?
> >
> > Patrick
> >
> > On Sun, Apr 14, 2019 at 6:52 AM Andor Molnar  wrote:
> >
> > > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117
> > > issues, including Maven migration, Quorum TLS, TTL nodes and lots of
> > other
> > > performance and stability improvements.
> > >
> > > The full release notes is available at:
> > >
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268
> > >
> > > *** Please download, test and vote by April 21st 2019, 23:59 UTC+0. ***
> > >
> > > Source files:
> > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc4/
> > >
> > > Maven staging repos:
> > >
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/
> > >
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/
> > >
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/
> > >
> > > The release candidate tag in git to be voted upon: release-3.5.5-rc4
> > >
> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > http://www.apache.org/dist/zookeeper/KEYS
> > >
> > > Should we release this candidate?
> > >
> > >
> >
>

[GitHub] [zookeeper] eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file

2019-04-18 Thread GitBox 
eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a 
simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/909#discussion_r276678434
 
 

 ##
 File path: 
zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/com/nitido/utils/toaster/Toaster.java
 ##
 @@ -44,8 +44,6 @@
 /**
  * Class to show tosters in multiplatform
  *
- * @author daniele piras
 
 Review comment:
   I think this is only a mistake done from the committer who committed this 
files.
   I seems that the rules of the project say that author tags are not allowed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file

2019-04-18 Thread GitBox 
eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a 
simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/909#discussion_r276678551
 
 

 ##
 File path: pom.xml
 ##
 @@ -545,6 +545,36 @@
   dependency-check-maven
   4.0.2
 
+
+  org.apache.maven.plugins
+  maven-checkstyle-plugin
+  3.0.0
+  
+
+  com.puppycrawl.tools
+  checkstyle
+  8.17
 
 Review comment:
   @nkalmar  done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file

2019-04-18 Thread GitBox 
eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a 
simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/909#discussion_r276678020
 
 

 ##
 File path: pom.xml
 ##
 @@ -545,6 +545,36 @@
   dependency-check-maven
   4.0.2
 
+
+  org.apache.maven.plugins
+  maven-checkstyle-plugin
+  3.0.0
 
 Review comment:
   @nkalmar it is already inside the "pluginManagement" block


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ZOOKEEPER-3369) Maven release artifacts cleanup

2019-04-18 Thread Norbert Kalmar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3369:
--
Description: 
- Change source tarball name from
zookeeper-3.5.5-source-package.tar.gz 
to 
apache-zookeeper-3.5.5.tar.gz

- After unpacking the tarballs the top level dir should match the archive's 
name.

- missing api docs after mvn clean install and from binary package. Fix readme 
on this:
"Full documentation for this release can also be found in docs/index.html"
Perhaps we should have a general README and a binary specific readme?

- Correct "The release artifact contains the following jar files in
"dist-maven" directory" - no dist-maven dir anymore.

- Include license file for netty-all-4.1.29.Final.jar 


  was:
- Change source tarball name from
zookeeper-3.5.5-source-package.tar.gz 
to 
apache-zookeeper-3.5.5.tar.gz

- After unpacking the tarballs the top level dir should match the archive's 
name.

Where are the api docs? I did a "mvn install" and I see the user/admin/...
html docs, but I can't find the api docs. The readme doesn't shed much
light, and specifically says "Full documentation for this release can also
be found in docs/index.html" which seems to be incorrect at this point, as
docs is in the binary but not the source. Perhaps we should have a general
README and a binary specific readme?
In the binary I don't see an api either. shouldn't we be including that
along with the regular docs?

- Correct "The release artifact contains the following jar files in
"dist-maven" directory" - no dist-maven dir anymore.

- Include license file for netty-all-4.1.29.Final.jar 



> Maven release artifacts cleanup
> ---
>
> Key: ZOOKEEPER-3369
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3369
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>
> - Change source tarball name from
> zookeeper-3.5.5-source-package.tar.gz 
> to 
> apache-zookeeper-3.5.5.tar.gz
> - After unpacking the tarballs the top level dir should match the archive's 
> name.
> - missing api docs after mvn clean install and from binary package. Fix 
> readme on this:
> "Full documentation for this release can also be found in docs/index.html"
> Perhaps we should have a general README and a binary specific readme?
> - Correct "The release artifact contains the following jar files in
> "dist-maven" directory" - no dist-maven dir anymore.
> - Include license file for netty-all-4.1.29.Final.jar 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Jenkins build is back to normal : ZooKeeper-trunk-owasp #336

2019-04-18 Thread Apache Jenkins Server 
See

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 4

2019-04-18 Thread Norbert Kalmar 
Thanks Patrick, I created a Jira for the fixes:
https://issues.apache.org/jira/browse/ZOOKEEPER-3369
Should we modify the artifact name for the binary as well? Either to "
apache-zookeeper-3.5.5-bin.tar.gz" or leave apache out of it: "
zookeeper-3.5.5-bin.tar.gz"
I think it would make sense to keep the two tarball name similar.

Regards,
Norbert

On Wed, Apr 17, 2019 at 8:28 PM Patrick Hunt  wrote:

> -1 currently. On the plus side things seem to be functional and I tested
> 3.4 against this release in a mixed ensemble and it seemed fine.
>
> I would recommend changing the name
> from zookeeper-3.5.5-source-package.tar.gz to apache-zookeeper-3.5.5.tar.gz
> - this is _the_ artifact. Everything else is a convenience (e.g. the
> binary). Prepend apache to the binary name as well.
>
> When I unpack the binary archive it has the same toplevel directory name as
> the source, do we want that or should it have binary in the name? Principle
> of least surprise seems to say the directory name should match the archive
> name.
>
> Where are the api docs? I did a "mvn install" and I see the user/admin/...
> html docs, but I can't find the api docs. The readme doesn't shed much
> light, and specifically says "Full documentation for this release can also
> be found in docs/index.html" which seems to be incorrect at this point, as
> docs is in the binary but not the source. Perhaps we should have a general
> README and a binary specific readme?
>
> also inaccurate "The release artifact contains the following jar files in
> "dist-maven" directory" which doesn't exist for the source distro.
>
> netty-all-4.1.29.Final.jar does not include a license file, nor are we
> including one in h the lib directory.
>
> In the binary I don't see an api either. shouldn't we be including that
> along with the regular docs?
>
> Patrick
>
> On Sun, Apr 14, 2019 at 6:52 AM Andor Molnar  wrote:
>
> > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117
> > issues, including Maven migration, Quorum TLS, TTL nodes and lots of
> other
> > performance and stability improvements.
> >
> > The full release notes is available at:
> >
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268
> >
> > *** Please download, test and vote by April 21st 2019, 23:59 UTC+0. ***
> >
> > Source files:
> > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc4/
> >
> > Maven staging repos:
> >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/
> >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/
> >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/
> >
> > The release candidate tag in git to be voted upon: release-3.5.5-rc4
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > http://www.apache.org/dist/zookeeper/KEYS
> >
> > Should we release this candidate?
> >
> >
>

[jira] [Created] (ZOOKEEPER-3369) Maven release artifacts cleanup

2019-04-18 Thread Norbert Kalmar (JIRA) 
Norbert Kalmar created ZOOKEEPER-3369:
-

 Summary: Maven release artifacts cleanup
 Key: ZOOKEEPER-3369
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3369
 Project: ZooKeeper
  Issue Type: Improvement
  Components: build
Affects Versions: 3.6.0, 3.5.5
Reporter: Norbert Kalmar


- Change source tarball name from
zookeeper-3.5.5-source-package.tar.gz 
to 
apache-zookeeper-3.5.5.tar.gz

- After unpacking the tarballs the top level dir should match the archive's 
name.

Where are the api docs? I did a "mvn install" and I see the user/admin/...
html docs, but I can't find the api docs. The readme doesn't shed much
light, and specifically says "Full documentation for this release can also
be found in docs/index.html" which seems to be incorrect at this point, as
docs is in the binary but not the source. Perhaps we should have a general
README and a binary specific readme?
In the binary I don't see an api either. shouldn't we be including that
along with the regular docs?

- Correct "The release artifact contains the following jar files in
"dist-maven" directory" - no dist-maven dir anymore.

- Include license file for netty-all-4.1.29.Final.jar 




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ZOOKEEPER-3369) Maven release artifacts cleanup

2019-04-18 Thread Norbert Kalmar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar reassigned ZOOKEEPER-3369:
-

Assignee: Norbert Kalmar

> Maven release artifacts cleanup
> ---
>
> Key: ZOOKEEPER-3369
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3369
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>
> - Change source tarball name from
> zookeeper-3.5.5-source-package.tar.gz 
> to 
> apache-zookeeper-3.5.5.tar.gz
> - After unpacking the tarballs the top level dir should match the archive's 
> name.
> Where are the api docs? I did a "mvn install" and I see the user/admin/...
> html docs, but I can't find the api docs. The readme doesn't shed much
> light, and specifically says "Full documentation for this release can also
> be found in docs/index.html" which seems to be incorrect at this point, as
> docs is in the binary but not the source. Perhaps we should have a general
> README and a binary specific readme?
> In the binary I don't see an api either. shouldn't we be including that
> along with the regular docs?
> - Correct "The release artifact contains the following jar files in
> "dist-maven" directory" - no dist-maven dir anymore.
> - Include license file for netty-all-4.1.29.Final.jar 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)