ZooKeeper_branch34_jdk7 - Build # 2305 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/2305/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 46.93 KB...]
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.825 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.693 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.611 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.762 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.522 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.62 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.569 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.081 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.633 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.054 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.83 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.867 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.877 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.821 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.609 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.634 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.432 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.1 
sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.359 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.189 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.32 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.757 sec
[junit] Running org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.095 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1425: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1428: 
Tests failed!

Total time: 37 minutes 39 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.QuorumTest.testLeaderShutdown

Error Message:
Forked Java VM exited abnormally. Please note the time in the report does not 
reflect the time until the VM exit.

Stack Trace:
junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please 
note the time in the report does not reflect the time until the VM exit.

[GitHub] [zookeeper] maoling commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

[GitBox]

maoling commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for 
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-485617882
 
 
   @eolivelli 
   After your Prometheus MetricsProvider has landed,Plz ping me.
   I will write a grafana template for zk, just like 
[this](https://grafana.com/dashboards/3070).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZOOKEEPER-3371) Port unification for admin server

[Eric Lee (JIRA)]

Eric Lee created ZOOKEEPER-3371:
---

 Summary: Port unification for admin server
 Key: ZOOKEEPER-3371
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3371
 Project: ZooKeeper
  Issue Type: New Feature
  Components: security
Affects Versions: 3.6.0
Reporter: Eric Lee


This issue provides the Jetty admin server with port unification, meaning both 
secure and insecure connections can be established on the same port. By 
default, this feature is disable. It can be enabled by passing 
"zookeeper.admin.portUnification" as a command line argument.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Jenkins build doesn't work

[Patrick Hunt]

Trunk is green again, so we should be OK for the moment while you workout
the details. No rush. :-)

Patrick

On Mon, Apr 22, 2019 at 3:04 PM Enrico Olivelli  wrote:

> Il lun 22 apr 2019, 18:04 Patrick Hunt  ha scritto:
>
> > Hm, my guess is that they may have removed it? However this was not
> updated
> > afaict
> >
> https://cwiki.apache.org/confluence/display/INFRA/Ant+Installation+Matrix
> > I just updated to be 1.9 latest, we'll see.
> >
> > In terms of ant vs maven, iirc ant was used because we run some special
> > build steps that were not in ant build.xml in the repo. If you want to
> > replace with maven on trunk (which sounds reasonable) you'd have to check
> > that first.
> >
>
> Yes, this is want I am doing, I am tracking my work here:
>
> https://jira.apache.org/jira/plugins/servlet/mobile#issue/ZOOKEEPER-3351
>
>
> Enrico
>
>
>
> > Regards,
> >
> > Patrick
> >
> >
> > On Fri, Apr 19, 2019 at 11:43 PM Enrico Olivelli 
> > wrote:
> >
> > > I have fixed configuration of the ANT based precommit job
> > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> > >
> > > @Patrick please take a look
> > >
> > > Some jobs are using "Invoke ant" build step and they seem to work
> > > I the approach is good I can change the configs of the other jobs, like
> > > https://builds.apache.org/job/ZooKeeper-trunk/
> > >
> > >
> > > Cheers
> > > Enrico
> > >
> > > Il giorno sab 20 apr 2019 alle ore 07:57 Enrico Olivelli
> > >  ha scritto:
> > > >
> > > >
> > > >
> > > > Il sab 20 apr 2019, 01:17 Jie Huang  ha
> > scritto:
> > > >>
> > > >> It doesn't seem to build at all. The most suspicious error message
> is:
> > > >>
> > > >> /tmp/jenkins1102606335931600364.sh: line 26:
> > > >> /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or
> > > >> directory
> > > >>
> > > >>
> > > >> Is this happening only to me?
> > > >
> > > >
> > > > No it is for al of the build.
> > > > And travis is also broken (openjdk11 no more available)
> > > >
> > > > In
> > > > https://github.com/apache/zookeeper/pull/910
> > > >
> > > > I am fixing Travis.
> > > > If the patch cannot be merged, because it contains another change
> (btw
> > > needed for dropping ant)
> > > >
> > > > I will take a look to ant as well.
> > > >
> > > > We are dropping ant for master and for 3.5 but not for 3.4
> > > >
> > > > Regards
> > > >
> > > > Enrico
> > > >
> > > >
> > > > Enrico
> > > >
> > > >>
> > > >> Thanks,
> > > >> Jie
> > >
> >
>

[jira] [Commented] (ZOOKEEPER-3326) Add session/connection related metrics

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823531#comment-16823531
 ] 

Hudson commented on ZOOKEEPER-3326:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #490 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/490/])
ZOOKEEPER-3326: Add session/connection related metrics (fangmin: rev 
d8db88914e7af7c11a2588be202d90b925791d31)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/SessionTrackerImpl.java


> Add session/connection related metrics
> --
>
> Key: ZOOKEEPER-3326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3326
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Assignee: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Jenkins build doesn't work

[Enrico Olivelli]

Il lun 22 apr 2019, 18:04 Patrick Hunt  ha scritto:

> Hm, my guess is that they may have removed it? However this was not updated
> afaict
> https://cwiki.apache.org/confluence/display/INFRA/Ant+Installation+Matrix
> I just updated to be 1.9 latest, we'll see.
>
> In terms of ant vs maven, iirc ant was used because we run some special
> build steps that were not in ant build.xml in the repo. If you want to
> replace with maven on trunk (which sounds reasonable) you'd have to check
> that first.
>

Yes, this is want I am doing, I am tracking my work here:

https://jira.apache.org/jira/plugins/servlet/mobile#issue/ZOOKEEPER-3351


Enrico



> Regards,
>
> Patrick
>
>
> On Fri, Apr 19, 2019 at 11:43 PM Enrico Olivelli 
> wrote:
>
> > I have fixed configuration of the ANT based precommit job
> > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> >
> > @Patrick please take a look
> >
> > Some jobs are using "Invoke ant" build step and they seem to work
> > I the approach is good I can change the configs of the other jobs, like
> > https://builds.apache.org/job/ZooKeeper-trunk/
> >
> >
> > Cheers
> > Enrico
> >
> > Il giorno sab 20 apr 2019 alle ore 07:57 Enrico Olivelli
> >  ha scritto:
> > >
> > >
> > >
> > > Il sab 20 apr 2019, 01:17 Jie Huang  ha
> scritto:
> > >>
> > >> It doesn't seem to build at all. The most suspicious error message is:
> > >>
> > >> /tmp/jenkins1102606335931600364.sh: line 26:
> > >> /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or
> > >> directory
> > >>
> > >>
> > >> Is this happening only to me?
> > >
> > >
> > > No it is for al of the build.
> > > And travis is also broken (openjdk11 no more available)
> > >
> > > In
> > > https://github.com/apache/zookeeper/pull/910
> > >
> > > I am fixing Travis.
> > > If the patch cannot be merged, because it contains another change (btw
> > needed for dropping ant)
> > >
> > > I will take a look to ant as well.
> > >
> > > We are dropping ant for master and for 3.5 but not for 3.4
> > >
> > > Regards
> > >
> > > Enrico
> > >
> > >
> > > Enrico
> > >
> > >>
> > >> Thanks,
> > >> Jie
> >
>

[jira] [Commented] (ZOOKEEPER-3326) Add session/connection related metrics

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823330#comment-16823330
 ] 

Hudson commented on ZOOKEEPER-3326:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #323 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/323/])
ZOOKEEPER-3326: Add session/connection related metrics (fangmin: rev 
d8db88914e7af7c11a2588be202d90b925791d31)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/SessionTrackerImpl.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java


> Add session/connection related metrics
> --
>
> Key: ZOOKEEPER-3326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3326
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Assignee: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] lvfangmin commented on issue #849: ZOOKEEPER-3305: Add Quorum Packet metrics

[GitBox]

lvfangmin commented on issue #849: ZOOKEEPER-3305: Add Quorum Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#issuecomment-485492869
 
 
   @jhuan31 this needs to be rebased as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (ZOOKEEPER-3326) Add session/connection related metrics

[Fangmin Lv (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fangmin Lv reassigned ZOOKEEPER-3326:
-

Assignee: Jie Huang

> Add session/connection related metrics
> --
>
> Key: ZOOKEEPER-3326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3326
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Assignee: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ZOOKEEPER-3326) Add session/connection related metrics

[Fangmin Lv (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fangmin Lv resolved ZOOKEEPER-3326.
---
Resolution: Fixed

Issue resolved by pull request 861
[https://github.com/apache/zookeeper/pull/861]

> Add session/connection related metrics
> --
>
> Key: ZOOKEEPER-3326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3326
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: metric system
>Reporter: Jie Huang
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] lvfangmin commented on issue #861: ZOOKEEPER-3326: Add session/connection related metrics

[GitBox]

lvfangmin commented on issue #861: ZOOKEEPER-3326: Add session/connection 
related metrics
URL: https://github.com/apache/zookeeper/pull/861#issuecomment-485482799
 
 
   Merged, thanks @jhuan31.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] asfgit closed pull request #861: ZOOKEEPER-3326: Add session/connection related metrics

[GitBox]

asfgit closed pull request #861: ZOOKEEPER-3326: Add session/connection related 
metrics
URL: https://github.com/apache/zookeeper/pull/861
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : ZooKeeper-trunk-owasp #341

[Apache Jenkins Server]

See 

ZooKeeper_branch34_openjdk7 - Build # 2283 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2283/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 47.58 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.847 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.839 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.745 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.09 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.71 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.204 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.226 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.872 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.213 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.564 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.964 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.402 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.438 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.08 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.842 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.235 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.233 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.541 sec
[junit] Running org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.147 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1425:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1428:
 Tests failed!

Total time: 34 minutes 37 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Recording test results
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView(QuorumPeerMainTest.java:1321)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

Re: Jenkins build doesn't work

[Patrick Hunt]

Hm, my guess is that they may have removed it? However this was not updated
afaict
https://cwiki.apache.org/confluence/display/INFRA/Ant+Installation+Matrix
I just updated to be 1.9 latest, we'll see.

In terms of ant vs maven, iirc ant was used because we run some special
build steps that were not in ant build.xml in the repo. If you want to
replace with maven on trunk (which sounds reasonable) you'd have to check
that first.

Regards,

Patrick


On Fri, Apr 19, 2019 at 11:43 PM Enrico Olivelli 
wrote:

> I have fixed configuration of the ANT based precommit job
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
>
> @Patrick please take a look
>
> Some jobs are using "Invoke ant" build step and they seem to work
> I the approach is good I can change the configs of the other jobs, like
> https://builds.apache.org/job/ZooKeeper-trunk/
>
>
> Cheers
> Enrico
>
> Il giorno sab 20 apr 2019 alle ore 07:57 Enrico Olivelli
>  ha scritto:
> >
> >
> >
> > Il sab 20 apr 2019, 01:17 Jie Huang  ha scritto:
> >>
> >> It doesn't seem to build at all. The most suspicious error message is:
> >>
> >> /tmp/jenkins1102606335931600364.sh: line 26:
> >> /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant: No such file or
> >> directory
> >>
> >>
> >> Is this happening only to me?
> >
> >
> > No it is for al of the build.
> > And travis is also broken (openjdk11 no more available)
> >
> > In
> > https://github.com/apache/zookeeper/pull/910
> >
> > I am fixing Travis.
> > If the patch cannot be merged, because it contains another change (btw
> needed for dropping ant)
> >
> > I will take a look to ant as well.
> >
> > We are dropping ant for master and for 3.5 but not for 3.4
> >
> > Regards
> >
> > Enrico
> >
> >
> > Enrico
> >
> >>
> >> Thanks,
> >> Jie
>

[jira] [Updated] (ZOOKEEPER-3340) Improve Queue Usage in QuorumCnxManager.java

[David Mollitor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated ZOOKEEPER-3340:
--
Description: 
I was recently profiling a on a ZK Quorum Leader in a low-volume environment 
and noticed that most of its time was spent in {{QuorumCnxManager#RecvWorker}}. 
 Nothing wrong with that, but it did draw my attention to it.  I noticed that 
{{Queue}} interactions are a bit... verbose.  I would like to propose that we 
streamline this area of the code.
 

[https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1291-L1309]


This proposed JIRA should not be viewed simply as 'ArrayBlockingQueue' v.s. 
'CircularBlockingQueue'.

One of the things that this PR does is remove the need for double-locking. For 
example in addToRecvQueue the following condition exists:
{code}
public void addToRecvQueue(Message msg) {
synchronized(recvQLock) {
if (recvQueue.remainingCapacity() == 0) {
try {
{code}

>From here it can be observed that there are two locks obtained: {{recvQLock}} 
>and the one internal to {{recvQueue}}. This is required because there are 
>multiple interactions that this Manager wants to do on the queue in a 
>serialized way. The {{CircularBlockingQueue}} performs all of those actions on 
>behalf of the caller, but it does it internal to the queue, under a single 
>lock,... the one internal to {{CircularBlockingQueue}}.

The current code also has some race-conditions that are simply ignored when 
they happen. The race conditions are detailed nicely in the code comments here. 
However, the changes in this PR directly deal with, and eliminate, these race 
conditions altogether since all actions that work against the 
{{CircularBlockingQueue}} all occur within its internal locks. This greatly 
simplifies the code and removes the need for new folks to learn this nuance of 
"why is the code doing this."

  was:
I was recently profiling a on a ZK Quorum Leader in a low-volume environment 
and noticed that most of its time was spent in {{QuorumCnxManager#RecvWorker}}. 
 Nothing wrong with that, but it did draw my attention to it.  I noticed that 
{{Queue}} interactions are a bit... verbose.  I would like to propose that we 
streamline this area of the code.
 

[https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1291-L1309]


> Improve Queue Usage in QuorumCnxManager.java
> 
>
> Key: ZOOKEEPER-3340
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3340
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> I was recently profiling a on a ZK Quorum Leader in a low-volume environment 
> and noticed that most of its time was spent in 
> {{QuorumCnxManager#RecvWorker}}.  Nothing wrong with that, but it did draw my 
> attention to it.  I noticed that {{Queue}} interactions are a bit... verbose. 
>  I would like to propose that we streamline this area of the code.
>  
> [https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1291-L1309]
> This proposed JIRA should not be viewed simply as 'ArrayBlockingQueue' v.s. 
> 'CircularBlockingQueue'.
> One of the things that this PR does is remove the need for double-locking. 
> For example in addToRecvQueue the following condition exists:
> {code}
> public void addToRecvQueue(Message msg) {
> synchronized(recvQLock) {
> if (recvQueue.remainingCapacity() == 0) {
> try {
> {code}
> From here it can be observed that there are two locks obtained: {{recvQLock}} 
> and the one internal to {{recvQueue}}. This is required because there are 
> multiple interactions that this Manager wants to do on the queue in a 
> serialized way. The {{CircularBlockingQueue}} performs all of those actions 
> on behalf of the caller, but it does it internal to the queue, under a single 
> lock,... the one internal to {{CircularBlockingQueue}}.
> The current code also has some race-conditions that are simply ignored when 
> they happen. The race conditions are detailed nicely in the code comments 
> here. However, the changes in this PR directly deal with, and eliminate, 
> these race conditions altogether since all actions that work against the 
> {{CircularBlockingQueue}} all occur within its internal locks. This greatly 
> simplifies the code and removes the need for new folks to learn this 

[jira] [Updated] (ZOOKEEPER-3340) Introduce CircularBlockingQueue in QuorumCnxManager.java

[David Mollitor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated ZOOKEEPER-3340:
--
Summary: Introduce CircularBlockingQueue in QuorumCnxManager.java  (was: 
Improve Queue Usage in QuorumCnxManager.java)

> Introduce CircularBlockingQueue in QuorumCnxManager.java
> 
>
> Key: ZOOKEEPER-3340
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3340
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> I was recently profiling a on a ZK Quorum Leader in a low-volume environment 
> and noticed that most of its time was spent in 
> {{QuorumCnxManager#RecvWorker}}.  Nothing wrong with that, but it did draw my 
> attention to it.  I noticed that {{Queue}} interactions are a bit... verbose. 
>  I would like to propose that we streamline this area of the code.
>  
> [https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1291-L1309]
> This proposed JIRA should not be viewed simply as 'ArrayBlockingQueue' v.s. 
> 'CircularBlockingQueue'.
> One of the things that this PR does is remove the need for double-locking. 
> For example in addToRecvQueue the following condition exists:
> {code}
> public void addToRecvQueue(Message msg) {
> synchronized(recvQLock) {
> if (recvQueue.remainingCapacity() == 0) {
> try {
> {code}
> From here it can be observed that there are two locks obtained: {{recvQLock}} 
> and the one internal to {{recvQueue}}. This is required because there are 
> multiple interactions that this Manager wants to do on the queue in a 
> serialized way. The {{CircularBlockingQueue}} performs all of those actions 
> on behalf of the caller, but it does it internal to the queue, under a single 
> lock,... the one internal to {{CircularBlockingQueue}}.
> The current code also has some race-conditions that are simply ignored when 
> they happen. The race conditions are detailed nicely in the code comments 
> here. However, the changes in this PR directly deal with, and eliminate, 
> these race conditions altogether since all actions that work against the 
> {{CircularBlockingQueue}} all occur within its internal locks. This greatly 
> simplifies the code and removes the need for new folks to learn this nuance 
> of "why is the code doing this."



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

[maoling (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

maoling updated ZOOKEEPER-3318:
---
Description: 
We already had some workaround ways for the backup, e.g:
scenario 1: just write a cron shell to copy the snapshots periodically. 
scenario 2: use the observer as the role of backup, then write the snapshots to 
distributed file system. (e.g HDFS)

this issue is aiming to implement a complete backup mechanism for zookeeper 
internal:
the init propose:
1. for realtime backup.
write a new CLI:snapshot
1.1
[zk: 127.0.0.1:2180(CONNECTED) 0] snapshot backupDataDir
[zk: 127.0.0.1:2180(CONNECTED) 1] snapshot
 
***
1.2 
if no parameter, the default backupDataDir is the dataDir. the format of the 
backup-snapshot is just like: snapshot.f9f82834 which is the same as the 
original one.
when recovering,moving the snapshot.f9f82834 to the dataDir, then restart 
the ensemble.
1.3
don't worry about exposing the takeSnap() api to the client.Look at this two 
references:
https://github.com/etcd-io/etcd/blob/master/clientv3/snapshot/v3_snapshot.go
https://github.com/xetorthio/jedis/blob/master/src/main/java/redis/clients/jedis/commands/BasicCommands.java#L68
2. for no-realtime backup.
2.1 
write a new tool/shell: zkBackup.sh which is the reverse proces of the 
zkCleanup.sh for no-realtime backup.

  was:
We already had some workaround ways for the backup, e.g
*scenario 1:* just write a cron shell to copy the snapshots periodically. 
*scenario 2:* use the observer as the role of backup, then write the snapshots 
to file system. (e.g HDFS)

this issue is aiming to implement a complete backup mechanism for zookeeper 
internal:
the init propose:
*1*. write a new CLI:snapshot
 *1.1* 
 because this CLI may be time-consuming.A confirmation is needed. e.g.
 [zk: 127.0.0.1:2180(CONNECTED) 0] snapshot backupDataDir
 Are you sure to exec:snapshot [yes/no]
 *1.2* 
 if no parameter, the default backupDataDir is the dataDir. the format of the 
backup-snapshot is just like: backup_snapshot.f9f82834 with the "backup_" 
prefix,when recovering,rename backup_snapshot.f9f82834 to 
snapshot.f9f82834 and move it to the dataDir, then restart the ensemble.
 *1.3* 
 don't worry about exposing the takeSnap() api to the client.Look at this two 
references:
 https://github.com/etcd-io/etcd/blob/master/clientv3/snapshot/v3_snapshot.go
 
https://github.com/xetorthio/jedis/blob/master/src/main/java/redis/clients/jedis/commands/BasicCommands.java#L68
*2*. 
 *2.1* 
 write a new tool/shell: zkBackup.sh which is the reverse proces of the 
zkCleanup.sh for no-realtime backup
 *2.2* 
 write a new tool/shell: zkBackup_v2.sh which calls the api of the takeSnap() 
for realtime backup.


> Add a complete backup mechanism for zookeeper internal
> --
>
> Key: ZOOKEEPER-3318
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3318
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: other
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We already had some workaround ways for the backup, e.g:
> scenario 1: just write a cron shell to copy the snapshots periodically. 
> scenario 2: use the observer as the role of backup, then write the snapshots 
> to distributed file system. (e.g HDFS)
> this issue is aiming to implement a complete backup mechanism for zookeeper 
> internal:
> the init propose:
> 1. for realtime backup.
> write a new CLI:snapshot
> 1.1
> [zk: 127.0.0.1:2180(CONNECTED) 0] snapshot backupDataDir
> [zk: 127.0.0.1:2180(CONNECTED) 1] snapshot
>  
> ***
> 1.2 
> if no parameter, the default backupDataDir is the dataDir. the format of the 
> backup-snapshot is just like: snapshot.f9f82834 which is the same as the 
> original one.
> when recovering,moving the snapshot.f9f82834 to the dataDir, then restart 
> the ensemble.
> 1.3
> don't worry about exposing the takeSnap() api to the client.Look at this two 
> references:
> https://github.com/etcd-io/etcd/blob/master/clientv3/snapshot/v3_snapshot.go
> https://github.com/xetorthio/jedis/blob/master/src/main/java/redis/clients/jedis/commands/BasicCommands.java#L68
> 2. for no-realtime backup.
> 2.1 
> write a new tool/shell: zkBackup.sh which is the reverse proces of the 
> zkCleanup.sh for no-realtime backup.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [zookeeper] maoling opened a new pull request #917: ZOOKEEPER-3318:-[WIP]-Add a complete backup mechanism for zookeeper internal

[GitBox]

maoling opened a new pull request #917: ZOOKEEPER-3318:-[WIP]-Add a complete 
backup mechanism for zookeeper internal
URL: https://github.com/apache/zookeeper/pull/917
 
 
   - this is still a work in the progress,Plz don't review before removing the 
WIP tag.
   - more details in 
[ZOOKEEPER-3318](https://issues.apache.org/jira/browse/ZOOKEEPER-3318) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3318:
--
Labels: pull-request-available  (was: )

> Add a complete backup mechanism for zookeeper internal
> --
>
> Key: ZOOKEEPER-3318
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3318
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: other
>Reporter: maoling
>Assignee: maoling
>Priority: Major
>  Labels: pull-request-available
>
> We already had some workaround ways for the backup, e.g
> *scenario 1:* just write a cron shell to copy the snapshots periodically. 
> *scenario 2:* use the observer as the role of backup, then write the 
> snapshots to file system. (e.g HDFS)
> this issue is aiming to implement a complete backup mechanism for zookeeper 
> internal:
> the init propose:
> *1*. write a new CLI:snapshot
>  *1.1* 
>  because this CLI may be time-consuming.A confirmation is needed. e.g.
>  [zk: 127.0.0.1:2180(CONNECTED) 0] snapshot backupDataDir
>  Are you sure to exec:snapshot [yes/no]
>  *1.2* 
>  if no parameter, the default backupDataDir is the dataDir. the format of the 
> backup-snapshot is just like: backup_snapshot.f9f82834 with the "backup_" 
> prefix,when recovering,rename backup_snapshot.f9f82834 to 
> snapshot.f9f82834 and move it to the dataDir, then restart the ensemble.
>  *1.3* 
>  don't worry about exposing the takeSnap() api to the client.Look at this two 
> references:
>  https://github.com/etcd-io/etcd/blob/master/clientv3/snapshot/v3_snapshot.go
>  
> https://github.com/xetorthio/jedis/blob/master/src/main/java/redis/clients/jedis/commands/BasicCommands.java#L68
> *2*. 
>  *2.1* 
>  write a new tool/shell: zkBackup.sh which is the reverse proces of the 
> zkCleanup.sh for no-realtime backup
>  *2.2* 
>  write a new tool/shell: zkBackup_v2.sh which calls the api of the takeSnap() 
> for realtime backup.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Build failed in Jenkins: ZooKeeper-trunk-owasp #340

[Apache Jenkins Server]

See 

--
[...truncated 20.50 KB...]
version-info:

process-template:

build-generated:
[javac] Compiling 67 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 1 warning

compile:
[javac] Compiling 315 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 
:26:
 warning: [serial] serializable class ClientCnxnLimitException has no 
definition of serialVersionUID
[javac] public class ClientCnxnLimitException extends Exception {
[javac]^
[javac] 
:72:
 warning: [deprecation] ROUND_HALF_UP in BigDecimal has been deprecated
[javac] return bg.setScale(4, 
BigDecimal.ROUND_HALF_UP).doubleValue();
[javac] ^
[javac] 
:72:
 warning: [deprecation] setScale(int,int) in BigDecimal has been deprecated
[javac] return bg.setScale(4, 
BigDecimal.ROUND_HALF_UP).doubleValue();
[javac]  ^
[javac] 
:37:
 warning: [deprecation] newInstance() in Class has been deprecated
[javac] true, 
Thread.currentThread().getContextClassLoader()).newInstance();
[javac] 
 ^
[javac]   where T is a type-variable:
[javac] T extends Object declared in class Class
[javac] 
:44:
 warning: [dep-ann] deprecated item is not annotated with @Deprecated
[javac] public class LogFormatter {
[javac]^
[javac] 
:246:
 warning: [cast] redundant cast to ByteBuffer
[javac] b = (ByteBuffer) b.slice().limit(
[javac] ^
[javac] 
:78:
 warning: [cast] redundant cast to ByteBuffer
[javac] fileChannel.write((ByteBuffer) fill.position(0), 
newFileSize - fill.remaining());
[javac]   ^
[javac] 
:42:
 warning: [deprecation] newInstance() in Class has been deprecated
[javac] (IWatchManager) 
Class.forName(watchManagerName).newInstance();
[javac]^
[javac]   where T is a type-variable:
[javac] T extends Object declared in class Class
[javac] 9 warnings

compile-test:
[mkdir] Created dir: 

[javac] Compiling 284 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 warning
[javac] Compiling 11 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 1 warning
[javac] Compiling 2 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] Note: