ZooKeeper_branch34_jdk7 - Build # 2328 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/2328/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 46.89 KB...] [junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.101 sec [junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.673 sec [junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.598 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.64 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.736 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.611 sec [junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.553 sec [junit] Running org.apache.zookeeper.test.SaslClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec [junit] Running org.apache.zookeeper.test.SessionInvalidationTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.652 sec [junit] Running org.apache.zookeeper.test.SessionTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.495 sec [junit] Running org.apache.zookeeper.test.SessionTimeoutTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.866 sec [junit] Running org.apache.zookeeper.test.StandaloneTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.862 sec [junit] Running org.apache.zookeeper.test.StatTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.909 sec [junit] Running org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.801 sec [junit] Running org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.634 sec [junit] Running org.apache.zookeeper.test.TruncateTest [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.349 sec [junit] Running org.apache.zookeeper.test.UpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.455 sec [junit] Running org.apache.zookeeper.test.WatchedEventTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.093 sec [junit] Running org.apache.zookeeper.test.WatcherFuncTest [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.392 sec [junit] Running org.apache.zookeeper.test.WatcherTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.051 sec [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.7 sec [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.921 sec [junit] Running org.apache.jute.BinaryInputArchiveTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec fail.build.on.test.failure: BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1425: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1428: Tests failed! Total time: 39 minutes 40 seconds Build step 'Invoke Ant' marked build as failure Archiving artifacts Recording test results Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest.testValidCredentials Error Message: waiting for server 0 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 0 being up at org.apache.zookeeper.server.quorum.auth.QuorumAuthTestBase.startQuorum(QuorumAuthTestBase.java:75) at org.apache.zookeeper.server.quorum.auth.QuorumKerberosAuthTest.testValidCredentials(QuorumKerberosAuthTest.java:114) at
[GitHub] [zookeeper] anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size
anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492824563 @enixon Thanks, it's great you already have a fix in mind. No worries and no rush, just take your time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar edited a comment on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size
anmolnar edited a comment on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492824563 @enixon Thanks, it's great you already have a fix. No worries and no rush, just take your time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492824404 It would be great to have some integration test which loads zookeeper client with osgi and this way we will ensure that we are delivering something that really works. We can do this by adding another module to the build which uses the client inside an osgi container. It is not so simple (because the test will need to start at least one server and use the client and server and client are packaged inside of the same jars). We have to setup these kind of integration tests (maybe docker based) in the short term, not necessarily for thia case. I will be happy to work on this. Maybe you can continue with the osgi packaging stuff and I will then try to setup the integration test in a followup patch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size
enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492812456 Created a new ticket (3396) and opened #949 to resolve (cc @anmolnar - sorry for the trouble!) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3396: -- Labels: pull-request-available (was: ) > Flaky test in RestoreCommittedLogTest > - > > Key: ZOOKEEPER-3396 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396 > Project: ZooKeeper > Issue Type: Improvement > Components: tests >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Minor > Labels: pull-request-available > > The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] > introduced a flaky test > RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize. > > Get it running consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest
Brian Nixon created ZOOKEEPER-3396: -- Summary: Flaky test in RestoreCommittedLogTest Key: ZOOKEEPER-3396 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.6.0 Reporter: Brian Nixon The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] introduced a flaky test RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize. Get it running consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] enixon opened a new pull request #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest
enixon opened a new pull request #949: ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest URL: https://github.com/apache/zookeeper/pull/949 Adjusting parameters of RestoreCommittedLogTest to avoid failures caused by threshold configured to be below the minimum allowed file size This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size
enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492804816 @anmolnar It looks like the issue is FileTxnLog::getCurrentLogSize returns a multiple of a high number that is dependent on the machine running the test (the current thresholds work for my machine but playing with them starts to generate predictable error). With the low size thresholds in use in this test (e.g. less than 100 Kb), this leads to false positives in the "should snapshot" logic from the point of view of the test and it fails. I can put up a patch that fixes this flakiness. What's the preferred procedure - open a new ticket or link to this ticket (ZK-3244)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492796520 Hi @nkalmar @eolivelli, let me introduce "a better solution" for the problem with same package's names of zookeeper-jute and zookeeper-server. If I understand it correctly, maven way of solving this problem is acceptable even if it causes problems sometimes. From previous comment - "It's not ideal, and even causes problems like this one with OSGi." Maven solution is that in case that packages DOESN'T contain the same classes - it works as EXPECTED. If it contains the same classes, then classloader return class from jar based on ORDER of jars. (so even if I want clas from jute, I can get class from server) Which is typicalli zookeeper-server and then zookeeper-jute (as jute is dependency from server) I propose to use OSGi merge capability, which brings the same behavior. If someone wants class from that shared package, in case that classes are differen in both jars, this merge "feature" will behave as expected and correct class is returned. In case that there are overlapping classes, we define, which jar has advantage. (so I'd say that zookeeper-server has advantage). IMHO behavior will be a little bit better then in maven, because it will behave always in the same way. (In reality it won't robabnly happen, because the same classes in the shared packages will probably cause problems elsewhere, so everyone will try to avoid that) In other words - behavior of OSGI with merge will be the same as maven if packages contains different classes. If in the future there will be the overlapping classes, behavior in OSGi would be defined (in contrast with maven, where it would ddepend on order of jar loading - so almost "random") Possibly (I'm not sure about it in this time) I can also try to add some insurance/condition, that it will work for 3.5.x only. I mean that after upgrading to higher version of zookeeper, it will cause error during build (or at least warning), so someone will look into it and will find a comment explaining, that correct solution is to rename packages -> which is the correct solution. In case that packages won't be renamed at that time. This condition would allow us to solve problem in 3.5.x time, where packages couldn't be renamed. Just to avoid confusion, this merge capability only defines, how OSGi returns classes if the class is in package, which is shared in more jars. No actuall merging of compiled classes is not happening. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand
enixon commented on a change in pull request #899: ZOOKEEPER-3354: Improve
efficiency of DeleteAllCommand
URL: https://github.com/apache/zookeeper/pull/899#discussion_r284359820
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java
##
@@ -45,20 +48,71 @@
*
* @throws IllegalArgumentException if an invalid path is specified
*/
-public static void deleteRecursive(ZooKeeper zk, final String pathRoot)
+public static boolean deleteRecursive(ZooKeeper zk, final String pathRoot)
throws InterruptedException, KeeperException
{
PathUtils.validatePath(pathRoot);
List tree = listSubTreeBFS(zk, pathRoot);
LOG.debug("Deleting " + tree);
LOG.debug("Deleting " + tree.size() + " subnodes ");
-for (int i = tree.size() - 1; i >= 0 ; --i) {
-//Delete the leaves first and eventually get rid of the root
-zk.delete(tree.get(i), -1); //Delete all versions of the node with
-1.
+
+int asyncReqRateLimit = 10;
+// Try deleting the tree nodes in batches of size 1000.
Review comment:
1000 seemed like a reasonable number. I'm open to the idea of allowing the
user to do their own custom tuning, we didn't go with it because the available
schemes looked heavyweight and in practice, the users didn't care.
Two options: (1) take this property as a java/system arg or (2) modify the
cli for deleteall to allow batch size as a parameter in addition to the path.
Do you want to speak for one of these?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Assigned] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar reassigned ZOOKEEPER-3263:
---
Assignee: Andor Molnar
> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Assignee: Andor Molnar
>Priority: Major
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar
> and when am running kafka-acl script to maange ACLs, I am getting below
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be
> denied in a future release}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840556#comment-16840556
]
Andor Molnar commented on ZOOKEEPER-3263:
-
Issues that I've found so far:
{noformat}
WARNING: Illegal reflective access by org.apache.ivy.util.url.IvyAuthenticator
(file:/Users/andormolnar/git/my-zookeeper/zookeeper-server/src/main/resources/lib/ivy-2.4.0.jar)
to field java.net.Authenticator.theAuthenticator{noformat}
Upgrade ivy
{noformat}
WARNING: Illegal reflective access by org.mockito.cglib.core.ReflectUtils$2
(file:/Users/andormolnar/git/my-zookeeper/build/test/lib/mockito-all-1.8.5.jar)
to method
java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain){noformat}
Upgrade mockito
{noformat}
WARNING: Illegal reflective access by
org.apache.zookeeper.server.util.KerberosUtil
(file:/Users/andormolnar/git/my-zookeeper/build/classes/) to method
sun.security.krb5.Config.getInstance()
{noformat}
Patch {{KerberosUtil}}
I'm going to put together a patch to address these issues on all branches
tomorrow.
> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Priority: Major
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar
> and when am running kafka-acl script to maange ACLs, I am getting below
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be
> denied in a future release}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840544#comment-16840544
]
Andor Molnar commented on ZOOKEEPER-3263:
-
[~bansalp] Would you please confirm which versions of ZooKeeper are affected by
this Java 9 warning?
Is that correct that you tested with 3.4.13?
> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Pradeep Bansal
>Priority: Major
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar
> and when am running kafka-acl script to maange ACLs, I am getting below
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be
> denied in a future release}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3263:
Affects Version/s: 3.4.13
> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Priority: Major
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar
> and when am running kafka-acl script to maange ACLs, I am getting below
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be
> denied in a future release}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492714723 Maybe you can simply add raw entries to the manifest in the jar plugin configuration This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492704512 @nkalmar @eolivelli I'll continue with this tomorrow. I see in your comment: "Those should be all private to ZooKeeper, so we do not change public API" and the fact that jute is another artifact, I see "simple" solution: I'll try to dig up little bit if there is some way, when zookeeper-jute won't export these "private packages". But I have to try some possibilities, how to solve zookeeper-server's dependency on those libraries. I'm not sure whether it will be possible. Current status is: - build changes are only for zookeeper-server to be changed into OSGi bundle, - there are no warnings during build. - I have to validate whether there is some "real" difference between current manifest and manifest generated by ant. As there is a mentioning, that changing packaging from 'jar' to 'bundle' will cause some errors elsewhere. Unfortunately I'm not aware of other way of running OSGi build, but I'll try to look into it also tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-3353) Admin commands for showing initial settings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840477#comment-16840477 ] Hudson commented on ZOOKEEPER-3353: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #522 (See [https://builds.apache.org/job/ZooKeeper-trunk/522/]) ZOOKEEPER-3353: Admin commands for showing initial settings (andor: rev e45551fc7c691332ace7bff81926855e42ac2239) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/CommandBase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Command.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java > Admin commands for showing initial settings > --- > > Key: ZOOKEEPER-3353 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > It can be useful as a sysadmin to know the settings that were initially used > to configure a given ZooKeeper server. Some of these can be read from the > process logs and others from the java args in the process description but if, > for example, the zoo.cfg file used when starting a process up is overwritten > without the process itself being restarted then it can be difficult to know > exactly what is currently being run on the jvm. > Produce admin commands (and four-letter commands) to answer these questions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492683153 Yes changing the package name is feasible but only for 3.6+. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492680330 I see you changed zookeeper-server packaging from jar to bundle. Yeah... I will check up on this sometime this week. I'm afraid this also affects other things. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492677907 There will be 2 jars upon release, zookeeper-jute and zookeeper-server. zookeeper-jute is the serialization library (just like protobuf). zookeeper-server depends on zookeeper-jute. Since jute (originally) was an independent project, it was always kept seperate. But it evolved with zookeeper, hence the same package names. It's not ideal, and even causes problems like this one with OSGi. The jute classes are generated, just like in protobuf. I'm afraid merging the packages together is not.. uhm, preferable, to say. The most plausible solution out of these for me seems to be changing jute package names. Those should be all private to ZooKeeper, so we do not change public API. But I would be happy if we found another solution. Unfortunately I don't know much about OSGi, so I don't know what the best solution would be here. But zookeeper-server needs zookeeper-jute to serialize the messages between nodes. Maven automatically downloads zookeeper-jute when zookeeper-server is used, as it is a dependency for it. I'm not sure how OSGi solves this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492677907 There will be 2 jars upon release, zookeeper-jute and zookeeper-server. zookeeper-jute is the serialization library (just like protobuf). zookeeper-server depends on zookeeper-jute. Since jute (originally) was an independent project, it was always kept seperate. But it evolved with zookeeper, hence the same package names. It's not ideal, and even causes problems like this one with OSGi. The jute classes are generated, just like in protobuf. I'm afraid merging the packages together is not.. uhm, preferable, to say. The most plausible solution out of these fro me seems to be changing jute package names. Those should be all private to ZooKeeper, so we do not change public API. But I would be happy if we found another solution. Unfortunately I don't know much about OSGi, so I don't know what the best solution would be here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492672683 @nkalmar @eolivelli I'm getting close to the finishing. I just want to clarify some facts and also ask for the help. - just to be sure, only zookeeper-server jar will be compiled as OSGi bundle? (I see also possible modules jute and recipes, so I would like to be sure) - I'm currently facing a problem with OSGi build, there is a warning that zookeeper-server is exporting package, which is also present in different jar - zookeeper-jute. (Packages org/apache/zookeeper/server/quorum and org/apache/zookeeper/server/persistence) It would help me to know, how these packages should be handled. I looked into package 'quorum' and it seems, that it contains different classes. But even if they are different, it could change in the FUTURE. So I'd like to ask, how to face it - best solution from OSGi would be to change jute to use different package names - but it is probably not possible - best way (from my POV) is to merge packages together (with rule that classes from zookeeper-server has to be treated as primary) - but it can remove some classes which are needed to run and I have also problems to define it with maven-plugin (still not sure why it is not working, I think it should work) - may be it is possible also to ignore these packages from zookeeper-jute - but it doesn't seem much probable What do you think about it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492672683 @nkalmar @eolivelli I'm getting close to the finishing. I just want to clarify some facts and also ask for the help. - just to be sure, only zookeeper-server jar will be compiled as OSGi bundle? (I see also possible modules jute and recipes, so I would like to be sure) - I'm currently facing a problem with OSGi build, there is a warning that zookeeper-server is exporting package, which is also present in different jar - zookeeper-jute. (Packages org/apache/zookeeper/server/quorum and org/apache/zookeeper/server/persistence) It would help me to know, how these packages should be handled. I looked into package 'quorum' and it seems, that it contains different classes. But even if they are different, it could change in the FUTURE. So I'd like to ask, how to face it - best solution from OSGi would be to change jute to use different package names - but it is probably not possible - best way (from my POV) is to merge packages together (with rule that classes from zookeeper-server has to be treated as primary) - but it can remove some classes which are needed to run and I have also problems to define it with maven-plugin (still not sure why it is not working, I think it should work) - may be it is possible also to ignore these packages from zookeeper-jute - but it doesn't seem much probable What do you think about it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand
anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve
efficiency of DeleteAllCommand
URL: https://github.com/apache/zookeeper/pull/899#discussion_r284260180
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java
##
@@ -45,20 +48,71 @@
*
* @throws IllegalArgumentException if an invalid path is specified
*/
-public static void deleteRecursive(ZooKeeper zk, final String pathRoot)
+public static boolean deleteRecursive(ZooKeeper zk, final String pathRoot)
throws InterruptedException, KeeperException
{
PathUtils.validatePath(pathRoot);
List tree = listSubTreeBFS(zk, pathRoot);
LOG.debug("Deleting " + tree);
LOG.debug("Deleting " + tree.size() + " subnodes ");
-for (int i = tree.size() - 1; i >= 0 ; --i) {
-//Delete the leaves first and eventually get rid of the root
-zk.delete(tree.get(i), -1); //Delete all versions of the node with
-1.
+
+int asyncReqRateLimit = 10;
+// Try deleting the tree nodes in batches of size 1000.
Review comment:
Why 1000?
What if we make it configurable somehow?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (ZOOKEEPER-3353) Admin commands for showing initial settings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840369#comment-16840369 ] Hudson commented on ZOOKEEPER-3353: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #356 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/356/]) ZOOKEEPER-3353: Admin commands for showing initial settings (andor: rev e45551fc7c691332ace7bff81926855e42ac2239) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Command.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/CommandBase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java > Admin commands for showing initial settings > --- > > Key: ZOOKEEPER-3353 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > It can be useful as a sysadmin to know the settings that were initially used > to configure a given ZooKeeper server. Some of these can be read from the > process logs and others from the java args in the process description but if, > for example, the zoo.cfg file used when starting a process up is overwritten > without the process itself being restarted then it can be difficult to know > exactly what is currently being run on the jvm. > Produce admin commands (and four-letter commands) to answer these questions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings
anmolnar commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492604226 Committed to master branch. Thanks @enixon ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size
anmolnar commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-492603934 @enixon Please double check your test code, it looks like this patch has introduced a flaky test: https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java10/563/ https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/521/ https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java11/422/ https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-java11/423/ ... with the following error: ``` junit.framework.AssertionFailedError: too many snapshot files at org.apache.zookeeper.test.RestoreCommittedLogTest.testRestoreCommittedLog(RestoreCommittedLogTest.java:119) at org.apache.zookeeper.test.RestoreCommittedLogTest.testRestoreCommittedLogWithSnapSize(RestoreCommittedLogTest.java:67) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:80) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (ZOOKEEPER-3353) Admin commands for showing initial settings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3353: --- Assignee: Brian Nixon > Admin commands for showing initial settings > --- > > Key: ZOOKEEPER-3353 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > It can be useful as a sysadmin to know the settings that were initially used > to configure a given ZooKeeper server. Some of these can be read from the > process logs and others from the java args in the process description but if, > for example, the zoo.cfg file used when starting a process up is overwritten > without the process itself being restarted then it can be difficult to know > exactly what is currently being run on the jvm. > Produce admin commands (and four-letter commands) to answer these questions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3353) Admin commands for showing initial settings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3353. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 898 [https://github.com/apache/zookeeper/pull/898] > Admin commands for showing initial settings > --- > > Key: ZOOKEEPER-3353 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > It can be useful as a sysadmin to know the settings that were initially used > to configure a given ZooKeeper server. Some of these can be read from the > process logs and others from the java args in the process description but if, > for example, the zoo.cfg file used when starting a process up is overwritten > without the process itself being restarted then it can be difficult to know > exactly what is currently being run on the jvm. > Produce admin commands (and four-letter commands) to answer these questions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] asfgit closed pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings
asfgit closed pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492587354 I agree with Enrico, please just continue on this branch, as maven will be used to release future 3.5.x and 3.6.x versions. I don't have much to add, but I'll keep a lookout for this PR! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
eolivelli commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492569164 @JiriOndrusek I feel you can continue on this branch, we can merge all this OSGI stuff in a single commit. On branch 3.5 and master we are not using Ant anymore. Ant is living mostly only for 3.4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492561609 Hi @nkalmar , I've started with osgification of maven build, so far in my branch https://github.com/JiriOndrusek/zookeeper/commits/osgi_in_maven If you've already started with this task also, we can calaborate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings
enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-492516231 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
