ZooKeeper_branch34_jdk7 - Build # 2471 - Failure

2019-10-08 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/2471/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 46.95 KB...]
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.382 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.911 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.604 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.793 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.519 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.66 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.543 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.653 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.048 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.888 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.869 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.846 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.211 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.601 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.475 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.44 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.096 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.458 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.576 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.907 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.675 sec
[junit] Running org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1425: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk7/build.xml:1428: 
Tests failed!

Total time: 40 minutes 55 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics

Error Message:
Max latency check
Expected: a value equal to or greater than <2001L>
 but: <2000L> was less than <2001L>

Stack Trace:
junit.framework.AssertionFailedError: Max latency check
Expected: a value equal to or greater than <2001L>
 but: <2000L> was less than <2001L>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at 
org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics(ServerStatsTest.java:75)
at

[VOTE] Apache ZooKeeper release 3.5.6 candidate 4

2019-10-08 Thread Enrico Olivelli 
This is a bugfix release candidate for 3.5.6.

It fixes 29 issues, including upgrade of third party libraries,
TTL Node APIs for C API, support for PCKS12 Keystores, upgrade of Netty 4
and better procedure for the upgrade of servers from 3.4 to 3.5.

The full release notes is available at:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12345243

*** Please download, test and vote by October 11th 2019, 23:59 UTC+0. ***

Source files:
https://people.apache.org/~eolivelli/zookeeper-3.5.6-candidate-4

Maven staging repo:
https://repository.apache.org/content/repositories/orgapachezookeeper-1044

The release candidate tag in git to be voted upon: release-3.5.6-rc4
https://github.com/apache/zookeeper/tree/release-3.5.6-rc4

ZooKeeper's KEYS file containing PGP keys we use to sign the release:
https://www.apache.org/dist/zookeeper/KEYS

Should we release this candidate?

Enrico Olivelli

Jenkins build became unstable: PreCommit-ZOOKEEPER-github-pr-build-maven #1421

2019-10-08 Thread Apache Jenkins Server 
See

Jenkins build is back to stable : zookeeper-master-maven-jdk12 #177

2019-10-08 Thread Apache Jenkins Server 
See

Jenkins build became unstable: zookeeper-master-maven-jdk12 #176

2019-10-08 Thread Apache Jenkins Server 
See

Jenkins build is back to normal : PreCommit-ZOOKEEPER-github-pr-build-maven #1413

2019-10-08 Thread Apache Jenkins Server 
See

Build failed in Jenkins: PreCommit-ZOOKEEPER-github-pr-build-maven #1412

2019-10-08 Thread Apache Jenkins Server 
See 


Changes:


--
[...truncated 708.19 KB...]
Generating 

Generating 

Generating 

Generating 

Building index for all the packages and classes...
Generating 

Generating 

Generating 

Building index for all classes...
Generating 

Generating 

Generating 

Generating 

Generating 

46 warnings
[WARNING] Javadoc Warnings
[WARNING] 
:121:
 warning - Tag @see: can't find getData(String, boolean, DataCallback, Object) 
in org.apache.zookeeper.ZooKeeper
[WARNING] 
:121:
 warning - Tag @see: can't find getData(String, Watcher, DataCallback, Object) 
in org.apache.zookeeper.ZooKeeper
[WARNING] 
:121:
 warning - Tag @see: can't find getConfig(boolean, DataCallback, Object) in 
org.apache.zookeeper.ZooKeeper
[WARNING] 
:121:
 warning - Tag @see: can't find getConfig(Watcher, DataCallback, Object) in 
org.apache.zookeeper.ZooKeeper
[WARNING] 
:340:
 warning - Tag @see: can't find getEphemerals(EphemeralsCallback, Object) in 
org.apache.zookeeper.ZooKeeper
[WARNING] 
:340:
 warning - Tag @see: can't find getEphemerals(String, EphemeralsCallback, 
Object) in org.apache.zookeeper.ZooKeeper
[WARNING] 
:271:
 warning - Tag @link: can't find sync(String, VoidCallback, Object) in 
org.apache.zookeeper.ZooKeeper
[WARNING] 
:150:
 warning - Tag @see: can't find getACL(String, Stat, ACLCallback, Object) in 
org.apache.zookeeper.ZooKeeper
[WARNING] 
:89:
 warning - Tag @see: can't find getAllChildrenNumber(String, 
AllChildrenNumberCallback, Object) in org.apache.zookeeper.ZooKeeper
[WARNING] 
:202:
 warning - Tag @see: can't find getChildren(String, boolean, Children2Callback, 
Object) in org.apache.zookeeper.ZooKeeper
[WARNING]

Jenkins build is back to stable : PreCommit-ZOOKEEPER-github-pr-build-maven #1410

2019-10-08 Thread Apache Jenkins Server 
See

[jira] [Created] (ZOOKEEPER-3570) add the constant for cxid

2019-10-08 Thread maoling (Jira) 
maoling created ZOOKEEPER-3570:
--

 Summary: add the constant for cxid
 Key: ZOOKEEPER-3570
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3570
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.6.0
Reporter: maoling


in the *ClientCnxn*, we had hard-code cxid which is not elegant.

we need a constant for cxid
{code:java}
if (replyHdr.getXid() == -2) {
// -2 is the xid for pings
if (LOG.isDebugEnabled()) {
LOG.debug("Got ping response for sessionid: 0x"
  + Long.toHexString(sessionId)
  + " after "
  + ((System.nanoTime() - lastPingSentNs) / 100)
  + "ms");
}
return;
}
if (replyHdr.getXid() == -4) {
// -4 is the xid for AuthPacket
if (replyHdr.getErr() == KeeperException.Code.AUTHFAILED.intValue()) {
state = States.AUTH_FAILED;
eventThread.queueEvent(new WatchedEvent(Watcher.Event.EventType.None, 
Watcher.Event.KeeperState.AuthFailed, null));
eventThread.queueEventOfDeath();
}
if (LOG.isDebugEnabled()) {
LOG.debug("Got auth sessionid:0x" + Long.toHexString(sessionId));
}
return;
}
if (replyHdr.getXid() == -1) {
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Re: Coding Style

2019-10-08 Thread Zili Chen 
Thanks for your reply Justin.

For duplicated work, I mean we don't need to maintain two files, one is
checkstyle-strict,xml,
the other is eclipse_formatter.xml for the same checkstyle purpose.

I've found the eclipse plugin for checkstyle[1] so that one can reuse
checkstyle-strict.xml for
lint and format code.

Best,
tison.

[1] https://checkstyle.org/eclipse-cs/#!/


Justin Ling Mao  于2019年10月8日周二 下午1:38写道：

> 1. AFAIK, the IDEA also supports  Eclipse Format Template(install Eclipse
> Code Formatter plugin for IDEA) , so no duplicated work.
>
> 2. Since we now use a customized code checkstyle, so we cannot take
> advantage of the ready-make sun/google formatter, we also need a
> customized formatter, just like this:
> https://github.com/apache/hbase/blob/master/dev-support/hbase_eclipse_formatter.xml
>
> 3. Overall, this work is not in a hurry because mvn cmd can tell us where
> is the violations
>
> - Original Message -
> From: Zili Chen 
> To: Justin Ling Mao 
> Cc: dev 
> Subject: Re: Coding Style
> Date: 2019-10-08 10:52
>
> Hi Justin,
>
> If Eclipse has a checkstyle plugin as that in IDEA I don't think we have to
> maintain two versions of code style rules. Otherwise we have to sync one
> with the other when we add/remove rules, which is unnecessarily overhead.
>
> Best,
> tison.
>
>
> Justin Ling Mao  于2019年10月8日周二 上午10:49写道：
>
> 1. Currently, our coding style checker(maven checkstyle plugin) doesn't
> abide by Sun's conventions completely
> 2. maybe we need a eclipse_formatter.xml to  the automatic formatting for
> the IDEs,  https://hbase.apache.org/book.html#eclipse.code.formatting is
> a good example.
> - Original Message -
> From: David Mollitor 
> To: dev@zookeeper.apache.org
> Subject: Coding Style
> Date: 2019-10-08 03:10
>
> Hello,
> I am looking at this page for a coding style format / template.
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> There is a note about it with a link to: "Sun's conventions" (however, the
> link is dead)
> Can someone propose an Eclipse Format Template which has the required
> coding standards required by this project and submit them into 'dev' folder
> in GitHub?
> Thanks!
>
>