[jira] [Created] (ZOOKEEPER-3802) RAT check fails on fatjar module
Enrico Olivelli created ZOOKEEPER-3802: -- Summary: RAT check fails on fatjar module Key: ZOOKEEPER-3802 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3802 Project: ZooKeeper Issue Type: Task Components: build Affects Versions: 3.6.1 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
sg. Merged onto both. Thanks all! Patrick On Sat, Apr 18, 2020 at 10:08 AM Enrico Olivelli wrote: > Patrick, > Yes only to be merged to branch3.6 and release-3.6.1 > > Thanks > Enrico > > Il Sab 18 Apr 2020, 18:25 Christopher ha scritto: > > > 3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same > > issues and more for master/3.7 > > > > On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote: > > > > > I can take a look. Does this need to go into just 3.6.1 or other > branches > > > as well? The JIRA says just 3.6.1,is that right? > > > > > > Patrick > > > > > > On Sat, Apr 18, 2020 at 6:02 AM Enrico Olivelli > > > wrote: > > > > > > > PR is finally ready > > > > https://github.com/apache/zookeeper/pull/1323 > > > > > > > > Looking for some committer to help me merge that patch > > > > > > > > Enrico > > > > > > > > Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli < > > > > eolive...@gmail.com> ha scritto: > > > > > > > > > Thank you Christopher > > > > > > > > > > We are iterating over #1323. > > > > > I think we can finish the work today > > > > > > > > > > Enrico > > > > > > > > > > Il giorno sab 18 apr 2020 alle ore 09:39 Christopher < > > > > ctubb...@apache.org> > > > > > ha scritto: > > > > > > > > > >> +1 to that approach. I reviewed and made a suggestion on the PR at > > > > >> https://github.com/apache/zookeeper/pull/1323 > > > > >> > > > > >> On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli < > > eolive...@gmail.com> > > > > >> wrote: > > > > >> > > > > > >> > This is my patch. > > > > >> > Basically it adds back the fatjar module to the full-build > profile > > > > >> > this way we have only one profile that actually does the "full > > > build" > > > > = > > > > >> all > > > > >> > maven modules > > > > >> > > > > > >> > I feel this is a very clear way for users, > > > > >> > mvn clean package -Pfull-build > > > > >> > this builds the whole repository > > > > >> > > > > > >> > Enrico > > > > >> > > > > > >> > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < > > > > >> > eolive...@gmail.com> ha scritto: > > > > >> > > > > > >> > > Hi, > > > > >> > > Branch-3.6 is broken due to the fatjat stuff > > > > >> > > > > > > >> > > [eolivelli@localhost zookeeper]$ mvn clean > -Pfull-build,fatjar > > > > >> > > [INFO] Scanning for projects... > > > > >> > > [ERROR] [ERROR] Project > > > > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' > > is > > > > >> > > duplicated in the reactor @ > > > > >> > > [ERROR] Project > > > > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' > > is > > > > >> > > duplicated in the reactor -> [Help 1] > > > > >> > > [ERROR] > > > > >> > > > > > > >> > > > > > > >> > > I am preparing a fix > > > > >> > > > > > > >> > > Enrico > > > > >> > > > > > > >> > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < > > > > >> > > eolive...@gmail.com> ha scritto: > > > > >> > > > > > > >> > >> > > > > >> > >> > > > > >> > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli < > eolive...@gmail.com > > > > > > ha > > > > >> > >> scritto: > > > > >> > >> > > > > >> > >>> Thank you Christopher ! > > > > >> > >>> > > > > >> > >>> I have manually fixed the pom.xml files in branch-3.6 and > > > > >> release-3.6.1 > > > > >> > >>> branches. > > > > >> > >>> > > > > >> > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is > now > > > > >> > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) > > > > >> > >>> > > > > >> > >> > > > > >> > >> I will try to perform the release without ZOOKEEPER-3791 > > > > >> > >> > > > > >> > >> Enrico > > > > >> > >> > > > > >> > >> > > > > >> > >> > > > > >> > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed > > > > already > > > > >> > >>> started a review. > > > > >> > >>> > > > > >> > >>> I hope we can fix this stuff soon, this way we can release > > 3.6.1 > > > > to > > > > >> the > > > > >> > >>> public > > > > >> > >>> > > > > >> > >>> Enrico > > > > >> > >>> > > > > >> > >>> > > > > >> > >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < > > > > >> > >>> ctubb...@apache.org> ha scritto: > > > > >> > >>> > > > > >> > On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli < > > > > >> eolive...@gmail.com> > > > > >> > wrote: > > > > >> > > > > > > >> > > Christopher, > > > > >> > > answers inline. > > > > >> > > Thank you for testing ! > > > > >> > > > > > > >> > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < > > > > >> > ctubb...@apache.org> > > > > >> > > ha scritto: > > > > >> > > > > > > >> > > > -0 (non-binding), I did find some problems that prevent > > > some > > > > >> maven > > > > >> > > > profiles, including fatjar, from being activated, among > > > other > > > > >> minor > > > > >> > > > issues; nothing too serious, but the inability to run > the > > > > >> fatjar > > > > >> > > > profile might be a blocker for some, as might be the > > > missing > >
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
Patrick, Yes only to be merged to branch3.6 and release-3.6.1 Thanks Enrico Il Sab 18 Apr 2020, 18:25 Christopher ha scritto: > 3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same > issues and more for master/3.7 > > On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote: > > > I can take a look. Does this need to go into just 3.6.1 or other branches > > as well? The JIRA says just 3.6.1,is that right? > > > > Patrick > > > > On Sat, Apr 18, 2020 at 6:02 AM Enrico Olivelli > > wrote: > > > > > PR is finally ready > > > https://github.com/apache/zookeeper/pull/1323 > > > > > > Looking for some committer to help me merge that patch > > > > > > Enrico > > > > > > Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli < > > > eolive...@gmail.com> ha scritto: > > > > > > > Thank you Christopher > > > > > > > > We are iterating over #1323. > > > > I think we can finish the work today > > > > > > > > Enrico > > > > > > > > Il giorno sab 18 apr 2020 alle ore 09:39 Christopher < > > > ctubb...@apache.org> > > > > ha scritto: > > > > > > > >> +1 to that approach. I reviewed and made a suggestion on the PR at > > > >> https://github.com/apache/zookeeper/pull/1323 > > > >> > > > >> On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli < > eolive...@gmail.com> > > > >> wrote: > > > >> > > > > >> > This is my patch. > > > >> > Basically it adds back the fatjar module to the full-build profile > > > >> > this way we have only one profile that actually does the "full > > build" > > > = > > > >> all > > > >> > maven modules > > > >> > > > > >> > I feel this is a very clear way for users, > > > >> > mvn clean package -Pfull-build > > > >> > this builds the whole repository > > > >> > > > > >> > Enrico > > > >> > > > > >> > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < > > > >> > eolive...@gmail.com> ha scritto: > > > >> > > > > >> > > Hi, > > > >> > > Branch-3.6 is broken due to the fatjat stuff > > > >> > > > > > >> > > [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar > > > >> > > [INFO] Scanning for projects... > > > >> > > [ERROR] [ERROR] Project > > > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' > is > > > >> > > duplicated in the reactor @ > > > >> > > [ERROR] Project > > > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' > is > > > >> > > duplicated in the reactor -> [Help 1] > > > >> > > [ERROR] > > > >> > > > > > >> > > > > > >> > > I am preparing a fix > > > >> > > > > > >> > > Enrico > > > >> > > > > > >> > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < > > > >> > > eolive...@gmail.com> ha scritto: > > > >> > > > > > >> > >> > > > >> > >> > > > >> > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli > > > ha > > > >> > >> scritto: > > > >> > >> > > > >> > >>> Thank you Christopher ! > > > >> > >>> > > > >> > >>> I have manually fixed the pom.xml files in branch-3.6 and > > > >> release-3.6.1 > > > >> > >>> branches. > > > >> > >>> > > > >> > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now > > > >> > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) > > > >> > >>> > > > >> > >> > > > >> > >> I will try to perform the release without ZOOKEEPER-3791 > > > >> > >> > > > >> > >> Enrico > > > >> > >> > > > >> > >> > > > >> > >> > > > >> > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed > > > already > > > >> > >>> started a review. > > > >> > >>> > > > >> > >>> I hope we can fix this stuff soon, this way we can release > 3.6.1 > > > to > > > >> the > > > >> > >>> public > > > >> > >>> > > > >> > >>> Enrico > > > >> > >>> > > > >> > >>> > > > >> > >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < > > > >> > >>> ctubb...@apache.org> ha scritto: > > > >> > >>> > > > >> > On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli < > > > >> eolive...@gmail.com> > > > >> > wrote: > > > >> > > > > > >> > > Christopher, > > > >> > > answers inline. > > > >> > > Thank you for testing ! > > > >> > > > > > >> > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < > > > >> > ctubb...@apache.org> > > > >> > > ha scritto: > > > >> > > > > > >> > > > -0 (non-binding), I did find some problems that prevent > > some > > > >> maven > > > >> > > > profiles, including fatjar, from being activated, among > > other > > > >> minor > > > >> > > > issues; nothing too serious, but the inability to run the > > > >> fatjar > > > >> > > > profile might be a blocker for some, as might be the > > missing > > > >> patch > > > >> > for > > > >> > > > ipv6 comparisons in the C client. > > > >> > > > > > > >> > > > Good > > > >> > > > * I tested the convenience binary with Apache Accumulo > > 2.0.0 > > > >> and > > > >> > basic > > > >> > > > functionality is all there > > > >> > > > * I checked the LICENSE.txt/NOTICE.txt files for expected > > > >> content > > > >> > > > (copyright year was 2
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same issues and more for master/3.7 On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote: > I can take a look. Does this need to go into just 3.6.1 or other branches > as well? The JIRA says just 3.6.1,is that right? > > Patrick > > On Sat, Apr 18, 2020 at 6:02 AM Enrico Olivelli > wrote: > > > PR is finally ready > > https://github.com/apache/zookeeper/pull/1323 > > > > Looking for some committer to help me merge that patch > > > > Enrico > > > > Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli < > > eolive...@gmail.com> ha scritto: > > > > > Thank you Christopher > > > > > > We are iterating over #1323. > > > I think we can finish the work today > > > > > > Enrico > > > > > > Il giorno sab 18 apr 2020 alle ore 09:39 Christopher < > > ctubb...@apache.org> > > > ha scritto: > > > > > >> +1 to that approach. I reviewed and made a suggestion on the PR at > > >> https://github.com/apache/zookeeper/pull/1323 > > >> > > >> On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli > > >> wrote: > > >> > > > >> > This is my patch. > > >> > Basically it adds back the fatjar module to the full-build profile > > >> > this way we have only one profile that actually does the "full > build" > > = > > >> all > > >> > maven modules > > >> > > > >> > I feel this is a very clear way for users, > > >> > mvn clean package -Pfull-build > > >> > this builds the whole repository > > >> > > > >> > Enrico > > >> > > > >> > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < > > >> > eolive...@gmail.com> ha scritto: > > >> > > > >> > > Hi, > > >> > > Branch-3.6 is broken due to the fatjat stuff > > >> > > > > >> > > [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar > > >> > > [INFO] Scanning for projects... > > >> > > [ERROR] [ERROR] Project > > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > > >> > > duplicated in the reactor @ > > >> > > [ERROR] Project > > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > > >> > > duplicated in the reactor -> [Help 1] > > >> > > [ERROR] > > >> > > > > >> > > > > >> > > I am preparing a fix > > >> > > > > >> > > Enrico > > >> > > > > >> > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < > > >> > > eolive...@gmail.com> ha scritto: > > >> > > > > >> > >> > > >> > >> > > >> > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli > ha > > >> > >> scritto: > > >> > >> > > >> > >>> Thank you Christopher ! > > >> > >>> > > >> > >>> I have manually fixed the pom.xml files in branch-3.6 and > > >> release-3.6.1 > > >> > >>> branches. > > >> > >>> > > >> > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now > > >> > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) > > >> > >>> > > >> > >> > > >> > >> I will try to perform the release without ZOOKEEPER-3791 > > >> > >> > > >> > >> Enrico > > >> > >> > > >> > >> > > >> > >> > > >> > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed > > already > > >> > >>> started a review. > > >> > >>> > > >> > >>> I hope we can fix this stuff soon, this way we can release 3.6.1 > > to > > >> the > > >> > >>> public > > >> > >>> > > >> > >>> Enrico > > >> > >>> > > >> > >>> > > >> > >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < > > >> > >>> ctubb...@apache.org> ha scritto: > > >> > >>> > > >> > On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli < > > >> eolive...@gmail.com> > > >> > wrote: > > >> > > > > >> > > Christopher, > > >> > > answers inline. > > >> > > Thank you for testing ! > > >> > > > > >> > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < > > >> > ctubb...@apache.org> > > >> > > ha scritto: > > >> > > > > >> > > > -0 (non-binding), I did find some problems that prevent > some > > >> maven > > >> > > > profiles, including fatjar, from being activated, among > other > > >> minor > > >> > > > issues; nothing too serious, but the inability to run the > > >> fatjar > > >> > > > profile might be a blocker for some, as might be the > missing > > >> patch > > >> > for > > >> > > > ipv6 comparisons in the C client. > > >> > > > > > >> > > > Good > > >> > > > * I tested the convenience binary with Apache Accumulo > 2.0.0 > > >> and > > >> > basic > > >> > > > functionality is all there > > >> > > > * I checked the LICENSE.txt/NOTICE.txt files for expected > > >> content > > >> > > > (copyright year was 2020, as expected) > > >> > > > * Provided SHA512 signatures and GPG signatures match the > > >> tarballs > > >> > > > (though the .sha512 files don't have terminating EOL chars) > > >> > > > > > >> > > > > > >> > > > >> > > > 3cc33e7630eb47e5807bc90610ae084c603960645ab36d4d6f775715ea75a7041835507029a2ca815ae16f4b8110bf9001a602ed78f0a7866c11dc15643b747c > > >> > > > apache-zookeeper-3.6.1-bin.tar.gz > > >> > > > > > >> >
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
I can take a look. Does this need to go into just 3.6.1 or other branches as well? The JIRA says just 3.6.1,is that right? Patrick On Sat, Apr 18, 2020 at 6:02 AM Enrico Olivelli wrote: > PR is finally ready > https://github.com/apache/zookeeper/pull/1323 > > Looking for some committer to help me merge that patch > > Enrico > > Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > > > Thank you Christopher > > > > We are iterating over #1323. > > I think we can finish the work today > > > > Enrico > > > > Il giorno sab 18 apr 2020 alle ore 09:39 Christopher < > ctubb...@apache.org> > > ha scritto: > > > >> +1 to that approach. I reviewed and made a suggestion on the PR at > >> https://github.com/apache/zookeeper/pull/1323 > >> > >> On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli > >> wrote: > >> > > >> > This is my patch. > >> > Basically it adds back the fatjar module to the full-build profile > >> > this way we have only one profile that actually does the "full build" > = > >> all > >> > maven modules > >> > > >> > I feel this is a very clear way for users, > >> > mvn clean package -Pfull-build > >> > this builds the whole repository > >> > > >> > Enrico > >> > > >> > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < > >> > eolive...@gmail.com> ha scritto: > >> > > >> > > Hi, > >> > > Branch-3.6 is broken due to the fatjat stuff > >> > > > >> > > [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar > >> > > [INFO] Scanning for projects... > >> > > [ERROR] [ERROR] Project > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > >> > > duplicated in the reactor @ > >> > > [ERROR] Project > >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > >> > > duplicated in the reactor -> [Help 1] > >> > > [ERROR] > >> > > > >> > > > >> > > I am preparing a fix > >> > > > >> > > Enrico > >> > > > >> > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < > >> > > eolive...@gmail.com> ha scritto: > >> > > > >> > >> > >> > >> > >> > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli ha > >> > >> scritto: > >> > >> > >> > >>> Thank you Christopher ! > >> > >>> > >> > >>> I have manually fixed the pom.xml files in branch-3.6 and > >> release-3.6.1 > >> > >>> branches. > >> > >>> > >> > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now > >> > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) > >> > >>> > >> > >> > >> > >> I will try to perform the release without ZOOKEEPER-3791 > >> > >> > >> > >> Enrico > >> > >> > >> > >> > >> > >> > >> > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed > already > >> > >>> started a review. > >> > >>> > >> > >>> I hope we can fix this stuff soon, this way we can release 3.6.1 > to > >> the > >> > >>> public > >> > >>> > >> > >>> Enrico > >> > >>> > >> > >>> > >> > >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < > >> > >>> ctubb...@apache.org> ha scritto: > >> > >>> > >> > On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli < > >> eolive...@gmail.com> > >> > wrote: > >> > > > >> > > Christopher, > >> > > answers inline. > >> > > Thank you for testing ! > >> > > > >> > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < > >> > ctubb...@apache.org> > >> > > ha scritto: > >> > > > >> > > > -0 (non-binding), I did find some problems that prevent some > >> maven > >> > > > profiles, including fatjar, from being activated, among other > >> minor > >> > > > issues; nothing too serious, but the inability to run the > >> fatjar > >> > > > profile might be a blocker for some, as might be the missing > >> patch > >> > for > >> > > > ipv6 comparisons in the C client. > >> > > > > >> > > > Good > >> > > > * I tested the convenience binary with Apache Accumulo 2.0.0 > >> and > >> > basic > >> > > > functionality is all there > >> > > > * I checked the LICENSE.txt/NOTICE.txt files for expected > >> content > >> > > > (copyright year was 2020, as expected) > >> > > > * Provided SHA512 signatures and GPG signatures match the > >> tarballs > >> > > > (though the .sha512 files don't have terminating EOL chars) > >> > > > > >> > > > > >> > > >> > 3cc33e7630eb47e5807bc90610ae084c603960645ab36d4d6f775715ea75a7041835507029a2ca815ae16f4b8110bf9001a602ed78f0a7866c11dc15643b747c > >> > > > apache-zookeeper-3.6.1-bin.tar.gz > >> > > > > >> > > > > >> > > >> > 21741f5ee09a8ad897da965c4e3570e4dd7d3a24bf990a8d77738144f4ca883ae6ccf86eb6f9a248c772ef2a22eaed438f4f3313166f89b8e28448d59a6ea7bd > >> > > > apache-zookeeper-3.6.1.tar.gz > >> > > > * The contents of the source tarball match the contents of > the > >> tag > >> > > > (3ed3a9890472b251f9a6241317feef5f02cc0692) > >> > > > * Was able to build from source using `mvn clean verify > >> -Pfull-build > >> > > > -Dskip
Migration of Hadoop labelled nodes to new dedicated Master
Hi All, A couple of months ago, I wrote to a few project private lists mentioning the need to migrate Hadoop labelled nodes (H0-H21) over to a new dedicated Jenkins Master [1] (a Cloudbees Client Master.). I'd like to revisit this now that I have more time to dedicate to getting this done. However, keeping track across multiple mailing lists, separate conversations that spring up in various places is cumbersome and not realistic. To that end, I have created a new specific mailing list dedicated to the migrations of these nodes, and the projects that use them, over to the new system. The mailing list 'hadoop-migrati...@infra.apache.org' is up and running now (and this will be the first post to it). Previous discussions were on the private PMC lists, (there was some debate about that but I wanted the PMCs initially to be aware of the change,) this new list is public and archived. This email is BCC'd to 13 projects dev lists [2] determined by the https:/ hadoop.apache.org list of Related projects, minus Cassandra whom already have their own dedicated client master [3] and I added Yetus as I think they cross collaborate with many Hadoop based projects. If anyone thinks a project is missing, or should not be on the list, let me know. What I would like from each community, is to decide who is going to help with their project in performing these migrations - ideally 2 or 3 folks who use the current builds.a.o regularly. Those folks should then subscribe to the new dedicated hadoop-migrati...@infra.apache.org mailing lists as soon as possible so we can get started. About the current setup - and I hope this answers previously asked questions on private lists - the new dedicated master is a Cloudbees Client Master 2.204.3.7-rolling. It is not the same setup as the current Jenkins master on builds.a.o - it is not intended to be. It is more or less a 'clean install' in that I have not installed over 500 plugins as is the case on builds.a.o , I would rather we install plugins as we find we need them. So yes, there may be some features missing - the point of having people sign up to the new list is to find out what those are, get them installed, and get your builds to at least the same state they are in currently. We have 2 nodes on there currently for testing, as things progress we can transfer over a couple more, projects can start to migrate their jobs over at any time they are happy , until done. We also need to test auth - the master; and its nodes will be restricted to just Hadoop + Related projects (which is important this list of related projects is correct). No longer will other projects be able to hop on to Hadoop nodes, and no longer will Hadoop related projects be able to hop onto other folks nodes. This is a good thing, and may encourage some providers to donate a few more VMs for dedicated use. For now then, decide who will help with this process, and sign up to the new mailing list, and lets get started! Note I am NOT subscribed to any of your dev lists, so replies please cc the new list. and I will await your presence there to get started. Thanks all. Gavin McDonald (ASF Infra) [1] - https://ci-hadoop.apache.org [2] - hadoop,chukwa,avro,ambari,hbase,hive,mahout,pig,spark,submarine,tez,zookeeper,yetus [3] - https://ci-cassandra.apache.org
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
PR is finally ready https://github.com/apache/zookeeper/pull/1323 Looking for some committer to help me merge that patch Enrico Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Thank you Christopher > > We are iterating over #1323. > I think we can finish the work today > > Enrico > > Il giorno sab 18 apr 2020 alle ore 09:39 Christopher > ha scritto: > >> +1 to that approach. I reviewed and made a suggestion on the PR at >> https://github.com/apache/zookeeper/pull/1323 >> >> On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli >> wrote: >> > >> > This is my patch. >> > Basically it adds back the fatjar module to the full-build profile >> > this way we have only one profile that actually does the "full build" = >> all >> > maven modules >> > >> > I feel this is a very clear way for users, >> > mvn clean package -Pfull-build >> > this builds the whole repository >> > >> > Enrico >> > >> > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < >> > eolive...@gmail.com> ha scritto: >> > >> > > Hi, >> > > Branch-3.6 is broken due to the fatjat stuff >> > > >> > > [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar >> > > [INFO] Scanning for projects... >> > > [ERROR] [ERROR] Project >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is >> > > duplicated in the reactor @ >> > > [ERROR] Project >> > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is >> > > duplicated in the reactor -> [Help 1] >> > > [ERROR] >> > > >> > > >> > > I am preparing a fix >> > > >> > > Enrico >> > > >> > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < >> > > eolive...@gmail.com> ha scritto: >> > > >> > >> >> > >> >> > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli ha >> > >> scritto: >> > >> >> > >>> Thank you Christopher ! >> > >>> >> > >>> I have manually fixed the pom.xml files in branch-3.6 and >> release-3.6.1 >> > >>> branches. >> > >>> >> > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now >> > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) >> > >>> >> > >> >> > >> I will try to perform the release without ZOOKEEPER-3791 >> > >> >> > >> Enrico >> > >> >> > >> >> > >> >> > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed already >> > >>> started a review. >> > >>> >> > >>> I hope we can fix this stuff soon, this way we can release 3.6.1 to >> the >> > >>> public >> > >>> >> > >>> Enrico >> > >>> >> > >>> >> > >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < >> > >>> ctubb...@apache.org> ha scritto: >> > >>> >> > On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli < >> eolive...@gmail.com> >> > wrote: >> > > >> > > Christopher, >> > > answers inline. >> > > Thank you for testing ! >> > > >> > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < >> > ctubb...@apache.org> >> > > ha scritto: >> > > >> > > > -0 (non-binding), I did find some problems that prevent some >> maven >> > > > profiles, including fatjar, from being activated, among other >> minor >> > > > issues; nothing too serious, but the inability to run the >> fatjar >> > > > profile might be a blocker for some, as might be the missing >> patch >> > for >> > > > ipv6 comparisons in the C client. >> > > > >> > > > Good >> > > > * I tested the convenience binary with Apache Accumulo 2.0.0 >> and >> > basic >> > > > functionality is all there >> > > > * I checked the LICENSE.txt/NOTICE.txt files for expected >> content >> > > > (copyright year was 2020, as expected) >> > > > * Provided SHA512 signatures and GPG signatures match the >> tarballs >> > > > (though the .sha512 files don't have terminating EOL chars) >> > > > >> > > > >> > >> 3cc33e7630eb47e5807bc90610ae084c603960645ab36d4d6f775715ea75a7041835507029a2ca815ae16f4b8110bf9001a602ed78f0a7866c11dc15643b747c >> > > > apache-zookeeper-3.6.1-bin.tar.gz >> > > > >> > > > >> > >> 21741f5ee09a8ad897da965c4e3570e4dd7d3a24bf990a8d77738144f4ca883ae6ccf86eb6f9a248c772ef2a22eaed438f4f3313166f89b8e28448d59a6ea7bd >> > > > apache-zookeeper-3.6.1.tar.gz >> > > > * The contents of the source tarball match the contents of the >> tag >> > > > (3ed3a9890472b251f9a6241317feef5f02cc0692) >> > > > * Was able to build from source using `mvn clean verify >> -Pfull-build >> > > > -DskipTests` >> > > > >> > > > Bad >> > > > * The tag (and source tarball) is missing the commit for >> '754cf015f >> > > > ZOOKEEPER-3726: invalid ipv6 address comparison in C client', >> which >> > is >> > > > present in the branch-3.6 branch >> > > >> > > ** This might be resolvable by simply updating the JIRA to mark >> > > > 3.6.2 as the fixVersion instead of 3.6.1, unless it's critical >> to >> > > > include >> > > > >> > > >> > > Done. If ZOO
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
Thank you Christopher We are iterating over #1323. I think we can finish the work today Enrico Il giorno sab 18 apr 2020 alle ore 09:39 Christopher ha scritto: > +1 to that approach. I reviewed and made a suggestion on the PR at > https://github.com/apache/zookeeper/pull/1323 > > On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli > wrote: > > > > This is my patch. > > Basically it adds back the fatjar module to the full-build profile > > this way we have only one profile that actually does the "full build" = > all > > maven modules > > > > I feel this is a very clear way for users, > > mvn clean package -Pfull-build > > this builds the whole repository > > > > Enrico > > > > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < > > eolive...@gmail.com> ha scritto: > > > > > Hi, > > > Branch-3.6 is broken due to the fatjat stuff > > > > > > [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar > > > [INFO] Scanning for projects... > > > [ERROR] [ERROR] Project > > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > > > duplicated in the reactor @ > > > [ERROR] Project > > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > > > duplicated in the reactor -> [Help 1] > > > [ERROR] > > > > > > > > > I am preparing a fix > > > > > > Enrico > > > > > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < > > > eolive...@gmail.com> ha scritto: > > > > > >> > > >> > > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli ha > > >> scritto: > > >> > > >>> Thank you Christopher ! > > >>> > > >>> I have manually fixed the pom.xml files in branch-3.6 and > release-3.6.1 > > >>> branches. > > >>> > > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now > > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) > > >>> > > >> > > >> I will try to perform the release without ZOOKEEPER-3791 > > >> > > >> Enrico > > >> > > >> > > >> > > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed already > > >>> started a review. > > >>> > > >>> I hope we can fix this stuff soon, this way we can release 3.6.1 to > the > > >>> public > > >>> > > >>> Enrico > > >>> > > >>> > > >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < > > >>> ctubb...@apache.org> ha scritto: > > >>> > > On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli < > eolive...@gmail.com> > > wrote: > > > > > > Christopher, > > > answers inline. > > > Thank you for testing ! > > > > > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < > > ctubb...@apache.org> > > > ha scritto: > > > > > > > -0 (non-binding), I did find some problems that prevent some > maven > > > > profiles, including fatjar, from being activated, among other > minor > > > > issues; nothing too serious, but the inability to run the fatjar > > > > profile might be a blocker for some, as might be the missing > patch > > for > > > > ipv6 comparisons in the C client. > > > > > > > > Good > > > > * I tested the convenience binary with Apache Accumulo 2.0.0 and > > basic > > > > functionality is all there > > > > * I checked the LICENSE.txt/NOTICE.txt files for expected > content > > > > (copyright year was 2020, as expected) > > > > * Provided SHA512 signatures and GPG signatures match the > tarballs > > > > (though the .sha512 files don't have terminating EOL chars) > > > > > > > > > > > 3cc33e7630eb47e5807bc90610ae084c603960645ab36d4d6f775715ea75a7041835507029a2ca815ae16f4b8110bf9001a602ed78f0a7866c11dc15643b747c > > > > apache-zookeeper-3.6.1-bin.tar.gz > > > > > > > > > > > 21741f5ee09a8ad897da965c4e3570e4dd7d3a24bf990a8d77738144f4ca883ae6ccf86eb6f9a248c772ef2a22eaed438f4f3313166f89b8e28448d59a6ea7bd > > > > apache-zookeeper-3.6.1.tar.gz > > > > * The contents of the source tarball match the contents of the > tag > > > > (3ed3a9890472b251f9a6241317feef5f02cc0692) > > > > * Was able to build from source using `mvn clean verify > -Pfull-build > > > > -DskipTests` > > > > > > > > Bad > > > > * The tag (and source tarball) is missing the commit for > '754cf015f > > > > ZOOKEEPER-3726: invalid ipv6 address comparison in C client', > which > > is > > > > present in the branch-3.6 branch > > > > > > ** This might be resolvable by simply updating the JIRA to mark > > > > 3.6.2 as the fixVersion instead of 3.6.1, unless it's critical > to > > > > include > > > > > > > > > > Done. If ZOOKEEPER-3726 is not a blocker then I feel we can live > > without it. > > > We can add it in case of the need of a new iteration. > > > > Agreed. Makes sense. > > > > > > > > > * Saw a few unit test failures on Fedora 31 x86_64 with Maven > 3.6.3 > > > > and java-13-openjdk-13.0.2.8-1.rolling.fc31.x86_64 (I ran `mvn > clean > > > > package`
[jira] [Created] (ZOOKEEPER-3801) Fix Jenkins link in pom
Christopher Tubbs created ZOOKEEPER-3801: Summary: Fix Jenkins link in pom Key: ZOOKEEPER-3801 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3801 Project: ZooKeeper Issue Type: Bug Components: build Reporter: Christopher Tubbs Assignee: Christopher Tubbs Fix For: 3.7.0, 3.5.8, 3.6.2 To improve the stability of Jenkins links, the views have been updated to use a single letter prefix. So, the pom.xml should be updated to point to https://builds.apache.org/view/Z/view/ZooKeeper/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3800) improve the log printing the address when QuorumCnxManager#ListenerHandler's port binds
maoling created ZOOKEEPER-3800:
--
Summary: improve the log printing the address when
QuorumCnxManager#ListenerHandler's port binds
Key: ZOOKEEPER-3800
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3800
Project: ZooKeeper
Issue Type: Improvement
Reporter: maoling
Fix For: 3.7.0
1.
{code:java}
LOG.error("Exception while listening", e);{code}
At least, the log should print the address to help me find what port has
conflicted in my host
2. The stack trace is following:
{code:java}
2020-04-17 18:49:24,757 [myid:1] - INFO [main:ZKAuditProvider@42] - ZooKeeper
audit is disabled.
2020-04-17 18:49:24,758 [myid:1] - ERROR
[ListenerHandler-/127.0.0.1:3888:QuorumCnxManager$Listener$ListenerHandler@1093]
- Exception while listening
java.net.BindException: Address already in use (Bind failed)
at java.net.PlainSocketImpl.socketBind(Native Method)
at
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
at java.net.ServerSocket.bind(ServerSocket.java:375)
at java.net.ServerSocket.bind(ServerSocket.java:329)
at
org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener$ListenerHandler.createNewServerSocket(QuorumCnxManager.java:1134)
at
org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener$ListenerHandler.acceptConnections(QuorumCnxManager.java:1064)
at
org.apache.zookeeper.server.quorum.QuorumCnxManager$Listener$ListenerHandler.run(QuorumCnxManager.java:1033)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
2020-04-17 18:49:24,764 [myid:1] - INFO
[QuorumPeer[myid=1](plain=[0:0:0:0:0:0:0:0]:2183)(secure=disabled):QuorumPeer@1371]
- LOOKING
2020-04-17 18:49:24,765 [myid:1] - INFO
[QuorumPeer[myid=1](plain=[0:0:0:0:0:0:0:0]:2183)(secure=disabled):FastLeaderElection@944]
- New election. My id = 1, proposed zxid=0xfab2
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3799) rename CommitProcessor to CommitRequestProcessor
maoling created ZOOKEEPER-3799: -- Summary: rename CommitProcessor to CommitRequestProcessor Key: ZOOKEEPER-3799 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3799 Project: ZooKeeper Issue Type: Improvement Reporter: maoling All the requestProcessors which had implemented interface RequestProcessor named xxxRequestProcessor, but CommitProcessor is an exception. we should rename CommitProcessor to CommitRequestProcessor for the naming uniformity. # also refactor the related documentations and javaDocs # against master, also the branch3.5 and branch3.6 for the uniformity -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3798) remove the useless code in the ProposalRequestProcessor#processRequest
maoling created ZOOKEEPER-3798:
--
Summary: remove the useless code in the
ProposalRequestProcessor#processRequest
Key: ZOOKEEPER-3798
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3798
Project: ZooKeeper
Issue Type: Improvement
Components: server
Reporter: maoling
Fix For: 3.7.0
remove the following useless codes in the
ProposalRequestProcessor#processRequest
{code:java}
public void processRequest(Request request) throws RequestProcessorException {
// LOG.warn("Ack>>> cxid = " + request.cxid + " type = " +
// request.type + " id = " + request.sessionId);
// request.addRQRec(">prop");
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
+1 to that approach. I reviewed and made a suggestion on the PR at https://github.com/apache/zookeeper/pull/1323 On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli wrote: > > This is my patch. > Basically it adds back the fatjar module to the full-build profile > this way we have only one profile that actually does the "full build" = all > maven modules > > I feel this is a very clear way for users, > mvn clean package -Pfull-build > this builds the whole repository > > Enrico > > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > > > Hi, > > Branch-3.6 is broken due to the fatjat stuff > > > > [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar > > [INFO] Scanning for projects... > > [ERROR] [ERROR] Project > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > > duplicated in the reactor @ > > [ERROR] Project > > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > > duplicated in the reactor -> [Help 1] > > [ERROR] > > > > > > I am preparing a fix > > > > Enrico > > > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < > > eolive...@gmail.com> ha scritto: > > > >> > >> > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli ha > >> scritto: > >> > >>> Thank you Christopher ! > >>> > >>> I have manually fixed the pom.xml files in branch-3.6 and release-3.6.1 > >>> branches. > >>> > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) > >>> > >> > >> I will try to perform the release without ZOOKEEPER-3791 > >> > >> Enrico > >> > >> > >> > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed already > >>> started a review. > >>> > >>> I hope we can fix this stuff soon, this way we can release 3.6.1 to the > >>> public > >>> > >>> Enrico > >>> > >>> > >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < > >>> ctubb...@apache.org> ha scritto: > >>> > On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli > wrote: > > > > Christopher, > > answers inline. > > Thank you for testing ! > > > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < > ctubb...@apache.org> > > ha scritto: > > > > > -0 (non-binding), I did find some problems that prevent some maven > > > profiles, including fatjar, from being activated, among other minor > > > issues; nothing too serious, but the inability to run the fatjar > > > profile might be a blocker for some, as might be the missing patch > for > > > ipv6 comparisons in the C client. > > > > > > Good > > > * I tested the convenience binary with Apache Accumulo 2.0.0 and > basic > > > functionality is all there > > > * I checked the LICENSE.txt/NOTICE.txt files for expected content > > > (copyright year was 2020, as expected) > > > * Provided SHA512 signatures and GPG signatures match the tarballs > > > (though the .sha512 files don't have terminating EOL chars) > > > > > > > 3cc33e7630eb47e5807bc90610ae084c603960645ab36d4d6f775715ea75a7041835507029a2ca815ae16f4b8110bf9001a602ed78f0a7866c11dc15643b747c > > > apache-zookeeper-3.6.1-bin.tar.gz > > > > > > > 21741f5ee09a8ad897da965c4e3570e4dd7d3a24bf990a8d77738144f4ca883ae6ccf86eb6f9a248c772ef2a22eaed438f4f3313166f89b8e28448d59a6ea7bd > > > apache-zookeeper-3.6.1.tar.gz > > > * The contents of the source tarball match the contents of the tag > > > (3ed3a9890472b251f9a6241317feef5f02cc0692) > > > * Was able to build from source using `mvn clean verify -Pfull-build > > > -DskipTests` > > > > > > Bad > > > * The tag (and source tarball) is missing the commit for '754cf015f > > > ZOOKEEPER-3726: invalid ipv6 address comparison in C client', which > is > > > present in the branch-3.6 branch > > > > ** This might be resolvable by simply updating the JIRA to mark > > > 3.6.2 as the fixVersion instead of 3.6.1, unless it's critical to > > > include > > > > > > > Done. If ZOOKEEPER-3726 is not a blocker then I feel we can live > without it. > > We can add it in case of the need of a new iteration. > > Agreed. Makes sense. > > > > > > * Saw a few unit test failures on Fedora 31 x86_64 with Maven 3.6.3 > > > and java-13-openjdk-13.0.2.8-1.rolling.fc31.x86_64 (I ran `mvn clean > > > package`) > > > ** > org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest > > > failed with AssertionError > > > ** org.apache.zookeeper.server.quorum.QuorumDigestTest failed with > > > AssertionError > > > > > Does it pass if you rerun it again ? This test is not failing for me > (on > > Linux + jdk8) > > They both pass on a second run, when I ran them in isolation. It might > just be because surefire forkCount is 8
Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0
This is my patch. Basically it adds back the fatjar module to the full-build profile this way we have only one profile that actually does the "full build" = all maven modules I feel this is a very clear way for users, mvn clean package -Pfull-build this builds the whole repository Enrico Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Hi, > Branch-3.6 is broken due to the fatjat stuff > > [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar > [INFO] Scanning for projects... > [ERROR] [ERROR] Project > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > duplicated in the reactor @ > [ERROR] Project > 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is > duplicated in the reactor -> [Help 1] > [ERROR] > > > I am preparing a fix > > Enrico > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > >> >> >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli ha >> scritto: >> >>> Thank you Christopher ! >>> >>> I have manually fixed the pom.xml files in branch-3.6 and release-3.6.1 >>> branches. >>> >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is now >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT) >>> >> >> I will try to perform the release without ZOOKEEPER-3791 >> >> Enrico >> >> >> >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin Reed already >>> started a review. >>> >>> I hope we can fix this stuff soon, this way we can release 3.6.1 to the >>> public >>> >>> Enrico >>> >>> >>> Il giorno gio 16 apr 2020 alle ore 23:08 Christopher < >>> ctubb...@apache.org> ha scritto: >>> On Thu, Apr 16, 2020 at 9:52 AM Enrico Olivelli wrote: > > Christopher, > answers inline. > Thank you for testing ! > > Il giorno gio 16 apr 2020 alle ore 15:12 Christopher < ctubb...@apache.org> > ha scritto: > > > -0 (non-binding), I did find some problems that prevent some maven > > profiles, including fatjar, from being activated, among other minor > > issues; nothing too serious, but the inability to run the fatjar > > profile might be a blocker for some, as might be the missing patch for > > ipv6 comparisons in the C client. > > > > Good > > * I tested the convenience binary with Apache Accumulo 2.0.0 and basic > > functionality is all there > > * I checked the LICENSE.txt/NOTICE.txt files for expected content > > (copyright year was 2020, as expected) > > * Provided SHA512 signatures and GPG signatures match the tarballs > > (though the .sha512 files don't have terminating EOL chars) > > > > 3cc33e7630eb47e5807bc90610ae084c603960645ab36d4d6f775715ea75a7041835507029a2ca815ae16f4b8110bf9001a602ed78f0a7866c11dc15643b747c > > apache-zookeeper-3.6.1-bin.tar.gz > > > > 21741f5ee09a8ad897da965c4e3570e4dd7d3a24bf990a8d77738144f4ca883ae6ccf86eb6f9a248c772ef2a22eaed438f4f3313166f89b8e28448d59a6ea7bd > > apache-zookeeper-3.6.1.tar.gz > > * The contents of the source tarball match the contents of the tag > > (3ed3a9890472b251f9a6241317feef5f02cc0692) > > * Was able to build from source using `mvn clean verify -Pfull-build > > -DskipTests` > > > > Bad > > * The tag (and source tarball) is missing the commit for '754cf015f > > ZOOKEEPER-3726: invalid ipv6 address comparison in C client', which is > > present in the branch-3.6 branch > > ** This might be resolvable by simply updating the JIRA to mark > > 3.6.2 as the fixVersion instead of 3.6.1, unless it's critical to > > include > > > > Done. If ZOOKEEPER-3726 is not a blocker then I feel we can live without it. > We can add it in case of the need of a new iteration. Agreed. Makes sense. > > > * Saw a few unit test failures on Fedora 31 x86_64 with Maven 3.6.3 > > and java-13-openjdk-13.0.2.8-1.rolling.fc31.x86_64 (I ran `mvn clean > > package`) > > ** org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest > > failed with AssertionError > > ** org.apache.zookeeper.server.quorum.QuorumDigestTest failed with > > AssertionError > > > Does it pass if you rerun it again ? This test is not failing for me (on > Linux + jdk8) They both pass on a second run, when I ran them in isolation. It might just be because surefire forkCount is 8, and my laptop is slow. Not sure. Would need further investigation. I'm not worried about this, though, and wouldn't consider it a blocker... but I might open up a JIRA if I see it again and can capture a stack trace or logs. > > > > * release did not appear to be prepared using the maven-release-plugin > > from the branch-3.6, but from a different (local?) branch; this > > resulted in a few
[jira] [Created] (ZOOKEEPER-3797) Conflict between fatjar and full-build Maven profiles in branch-3.6
Enrico Olivelli created ZOOKEEPER-3797:
--
Summary: Conflict between fatjar and full-build Maven profiles in
branch-3.6
Key: ZOOKEEPER-3797
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3797
Project: ZooKeeper
Issue Type: Bug
Components: build
Affects Versions: 3.6.1
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Fix For: 3.6.1
fatjat and full-build profiles conflict, because both enable the fatjar module.
but with full-build the fatjar is not actually built.
This is an example of error
{code:java}
[eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar
[INFO] Scanning for projects...
[ERROR] [ERROR] Project
'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is duplicated in
the reactor @
[ERROR] Project 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT'
is duplicated in the reactor -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, pl
{code}
The minimal fix is to enable fatjar even with full-build profile.
The full-build profile is meant to build all of the modules, and it is used
during the release process as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
