[jira] [Created] (ZOOKEEPER-4021) Zookeeper C Client ERROR about poll
lyg created ZOOKEEPER-4021: -- Summary: Zookeeper C Client ERROR about poll Key: ZOOKEEPER-4021 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4021 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.5.8 Environment: CentOS Linux release 7.8.2003 (Core) Reporter: lyg Zookeeper c client request server by dns ， when the zookeeper server and dns server down at the same time ， c client poll will set revent to POLLNVAL . At this time The parameter timeout of poll is not valid. it cause very frequent requests and high cpu use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-4020) Memory leak in Zookeeper C Client
Roger Luo created ZOOKEEPER-4020:
Summary: Memory leak in Zookeeper C Client
Key: ZOOKEEPER-4020
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4020
Project: ZooKeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.6.2
Reporter: Roger Luo
There is memory leak in the SSL support of Zookeeper C Client, see below code
(line 1457 of zookeeper.c):
{code:java}
zcert.ca = strtok(strdup(cert), ",");
{code}
In the above code, memory is allocated by calling strdup, but it's never been
released.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-4019) FileChangeWatcher keep throwing exceptions on k8s deployment
Yassin Mohii created ZOOKEEPER-4019:
---
Summary: FileChangeWatcher keep throwing exceptions on k8s
deployment
Key: ZOOKEEPER-4019
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4019
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.6.1
Reporter: Yassin Mohii
Using zookeeper 3.6.1 on k8s cluster, the deployment keep throwing this
exception every 3~5 minutes.
{code:java}
ERROR [FileChangeWatcher:FileChangeWatcher$WatcherThread@223] - Error from
callbackERROR [FileChangeWatcher:FileChangeWatcher$WatcherThread@223] - Error
from callbackjava.lang.RuntimeException:
org.apache.zookeeper.common.X509Exception$SSLContextException: Failed to create
KeyManager at
org.apache.zookeeper.common.X509Util.handleWatchEvent(X509Util.java:638)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.lambda$newFileChangeWatcher$0(X509Util.java:562)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.FileChangeWatcher$WatcherThread.runLoop(FileChangeWatcher.java:221)
[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.FileChangeWatcher$WatcherThread.run(FileChangeWatcher.java:194)
[zookeeper-3.6.1.jar:3.6.1]Caused by:
org.apache.zookeeper.common.X509Exception$SSLContextException: Failed to create
KeyManager at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptionsFromConfig(X509Util.java:350)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptions(X509Util.java:328)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptions(X509Util.java:282)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.resetDefaultSSLContextAndOptions(X509Util.java:272)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.handleWatchEvent(X509Util.java:636)
~[zookeeper-3.6.1.jar:3.6.1] ... 3 moreCaused by:
org.apache.zookeeper.common.X509Exception$KeyManagerException:
java.security.KeyStoreException: did not find a private key at
org.apache.zookeeper.common.X509Util.createKeyManager(X509Util.java:447)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptionsFromConfig(X509Util.java:348)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptions(X509Util.java:328)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptions(X509Util.java:282)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.resetDefaultSSLContextAndOptions(X509Util.java:272)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.handleWatchEvent(X509Util.java:636)
~[zookeeper-3.6.1.jar:3.6.1] ... 3 moreCaused by:
java.security.KeyStoreException: did not find a private key at
org.apache.zookeeper.util.PemReader.loadPrivateKey(PemReader.java:148)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.util.PemReader.loadPrivateKey(PemReader.java:142)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.util.PemReader.loadKeyStore(PemReader.java:103)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.PEMFileLoader.loadKeyStore(PEMFileLoader.java:50)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.loadKeyStore(X509Util.java:400)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createKeyManager(X509Util.java:436)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptionsFromConfig(X509Util.java:348)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptions(X509Util.java:328)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.createSSLContextAndOptions(X509Util.java:282)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.resetDefaultSSLContextAndOptions(X509Util.java:272)
~[zookeeper-3.6.1.jar:3.6.1] at
org.apache.zookeeper.common.X509Util.handleWatchEvent(X509Util.java:636)
~[zookeeper-3.6.1.jar:3.6.1] ... 3 more
{code}
When enabling the debug logs it appears that it tries to reload the key
certificates and it fails on the first try then succeeds afterwards,
Worth to mention here that the certificates are not renewed this frequently
anyway.
Logs when enabling Debug
{code:java}
2020-12-02T12:32:33.846+ [myid:] - DEBUG
[FileChangeWatcher:FileChangeWatcher$WatcherThread@219] - Got file changed
event: ENTRY_MODIFY with context:
..2020_12_02_12_23_22.5578198682020-12-02T12:32:33.846+ [myid:] - DEBUG
[FileChangeWatcher:FileChangeWatcher$WatcherThread@219] - Got file changed
event: ENTRY_MODIFY with context:
..2020_12_02_12_23_22.5578198682020-12-02T12:32:33.846+ [myid:] - DEBUG
[FileChangeWatcher:X509Util@641] - Ignoring watch event and keeping previous
default SSL context. Event kind: ENTRY_MODIFY with context:
Re: [VOTE] Apache ZooKeeper release 3.5.9 candidate 0
+1 (binding) - verified signatures and checksums - run smoke tests with server binaries on Linux Fedora (with JDK15) - built with JDK8 and run tests (even C-client) - verified rat and checkstyle - checked license files - run thru the release notes We have still a few inconsistencies in the way we handle licence files, we should have a consistent approach and add some automatic check. For instance we have only one LICENSE file for slfj4 and one file per each Jetty jar thank you Norbert for putting this together Enrico Il giorno mar 1 dic 2020 alle ore 17:58 Norbert Kalmar ha scritto: > This is a bugfix release candidate for 3.5.9. It contains 24 fixes, > including 2 CVE fix. > > The full release notes is available at: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12348201 > > *** Please download, test and vote by December 4th 2020, 23:59 UTC+0. *** > > Source files: > https://people.apache.org/~nkalmar/zookeeper-3.5.9-candidate-0/ > > Maven staging repo: > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.9/ > > The release candidate tag in git to be voted upon: release-3.5.9-rc0 > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > https://www.apache.org/dist/zookeeper/KEYS > > Should we release this candidate? > > - Norbert >
