[jira] [Created] (ZOOKEEPER-4212) add committer checklist to zk-merge-pr.py

2021-02-16 Thread Ling Mao (Jira)
Ling Mao created ZOOKEEPER-4212:
---

 Summary: add committer checklist to zk-merge-pr.py
 Key: ZOOKEEPER-4212
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4212
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: Ling Mao
Assignee: Ling Mao






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Removing Java 11 CI job

2021-02-16 Thread Christopher
Cool. Go ahead. I have not tested it on anything other than the master
branch, though.

On Tue, Feb 16, 2021 at 10:03 AM Enrico Olivelli  wrote:
>
> Perfect!
> I have approved the patch
>
> I would like to commit it ASAP
>
> Enrico
>
> Il giorno mar 16 feb 2021 alle ore 15:51 Christopher 
> ha scritto:
>
> > I changed the surefire-forkCount to 1, instead of 1C in
> > https://github.com/apache/zookeeper/pull/1606 and the "Address in use"
> > error goes away, and tests pass on Java 11. I saw it pass once in my
> > branch. It is currently running in the PR, and if it completes, I
> > recommend making that change, instead of disabling it.
> >
> > On Tue, Feb 16, 2021 at 8:55 AM Enrico Olivelli 
> > wrote:
> > >
> > > Hello,
> > > Currently the new Java 11 CI job is not passing and it is very annoying
> > for
> > > every PR validation.
> > >
> > > I suggest to remove it and add it again when we know that it is
> > > working properly
> > >
> > > Thoughts ?
> > > Enrico
> >


Re: collecting and exposing quota related metrics to Prometheus

2021-02-16 Thread Li Wang
Awesome!  I will work on that.

JIRA ticket created: https://issues.apache.org/jira/browse/ZOOKEEPER-4211

On Tue, Feb 16, 2021 at 6:02 AM Justin Ling Mao 
wrote:

> @Li Wang
>
> Great addition, we really need this. Please help us to do this:)
>
>
>
> - Original Message -
> From: Li Wang 
> To: dev@zookeeper.apache.org
> Subject: collecting and exposing quota related metrics to Prometheus
> Date: 2021-02-16 09:23
>
> Hi,
> In 3.7, Quota limit can be enforced and the quota related stats are
> captured in the StatsTrack. From the "*listquota*" CLI command, we can get
> the info about the quota limit and usage.
> From the monitoring and alert points of view, we would like to collect the
> quota metrics/stats and expose them to Prometheus so alert can be created
> based on the quota level (e.g. 90% used). I wonder if this feature has
> been supported or there is a plan to support it?
> If not, I will open a JIRA and can start to look into it.
> Thanks,
> Li
>


[jira] [Created] (ZOOKEEPER-4211) Expose Quota Metrics to Prometheus

2021-02-16 Thread Li Wang (Jira)
Li Wang created ZOOKEEPER-4211:
--

 Summary: Expose Quota Metrics to Prometheus
 Key: ZOOKEEPER-4211
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4211
 Project: ZooKeeper
  Issue Type: New Feature
  Components: metric system
Reporter: Li Wang


In 3.7, Quota limit can be enforced and the quota related stats are captured in 
the StatsTrack.  From the "listquota" CLI command, we can the quota limit and 
usage info. 

As an addition to that, we would like to collect the quota metrics and expose 
them to the Prometheus for the following:

1. Monitoring per namespace (Chroot) quota usage via the Grafana dashboard
2. Creating alert based on the quota levels (e.g. 90% used)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Removing Java 11 CI job

2021-02-16 Thread Enrico Olivelli
Perfect!
I have approved the patch

I would like to commit it ASAP

Enrico

Il giorno mar 16 feb 2021 alle ore 15:51 Christopher 
ha scritto:

> I changed the surefire-forkCount to 1, instead of 1C in
> https://github.com/apache/zookeeper/pull/1606 and the "Address in use"
> error goes away, and tests pass on Java 11. I saw it pass once in my
> branch. It is currently running in the PR, and if it completes, I
> recommend making that change, instead of disabling it.
>
> On Tue, Feb 16, 2021 at 8:55 AM Enrico Olivelli 
> wrote:
> >
> > Hello,
> > Currently the new Java 11 CI job is not passing and it is very annoying
> for
> > every PR validation.
> >
> > I suggest to remove it and add it again when we know that it is
> > working properly
> >
> > Thoughts ?
> > Enrico
>


Re: Removing Java 11 CI job

2021-02-16 Thread Christopher
I changed the surefire-forkCount to 1, instead of 1C in
https://github.com/apache/zookeeper/pull/1606 and the "Address in use"
error goes away, and tests pass on Java 11. I saw it pass once in my
branch. It is currently running in the PR, and if it completes, I
recommend making that change, instead of disabling it.

On Tue, Feb 16, 2021 at 8:55 AM Enrico Olivelli  wrote:
>
> Hello,
> Currently the new Java 11 CI job is not passing and it is very annoying for
> every PR validation.
>
> I suggest to remove it and add it again when we know that it is
> working properly
>
> Thoughts ?
> Enrico


Re: collecting and exposing quota related metrics to Prometheus

2021-02-16 Thread Justin Ling Mao
@Li Wang
Great addition, we really need this. Please help us to do this:)


- Original Message -
From: Li Wang 
To: dev@zookeeper.apache.org
Subject: collecting and exposing quota related metrics to Prometheus
Date: 2021-02-16 09:23

Hi,
In 3.7, Quota limit can be enforced and the quota related stats are
captured in the StatsTrack.  From the "*listquota*" CLI command, we can get
the info about the quota limit and usage.
From the monitoring and alert points of view, we would like to collect the
quota metrics/stats and expose them to Prometheus so alert can be created
based on the quota level (e.g. 90% used).  I wonder if this feature has
been supported or there is a plan to support it?
If not, I will open a JIRA and can start to look into it.
Thanks,
Li


Removing Java 11 CI job

2021-02-16 Thread Enrico Olivelli
Hello,
Currently the new Java 11 CI job is not passing and it is very annoying for
every PR validation.

I suggest to remove it and add it again when we know that it is
working properly

Thoughts ?
Enrico