[RESULT] [VOTE] Apache ZooKeeper release 3.8.4 candidate 0
I'm happy to announce that we have unanimously approved this release. There are 4 approving votes, 3 of which are binding: - Szalay-Bekő Máté (binding) - Andor Molnar (binding) - Enrico Olivelli (binding) - tison (non-binding) There are no disapproving votes. I will promote the artifacts and complete the release procedure. Thanks to every one who contributed to this great release ! Damien Diederen Damien Diederen writes: > Greetings, all! > > > This is a release candidate for 3.8.4. > > This is a bugfix release for the 3.8 release line. Includes important > dependency upgrades to address CVEs. > > > The full release notes is available at: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12353693 > > *** Please download, test and vote by February 16th 2024, 23:59 UTC+0. *** > > Source files: > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/ > > Maven staging repo: > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/ > > The release candidate tag in git to be voted upon: release-3.8.4-0 > https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0 > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > https://www.apache.org/dist/zookeeper/KEYS > > The staging version of the website is: > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html > > > Should we release this candidate? > > > Regards, > Damien Diederen
Re: First time contribution to ZK. Attn: Patrick Hunt, Andor Molnar, Flavio Junqueira
George, thanks for sharing your patch. A couple of thoughts below Il giorno mer 21 feb 2024 alle ore 02:57 Liz George ha scritto: > > Hi Zk dev experts and users. > We are currently considering this change to Apache Zookeeper code. Details > are outlined in this ticket > https://issues.apache.org/jira/browse/ZOOKEEPER-4766 You did well in sharing the patch here on the mailing list and sending out a PR. Can you please target the "master" branch in the PR ? > This code change is to improve how ZK handles taking snapshots during > leader elections. Any review of this code change would be appreciated. > Specifically if there are any risks, or if this seems like a valuable fix > to have that we could push to the community at a later date if needed. Are all the tests passing ? CI is not running the tests probably because the PR is not targeting the master branch > > Rishabh is the engineer who has made this change in a private env. Please > can you add your comments to the Jira ticket itself or email him at > rishabhrai.m...@gmail.com (Cc me as well Pls) Could Rishabh subscribe to this mailing list ? We could miss adding him We prefer discussing all together here in the mailing list. JIRA is not good for "discussions" because folks have to follow JIRA notifications and for many people they are not taken much into consideration. Thanks Enrico > Thanks in advance, > Liz George > Director, Software Engineering | Salesforce > Mobile: 408-406-0524
Re: [VOTE] Apache ZooKeeper release 3.8.4 candidate 0
+1 non-binding I checked * Download links valid * Signature and checksum matches apache-zookeeper-3.8.4-bin.tar.gz gpg: Signature made 二 2/13 06:17:28 2024 CST gpg:using RSA key AF3D175EC05DB249738D01AC8D8C3C3ED0B02E66 gpg: Good signature from "Damien Diederen (CODE SIGNING KEY) " [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: AF3D 175E C05D B249 738D 01AC 8D8C 3C3E D0B0 2E66 apache-zookeeper-3.8.4.tar.gz gpg: Signature made 二 2/13 06:15:56 2024 CST gpg:using RSA key AF3D175EC05DB249738D01AC8D8C3C3ED0B02E66 gpg: Good signature from "Damien Diederen (CODE SIGNING KEY) " [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: AF3D 175E C05D B249 738D 01AC 8D8C 3C3E D0B0 2E66 * Build from source on macOS ARM64 with JDK 21 * Extra binary, start the server, and run some simple commands * Run the same for the binary built from the source * LICENSE and NOTICE exist for both tarballs Best, tison. Enrico Olivelli 于2024年3月4日周一 17:46写道： > > +1 (binding) > > - verified checksums and signatures > - full build, on Ubuntu, JDK11 > - smoke tests using the binaries I have built from sources > > Thanks > > Enrico > > Il giorno mer 28 feb 2024 alle ore 22:49 Andor Molnar > ha scritto: > > > > +1 (binding) > > > > - verified checksum and gpg signature of the artifacts > > - full build was successful > > - unit tests passed > > - checkstyle and spotbugs passed > > - apache-rat passed > > - owasp (CVE check) passed > > - smoke tests (basic commands, watchers, etc.) passed > > > > Andor > > > > > > > > On Mon, 2024-02-12 at 23:35 +0100, Damien Diederen wrote: > > > Greetings, all! > > > > > > > > > This is a release candidate for 3.8.4. > > > > > > This is a bugfix release for the 3.8 release line. Includes important > > > dependency upgrades to address CVEs. > > > > > > > > > The full release notes is available at: > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12353693 > > > > > > *** Please download, test and vote by February 16th 2024, 23:59 > > > UTC+0. *** > > > > > > Source files: > > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/ > > > > > > Maven staging repo: > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/ > > > > > > The release candidate tag in git to be voted upon: release-3.8.4-0 > > > https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0 > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > https://www.apache.org/dist/zookeeper/KEYS > > > > > > The staging version of the website is: > > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html > > > > > > > > > Should we release this candidate? > > > > > > > > > Regards, > > > Damien Diederen > >
Re: [VOTE] Apache ZooKeeper release 3.8.4 candidate 0
+1 (binding) - verified checksums and signatures - full build, on Ubuntu, JDK11 - smoke tests using the binaries I have built from sources Thanks Enrico Il giorno mer 28 feb 2024 alle ore 22:49 Andor Molnar ha scritto: > > +1 (binding) > > - verified checksum and gpg signature of the artifacts > - full build was successful > - unit tests passed > - checkstyle and spotbugs passed > - apache-rat passed > - owasp (CVE check) passed > - smoke tests (basic commands, watchers, etc.) passed > > Andor > > > > On Mon, 2024-02-12 at 23:35 +0100, Damien Diederen wrote: > > Greetings, all! > > > > > > This is a release candidate for 3.8.4. > > > > This is a bugfix release for the 3.8 release line. Includes important > > dependency upgrades to address CVEs. > > > > > > The full release notes is available at: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12353693 > > > > *** Please download, test and vote by February 16th 2024, 23:59 > > UTC+0. *** > > > > Source files: > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/ > > > > Maven staging repo: > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/ > > > > The release candidate tag in git to be voted upon: release-3.8.4-0 > > https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > https://www.apache.org/dist/zookeeper/KEYS > > > > The staging version of the website is: > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html > > > > > > Should we release this candidate? > > > > > > Regards, > > Damien Diederen >
