[GitHub] [zookeeper] szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation
szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497321392 retest ant build Edit: Well, it seems I do not own this power... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation
szepet edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497321392 retest ant build Well, it seems I do not own this power... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation
szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497321392 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server
nkalmar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-497321302 If were talking about "if [ ! `ls build/zookeeper*.jar` ]; then" thats just for checking if ZK has been built before running the script. (If not, it will fail anyway). This can either be removed OR add a check for maven as well, checking in the zookeeper-server target directory if the jar is there or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #938: ZOOKEEPER-2559:[WIP]Failed to delete the set quota for ephemeral node when … the node is deleted because of client session closed
anmolnar commented on issue #938: ZOOKEEPER-2559:[WIP]Failed to delete the set quota for ephemeral node when … the node is deleted because of client session closed URL: https://github.com/apache/zookeeper/pull/938#issuecomment-497318680 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator)
anmolnar commented on issue #946: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (for Curator) URL: https://github.com/apache/zookeeper/pull/946#issuecomment-497318173 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation
anmolnar commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-497257586 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] phunt commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE
phunt commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-497200481 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-497156627 >> if this config could be generalized to be used exclusively for socket connection timeout I am not sure if all socket connection timeouts can be generalized. It seems to me the timeout configuration is case by case. But, an improvement regardless if we can generalize this or not, is to have a timeout provisioning class that provides a set of interfaces so we can query different timeouts with different semantics and have the actual timeout implementation in a single place, then we can get rid of all the `self.tickTime * self.initLimit` or `self.tickTime * self.syncLimit` scattered through code base. We could even consider teaching this class to be adaptive of network conditions instead of relying on static timeout values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-497155402 When a leader is partitioned after LE, a smaller socket timeout value will make it faster to detect the partition. But I can see choose a small value can also impact follower / leader connection in normal use case, especially if the latency between the two is big (e.g. over WAN). How do we choose a value that works for both cases? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r288816030 ## File path: conf/zoo_sample.cfg ## @@ -6,6 +6,9 @@ initLimit=10 # The number of ticks that can pass between # sending a request and getting an acknowledgement syncLimit=5 +# The number of ticks that followers can take +# to connect to the leader after leader election +connectToLeaderLimit=5 Review comment: I think we probably want to rename this variable to something like `connectToLearnerMasterLimit`, or if we keep the current name, at least document that this will also impact the socket timeout between observer and learner master. This is unfortunate, so maybe we ultimately want to rename the method of `connectToLeader` to something like `connectToLearnerMaster`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
hanm commented on a change in pull request #953: ZOOKEEPER-3398
Learner.connectToLeader() may take too long to time-out
URL: https://github.com/apache/zookeeper/pull/953#discussion_r288816455
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
##
@@ -1735,8 +1741,22 @@ public void setSyncLimit(int syncLimit) {
LOG.info("syncLimit set to " + syncLimit);
this.syncLimit = syncLimit;
}
-
-
+
+/**
+ * Get the connectToLeaderLimit
+ */
+public int getConnectToLeaderLimit() {
+return connectToLeaderLimit;
+}
+
+/**
+ * Set the connectToLeaderLimit
+ */
+public void setConnectToLeaderLimit(int connectToLeaderLimit) {
+LOG.info("connectToLeaderLimit set to " + connectToLeaderLimit);
Review comment:
nit: use parameterized (`{}`) log.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] hanm commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document
hanm commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-497152729 I agree the original statement is not very clear, but instead of changing it, how about actually clarify it with this: A client will see the same view of the service regardless of the server that it connects to, and a client will never see an older view of the system even if the client fails over to a different server with the same session. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists
enixon commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497144847 lgtm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] lfrancke opened a new pull request #964: ZOOKEEPER-3407: Update POM file
lfrancke opened a new pull request #964: ZOOKEEPER-3407: Update POM file URL: https://github.com/apache/zookeeper/pull/964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] lfrancke opened a new pull request #963: ZOOKEEPER-3406: Update website for new mailing lists
lfrancke opened a new pull request #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963 This updates the website with the new mailing lists. Probably makes sense to wait with merging until INFRA has completed the changes. Whoever merges this probably needs to follow the remaining steps here as well: https://cwiki.apache.org/confluence/display/ZOOKEEPER/WebSiteSetup This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device
anmolnar commented on issue #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device URL: https://github.com/apache/zookeeper/pull/935#issuecomment-496980833 Merged to master. Thanks @BELUGABEHR ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device
asfgit closed pull request #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device URL: https://github.com/apache/zookeeper/pull/935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document
anmolnar commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-496963385 @hanm @phunt Do you agree with this change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements
anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-496959862 We have so many committers nowadays. @lvfangmin @eolivelli @nkalmar Would you please let me have one of your approvals? :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements
anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-496959084 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter
anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter URL: https://github.com/apache/zookeeper/pull/941#issuecomment-496958325 @bd2019us This patch doesn't compile: ``` [ERROR] /home/travis/build/apache/zookeeper/zookeeper-jute/target/classes/org/apache/zookeeper/data/Stat.java:[273,17] error: reached end of file while parsing ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter
anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter URL: https://github.com/apache/zookeeper/pull/941#issuecomment-496956993 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide
anmolnar commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide URL: https://github.com/apache/zookeeper/pull/903#issuecomment-496956167 @BELUGABEHR Could be right, but I feel I can argue with. Not sure though. I would really just fix the URL instead of removing it. It's a very good video and available on YouTube since 2013. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor
eolivelli commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-496949661 This is cool @anmolnar @nkalmar please take a look as well. I will review as soon as I can. The change is not trivial @enixon we need to rebase the change after review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948713 @nkalmar I have restarted the tests because this patch was approved but it is quite old. I hope tests will pass. Than we can commit it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948507 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948413 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK
eolivelli commented on issue #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#issuecomment-496948152 @lvfangmin we need to rebase. I hope @normanmaurer have cycles to take a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader
eolivelli commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-496947055 Please rebase @enixon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE
eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-496946298 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE
eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-496789395 retest maven buiild This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication.
hanm commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication. URL: https://github.com/apache/zookeeper/pull/118#issuecomment-496771839 @enixon Thank you for feedback, I'll keep this in mind. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496750615 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] phunt opened a new pull request #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE
phunt opened a new pull request #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962 Upgraded the library to the latest version. Change-Id: I94743e7f7817202fff25c757730ba05fe0a9cc17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #960: Fix typos and grammar in zookeeper docs
enixon commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-496686220 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #960: Fix typos and grammar in zookeeper docs
enixon commented on issue #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960#issuecomment-496685882 looks good to me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server
szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496678387 Yes, it the condition at the beginning was unnecessary since @nkalmar has done ZOOKEEPER-3029. In 05b774a the maven generated files are added to the zkEnv as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server
szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496678387 Yes, it the condition at the beginning was unnecessary since @nkalmar has done ZOOKEEPER-3029. In #05b774 the maven generated files are added to the zkEnv as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648615 retest maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496648163 reset maven build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
jhuan31 commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-496606096 > Did you see my last comments? Sorry! Was on vacation. Just made the changes. Thank you @eolivelli This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader
jhuan31 commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#issuecomment-496601707 Thank you @eolivelli This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …
eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-496587533 I wasn't aware of OptionalSSLHandler. This is very interesting. What do you think @enixon? I want this feature because I have cases on which from a jvm I have to connect to different zk clusters but the customer cannot upgrade to ssl every cluster . So having a client that is able to connect to a secure and an unsecured cluster will be great. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60
nkalmar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961#issuecomment-496532806 Thanks @anmolnar , merged to master and 3.5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60
asfgit closed pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY
nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-496527666 Thanks @jhuan31 , merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY
asfgit closed pull request #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
nkalmar commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496521330 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …
anmolnar commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted … URL: https://github.com/apache/zookeeper/pull/944#issuecomment-496507605 @enixon Quite an impressive new feature gets little attention. Let's clarify one thing. We already have this feature implemented for quorum communication with `UnifiedServerSocket`, but we don't want to use it here, because we have Netty for client communication and Netty already has a built-in feature, `OptionalSSLHandler` for exactly this purpose. Is that the reason why you upgraded to the latest version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60
anmolnar commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961#issuecomment-496370179 > btw if we have these problems now someday we will see them again when we will need to upgrade. Aren't we using BC only for generating certs and keys ? it is not used by the runtime. @eolivelli This is valid. BC is for testing only currently and we'll face this problem again once we need to upgrade to address a CVE for example. However that could be a more recent version of BC where they identify and fix the performance regression. Other option could be to improve `QuorumSSL` tests: it's already running for 5-6 minutes which is kinda odd for unit tests. I'll do some research on that side to find where the bottleneck is. Wrt to Security Providers I think you're right, though I'm not an expert of Java Security, so not sure how to address the problem properly. I suggest to keep this patch for the performance problem only for now. Please see my comments / evidence in Jira too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496307959 @lvfangmin please help me move forward this patch :-) cc @anmolnar @nkalmar This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60
eolivelli commented on issue #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961#issuecomment-496307315 As we are using BC only for tests it is okay to downgrade in order to make tests more stable. btw if we have these problems now someday we will see them again when we will need to upgrade. Aren't we using BC only for generating certs and keys ? it is not used by the runtime. BC comes with its own Security Providers, **I am afraid that it not polluting the classpath during tests** executions. The JVM (Javax Crypto) selects Security Providers by using what is on the classpath. **It is a problem if during tests execution we are using a Security Provider that it is not used in production.** We should add debug in every security-related utility and dump which Security Provider is in use. In order to be sure about the security provider we are using every Javax Crypto utility has a way to force the provider without using auto discovery. We should also add Netty (Google) Boring SSL library in order to be sure about the SSL implementation we are using. Unfortunately we are not using Netty yet on server to server communication, as so I guess we are more fragile in this Security Provider selection. cc @enixon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar opened a new pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60
anmolnar opened a new pull request #961: ZOOKEEPER-3404. Downgrade BouncyCastle to 1.60 URL: https://github.com/apache/zookeeper/pull/961 I've seen a lot of test timeout errors with QuorumSSL tests since I upgraded master to BouncyCastle 1.61 due to a Java 9 warning. The warning has been reported by Enrico Olivelli which we tried to solve by the upgrade, but the warning message is still present so I don't see any harm in downgrading to the previous version. https://issues.apache.org/jira/browse/ZOOKEEPER-3404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] ashashwat opened a new pull request #960: Fix typos and grammar in zookeeper docs
ashashwat opened a new pull request #960: Fix typos and grammar in zookeeper docs URL: https://github.com/apache/zookeeper/pull/960 Raising a PR to fix typos and grammar in zookeeper docs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496300939 I had enough with the failing Ant build, committed anyway. Thanks @jhuan31 ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
asfgit closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496295873 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server
szepet commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#discussion_r287851484 ## File path: zookeeper-server/src/test/resources/test-scripts.sh ## @@ -217,6 +217,9 @@ stop $ZKSI --force --myid=1 --configfile "$ZOOCFGDIR/$ZOOCFG" || fail $LINENO +#test version script Review comment: It just checks whether the sh scripts working properly. Or at least that they return a '0' exit code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server
szepet commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496270234 Yepp, sorry for the late response. I have found some other problems using the `test-scripts.sh` but hopefully managed to correct it to work on all platform. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server
szepet edited a comment on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-496270234 @eolivelli @anmolnar Yepp, sorry for the late response. I have found some other problems using the `test-scripts.sh` but hopefully managed to correct it to work on all platform. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496267890 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server
anmolnar commented on a change in pull request #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#discussion_r287838351 ## File path: zookeeper-server/src/test/resources/test-scripts.sh ## @@ -217,6 +217,9 @@ stop $ZKSI --force --myid=1 --configfile "$ZOOCFGDIR/$ZOOCFG" || fail $LINENO +#test version script Review comment: Is this script actually used anywhere in our code? How is it supposed to work? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496253615 I think we really made something wrong with `testHostnameVerificationWithInvalidIpAddressAndInvalidHostname`. retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496253670 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496187671 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation
szepet commented on issue #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#issuecomment-496162411 @lvfangmin @anmolnar What do you think about it? (forgot to mention you in the initial comment) Of course, every idea or question is welcome here from everyone who is interested in this! :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY
nkalmar commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-496153591 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information
nkalmar commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947#issuecomment-496137617 Thanks @enixon , committed to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #947: ZOOKEEPER-3392: Add admin command to display last snapshot information
asfgit closed pull request #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] szepet opened a new pull request #959: ZOOKEEPER-3402: Add multiRead operation
szepet opened a new pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959 So, the possibility of the multi version of getChildren, getData, and a common multiRead interface was already mentioned and briefly discussed in the conversation thread of #922. This patch introduces the concept of multiRead operation. Note: This is a 'work-in-progress', not every comment is added, and test cases should be extended as well. Currently, the aim is to decide whether this direction is something that the community would get behind or should fin. I've faced more design decision while implementing this (note: I wanted to keep the backward compatibility at all cost), the more important ones were the following: 1. Whether the new read operations should be part of Op or should we create new descendant classes of `Op` like `ReadOp` and `WriteOp`. In this case, I believe it would be unnecessary to create new classes since it would create a lot of code duplication (despite the common ancestor) and the flow of the processing would not be as clean as in the initial state. However, by simply adding an OpKind enum to the class enables us to ensure the type-safety behavior (read and write operations should not mix) and still preserve the clean processing flow. 2. At which point of request processing should we capture the mixed (transaction and read operation) multi requests? It seems pretty clear to catch them client side and not create extra work for the server. 3. Do we even need a `multiRead` operation or this whole improvement could be just part of multi? Well, the main problem is the following: currently, on server side (and in general, everywhere in ZooKeeper) the fact that multi only contains transactions is a heavily used and built upon it. The whole `multi` processing flow should be rewritten from zero and also the server would get a significant extra work for that. So yeah, it seems pretty clear to me that introducing the `multiRead` operation is beneficial. Hope these thoughts make sense! Any observations, questions are welcome! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496014349 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-496008413 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495989214 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling closed pull request #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node
maoling closed pull request #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node URL: https://github.com/apache/zookeeper/pull/942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling edited a comment on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node
maoling edited a comment on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node URL: https://github.com/apache/zookeeper/pull/942#issuecomment-495974415 - "**listquota display the quota even it is set on parent/child node**" is not a good way to solve this issue - we should handle this Exception to tell users that a specific parent/child node already had a quota and a complete path(from root to leaf node) can only be set one quota. - this fix is travial and will be done with ZOOKEEPER-2563([PR-936](https://github.com/apache/zookeeper/pull/936)) together, because in that path we will do a refactor for the `setquota ` - Let me close this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling commented on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node
maoling commented on issue #942: ZOOKEEPER-2565:[WIP]---listquota should display the quota even it is set on parent/child node URL: https://github.com/apache/zookeeper/pull/942#issuecomment-495974415 - "**listquota display the quota even it is set on parent/child node**" is not a good way to solve this issue - we should handle this Exception to tell users that a specific parent/child node already had a quota and a complete path(from root to leaf node) can only be set one quota. - this fix is travial and will be done with ZOOKEEPER-2563([PR-936](https://github.com/apache/zookeeper/pull/936)) together, because in that path we will do a refactor for the `setquota ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.
asfgit closed pull request #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance. URL: https://github.com/apache/zookeeper/pull/956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics
eolivelli commented on issue #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850#issuecomment-495871830 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
jhuan31 commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495773198 A green build is hard to get these days :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 To address a potential flaky test in PR #849 (LearnerHandlerMetricsTest) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information
enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947#issuecomment-495725161 @nkalmar you're correct that we're not looking to add new four letter words to 3.6 anymore and move forward with deprecating them. This is adding a command against the admin server, which are still supported. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing
enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-495723744 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing
eolivelli commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-495707052 This looks very interesting This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar closed pull request #955: ZOOKEEPER-3362: Create a simple checkstyle file
anmolnar closed pull request #955: ZOOKEEPER-3362: Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file
anmolnar commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/955#issuecomment-495688201 Merged. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar closed pull request #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)
anmolnar closed pull request #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5) URL: https://github.com/apache/zookeeper/pull/954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495680030 @lvfangmin Are you happy with committing this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495679764 @eolivelli Please review again and make sure your comments have been addressed. I'll commit this once we got a green build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics
jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics
jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY
jhuan31 commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-495672330 Thank you @nkalmar. Fixed the unit test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics
jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 To address a potential flaky test in PR #849 (LearnerHandlerMetricsTest) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #924: ZOOKEEPER-3371: Port unification for Jetty admin server
anmolnar commented on issue #924: ZOOKEEPER-3371: Port unification for Jetty admin server URL: https://github.com/apache/zookeeper/pull/924#issuecomment-495612493 Please fix the failing unit test `org.apache.zookeeper.server.quorum.QuorumSSLTest.testHostnameVerificationWithInvalidIpAddressAndInvalidHostname` It failed in both Maven and Ant builds, so looks like it's broken by this patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.
nkalmar commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance. URL: https://github.com/apache/zookeeper/pull/956#issuecomment-495567490 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing
enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-495423430 This adds a new admin command that will show the syncing state of a peer. The ticket also requests better logging - I'm not sure what exactly is being requested but I'm happy to augment this diff to include the desired. cc @Randgalt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon opened a new pull request #958: ZOOKEEPER-1523: Better logging during instance loading/syncing
enixon opened a new pull request #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader
enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-495401373 retest ant build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
