[GitHub] [zookeeper] maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-481222724 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-481222826 ping @anmolnar This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-469504060 - > Maybe the flag is not needed and I am fine with it. agree - adding a new field/attributive will not corrupt the response/request,but remove a field could be I guess:D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-469107877 +1 - don't look at the specific code,just take a test,it will be ok to throw the error path. - also think about backward compatibility,take a quick test to show I'am overreacting,no backward compatibility problem with the change of the protocol:`ErrorTxn`. 1.low version client(without this patch) connect to high version server(with this patch): `org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode` 2.high version client connect to lower version server: `org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
