[GitHub] eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs
eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#issuecomment-451942104 @anmolnar cherry pick fails because some commits about Maven migration are missing on branch-3.5 and branch-3.4 @nkalmar can we sync Maven Migration commits before the Spotbugs one ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs
eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#issuecomment-451139535 @anmolnar the change around `// TTL.toEphemeralOwner(ttl);` was because that method for spotbugs won't have any side effects, but indeed it is a false positive, so I am reverting it and adding a suppression This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
