[GitHub] zookeeper issue #167: ZOOKEEPER-2684 commitProcessor does not crash when an ...

[nerdyyatrice]

Github user nerdyyatrice commented on the issue:

https://github.com/apache/zookeeper/pull/167
  
I can’t repro it on my laptop so I tried to see if it can pass on the 
machine. I will look into code in more detail. 

> On May 23, 2017, at 9:15 PM, Michael Han  wrote:
> 
> @nerdyyatrice  I see you've closed / 
reopened this PR, and the build bot is kicked off as expected. There is the 
same test failure in pre-commit build: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/739/testReport/junit/org.apache.zookeeper.server.quorum/CommitProcessorConcurrencyTest/noCrashOnCommittedRequestsOfUnSeenRequestTest/
 
.
 We should get this fixed before merging this PR.
> 
> I'll try reviewing this patch in detail to understand what goes wrong 
here.
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or mute 
the thread 
.
> 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #167: ZOOKEEPER-2684 commitProcessor does not crash when an ...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/167
  
@nerdyyatrice I see you've closed / reopened this PR, and the build bot is 
kicked off as expected.  There is the same test failure in pre-commit build: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/739/testReport/junit/org.apache.zookeeper.server.quorum/CommitProcessorConcurrencyTest/noCrashOnCommittedRequestsOfUnSeenRequestTest/.
 We should get this fixed before merging this PR.

I'll try reviewing this patch in detail to understand what goes wrong here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---