[GitHub] zookeeper issue #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 i...

2017-11-27 Thread phunt 
Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/417
  
lgtm +1 - Thanks Abe.


---

[GitHub] zookeeper issue #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 i...

2017-11-27 Thread afine 
Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/417
  
@phunt i believe all of your concerns are resolved.



---

[GitHub] zookeeper issue #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 i...

2017-11-22 Thread phunt 
Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/417
  
Reviewed this an aside from the noted issue it seems ok to me. Ran some 
tests and they are passing. I think we're good to go if you can get this one 
last item finalized.


---

[GitHub] zookeeper issue #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 i...

2017-11-22 Thread phunt 
Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/417
  
There's a debug log missing from 1045 in 
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java


---

[GitHub] zookeeper issue #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 i...

2017-11-21 Thread afine 
Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/417
  
@phunt fixed!


---

[GitHub] zookeeper issue #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER-1045 i...

2017-11-21 Thread phunt 
Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/417
  
Hi Abe. I started looking at this but noticed an issue right off the bat. 
This line is removed when I diff btw your patch applied to trunk and 
branch-3.5. Can you take a look through this again and verify? (obv fix this as 
well).

```
 
-
 
```


---