[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-11-17 Thread lvfangmin
Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/632
  
Rebase onto latest master.


---


[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-14 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/632
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2430/



---


[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/632
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388/



---


[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/632
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385/



---


[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/632
  
retest this please


---


[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/632
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2375/



---


[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-06 Thread lvfangmin
Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/632
  
This is a really useful feature, which helps us find multiple data 
inconsistent issues, like ZOOKEEPER-3144, ZOOKEEPER-3127, ZOOKEEPER-3125. 

It can avoid introducing new inconsistent bugs in ZooKeeper in the future, 
so please take a look when you have time. I'll introduce the 2nd part after 
this got reviewed and merged.

For performance, we saw some very minor impact, will provide the 
micro-benchmark result.


---


[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-06 Thread asfgit
Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/632
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2374/



---