[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-28 Thread lvfangmin 
Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/726
  
Only a few nits, other LGTM.


---

[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-28 Thread akkumar 
Github user akkumar commented on the issue:

https://github.com/apache/zookeeper/pull/726
  
@eolivelli - import static added. Let me know if this looks ok !


---

[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-27 Thread akkumar 
Github user akkumar commented on the issue:

https://github.com/apache/zookeeper/pull/726
  
Ok - in the logs I see this.  Any suggestion what needs to be done to get 
this sorted out ? 

```

 [exec] 

 [exec] 

 [exec] Error: No value specified for option "issue"

 [exec] Session logged out. Session was JSESSIONID=

 [exec] 

 [exec] 

 [exec] 
==

 [exec] 
==

 [exec] Finished build.

 [exec] 
==

 [exec] 
==

 [exec] 

 [exec] 

 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file
```




---

[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-27 Thread akkumar 
Github user akkumar commented on the issue:

https://github.com/apache/zookeeper/pull/726
  
The test cases seem to run with no failures. 

It is not obvious what caused the jenkins failure ? Any suggestions where 
to look for ? 


---