[GitHub] zookeeper issue #90: ZOOKEEPER-761: Remove *synchronous* calls from the *sin...

2016-12-09 Thread fpj
Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/90
  
It sounds like there is a conflict in `TestReconfigServer`, could you 
resolve it, please @breed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zookeeper issue #90: ZOOKEEPER-761: Remove *synchronous* calls from the *sin...

2016-11-17 Thread fpj
Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/90
  
It looks good, I just left a comment about creating a jira before we 
forget. Could you do it before we close this issue, please @breed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zookeeper issue #90: ZOOKEEPER-761: Remove *synchronous* calls from the *sin...

2016-10-27 Thread breed
Github user breed commented on the issue:

https://github.com/apache/zookeeper/pull/90
  
@fpj on the plus side that failure validates that the change is correct :) 
(it is trying to use a sync API with a non threaded test)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zookeeper issue #90: ZOOKEEPER-761: Remove *synchronous* calls from the *sin...

2016-10-27 Thread fpj
Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/90
  
@breed `make check` does not compile for me:

```
g++ -DHAVE_CONFIG_H -I.  -I./include -I./tests -I./generated   
-DUSE_STATIC_LIB -DZKSERVER_CMD="\"./tests/zkServer.sh\"" -DZOO_IPV6_ENABLED  
-g -O2 -MT zktest_st-TestReconfigServer.o -MD -MP -MF 
.deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o 
`test -f 'tests/TestReconfigServer.cc' || echo './'`tests/TestReconfigServer.cc
In file included from /usr/include/cppunit/TestCase.h:6:0,
 from /usr/include/cppunit/TestCaller.h:5,
 from /usr/include/cppunit/extensions/HelperMacros.h:9,
 from tests/TestReconfigServer.cc:18:
tests/TestReconfigServer.cc: In member function 'void 
TestReconfigServer::testRemoveFollower()':
tests/TestReconfigServer.cc:153:73: error: 'zoo_getconfig' was not declared 
in this scope
 CPPUNIT_ASSERT_EQUAL((int)ZOK, zoo_getconfig(zk, 0, buf, , ));
 ^
tests/TestReconfigServer.cc:174:32: error: 'zoo_reconfig' was not declared 
in this scope
   );
^
In file included from /usr/include/cppunit/TestCase.h:6:0,
 from /usr/include/cppunit/TestCaller.h:5,
 from /usr/include/cppunit/extensions/HelperMacros.h:9,
 from tests/TestReconfigServer.cc:18:
tests/TestReconfigServer.cc: In member function 'void 
TestReconfigServer::testNonIncremental()':
tests/TestReconfigServer.cc:221:73: error: 'zoo_getconfig' was not declared 
in this scope
 CPPUNIT_ASSERT_EQUAL((int)ZOK, zoo_getconfig(zk, 0, buf, , ));
 ^
tests/TestReconfigServer.cc:246:32: error: 'zoo_reconfig' was not declared 
in this scope
   );
^
tests/TestReconfigServer.cc: In member function 'void 
TestReconfigServer::testRemoveConnectedFollower()':
tests/TestReconfigServer.cc:313:72: error: 'zoo_reconfig' was not declared 
in this scope
 zoo_reconfig(zk, NULL, ss.str().c_str(), NULL, -1, buf, , );
^
In file included from /usr/include/cppunit/TestCase.h:6:0,
 from /usr/include/cppunit/TestCaller.h:5,
 from /usr/include/cppunit/extensions/HelperMacros.h:9,
 from tests/TestReconfigServer.cc:18:
tests/TestReconfigServer.cc:314:73: error: 'zoo_getconfig' was not declared 
in this scope
 CPPUNIT_ASSERT_EQUAL((int)ZOK, zoo_getconfig(zk, 0, buf, , ));
```

have you tried running the C tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---