[GitHub] zookeeper pull request #562: [ZOOKEEPER-3084] Exit when zeus cannot bind to ...

[lvfangmin]

Github user lvfangmin commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/562#discussion_r200719504
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -905,6 +908,12 @@ public void run() {
 + "I won't be able to participate in leader "
 + "election any longer: "
 + self.getElectionAddress());
+if (exitException instanceof BindException) {
+// After leaving listener thread, the host cannot join 
the
+// quorum anymore, this is a severe error that we 
cannot
+// recover from, so we need to exit
+System.exit(14);
--- End diff --

I picked an exit code which is not being used in anywhere else, so it can 
identify why it exited.


---

[GitHub] zookeeper pull request #562: [ZOOKEEPER-3084] Exit when zeus cannot bind to ...

[breed]

Github user breed commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/562#discussion_r200717310
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -905,6 +908,12 @@ public void run() {
 + "I won't be able to participate in leader "
 + "election any longer: "
 + self.getElectionAddress());
+if (exitException instanceof BindException) {
+// After leaving listener thread, the host cannot join 
the
+// quorum anymore, this is a severe error that we 
cannot
+// recover from, so we need to exit
+System.exit(14);
--- End diff --

how did we pick 14?


---

[GitHub] zookeeper pull request #562: [ZOOKEEPER-3084] Exit when zeus cannot bind to ...

[lvfangmin]

GitHub user lvfangmin opened a pull request:

https://github.com/apache/zookeeper/pull/562

[ZOOKEEPER-3084] Exit when zeus cannot bind to the leader election port



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-3084

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #562


commit 619651055fd9de73fd8f679a1b883829e2a35905
Author: Fangmin Lyu 
Date:   2018-07-06T05:56:50Z

Exit when zeus cannot bind to the leader election port




---