[RESULT] [VOTE] Apache ZooKeeper release 3.8.4 candidate 0

2024-03-04 Thread Damien Diederen


I'm happy to announce that we have unanimously approved this release.
 
There are 4 approving votes, 3 of which are binding:

- Szalay-Bekő Máté (binding)
- Andor Molnar (binding)
- Enrico Olivelli (binding)
- tison (non-binding)
 
There are no disapproving votes.
 
I will promote the artifacts and complete the release procedure.
 
Thanks to every one who contributed to this great release !
 
Damien Diederen




Damien Diederen  writes:
> Greetings, all!
>
>
> This is a release candidate for 3.8.4.
>
> This is a bugfix release for the 3.8 release line. Includes important
> dependency upgrades to address CVEs.
>
>
> The full release notes is available at:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353693
>
> *** Please download, test and vote by February 16th 2024, 23:59 UTC+0. ***
>
> Source files:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/
>
> Maven staging repo:
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/
>
> The release candidate tag in git to be voted upon: release-3.8.4-0
> https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html
>
>
> Should we release this candidate?
>
>
> Regards,
> Damien Diederen


Re: [VOTE] Apache ZooKeeper release 3.8.4 candidate 0

2024-03-04 Thread tison
+1 non-binding

I checked

* Download links valid
* Signature and checksum matches

apache-zookeeper-3.8.4-bin.tar.gz
gpg: Signature made 二  2/13 06:17:28 2024 CST
gpg:using RSA key AF3D175EC05DB249738D01AC8D8C3C3ED0B02E66
gpg: Good signature from "Damien Diederen (CODE SIGNING KEY)
" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:  There is no indication that the signature belongs to the owner.
Primary key fingerprint: AF3D 175E C05D B249 738D  01AC 8D8C 3C3E D0B0 2E66
apache-zookeeper-3.8.4.tar.gz
gpg: Signature made 二  2/13 06:15:56 2024 CST
gpg:using RSA key AF3D175EC05DB249738D01AC8D8C3C3ED0B02E66
gpg: Good signature from "Damien Diederen (CODE SIGNING KEY)
" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:  There is no indication that the signature belongs to the owner.
Primary key fingerprint: AF3D 175E C05D B249 738D  01AC 8D8C 3C3E D0B0 2E66

* Build from source on macOS ARM64 with JDK 21
* Extra binary, start the server, and run some simple commands
* Run the same for the binary built from the source
* LICENSE and NOTICE exist for both tarballs

Best,
tison.

Enrico Olivelli  于2024年3月4日周一 17:46写道:
>
> +1 (binding)
>
> - verified checksums and signatures
> - full build, on Ubuntu, JDK11
> - smoke tests using the binaries I have built from sources
>
> Thanks
>
> Enrico
>
> Il giorno mer 28 feb 2024 alle ore 22:49 Andor Molnar
>  ha scritto:
> >
> > +1 (binding)
> >
> > - verified checksum and gpg signature of the artifacts
> > - full build was successful
> > - unit tests passed
> > - checkstyle and spotbugs passed
> > - apache-rat passed
> > - owasp (CVE check) passed
> > - smoke tests (basic commands, watchers, etc.) passed
> >
> > Andor
> >
> >
> >
> > On Mon, 2024-02-12 at 23:35 +0100, Damien Diederen wrote:
> > > Greetings, all!
> > >
> > >
> > > This is a release candidate for 3.8.4.
> > >
> > > This is a bugfix release for the 3.8 release line. Includes important
> > > dependency upgrades to address CVEs.
> > >
> > >
> > > The full release notes is available at:
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353693
> > >
> > > *** Please download, test and vote by February 16th 2024, 23:59
> > > UTC+0. ***
> > >
> > > Source files:
> > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/
> > >
> > > Maven staging repo:
> > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/
> > >
> > > The release candidate tag in git to be voted upon: release-3.8.4-0
> > > https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0
> > >
> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > https://www.apache.org/dist/zookeeper/KEYS
> > >
> > > The staging version of the website is:
> > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html
> > >
> > >
> > > Should we release this candidate?
> > >
> > >
> > > Regards,
> > > Damien Diederen
> >


Re: [VOTE] Apache ZooKeeper release 3.8.4 candidate 0

2024-03-04 Thread Enrico Olivelli
+1 (binding)

- verified checksums and signatures
- full build, on Ubuntu, JDK11
- smoke tests using the binaries I have built from sources

Thanks

Enrico

Il giorno mer 28 feb 2024 alle ore 22:49 Andor Molnar
 ha scritto:
>
> +1 (binding)
>
> - verified checksum and gpg signature of the artifacts
> - full build was successful
> - unit tests passed
> - checkstyle and spotbugs passed
> - apache-rat passed
> - owasp (CVE check) passed
> - smoke tests (basic commands, watchers, etc.) passed
>
> Andor
>
>
>
> On Mon, 2024-02-12 at 23:35 +0100, Damien Diederen wrote:
> > Greetings, all!
> >
> >
> > This is a release candidate for 3.8.4.
> >
> > This is a bugfix release for the 3.8 release line. Includes important
> > dependency upgrades to address CVEs.
> >
> >
> > The full release notes is available at:
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353693
> >
> > *** Please download, test and vote by February 16th 2024, 23:59
> > UTC+0. ***
> >
> > Source files:
> > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/
> >
> > Maven staging repo:
> > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/
> >
> > The release candidate tag in git to be voted upon: release-3.8.4-0
> > https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html
> >
> >
> > Should we release this candidate?
> >
> >
> > Regards,
> > Damien Diederen
>


Re: [VOTE] Apache ZooKeeper release 3.8.4 candidate 0

2024-02-28 Thread Andor Molnar
+1 (binding)

- verified checksum and gpg signature of the artifacts
- full build was successful
- unit tests passed
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed
- smoke tests (basic commands, watchers, etc.) passed

Andor



On Mon, 2024-02-12 at 23:35 +0100, Damien Diederen wrote:
> Greetings, all!
> 
> 
> This is a release candidate for 3.8.4.
> 
> This is a bugfix release for the 3.8 release line. Includes important
> dependency upgrades to address CVEs.
> 
> 
> The full release notes is available at:
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353693
> 
> *** Please download, test and vote by February 16th 2024, 23:59
> UTC+0. ***
> 
> Source files:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/
> 
> Maven staging repo:
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/
> 
> The release candidate tag in git to be voted upon: release-3.8.4-0
> https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0
> 
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
> 
> The staging version of the website is:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html
> 
> 
> Should we release this candidate?
> 
> 
> Regards,
> Damien Diederen



Re: [VOTE] Apache ZooKeeper release 3.8.4 candidate 0

2024-02-16 Thread Szalay-Bekő Máté
+1 (binding)

I did the following tests for the release candidate:
- verified checksum and gpg signature of the artifacts
- I built the source code (incl. the C-client, using -Pfull-build) on
Ubuntu 22.04.3 using OpenJDK 8u402, maven 3.9.6 and GCC version 11.4.0
- all the unit tests passed eventually (both Java and C-client), although I
saw a few flakies again
- I also built and executed unit tests for zkpython
- I also built the java code (without -Pfull-build) using other JDK
versions: 11.0.22, 17.0.10, 21.0.1 (but didn't run the tests this time,
just used 'clean install -DskipTests')
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed
- fatjar built
- I executed quick rolling-upgrade tests without SSL (using
https://github.com/symat/zk-rolling-upgrade-test):
  - rolling upgrade from 3.6.4 to 3.8.4 RC0
  - rolling upgrade from 3.7.2 to 3.8.4 RC0
  - rolling upgrade from 3.8.3 to 3.8.4 RC0
  - rolling upgrade from 3.8.4 RC0 to 3.9.1
  - rolling upgrade from 3.8.4 RC0 to 3.9.2 RC0
- checked the uploaded documentation (
https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html
)
- compared generated release notes (
https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/releasenotes.html)
with Jira (
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353693=12310801
)

Best regards,
Máté

On Mon, Feb 12, 2024 at 11:35 PM Damien Diederen 
wrote:

>
> Greetings, all!
>
>
> This is a release candidate for 3.8.4.
>
> This is a bugfix release for the 3.8 release line. Includes important
> dependency upgrades to address CVEs.
>
>
> The full release notes is available at:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353693
>
> *** Please download, test and vote by February 16th 2024, 23:59 UTC+0. ***
>
> Source files:
>
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/
>
> Maven staging repo:
>
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/
>
> The release candidate tag in git to be voted upon: release-3.8.4-0
> https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html
>
>
> Should we release this candidate?
>
>
> Regards,
> Damien Diederen
>


[VOTE] Apache ZooKeeper release 3.8.4 candidate 0

2024-02-12 Thread Damien Diederen


Greetings, all!


This is a release candidate for 3.8.4.

This is a bugfix release for the 3.8 release line. Includes important
dependency upgrades to address CVEs.


The full release notes is available at:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353693

*** Please download, test and vote by February 16th 2024, 23:59 UTC+0. ***

Source files:
https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/

Maven staging repo:
https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.8.4/

The release candidate tag in git to be voted upon: release-3.8.4-0
https://github.com/apache/zookeeper/releases/tag/release-3.8.4-0

ZooKeeper's KEYS file containing PGP keys we use to sign the release:
https://www.apache.org/dist/zookeeper/KEYS

The staging version of the website is:
https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.8.4-candidate-0/website/index.html


Should we release this candidate?


Regards,
Damien Diederen