[RESULT] [VOTE] Apache ZooKeeper release 3.9.1 candidate 0

2023-10-09 Thread Andor Molnar
I'm happy to announce that we have unanimously approved this release.
 
There are 5 approving votes, 4 of which are binding:
 
- Enrico Olivelli (binding)
- Damien Diederen (non-binding)
- Mate Szalay-Beko (binding)
- Patrick Hunt (binding)
- Andor Molnar (binding)
 
There are no disapproving votes.
 
I will promote the artifacts and complete the release procedure.
 
Thanks to every one who contributed to this great release !
 
Andor



On Wed, 2023-10-04 at 14:28 +0200, Andor Molnar wrote:
> Hi team,
> 
> This is a release candidate for 3.9.1.
> 
> This is a bugfix release for the 3.9 release line. Includes important
> dependency upgrades to address CVEs.
> 
> 
> The full release notes is available at:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480
> 
> *** Please download, test and vote by October 6th 2023, 23:59 UTC+0.
> ***
> 
> Source files:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/
> 
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachezookeeper-1096/
> 
> The release candidate tag in git to be voted upon: release-3.9.1-0
> https://github.com/apache/zookeeper/releases/tag/release-3.9.1-0
> 
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
> 
> The staging version of the website is:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/index.html
> 
> 
> Should we release this candidate?
> 
> 
> Best regards,
> 
> Andor
> 
> 
> 



Re: [VOTE] Apache ZooKeeper release 3.9.1 candidate 0

2023-10-06 Thread Patrick Hunt
+1 - xsums validated, rat ran clean, was able to compile successfully,
owasp check is green, able to run multiple configurations/ensembles
successfully.

Note: there are a few license files which don't have accompanying jars, I
think this is fine. For the jars/licenses we do carry they matched OK.

Patrick


On Wed, Oct 4, 2023 at 5:29 AM Andor Molnar  wrote:

> Hi team,
>
> This is a release candidate for 3.9.1.
>
> This is a bugfix release for the 3.9 release line. Includes important
> dependency upgrades to address CVEs.
>
>
> The full release notes is available at:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480
>
> *** Please download, test and vote by October 6th 2023, 23:59 UTC+0.
> ***
>
> Source files:
>
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachezookeeper-1096/
>
> The release candidate tag in git to be voted upon: release-3.9.1-0
> https://github.com/apache/zookeeper/releases/tag/release-3.9.1-0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
>
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/index.html
>
>
> Should we release this candidate?
>
>
> Best regards,
>
> Andor
>
>
>
>


Re: [VOTE] Apache ZooKeeper release 3.9.1 candidate 0

2023-10-06 Thread Szalay-Bekő Máté
+1 (binding)

I did the following tests for the release candidate:
- verified checksum and gpg signature of the artifacts
- I built the source code (incl. the C-client, using -Pfull-build) on
Ubuntu 18.04.2 using OpenJDK 8u372, maven 3.9.3 and GCC version 7.4.0
- all the unit tests passed (both Java and C-client)
- I also built and executed unit tests for zkpython
- I also built the java code (without -Pfull-build) using other JDK
versions: 11.0.19, 17.0.7, 20.0.1 (but didn't run the tests this time, just
used 'clean install -DskipTests')
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed
- fatjar built
- I executed quick rolling-upgrade tests (using
https://github.com/symat/zk-rolling-upgrade-test):
  - rolling upgrade from 3.5.10 to 3.9.1
  - rolling upgrade from 3.6.4 to 3.9.1
  - rolling upgrade from 3.7.1 to 3.9.1
  - rolling upgrade from 3.8.2 to 3.9.1
  - rolling upgrade from 3.8.3 RC0 to 3.9.1
  - rolling upgrade from 3.9.0 to 3.9.1
- checked the generated documentation (zookeeper-docs/target/html)
- compared generated release notes (
https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/releasenotes.html)
with Jira (
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480
)

Best regards,
Máté

On Thu, Oct 5, 2023 at 10:49 AM Enrico Olivelli  wrote:

> +1 (binding)
>
> - Built from sources, run all the tests
> - Validated checksums and signatures
> - Run a single node cluster from the binaries
>
> Enrico
>
> Il giorno mer 4 ott 2023 alle ore 19:12 Damien Diederen
>  ha scritto:
> >
> >
> > Greetings, all,
> >
> > +1 (non-binding)
> >
> >   * Verified checksum/signature;
> >   * Upgraded a 5-node ensemble to apache-zookeeper-3.9.1-bin.tar.gz,
> > ran a few smoke tests;
> >   * Reviewed the Release Notes;
> >   * Ran dependency-check:check on the source tree.
> >
> > Cheers, -D
> >
> >
> > Andor Molnar  writes:
> > > Hi team,
> > >
> > > This is a release candidate for 3.9.1.
> > >
> > > This is a bugfix release for the 3.9 release line. Includes important
> > > dependency upgrades to address CVEs.
> > >
> > >
> > > The full release notes is available at:
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480
> > >
> > > *** Please download, test and vote by October 6th 2023, 23:59 UTC+0.
> > > ***
> > >
> > > Source files:
> > >
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/
> > >
> > > Maven staging repo:
> > >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1096/
> > >
> > > The release candidate tag in git to be voted upon: release-3.9.1-0
> > > https://github.com/apache/zookeeper/releases/tag/release-3.9.1-0
> > >
> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > https://www.apache.org/dist/zookeeper/KEYS
> > >
> > > The staging version of the website is:
> > >
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/index.html
> > >
> > >
> > > Should we release this candidate?
> > >
> > >
> > > Best regards,
> > >
> > > Andor
>


Re: [VOTE] Apache ZooKeeper release 3.9.1 candidate 0

2023-10-05 Thread Enrico Olivelli
+1 (binding)

- Built from sources, run all the tests
- Validated checksums and signatures
- Run a single node cluster from the binaries

Enrico

Il giorno mer 4 ott 2023 alle ore 19:12 Damien Diederen
 ha scritto:
>
>
> Greetings, all,
>
> +1 (non-binding)
>
>   * Verified checksum/signature;
>   * Upgraded a 5-node ensemble to apache-zookeeper-3.9.1-bin.tar.gz,
> ran a few smoke tests;
>   * Reviewed the Release Notes;
>   * Ran dependency-check:check on the source tree.
>
> Cheers, -D
>
>
> Andor Molnar  writes:
> > Hi team,
> >
> > This is a release candidate for 3.9.1.
> >
> > This is a bugfix release for the 3.9 release line. Includes important
> > dependency upgrades to address CVEs.
> >
> >
> > The full release notes is available at:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480
> >
> > *** Please download, test and vote by October 6th 2023, 23:59 UTC+0.
> > ***
> >
> > Source files:
> > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachezookeeper-1096/
> >
> > The release candidate tag in git to be voted upon: release-3.9.1-0
> > https://github.com/apache/zookeeper/releases/tag/release-3.9.1-0
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/index.html
> >
> >
> > Should we release this candidate?
> >
> >
> > Best regards,
> >
> > Andor


Re: [VOTE] Apache ZooKeeper release 3.9.1 candidate 0

2023-10-04 Thread Damien Diederen


Greetings, all,

+1 (non-binding)

  * Verified checksum/signature;
  * Upgraded a 5-node ensemble to apache-zookeeper-3.9.1-bin.tar.gz,
ran a few smoke tests;
  * Reviewed the Release Notes;
  * Ran dependency-check:check on the source tree.

Cheers, -D


Andor Molnar  writes:
> Hi team,
>
> This is a release candidate for 3.9.1.
>
> This is a bugfix release for the 3.9 release line. Includes important
> dependency upgrades to address CVEs.
>
>
> The full release notes is available at:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480
>
> *** Please download, test and vote by October 6th 2023, 23:59 UTC+0.
> ***
>
> Source files:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachezookeeper-1096/
>
> The release candidate tag in git to be voted upon: release-3.9.1-0
> https://github.com/apache/zookeeper/releases/tag/release-3.9.1-0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/index.html
>
>
> Should we release this candidate?
>
>
> Best regards,
>
> Andor


Re: [VOTE] Apache ZooKeeper release 3.9.1 candidate 0

2023-10-04 Thread Andor Molnar
+1

- checksum / signature good
- rat run clean
- owasp dependency check passed
- java unit tests passed on Ubuntu 20.04 / openjdk version "11.0.12"
- one of C++ tests failed, but based on CI builds everything is fine
https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-multi-branch-build/job/branch-3.9.1/

[exec] terminate called after throwing an instance of
'CppUnit::Exception'
[exec]   what():  equality assertion failed
[exec] - Expected: -101
[exec] - Actual  : -4
[exec]
[exec] Zookeeper_simpleSystem::testAsyncWatcherAutoResetFAIL: zktest-mt
[exec] ==
[exec] 1 of 2 tests failed
[exec] Please report to u...@zookeeper.apache.org
[exec] ==

- created 3-node SSL ensemble and ran a few smoke tests
- release notes looking fine
- verified CLI commands

Minor glitch in the client: the commit id is not replaced by Maven.

[zk: andor-5560-ubuntu:2183(CONNECTED) 5] version
ZooKeeper CLI version: 3.9.1-${mvngit.commit.id}, built on 2023-10-04
15:03 UTC

Andor



On Wed, 2023-10-04 at 14:28 +0200, Andor Molnar wrote:
> Hi team,
> 
> This is a release candidate for 3.9.1.
> 
> This is a bugfix release for the 3.9 release line. Includes important
> dependency upgrades to address CVEs.
> 
> 
> The full release notes is available at:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480
> 
> *** Please download, test and vote by October 6th 2023, 23:59 UTC+0.
> ***
> 
> Source files:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/
> 
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachezookeeper-1096/
> 
> The release candidate tag in git to be voted upon: release-3.9.1-0
> https://github.com/apache/zookeeper/releases/tag/release-3.9.1-0
> 
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
> 
> The staging version of the website is:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/index.html
> 
> 
> Should we release this candidate?
> 
> 
> Best regards,
> 
> Andor
> 
> 
> 



[VOTE] Apache ZooKeeper release 3.9.1 candidate 0

2023-10-04 Thread Andor Molnar
Hi team,

This is a release candidate for 3.9.1.

This is a bugfix release for the 3.9 release line. Includes important
dependency upgrades to address CVEs.


The full release notes is available at:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12353480

*** Please download, test and vote by October 6th 2023, 23:59 UTC+0.
***

Source files:
https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/

Maven staging repo:
https://repository.apache.org/content/repositories/orgapachezookeeper-1096/

The release candidate tag in git to be voted upon: release-3.9.1-0
https://github.com/apache/zookeeper/releases/tag/release-3.9.1-0

ZooKeeper's KEYS file containing PGP keys we use to sign the release:
https://www.apache.org/dist/zookeeper/KEYS

The staging version of the website is:
https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.1-candidate-0/website/index.html


Should we release this candidate?


Best regards,

Andor