[ https://issues.apache.org/jira/browse/ZOOKEEPER-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939052#comment-15939052 ]
Edward Ribeiro edited comment on ZOOKEEPER-2736 at 3/23/17 7:56 PM: -------------------------------------------------------------------- Hey, [~vincentpoon], nice initiative! I remember some past discussion about introducing a rate limiter into ZK codebase, particularly in the context of ZOOKEEPER-2693, so you may have to take a look there first to see what the others contributors have in mind. Also, *and most important*, we are not using patch upload + review board to accept patches in ZooKeeper anymore. Please, open a PR on Github as specified here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute Best regards PS: I was unable to apply your patch to branch-3.4 and branch-3.5. :( Did you generate your patch with a {{git diff --no-prefix}} or equivalent? was (Author: eribeiro): Hey, [~vincentpoon], nice initiative! I remember some past discussion about introducing a rate limiter into ZK codebase, particularly in the context of ZOOKEEPER-2693, so you may have to take a look there first to see what the others contributors have in mind. Also, *and most important*, we are not using patch upload + review board to accept patches in ZooKeeper anymore. Please, open a PR on Github as specified here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute Best regards > Add a connection rate limiter > ----------------------------- > > Key: ZOOKEEPER-2736 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2736 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.4.9, 3.5.2 > Reporter: Vincent Poon > Attachments: ZOOKEEPER-2736.v1.patch > > > Currently the maxClientCnxns property only limits the aggregate number of > connections from a client, but not the rate at which connections can be > created. > This patch adds a configurable connection rate limiter which limits the rate > as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)