[jira] [Commented] (ZOOKEEPER-1185) Send AuthFailed event to client if SASL authentication fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114815#comment-13114815 ] Eugene Koontz commented on ZOOKEEPER-1185: -- Hi Mahadev, I didn't see your comment on https://reviews.apache.org/r/1959/ - did you not publish it perhaps? -Eugene Send AuthFailed event to client if SASL authentication fails Key: ZOOKEEPER-1185 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1185 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Labels: kerberos, security Fix For: 3.4.0, 3.5.0 Attachments: ZOOKEEPER-1185.patch There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1185) Send AuthFailed event to client if SASL authentication fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114170#comment-13114170 ] Mahadev konar commented on ZOOKEEPER-1185: -- Eugene, Just a minor nit, commented on the review board. Other than that it looks good. Ill go ahead and commit it to 3.4 and 3.5 as soon as its updated. thanks! Send AuthFailed event to client if SASL authentication fails Key: ZOOKEEPER-1185 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1185 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Labels: kerberos, security Fix For: 3.4.0, 3.5.0 Attachments: ZOOKEEPER-1185.patch There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1185) Send AuthFailed event to client if SASL authentication fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112807#comment-13112807 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-1185: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1959/ --- (Updated 2011-09-22 18:33:42.805934) Review request for zookeeper. Changes --- add link to JIRA. Summary --- There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate). This patch fixes SaslAuthFailTest.testBadSaslAuthNotifiesWatch() to test for the AuthFailed event : previously, the test was incorrectly not testing for this event. It also removes the testBadSaslAuthNotifiesWatch() method from the SaslAuthTest class : this method belongs in SaslAuthFailTest, not SaslAuthTest. The former tests unsuccessful SASL authentication; the latter, successful SASL authentication. This addresses bug ZOOKEEPER-1185. https://issues.apache.org/jira/browse/ZOOKEEPER-1185 Diffs - src/java/main/org/apache/zookeeper/ClientCnxn.java db15348 src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 43382c8 src/java/test/org/apache/zookeeper/test/SaslAuthFailTest.java 8de7c2a src/java/test/org/apache/zookeeper/test/SaslAuthTest.java fd20346 Diff: https://reviews.apache.org/r/1959/diff Testing --- All unit tests pass. Also tested with an HBase cluster with an hbase shell running as an unauthenticated Zookeeper client. As expected, hbase shell could not access cluster, but, as expected, did not hang. Thanks, Eugene Send AuthFailed event to client if SASL authentication fails Key: ZOOKEEPER-1185 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1185 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Labels: kerberos, security Fix For: 3.4.0, 3.5.0 Attachments: ZOOKEEPER-1185.patch There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1185) Send AuthFailed event to client if SASL authentication fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13112255#comment-13112255 ] Eugene Koontz commented on ZOOKEEPER-1185: -- Hi Patrick, As with ZOOKEEPER-1181, I would like to lobby for this to be in 3.4.0. This fix addresses a significant functional bug in SASL authentication. -Eugene Send AuthFailed event to client if SASL authentication fails Key: ZOOKEEPER-1185 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1185 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Labels: kerberos, security Fix For: 3.4.0, 3.5.0 Attachments: ZOOKEEPER-1185.patch There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1185) Send AuthFailed event to client if SASL authentication fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108061#comment-13108061 ] Thomas Koch commented on ZOOKEEPER-1185: Could you please upload the patch to https://reviews.apache.org/r/new/ for review? Send AuthFailed event to client if SASL authentication fails Key: ZOOKEEPER-1185 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1185 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Labels: kerberos, security Fix For: 3.4.0 Attachments: ZOOKEEPER-1185.patch There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1185) Send AuthFailed event to client if SASL authentication fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105057#comment-13105057 ] Hadoop QA commented on ZOOKEEPER-1185: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494547/ZOOKEEPER-1185.patch against trunk revision 1170886. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/543//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/543//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/543//console This message is automatically generated. Send AuthFailed event to client if SASL authentication fails Key: ZOOKEEPER-1185 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1185 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Labels: kerberos, security Fix For: 3.4.0 Attachments: ZOOKEEPER-1185.patch There are 3 places where ClientCnxn should queue a AuthFailed event if client fails to authenticate. Without sending this event, clients may be stuck watching for a SaslAuthenticated event that will never come (since the client failed to authenticate). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
