[jira] [Commented] (ZOOKEEPER-1248) multi transaction sets request.exception without reason
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139177#comment-13139177 ] Hadoop QA commented on ZOOKEEPER-1248: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501442/ZOOKEEPER-1248.patch against trunk revision 1190450. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/730//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/730//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/730//console This message is automatically generated. multi transaction sets request.exception without reason --- Key: ZOOKEEPER-1248 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1248 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1248.patch, ZOOKEEPER-1248.patch, ZOOKEEPER-1248.patch I'm trying to understand the purpose of the exception field in request. This isn't made easier by the fact that the multi case in PrepRequestProcessor sets the exception without reason. The only code that calls request.getException() is in FinalRequestProcessor and this code only acts when the operation _is not_ a multi operation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1248) multi transaction sets request.exception without reason
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139357#comment-13139357 ] Marshall McMullen commented on ZOOKEEPER-1248: -- I think this was an artifact of one of my original implementations for multi to try to propagate failures out properly. Nice catch on cleaning this up. multi transaction sets request.exception without reason --- Key: ZOOKEEPER-1248 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1248 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1248.patch, ZOOKEEPER-1248.patch, ZOOKEEPER-1248.patch I'm trying to understand the purpose of the exception field in request. This isn't made easier by the fact that the multi case in PrepRequestProcessor sets the exception without reason. The only code that calls request.getException() is in FinalRequestProcessor and this code only acts when the operation _is not_ a multi operation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1248) multi transaction sets request.exception without reason
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13135064#comment-13135064 ] Hadoop QA commented on ZOOKEEPER-1248: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500670/ZOOKEEPER-1248.patch against trunk revision 1188523. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/664//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/664//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/664//console This message is automatically generated. multi transaction sets request.exception without reason --- Key: ZOOKEEPER-1248 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1248 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1248.patch I'm trying to understand the purpose of the exception field in request. This isn't made easier by the fact that the multi case in PrepRequestProcessor sets the exception without reason. The only code that calls request.getException() is in FinalRequestProcessor and this code only acts when the operation _is not_ a multi operation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1248) multi transaction sets request.exception without reason
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13135362#comment-13135362 ] Camille Fournier commented on ZOOKEEPER-1248: - It's those damned read-only mode tests that seem to be so buggy that are failing. Do we think this failure is meaningful or not? multi transaction sets request.exception without reason --- Key: ZOOKEEPER-1248 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1248 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1248.patch, ZOOKEEPER-1248.patch I'm trying to understand the purpose of the exception field in request. This isn't made easier by the fact that the multi case in PrepRequestProcessor sets the exception without reason. The only code that calls request.getException() is in FinalRequestProcessor and this code only acts when the operation _is not_ a multi operation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
