[jira] [Commented] (ZOOKEEPER-1358) In StaticHostProviderTest.java, testNextDoesNotSleepForZero tests that hostProvider.next(0) doesn't sleep by checking that the latency of this call is less than 10s

2012-01-15 Thread Camille Fournier (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186650#comment-13186650
 ] 

Camille Fournier commented on ZOOKEEPER-1358:
-

This looks good to me. I will check it in.

 In StaticHostProviderTest.java, testNextDoesNotSleepForZero tests that 
 hostProvider.next(0) doesn't sleep by checking that the latency of this call 
 is less than 10sec
 --

 Key: ZOOKEEPER-1358
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1358
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Alexander Shraer
Assignee: Alexander Shraer
Priority: Trivial
 Fix For: 3.2.3

 Attachments: ZOOKEEPER-1358.patch, ZOOKEEPER-1358.patch


 should check for something smaller, perhaps 1ms or 5ms

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (ZOOKEEPER-1358) In StaticHostProviderTest.java, testNextDoesNotSleepForZero tests that hostProvider.next(0) doesn't sleep by checking that the latency of this call is less than 10s

2012-01-15 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13186678#comment-13186678
 ] 

Hudson commented on ZOOKEEPER-1358:
---

Integrated in ZooKeeper-trunk #1429 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/1429/])
ZOOKEEPER-1358. In StaticHostProviderTest.java, testNextDoesNotSleepForZero 
tests that hostProvider.next(0) doesn't sleep by checking that the latency of 
this call is less than 10sec (Alex Shraer via camille)

camille : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1231806
Files : 
* /zookeeper/trunk/CHANGES.txt
* 
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java


 In StaticHostProviderTest.java, testNextDoesNotSleepForZero tests that 
 hostProvider.next(0) doesn't sleep by checking that the latency of this call 
 is less than 10sec
 --

 Key: ZOOKEEPER-1358
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1358
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Alexander Shraer
Assignee: Alexander Shraer
Priority: Trivial
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1358.patch, ZOOKEEPER-1358.patch


 should check for something smaller, perhaps 1ms or 5ms

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (ZOOKEEPER-1358) In StaticHostProviderTest.java, testNextDoesNotSleepForZero tests that hostProvider.next(0) doesn't sleep by checking that the latency of this call is less than 10s

2012-01-10 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183520#comment-13183520
 ] 

Hadoop QA commented on ZOOKEEPER-1358:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12510085/ZOOKEEPER-1358.patch
  against trunk revision 1227927.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/894//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/894//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/894//console

This message is automatically generated.

 In StaticHostProviderTest.java, testNextDoesNotSleepForZero tests that 
 hostProvider.next(0) doesn't sleep by checking that the latency of this call 
 is less than 10sec
 --

 Key: ZOOKEEPER-1358
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1358
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Alexander Shraer
Assignee: Alexander Shraer
Priority: Trivial
 Fix For: 3.2.3

 Attachments: ZOOKEEPER-1358.patch, ZOOKEEPER-1358.patch


 should check for something smaller, perhaps 1ms or 5ms

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira