[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15541733#comment-15541733
]
Arshad Mohammad commented on ZOOKEEPER-2397:
bq. kinit is a command, not a configuration parameter, right?
In general kinit is a command but in ZooKeeper it is also a configuration which
specifies the path to kinit binary. Default value of this configuration is
/usr/bin/kinit
Reference: org.apache.zookeeper.common.ZKConfig.KINIT_COMMAND
{code}
/**
* Path to a kinit binary: {@value}. Defaults to
* "/usr/bin/kinit"
*/
public static final String KINIT_COMMAND = "zookeeper.kinit";
{code}
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15541708#comment-15541708 ] Arshad Mohammad commented on ZOOKEEPER-2397: Yes, the remaining work is to figure out and document server side properties. > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536581#comment-15536581
]
Flavio Junqueira commented on ZOOKEEPER-2397:
-
I'm confused, ZOOKEEPER-2402 has documented the client-side properties, so in
this jira it remains to document the server-side properties in the admin guide.
The ones I can see from this description are:
# {{sasl.serverconfig}}
# {{SASLAuthenticationProvider.superPassword}}
# {{kerberos.removeHostFromPrincipal}}
# {{kerberos.removeRealmFromPrincipal}}
{{kinit}} is a command, not a configuration parameter, right? I suppose
[~arshad.mohammad] is saying that we need to document the use {{kinit}}.
Could I get a +1 or a -1 to my understanding of what needs to happen in this
jira?
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534141#comment-15534141 ] Michael Han commented on ZOOKEEPER-2397: Note that many if not all client side properties discussed here were documented as part of https://issues.apache.org/jira/browse/ZOOKEEPER-2402. So, the remaining work is to figure out and document server side properties? [~arshad.mohammad] thoughts? > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430548#comment-15430548
]
Arshad Mohammad commented on ZOOKEEPER-2397:
Above list is from the client perspective, corresponding to client which server
sasl properties are not documented, otherwise there are many other SASL
properties which are not documented.
For example, bellow properties are not documented
{code}
SASLAuthenticationProvider.superPassword
kerberos.removeHostFromPrincipal
kerberos.removeRealmFromPrincipal
{code}
ZOOKEEPER-2416 will segregate the all ZooKeeper properties,
After this jira, we can easily find and document all the undocumented ZooKeeper
properties
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.5.3, 3.6.0, 3.4.10
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422602#comment-15422602 ] Rakesh R commented on ZOOKEEPER-2397: - I am moving this out to 3.4.10 for now. Please feel free to discuss the target version, if needed. Thanks! > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.5.3, 3.6.0, 3.4.10 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411907#comment-15411907
]
Arshad Mohammad commented on ZOOKEEPER-2397:
# {{sasl.serverconfig}} and {{kinit}} are left for documentation
# No we don't have any jira for those TBD section. ZOOKEEPER-733 has added
those TBD sections. I could not find any follow up jira to complete these TBD.
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410924#comment-15410924
]
Flavio Junqueira commented on ZOOKEEPER-2397:
-
I had a look at the administrator guide, and the only property missing is
{{sasl.serverconfig}}, is that right [~arshad.mohammad]? Let me know if there
is anything else you see missing.
Another issue I spotted with the docs is these TBDs:
{noformat}
TBD - tuning options for netty - currently there are none that are netty
specific but we should add some. Esp around max bound on the number of reader
worker threads netty creates.
TBD - how to manage encryption
TBD - how to manage certificates
{noformat}
Do we have an issue for those? Adding something on managing encryption and
certificates sounds good.
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.9, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396846#comment-15396846 ] Rakesh R commented on ZOOKEEPER-2397: - Hi All, how is the progress of this issue, any chance to conclude this ? > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294252#comment-15294252 ] Arshad Mohammad commented on ZOOKEEPER-2397: Separated and documented all java client properties in ZOOKEEPER-2402. So as part of this jira only server side SASL properties are left for documentation > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217357#comment-15217357 ] Arshad Mohammad commented on ZOOKEEPER-2397: bq. jute.maxbuffer default value at server is 1 MB and at client 4 MB. This is an exception, because not all the properties, common between client and sever, have different behavior at client and server bq. client will always have properties with zookeeper prefix Till now this has been followed for almost all the client properties. A client property can be exposed without zookeeper prefix and there is no restriction in the code to disallow it. So it is not rule. > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213182#comment-15213182 ] Patrick Hunt commented on ZOOKEEPER-2397: - Duplicating seems reasonable if it's the exception rather than the rule. Is that the case? > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210014#comment-15210014
]
Arshad Mohammad commented on ZOOKEEPER-2397:
I am also more inclined towards duplicating the properties.
It is because client will always have properties with zookeeper prefix and
server will have both with and without zookeeper prefix
Also some properties may have different behavior in client and server for
example {{jute.maxbuffer}} default value at server is 1 MB and at client 4 MB.
Lets hear some more opinion then we can go for the fix
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.9, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209987#comment-15209987 ] Flavio Junqueira commented on ZOOKEEPER-2397: - Duplicating is probably best in this case and we note in the text that the property is the same. Otherwise it becomes confusing to find properties. We can alternatively have a "common" section in the admin guide, but then the developers visiting the programmer guide might miss it. We could have pointers, but I tend not to like when I have to hop around to find information. This alternative is still acceptable to me as long as note it in the programmer's guide. > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209772#comment-15209772
]
Arshad Mohammad commented on ZOOKEEPER-2397:
bq. Move the client-side options to the programmer's guide
What about the properties common between client and server, like
{{jute.maxbuffer}},{{zookeeper.ssl.keyStore.location}} ? are you suggesting to
duplicate common properties in Admin and Programmer's guide?
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.9, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209264#comment-15209264 ] Flavio Junqueira commented on ZOOKEEPER-2397: - Actually, on a second look, it sounds like the docs are a bit messed up. The admin page was supposed to have only server-side configuration options, but a whole bunch of properties that we need to set on the client side have been put there. I think it has been added there because there is nowhere else right now, but the admin guide for client properties doesn't seem ideal. Also, there is no discussion in the programmer's guide about sasl or ssl. We need to: # Add some text blurb about sasl and ssl to the programmer's guide # Move the client-side options to the programmer's guide Does it make sense to you guys? [~phunt] [~arshad.mohammad] > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209245#comment-15209245 ] Flavio Junqueira commented on ZOOKEEPER-2397: - [~phunt] this property is actually set at the client, so it is system property only. the only one that is server side is "sasl.serverconfig". also, there are other properties in the doc prefixed with "zookeeper.", e.g., zookeeper.client.secure. If I change the ones in the patch, then I'll need to change the others as well. > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208882#comment-15208882 ] Arshad Mohammad commented on ZOOKEEPER-2397: yes There are three categories of zookeeper properties # Specific to server # Specific to client # Common between client and server ZOOKEEPER-2139 attempts to segregate them in the code, (but this is not main functionality of the jira) ZOOKEEPER-2402 proposes to segregate in document > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208843#comment-15208843 ] Patrick Hunt commented on ZOOKEEPER-2397: - Are you saying that some of these configs are specific to the client and some specific to the server? If so we need to split them into distinct sections and call that out explicitly. > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208793#comment-15208793
]
Arshad Mohammad commented on ZOOKEEPER-2397:
AFAIK,
# For {{zookeeper.sasl.clientconfig}} it is ok to prefix zookeeper. as it is
purely client side property(it is not common between client and server). It is
all time must be used through java system property as of now
# but yes, for server side properties for example
{{zookeeper.sasl.serverconfig}} zookeeper should not be prefixed as in
zookeeper.sasl.serverconfig
> Undocumented SASL properties
>
>
> Key: ZOOKEEPER-2397
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: documentation
>Affects Versions: 3.4.8, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.9, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2397.patch
>
>
> There are a number of properties spread across the code that do not appear in
> the docs. For example, zookeeper.allowSaslFailedClients isn't documented
> afaict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2397) Undocumented SASL properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207904#comment-15207904 ] Hadoop QA commented on ZOOKEEPER-2397: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12794868/ZOOKEEPER-2397.patch against trunk revision 1736259. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3115//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3115//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3115//console This message is automatically generated. > Undocumented SASL properties > > > Key: ZOOKEEPER-2397 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2397 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Affects Versions: 3.4.8, 3.5.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2397.patch > > > There are a number of properties spread across the code that do not appear in > the docs. For example, zookeeper.allowSaslFailedClients isn't documented > afaict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
