[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Enrico Olivelli (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015161#comment-16015161
 ] 

Enrico Olivelli commented on ZOOKEEPER-2665:


Thank you [~rakeshr]

> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
>Assignee: Enrico Olivelli
> Fix For: 3.4.10, 3.5.3
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924647#comment-15924647
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user eolivelli closed the pull request at:

https://github.com/apache/zookeeper/pull/165


> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.4.10, 3.5.3
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924639#comment-15924639
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/165
  
@eolivelli - can you please also closing this pull request?
On a side note, this patch works, I see my PR to branch 3.5 is now kicking 
build bots.


> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.4.10, 3.5.3
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900683#comment-15900683
 ] 

Rakesh R commented on ZOOKEEPER-2665:
-

Hi [~fpj], please add [~eolivelli] to the contributor list and assign the issue 
to him. Thanks!

> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.4.10, 3.5.3
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900462#comment-15900462
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/165
  
Thanks @eolivelli, this is merged in 3.4. and 3.5. 


> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.4.10, 3.5.3
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898871#comment-15898871
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/165
  
@hanm the patch is almost the same as for trunk, just a work of "copy and 
paste"

Eventually you can compare the diff with #97 



> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898762#comment-15898762
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/165
  
I think it is fine to leave the names as they are for now and later update 
scripts for all branches all together. 

@eolivelli - are there any specific changes you made on top of 
ZOOKEEPER-2624 while porting the script to branch-3.5 and 3.4? 


> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866608#comment-15866608
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/165
  
@eribeiro that you for reviewing this.
IMHO it it just a variable name. The script is basically the same as in the 
trunk version. I think it would be better to leave all versions as much similar 
as possible.
Eventually I can change this and file a pr against trunk too but I don't 
know the impact.
@fpj what do you think?


> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866470#comment-15866470
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/165#discussion_r100269721
  
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,616 @@
+#!/usr/bin/env bash
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+
+
+#set -x
+
+### Setup some variables.
+### GIT_COMMIT and BUILD_URL are set by Hudson if it is run by patch 
process
+### Read variables from properties file
+. `dirname $0`/test-patch.properties
+

+###
+parseArgs() {
+  case "$1" in
+QABUILD)
+  ### Set QABUILD to true to indicate that this script is being run by 
Hudson
+  QABUILD=true
+  if [[ $# != 14 ]] ; then
+echo "ERROR: usage $0 QABUILD
  
   "
+cleanupAndExit 0
+  fi
+  PATCH_DIR=$2
+  PS=$3
+  WGET=$4
+  JIRACLI=$5
+  GIT=$6
+  GREP=$7
+  PATCH=$8
+  FINDBUGS_HOME=$9
+  FORREST_HOME=${10}
+  BASEDIR=${11}
+  JIRA_PASSWD=${12}
+  JAVA5_HOME=${13}
--- End diff --

Java6 is the mininum JVM required for branch-3.4, no? And Java7 for 
branch-3.5


> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866469#comment-15866469
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/165#discussion_r100269807
  
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,616 @@
+#!/usr/bin/env bash
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+
+
+#set -x
+
+### Setup some variables.
+### GIT_COMMIT and BUILD_URL are set by Hudson if it is run by patch 
process
+### Read variables from properties file
+. `dirname $0`/test-patch.properties
+

+###
+parseArgs() {
+  case "$1" in
+QABUILD)
+  ### Set QABUILD to true to indicate that this script is being run by 
Hudson
+  QABUILD=true
+  if [[ $# != 14 ]] ; then
+echo "ERROR: usage $0 QABUILD
  
   "
+cleanupAndExit 0
+  fi
+  PATCH_DIR=$2
+  PS=$3
+  WGET=$4
+  JIRACLI=$5
+  GIT=$6
+  GREP=$7
+  PATCH=$8
+  FINDBUGS_HOME=$9
+  FORREST_HOME=${10}
+  BASEDIR=${11}
+  JIRA_PASSWD=${12}
+  JAVA5_HOME=${13}
+  CURL=${14}
+  if [ ! -e "$PATCH_DIR" ] ; then
+mkdir -p $PATCH_DIR
+  fi
+
+  ## Obtain PR number and title
+  PULLREQUEST_ID=${GIT_PR_NUMBER}
+  PULLREQUEST_TITLE="${GIT_PR_TITLE}"
+
+  ## Extract jira number from PR title
+  local prefix=${PULLREQUEST_TITLE%ZOOKEEPER\-[0-9]*}
+  local noprefix=${PULLREQUEST_TITLE#$prefix}
+  local regex='\(ZOOKEEPER-.[0-9]*\)'
+  defect=$(expr "$noprefix" : ${regex})
+
+  echo "Pull request id: ${PULLREQUEST_ID}"
+  echo "Pull request title: ${PULLREQUEST_TITLE}"
+  echo "Defect number: ${defect}"
+
+  JIRA_COMMENT="GitHub Pull Request ${PULLREQUEST_NUMBER} Build
+  "
+  ;;
+DEVELOPER)
+  ### Set QABUILD to false to indicate that this script is being run 
by a developer
+  QABUILD=false
+  if [[ $# != 10 ]] ; then
+echo "ERROR: usage $0 DEVELOPER   
 
 "
+cleanupAndExit 0
+  fi
+  PATCH_DIR=$3
+  PATCH_FILE=${PATCH_DIR}/patch
+  curl -L $2.diff > ${PATCH_FILE}
+  ### PATCH_FILE contains the location of the patchfile
+  if [[ ! -e "$PATCH_FILE" ]] ; then
+echo "Unable to locate the patch file $PATCH_FILE"
+cleanupAndExit 0
+  fi
+  ### Check if $PATCH_DIR exists. If it does not exist, create a new 
directory
+  if [[ ! -e "$PATCH_DIR" ]] ; then
+   mkdir "$PATCH_DIR"
+   if [[ $? == 0 ]] ; then
+ echo "$PATCH_DIR has been created"
+   else
+ echo "Unable to create $PATCH_DIR"
+ cleanupAndExit 0
+   fi
+  fi
+  GIT=$4
+  GREP=$5
+  PATCH=$6
+  FINDBUGS_HOME=$7
+  FORREST_HOME=$8
+  BASEDIR=$9
+  JAVA5_HOME=${10}
--- End diff --

As above.


> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866471#comment-15866471
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/165#discussion_r100232542
  
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,616 @@
+#!/usr/bin/env bash
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+
+
+#set -x
+
+### Setup some variables.
+### GIT_COMMIT and BUILD_URL are set by Hudson if it is run by patch 
process
+### Read variables from properties file
+. `dirname $0`/test-patch.properties
+

+###
+parseArgs() {
+  case "$1" in
+QABUILD)
+  ### Set QABUILD to true to indicate that this script is being run by 
Hudson
+  QABUILD=true
+  if [[ $# != 14 ]] ; then
+echo "ERROR: usage $0 QABUILD
  
   "
+cleanupAndExit 0
+  fi
+  PATCH_DIR=$2
+  PS=$3
+  WGET=$4
+  JIRACLI=$5
+  GIT=$6
+  GREP=$7
+  PATCH=$8
+  FINDBUGS_HOME=$9
+  FORREST_HOME=${10}
+  BASEDIR=${11}
+  JIRA_PASSWD=${12}
+  JAVA5_HOME=${13}
+  CURL=${14}
+  if [ ! -e "$PATCH_DIR" ] ; then
+mkdir -p $PATCH_DIR
+  fi
+
+  ## Obtain PR number and title
+  PULLREQUEST_ID=${GIT_PR_NUMBER}
+  PULLREQUEST_TITLE="${GIT_PR_TITLE}"
+
+  ## Extract jira number from PR title
+  local prefix=${PULLREQUEST_TITLE%ZOOKEEPER\-[0-9]*}
+  local noprefix=${PULLREQUEST_TITLE#$prefix}
+  local regex='\(ZOOKEEPER-.[0-9]*\)'
+  defect=$(expr "$noprefix" : ${regex})
+
+  echo "Pull request id: ${PULLREQUEST_ID}"
+  echo "Pull request title: ${PULLREQUEST_TITLE}"
+  echo "Defect number: ${defect}"
+
+  JIRA_COMMENT="GitHub Pull Request ${PULLREQUEST_NUMBER} Build
+  "
+  ;;
+DEVELOPER)
+  ### Set QABUILD to false to indicate that this script is being run 
by a developer
+  QABUILD=false
+  if [[ $# != 10 ]] ; then
+echo "ERROR: usage $0 DEVELOPER   
 
 "
+cleanupAndExit 0
+  fi
+  PATCH_DIR=$3
+  PATCH_FILE=${PATCH_DIR}/patch
+  curl -L $2.diff > ${PATCH_FILE}
+  ### PATCH_FILE contains the location of the patchfile
+  if [[ ! -e "$PATCH_FILE" ]] ; then
+echo "Unable to locate the patch file $PATCH_FILE"
+cleanupAndExit 0
+  fi
+  ### Check if $PATCH_DIR exists. If it does not exist, create a new 
directory
+  if [[ ! -e "$PATCH_DIR" ]] ; then
+   mkdir "$PATCH_DIR"
+   if [[ $? == 0 ]] ; then
+ echo "$PATCH_DIR has been created"
+   else
+ echo "Unable to create $PATCH_DIR"
+ cleanupAndExit 0
+   fi
+  fi
+  GIT=$4
+  GREP=$5
+  PATCH=$6
+  FINDBUGS_HOME=$7
+  FORREST_HOME=$8
+  BASEDIR=$9
+  JAVA5_HOME=${10}
+  ### Obtain the patch filename to append it to the version number
+  local subject=`grep "Subject:" ${PATCH_FILE}`
+  local length=`expr match ${subject} ZOOKEEPER-[0-9]*`
+  local position=`expr index ${subject} ZOOKEEPER-`
+  defect=${${subject:$position:$length}#ZOOKEEPER-}
+  ;;
+*)
+  echo "ERROR: usage $0 QABUILD [args] | DEVELOPER [args]"
+  cleanupAndExit 0
+  ;;
+  esac
+}
+

+###
+checkout () {
+  echo ""
+  echo ""
+  echo 
"=="
+  echo 
"=="
+  echo "Testing patch for pull request ${PULLREQUEST_ID}."
+  echo 
"=="
+  echo 
"=="
+  echo ""
+  echo ""
+  ### When run by a 

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859925#comment-15859925
 ] 

Michael Han commented on ZOOKEEPER-2665:


Enrico needs to be granted a role of "contributor" on JIRA - however I don't 
think I have admin rights on JIRA. Either [~fpj] or [~phunt] could help make 
Enrico a contributor.

> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859301#comment-15859301
 ] 

Edward Ribeiro commented on ZOOKEEPER-2665:
---

I am not a committer myself, but pinging [~hanm] & [~fpj] ;) 

> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Enrico Olivelli (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859296#comment-15859296
 ] 

Enrico Olivelli commented on ZOOKEEPER-2665:


[~eribeiro]
I cannot assign the ticket to myself, can you add me the list of allowed 
'assignee' for ZookKeeper JIRA project ?




> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859276#comment-15859276
 ] 

Edward Ribeiro commented on ZOOKEEPER-2665:
---

Hey [~eolivelli], thanks for stepping up. You can assign the issue to yourself, 
btw. I will provide the best support I can do. :)

Cheers,
Eddie

> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Enrico Olivelli (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856218#comment-15856218
 ] 

Enrico Olivelli commented on ZOOKEEPER-2665:


[~fpj] [~eribeiro]

I have filed a PR for the 3.4 branch, IHMO it is workng well

{quote}
-1 @author. The patch appears to contain 6 @author tags which the Zookeeper 
community has agreed to not allow in code contribution
{quote}

the patch contains the "@author" keywork in self-code, I think it is OK

If for you it is OK I can file a PR for the 3.5 branch as well

> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856206#comment-15856206
 ] 

Hadoop QA commented on ZOOKEEPER-2665:
--

-1 overall.  GitHub Pull Request  Build
  

-1 @author.  The patch appears to contain 6 @author tags which the 
Zookeeper community has agreed to not allow in code contributions.

+1 tests included.  The patch appears to include 15 new or modified tests.

-1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 97 new Findbugs (version 
3.0.1) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/286//console

This message is automatically generated.

> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2665) Port QA github pull request build to branch 3.4 and 3.5

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856061#comment-15856061
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2665:
---

GitHub user eolivelli opened a pull request:

https://github.com/apache/zookeeper/pull/165

ZOOKEEPER-2665 Port QA github pull request build to branch 3.4 and 3.5



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eolivelli/zookeeper ZOOKEEPER-2665

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/165.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #165


commit a194d418828bda663e034cecc392a14e98325a1d
Author: eolivelli 
Date:   2017-02-07T14:17:24Z

ZOOKEEPER-2665 Port QA github pull request build to branch 3.4 and 3.5




> Port QA github pull request build to branch 3.4 and 3.5
> ---
>
> Key: ZOOKEEPER-2665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2665
> Project: ZooKeeper
>  Issue Type: Test
>  Components: build
>Reporter: Flavio Junqueira
> Fix For: 3.5.3, 3.4.11
>
>
> We have QA build for pull requests against master but not against branches 
> 3.4 and 3.5. We need to port the necessary wiring to do it, it shouldn't be 
> difficult.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)