[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-11-21 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261238#comment-16261238
 ] 

Hudson commented on ZOOKEEPER-2795:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3617 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3617/])
ZOOKEEPER-2795: Change log level for "ZKShutdownHandler is not (phunt: rev 
b5621c698baf5d3258ebcf9342a23aa4889d03ca)
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java


> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-11-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261129#comment-16261129
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2795:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/273


> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-11-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261120#comment-16261120
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2795:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/273
  
IC. Your investigation/summary makes sense to me. I'll commit this. Thanks 
Abe!


> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257576#comment-16257576
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2795:
---

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/273
  
@phunt I'm trying to understand the problem you are describing. Please let 
me know what I am missing.

Since `QuorumZooKeeperServer` reimplements `setState` without 
`ZooKeeperServerShutdownHandler`  I think this is only an issue when dealing 
with standalone ZooKeeper servers. 

Standalone servers are only instantiated (outside of tests) in 
`ZooKeeperServerMain#runFromConfig` (which also does the work of setting the 
`ZooKeeperServerShutdownHandler`).

In other words, I think we are dealing with an unfortunate usage of 
inheritance. It would be ideal to add this `ZooKeeperServerShutdownHandler` in 
a subclass of `ZooKeeperServer` used only for standalone purposes but it looks 
like we did the opposite, putting in the `ZooKeeperServerShutdownHandler` in 
the default case and reimplementing `setState` for the purpose of ignoring the 
`ZooKeeperServerShutdownHandler` it in `QuorumZooKeeperServer`. 

When the `ZooKeeperServerShutdownHandler` is needed it is always set (in 
production code). 

So I guess my question is, what problem would an operator be debugging with 
this log message?
 


> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257299#comment-16257299
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2795:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/273
  
iiuc that change comes from 
https://issues.apache.org/jira/browse/ZOOKEEPER-2247 and the concern is that 
we'd silently be broken without this log message. While the code change is 
trivial I'm concerned about the operational impact. Did you look into what 
happens in this situation? Without this log message how would the operator 
diagnose this problem? Is there a better way to do this? e.g. if it's truly an 
"ERROR" shouldn't we shut down the server? We'd obviously need to consider the 
b/w compat issues here as well such as the use in Kafka as recently pointed out.


> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-11-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254935#comment-16254935
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2795:
---

Github user ijuma commented on the issue:

https://github.com/apache/zookeeper/pull/273
  
It would be great for this to be merged so that projects that use ZooKeeper 
in their tests (e.g. Kafka) don't have a bunch of logging noise that can't be 
disabled without disabling real errors.


> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-06-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035194#comment-16035194
 ] 

Hadoop QA commented on ZOOKEEPER-2795:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/763//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/763//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/763//console

This message is automatically generated.

> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message

2017-06-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035153#comment-16035153
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2795:
---

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/273

ZOOKEEPER-2795 Change log level for "ZKShutdownHandler is not registered" 
error message

`ZKShutdownHandler` may not be registered if the user creates a 
`ZooKeeperServer` object outside of `ZooKeeperServerMain.runFromConfig`.

We should change the log level of the message that is printed on state 
changes of `ZooKeeperServer` when `ZKShutdownHandler` is missing to something 
lower.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2795

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #273


commit 36c7e4df9a127775d1d0840faacae0ea0ced8304
Author: Abraham Fine 
Date:   2017-06-02T17:50:29Z

ZOOKEEPER-2795: Change log level for "ZKShutdownHandler is not registered" 
error message




> Change log level for "ZKShutdownHandler is not registered" error message
> 
>
> Key: ZOOKEEPER-2795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
> Project: ZooKeeper
>  Issue Type: Wish
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Andy Chambers
>Assignee: Abraham Fine
>Priority: Trivial
>
> We have an integration test suite that starts up an embedded version of 
> zookeeper as part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of 
> warnings that look like this
> 17-05-30 15:04:56 achambers.local ERROR 
> [org.apache.zookeeper.server.ZooKeeperServer:472] - ZKShutdownHandler is not 
> registered, so ZooKeeper server won't take any action on ERROR or SHUTDOWN 
> server state changes
> My java is a bit rusty but I think I can't create one of these shutdown 
> handlers from outside the "org.apache.zookeeper.server" package because the 
> constructor has not been marked "public". Would it be possible to do so?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)