[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-10-13 Thread Patrick Hunt (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204345#comment-16204345
 ] 

Patrick Hunt commented on ZOOKEEPER-2814:
-

The expectation has always been that the user will format the string properly. 
I believe we should provide an error that allows the user to rectify, rather 
than ignoring. That just makes our lives harder in the future.

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203437#comment-16203437
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user dolphy17 commented on the issue:

https://github.com/apache/zookeeper/pull/371
  
I prefer the regex solution too as @mfenes did.


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-10-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202374#comment-16202374
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user mfenes commented on the issue:

https://github.com/apache/zookeeper/pull/371
  
Regex implementation would be shorter to ignore the spaces and empty 
strings as
```
connectString.replaceAll("\\s", "").replaceAll(",+", ",").split(",") 
```
does the same thing as the new StringUtils.split(String value, String 
separator) implementation in this PR.


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161599#comment-16161599
 ] 

Hadoop QA commented on ZOOKEEPER-2814:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 5 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1018//console

This message is automatically generated.

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161536#comment-16161536
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

GitHub user nikhilbhide opened a pull request:

https://github.com/apache/zookeeper/pull/371

ZOOKEEPER-2814: Ignore space after comma in connection string

Ported ZOOKEEPER-2814 from master to branch 3.4.

Added files
src/java/main/org/apache/zookeeper/common/StringUtils.java
src/java/test/org/apache/zookeeper/test/StringUtilTest.java

Modified Files:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #371


commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7
Author: Nikhil Bhide 
Date:   2017-09-11T13:14:29Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Added logic to trim host connection string for ZOOKEEPER-2814: Ignore space 
after comma in connection string
Port ZOOKEEPER-2814 from master

commit 3f210394e989507282d1e42fb9f3e35512d314e8
Author: Nikhil Bhide 
Date:   2017-09-11T13:19:44Z

Zookeeper 2814: ignore space after comma in connection string

Port Zookeeper 2814 from master to branch - 3.4
Created StringUtils.java

commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1
Author: Nikhil Bhide 
Date:   2017-09-11T13:22:26Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Port ZOOKEEPER-2814 from master to branch-3.4
Added code to test split logic implemented in StringUtils.java

commit 1629f64f58c7787bb993162e5c9b8565b4d45c64
Author: Nikhil Bhide 
Date:   2017-09-11T13:26:08Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Port ZOOKEEPER-2814 from master to branch-3.4
Added test to verify the logic added to remove the spaces provided in 
connection string

commit d5ed52d86e5717ccf984c18d9cbb44a2cf92c01a
Author: Nikhil Bhide 
Date:   2017-09-11T15:15:34Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Ported ZOOKEEPER-2814 from master to 3.4

commit f9c40c41f727a6c2d82b59a7eff2d0d9d0b7fba2
Author: Nikhil Bhide 
Date:   2017-09-11T15:16:58Z

ZOOKEEPER-2814: Ignore space after comma in connection string




> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161475#comment-16161475
 ] 

Hadoop QA commented on ZOOKEEPER-2814:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 5 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1017//console

This message is automatically generated.

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161449#comment-16161449
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user nikhilbhide closed the pull request at:

https://github.com/apache/zookeeper/pull/370


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161424#comment-16161424
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

GitHub user nikhilbhide opened a pull request:

https://github.com/apache/zookeeper/pull/370

Ported ZOOKEEPER-2814 from master to branch 3.4.  Added files 
src/java/main/org/apache/zookeeper/common/StringUtils.java 
src/java/test/org/apache/zookeeper/test/StringUtilTest.java  Modified Files: 
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java 
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

Ported ZOOKEEPER-2814 from master to branch 3.4.

Added files
src/java/main/org/apache/zookeeper/common/StringUtils.java
src/java/test/org/apache/zookeeper/test/StringUtilTest.java

Modified Files:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #370


commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7
Author: Nikhil Bhide 
Date:   2017-09-11T13:14:29Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Added logic to trim host connection string for ZOOKEEPER-2814: Ignore space 
after comma in connection string
Port ZOOKEEPER-2814 from master

commit 3f210394e989507282d1e42fb9f3e35512d314e8
Author: Nikhil Bhide 
Date:   2017-09-11T13:19:44Z

Zookeeper 2814: ignore space after comma in connection string

Port Zookeeper 2814 from master to branch - 3.4
Created StringUtils.java

commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1
Author: Nikhil Bhide 
Date:   2017-09-11T13:22:26Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Port ZOOKEEPER-2814 from master to branch-3.4
Added code to test split logic implemented in StringUtils.java

commit 1629f64f58c7787bb993162e5c9b8565b4d45c64
Author: Nikhil Bhide 
Date:   2017-09-11T13:26:08Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Port ZOOKEEPER-2814 from master to branch-3.4
Added test to verify the logic added to remove the spaces provided in 
connection string

commit d5ed52d86e5717ccf984c18d9cbb44a2cf92c01a
Author: Nikhil Bhide 
Date:   2017-09-11T15:15:34Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Ported ZOOKEEPER-2814 from master to 3.4

commit f9c40c41f727a6c2d82b59a7eff2d0d9d0b7fba2
Author: Nikhil Bhide 
Date:   2017-09-11T15:16:58Z

ZOOKEEPER-2814: Ignore space after comma in connection string




> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161422#comment-16161422
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user nikhilbhide closed the pull request at:

https://github.com/apache/zookeeper/pull/369


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161421#comment-16161421
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

GitHub user nikhilbhide opened a pull request:

https://github.com/apache/zookeeper/pull/369

ZOOKEEPER-2814: Ignore space after comma in connection string

Ported ZOOKEEPER-2814 from master to branch 3.4.

Added files
src/java/main/org/apache/zookeeper/common/StringUtils.java
src/java/test/org/apache/zookeeper/test/StringUtilTest.java

Modified Files:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #369


commit 6503f12e144bc6b0652f7adf558bdc28c984e6c0
Author: Flavio Paiva Junqueira 
Date:   2013-11-15T18:12:07Z

ZOOKEEPER-1786. ZooKeeper data model documentation is incorrect
  (Niraj Tolia via fpj)



git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542356 
13f79535-47bb-0310-9956-ffa450edef68

commit a452d791cff92d65937142c3475a9894264376f6
Author: Flavio Paiva Junqueira 
Date:   2013-11-16T10:06:19Z

ZOOKEEPER-1808. Add version to FLE notifications for 3.4 branch (fpj)



git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542489 
13f79535-47bb-0310-9956-ffa450edef68

commit b770aeb0c8bcb28a9b653b1dc0edac623c75b509
Author: Flavio Paiva Junqueira 
Date:   2013-11-17T11:42:22Z

ZOOKEEPER-1597. Windows build failing (michim via fpj)



git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1542710 
13f79535-47bb-0310-9956-ffa450edef68

commit 7f069c0e084a74f6de661267b828ff3fde30bd11
Author: Flavio Paiva Junqueira 
Date:   2013-11-23T18:21:38Z

ZOOKEEPER-1817. Fix don't care for b3.4 (fpj)



git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1544858 
13f79535-47bb-0310-9956-ffa450edef68

commit c62f2ffa7b9fb026004f66d788ebf1e293d2fdf8
Author: Flavio Paiva Junqueira 
Date:   2013-11-26T23:43:29Z

ZOOKEEPER-1653. zookeeper fails to start because of inconsistent epoch 
(michim via fpj)



git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1545883 
13f79535-47bb-0310-9956-ffa450edef68

commit 605c8d1b0db0baa57582bb39229c80bfec832ae3
Author: Flavio Paiva Junqueira 
Date:   2013-11-27T23:23:11Z

ZOOKEEPER-1821. very ugly warning when compiling load_gen.c (german blanco 
via fpj)


git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1546231 
13f79535-47bb-0310-9956-ffa450edef68

commit a1cdea63de42ed1eaba224570ad0304c224b21c1
Author: Michi Mutsuzaki 
Date:   2013-12-04T04:20:53Z

ZOOKEEPER-1632. fix memory leaks in cli_st (fpj via michim)


git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1547703 
13f79535-47bb-0310-9956-ffa450edef68

commit f23b85bde1bf53b284a85a8ec6c6251cd63e9feb
Author: Flavio Paiva Junqueira 
Date:   2013-12-07T10:17:54Z

ZOOKEEPER-1459. Standalone ZooKeeperServer is not closing 
  the transaction log files on shutdown (Rakesh R via fpj)



git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1548826 
13f79535-47bb-0310-9956-ffa450edef68

commit 4822626f958742baf98303fd9cdfcb51ce95cb46
Author: Michi Mutsuzaki 
Date:   2013-12-10T20:43:22Z

ZOOKEEPER-1019. zkfuse doesn't list dependency on boost in README (Raul 
Gutierrez Segales via michim)


git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1549963 
13f79535-47bb-0310-9956-ffa450edef68

commit b666d3bccc2e8a0851c4b68024a4c3ac2d97713c
Author: Michi Mutsuzaki 
Date:   2013-12-11T00:12:53Z

ZOOKEEPER-1834. Catch IOException in FileTxnLog (fpj via michim)


git-svn-id: 
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550006 
13f79535-47bb-0310-9956-ffa450edef68

commit 63b1f92102877757815eec5e0866b7a143868e2d
Author: Camille Fournier 
Date:   2013-12-11T18:31:05Z

ZOOKEEPER-1382. Zookeeper server holds onto dead/expired session ids in the 
watch data structures
  (Germán Blanco and Michael Morello via camille)

git-svn-id:

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161418#comment-16161418
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user nikhilbhide closed the pull request at:

https://github.com/apache/zookeeper/pull/368


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161238#comment-16161238
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

GitHub user nikhilbhide opened a pull request:

https://github.com/apache/zookeeper/pull/368

ZOOKEEPER-2814: Ignore space after comma in connection string

Ported ZOOKEEPER-2814 from master to branch 3.4.

Added files 
 src/java/main/org/apache/zookeeper/common/StringUtils.java
src/java/test/org/apache/zookeeper/test/StringUtilTest.java

Modified Files:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nikhilbhide/zookeeper ZOOKEEPER-2814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #368


commit 11da57df94c95b52a97b7c039e1ba042ebac8ed7
Author: Nikhil Bhide 
Date:   2017-09-11T13:14:29Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Added logic to trim host connection string for ZOOKEEPER-2814: Ignore space 
after comma in connection string
Port ZOOKEEPER-2814 from master

commit 3f210394e989507282d1e42fb9f3e35512d314e8
Author: Nikhil Bhide 
Date:   2017-09-11T13:19:44Z

Zookeeper 2814: ignore space after comma in connection string

Port Zookeeper 2814 from master to branch - 3.4
Created StringUtils.java

commit 7da1c0786f7ca7aabe73f53f818db97d82e701e1
Author: Nikhil Bhide 
Date:   2017-09-11T13:22:26Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Port ZOOKEEPER-2814 from master to branch-3.4
Added code to test split logic implemented in StringUtils.java

commit 1629f64f58c7787bb993162e5c9b8565b4d45c64
Author: Nikhil Bhide 
Date:   2017-09-11T13:26:08Z

ZOOKEEPER-2814: Ignore space after comma in connection string

Port ZOOKEEPER-2814 from master to branch-3.4
Added test to verify the logic added to remove the spaces provided in 
connection string




> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-24 Thread Nikhil Bhide (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140326#comment-16140326
 ] 

Nikhil Bhide commented on ZOOKEEPER-2814:
-

Thanks [~hanm] for the update.
Can you please let me know steps to check-in the changes?

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-24 Thread Michael Han (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140298#comment-16140298
 ] 

Michael Han commented on ZOOKEEPER-2814:


Thanks for working on this.

bq. give me write access so that I can commit the changes to Zookeeper- branch 
3.4 and close this issue.

This is not the way Apache works. Please read contributor guidelines at 
https://community.apache.org/contributors/. tldr: only committers have access 
to source repo.

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-24 Thread Nikhil Bhide (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139917#comment-16139917
 ] 

Nikhil Bhide commented on ZOOKEEPER-2814:
-

Hi Admin,
As per the guidelines, I forked out new branch, made the changes and opened a 
new pull request.
[https://github.com/apache/zookeeper/pull/345]
Build was passed successfully, but I can not check in the changes. Can you 
please review the changes and give me write access so that I can commit the 
changes to Zookeeper- branch 3.4 and close this issue.


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138755#comment-16138755
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user nikhilbhide commented on the issue:

https://github.com/apache/zookeeper/pull/343
  
Reopening pull request #343


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138756#comment-16138756
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

GitHub user nikhilbhide reopened a pull request:

https://github.com/apache/zookeeper/pull/343

ZOOKEEPER-2814: Ignore space after comma in connection string

Proposed changes:
- StringUtils.java
   - New class org.apache.zookeeper.common.StringUtils to be added
   - Logic to split trim the spaces to be added in split method

- ConnectStringParser.java
  - Instead of using String#split, use StringUtils#split 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #343


commit d2a5192d9ee2e52e50f3c943790ce4b09eaab820
Author: Rakesh Radhakrishnan 
Date:   2015-05-20T07:29:50Z

ZOOKEEPER-2156: If JAVA_HOME is not set zk startup and fetching status 
command execution result misleads user (J.Andreina via rakeshr)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680471 
13f79535-47bb-0310-9956-ffa450edef68

commit 111d60b6253e3e2911a6ff525f0af792e7793ce5
Author: Rakesh Radhakrishnan 
Date:   2015-05-22T05:24:39Z

ZOOKEEPER-2191: Continue supporting prior Ant versions that don't implement 
the threads attribute for the JUnit task (Chris Nauroth via rakeshr)


git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680994 
13f79535-47bb-0310-9956-ffa450edef68

commit 3a7a240ef7381edf15925045e9f94408177e51cd
Author: Hongchao Deng 
Date:   2015-05-29T17:45:53Z

ZOOKEEPER-2187: remove duplicated code between CreateRequest{,2}
(Raul Gutierrez Segales via hdeng)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682521 
13f79535-47bb-0310-9956-ffa450edef68

commit fe63c1c4fdbfce201e193cd8723488d9a40dc498
Author: Raúl Gutiérrez Segalés 
Date:   2015-05-29T19:48:23Z

ZOOKEEPER-2179: Typo in Watcher.java (Archana T via rgs)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682539 
13f79535-47bb-0310-9956-ffa450edef68

commit 63884670328f09a3814db54cb4644d683822e4d4
Author: Hongchao Deng 
Date:   2015-05-29T21:46:49Z

ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
(Raul Gutierrez Segales via hdeng)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682558 
13f79535-47bb-0310-9956-ffa450edef68

commit daf766aa74c0e2f584b1a30f33f946e4ac282e3a
Author: Hongchao Deng 
Date:   2015-05-30T16:39:30Z

ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
(Raul Gutierrez Segales via hdeng)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682623 
13f79535-47bb-0310-9956-ffa450edef68

commit 891b12d004842e6ea09509765eaa2a18eca727c4
Author: Michi Mutsuzaki 
Date:   2015-05-31T09:21:07Z

ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via 
michim)


git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682701 
13f79535-47bb-0310-9956-ffa450edef68

commit b0141aa40e44cc747d7899a2a038a3bbe19e67a7
Author: Michi Mutsuzaki 
Date:   2015-06-01T06:45:11Z

ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth 
via michim)


git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682823 
13f79535-47bb-0310-9956-ffa450edef68

commit 7f52bebb90ff2d61a2428013771ce0df09890876
Author: Raúl Gutiérrez Segalés 
Date:   2015-06-02T05:21:26Z

ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java

To be able to use utf-8 in .java source files we now use utf-8
encoding to build them (Michi Mutsuzaki via rgs).

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683042 
13f79535-47bb-0310-9956-ffa450edef68

commit ea500b8911223fb36555b12c391adc9a20c9e28d
Author: Raúl Gutiérrez Segalés 
Date:   2015-06-02T19:17:09Z

ZOOKEEPER-2096: C client builds with incorrect error codes in VisualStudio 
2010+
(Vitaly Stakhovsky via rgs)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683163 
13f79535-47bb-0310-9956-ffa450edef68

commit 9f89dd30187a48e39556b6305246d835b54e00ae
Author: Raúl Gutiérrez Segalés 
Date:   2015-06-04T16:26:06Z

ZOOKEEPER-2194: Let DataNode.getChildren() return an unmodifiable view of 
its
children set (Hitoshi Mitake via rgs)

git-svn-id:

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138757#comment-16138757
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user nikhilbhide commented on the issue:

https://github.com/apache/zookeeper/pull/343
  
Closing pull request #343 as there seems to be a conflict.


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138758#comment-16138758
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user nikhilbhide closed the pull request at:

https://github.com/apache/zookeeper/pull/343


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138753#comment-16138753
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

Github user nikhilbhide closed the pull request at:

https://github.com/apache/zookeeper/pull/343


> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138737#comment-16138737
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2814:
---

GitHub user nikhilbhide opened a pull request:

https://github.com/apache/zookeeper/pull/343

ZOOKEEPER-2814: Ignore space after comma in connection string

Proposed changes:
- StringUtils.java
   - New class org.apache.zookeeper.common.StringUtils to be added
   - Logic to split trim the spaces to be added in split method

- ConnectStringParser
  - Instead of using String#split, use StringUtils#split 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #343


commit d2a5192d9ee2e52e50f3c943790ce4b09eaab820
Author: Rakesh Radhakrishnan 
Date:   2015-05-20T07:29:50Z

ZOOKEEPER-2156: If JAVA_HOME is not set zk startup and fetching status 
command execution result misleads user (J.Andreina via rakeshr)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680471 
13f79535-47bb-0310-9956-ffa450edef68

commit 111d60b6253e3e2911a6ff525f0af792e7793ce5
Author: Rakesh Radhakrishnan 
Date:   2015-05-22T05:24:39Z

ZOOKEEPER-2191: Continue supporting prior Ant versions that don't implement 
the threads attribute for the JUnit task (Chris Nauroth via rakeshr)


git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1680994 
13f79535-47bb-0310-9956-ffa450edef68

commit 3a7a240ef7381edf15925045e9f94408177e51cd
Author: Hongchao Deng 
Date:   2015-05-29T17:45:53Z

ZOOKEEPER-2187: remove duplicated code between CreateRequest{,2}
(Raul Gutierrez Segales via hdeng)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682521 
13f79535-47bb-0310-9956-ffa450edef68

commit fe63c1c4fdbfce201e193cd8723488d9a40dc498
Author: Raúl Gutiérrez Segalés 
Date:   2015-05-29T19:48:23Z

ZOOKEEPER-2179: Typo in Watcher.java (Archana T via rgs)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682539 
13f79535-47bb-0310-9956-ffa450edef68

commit 63884670328f09a3814db54cb4644d683822e4d4
Author: Hongchao Deng 
Date:   2015-05-29T21:46:49Z

ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
(Raul Gutierrez Segales via hdeng)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682558 
13f79535-47bb-0310-9956-ffa450edef68

commit daf766aa74c0e2f584b1a30f33f946e4ac282e3a
Author: Hongchao Deng 
Date:   2015-05-30T16:39:30Z

ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg
(Raul Gutierrez Segales via hdeng)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682623 
13f79535-47bb-0310-9956-ffa450edef68

commit 891b12d004842e6ea09509765eaa2a18eca727c4
Author: Michi Mutsuzaki 
Date:   2015-05-31T09:21:07Z

ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via 
michim)


git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682701 
13f79535-47bb-0310-9956-ffa450edef68

commit b0141aa40e44cc747d7899a2a038a3bbe19e67a7
Author: Michi Mutsuzaki 
Date:   2015-06-01T06:45:11Z

ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth 
via michim)


git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1682823 
13f79535-47bb-0310-9956-ffa450edef68

commit 7f52bebb90ff2d61a2428013771ce0df09890876
Author: Raúl Gutiérrez Segalés 
Date:   2015-06-02T05:21:26Z

ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java

To be able to use utf-8 in .java source files we now use utf-8
encoding to build them (Michi Mutsuzaki via rgs).

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683042 
13f79535-47bb-0310-9956-ffa450edef68

commit ea500b8911223fb36555b12c391adc9a20c9e28d
Author: Raúl Gutiérrez Segalés 
Date:   2015-06-02T19:17:09Z

ZOOKEEPER-2096: C client builds with incorrect error codes in VisualStudio 
2010+
(Vitaly Stakhovsky via rgs)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1683163 
13f79535-47bb-0310-9956-ffa450edef68

commit 9f89dd30187a48e39556b6305246d835b54e00ae
Author: Raúl Gutiérrez Segalés 
Date:   2015-06-04T16:26:06Z

ZOOKEEPER-2194: Let DataNode.getChildren() return an unmodifiable view of 
its
children set (Hitoshi Mitake via rgs)

git-svn-id:

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-22 Thread Edward Ribeiro (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137354#comment-16137354
 ] 

Edward Ribeiro commented on ZOOKEEPER-2814:
---

Hi [~nikbhi15],

FYI, the trim of the host string seems to be fixed on branch-3.5 and master, 
doesn't it? See 
https://github.com/apache/zookeeper/blob/branch-3.5/src/java/main/org/apache/zookeeper/common/StringUtils.java#L37
 

While it is not fixed on branch-3.4 yet: 
https://github.com/apache/zookeeper/blob/branch-3.4/src/java/main/org/apache/zookeeper/client/ConnectStringParser.java#L65

I suggest that you add a method to check the host string with spaces after (and 
before) the comma.

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Assignee: Nikhil Ashok Bhide
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-22 Thread Nikhil Bhide (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137176#comment-16137176
 ] 

Nikhil Bhide commented on ZOOKEEPER-2814:
-

Please assign this to me. 

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2814) Ignore space after comma in connection string

2017-08-20 Thread Nikhil Ashok Bhide (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134393#comment-16134393
 ] 

Nikhil Ashok Bhide commented on ZOOKEEPER-2814:
---

Spaces are not allowed in the domain space. So, would it be good idea to trim 
the spaces and use the address or throw exception that IP address/host name of 
server can not contain space? According to me, its better to throw the 
exception rather than trimming spaces of provided IP address. 

> Ignore space after comma in connection string
> -
>
> Key: ZOOKEEPER-2814
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2814
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Viliam Durina
>Priority: Minor
>
> I'm using the following connection string:
> {{10.0.0.179:2181,10.0.0.176:2181}}
> However, I get:
> {{java.net.UnknownHostException: 10.0.0.176: Name or service not known
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.(ZooKeeper.java:445)
> at ...
> ...}}
> The problem was the space after the comma. I suggest to either make the space 
> optional or produce error on it, as this is a real pain to spot. Using the 
> space also makes the connect string more readable. Spaces are not allowed in 
> domain names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)