[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-17 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745825#comment-16745825
 ] 

Hudson commented on ZOOKEEPER-3232:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #356 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/356/])
ZOOKEEPER-3232: make the log of notification about LE more readable (fangmin: 
rev fd465ebf5380319b0ec9415ab832b01046e131ff)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java


> make the log of notification about LE more readable
> ---
>
> Key: ZOOKEEPER-3232
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3232
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: leaderElection
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> the log of notification about LE is very important to help us to see the 
> process of LE:e.g.
> {code:java}
> 2019-01-01 16:29:27,494 [myid:2] - INFO 
> [WorkerReceiver[myid=2]:FastLeaderElection@595] - Notification: 1 (message 
> format version), 3 (n.leader), 0x60b3dc215 (n.zxid), 0x3 (n.round), FOLLOWING 
> (n.state), 1 (n.sid), 0x7 (n.peerEpoch) LOOKING (my state){code}
> the current log have some problems:
> 1:don't use the placeholder(other:+),don't in the style of k:v（antiman）
> 2.the properties in the logs are very messed(no group by,no order), not easy 
> to read.
> 3.the value about version is HEX which don't have the 0x prefix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-17 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745789#comment-16745789
 ] 

Hudson commented on ZOOKEEPER-3232:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #194 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/194/])
ZOOKEEPER-3232: make the log of notification about LE more readable (fangmin: 
rev fd465ebf5380319b0ec9415ab832b01046e131ff)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java


> make the log of notification about LE more readable
> ---
>
> Key: ZOOKEEPER-3232
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3232
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: leaderElection
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> the log of notification about LE is very important to help us to see the 
> process of LE:e.g.
> {code:java}
> 2019-01-01 16:29:27,494 [myid:2] - INFO 
> [WorkerReceiver[myid=2]:FastLeaderElection@595] - Notification: 1 (message 
> format version), 3 (n.leader), 0x60b3dc215 (n.zxid), 0x3 (n.round), FOLLOWING 
> (n.state), 1 (n.sid), 0x7 (n.peerEpoch) LOOKING (my state){code}
> the current log have some problems:
> 1:don't use the placeholder(other:+),don't in the style of k:v（antiman）
> 2.the properties in the logs are very messed(no group by,no order), not easy 
> to read.
> 3.the value about version is HEX which don't have the 0x prefix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-03 Thread Brian Nixon (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733820#comment-16733820
 ] 

Brian Nixon commented on ZOOKEEPER-3232:


seems reasonable to me

> make the log of notification about LE more readable
> ---
>
> Key: ZOOKEEPER-3232
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3232
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: leaderElection
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>
> the log of notification about LE is very important to help us to see the 
> process of LE:e.g.
> {code:java}
> 2019-01-01 16:29:27,494 [myid:2] - INFO 
> [WorkerReceiver[myid=2]:FastLeaderElection@595] - Notification: 1 (message 
> format version), 3 (n.leader), 0x60b3dc215 (n.zxid), 0x3 (n.round), FOLLOWING 
> (n.state), 1 (n.sid), 0x7 (n.peerEpoch) LOOKING (my state){code}
> the current log have some problems:
> 1:don't use the placeholder(other:+),don't in the style of k:v（antiman）
> 2.the properties in the logs are very messed(no group by,no order), not easy 
> to read.
> 3.the value about version is HEX which don't have the 0x prefix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-01 Thread maoling (JIRA) 


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731589#comment-16731589
 ] 

maoling commented on ZOOKEEPER-3232:


The log is changed to like this:
{code:java}
// code placeholder
2019-01-01 18:18:40,073 [myid:2] - INFO 
[WorkerReceiver[myid=2]:FastLeaderElection@688] - Notification: my 
state:FOLLOWING; n.sid:3, n.state:LOOKING, n.leader:3, n.round:0x1, 
n.peerEpoch:0x10, n.zxid:0x10, message format version:0x2, n.config 
version:0x0

2019-01-01 20:24:44,873 [myid:2] - INFO 
[WorkerReceiver[myid=2]:FastLeaderElection@688] - Notification: my 
state:LOOKING; n.sid:2, n.state:LOOKING, n.leader:3, n.round:0x2, 
n.peerEpoch:0x11, n.zxid:0x11, message format version:0x2, n.config 
version:0x0{code}
 

> make the log of notification about LE more readable
> ---
>
> Key: ZOOKEEPER-3232
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3232
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: leaderElection
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>
> the log of notification about LE is very important to help us to see the 
> process of LE:e.g.
> {code:java}
> 2019-01-01 16:29:27,494 [myid:2] - INFO 
> [WorkerReceiver[myid=2]:FastLeaderElection@595] - Notification: 1 (message 
> format version), 3 (n.leader), 0x60b3dc215 (n.zxid), 0x3 (n.round), FOLLOWING 
> (n.state), 1 (n.sid), 0x7 (n.peerEpoch) LOOKING (my state){code}
> the current log have some problems:
> 1:don't use the placeholder(other:+),don't in the style of k:v（antiman）
> 2.the properties in the logs are very messed(no group by,no order), not easy 
> to read.
> 3.the value about version is HEX which don't have the 0x prefix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)