[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108545#comment-13108545 ] Hudson commented on ZOOKEEPER-961: -- Integrated in ZooKeeper-trunk #1309 (See [https://builds.apache.org/job/ZooKeeper-trunk/1309/]) rolling back excess checkin from ZOOKEEPER-961 camille : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1172406 Files : * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107571#comment-13107571 ] Camille Fournier commented on ZOOKEEPER-961: I'm rolling the unrelated changes that were checked in on this ticket from both 3.3.3 and 3.4. Please submit another ticket for those changes, with tests. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105266#comment-13105266 ] Hudson commented on ZOOKEEPER-961: -- Integrated in ZooKeeper-trunk #1304 (See [https://builds.apache.org/job/ZooKeeper-trunk/1304/]) ZOOKEEPER-961. Watch recovery after disconnection when connection string contains a prefix. (Matthias Spycher via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1170438 Files : * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/DisconnectedWatcherTest.java Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105513#comment-13105513 ] Mahadev konar commented on ZOOKEEPER-961: - @Camille, I actually like the change in the first part. Makes it cleaner and is also a no op change. What do you think? Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105538#comment-13105538 ] Matthias Spycher commented on ZOOKEEPER-961: I'm working on a more elaborate fix to prevent races from overwriting CLOSED (at least for 3.4). I agree that the first part in the change above is more important than the one line in the exception catch clause, but feel free to move it to another issue. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105544#comment-13105544 ] Camille Fournier commented on ZOOKEEPER-961: Oh Matthias, can you comment on the condition you're looking at? Is it something along the lines of https://issues.apache.org/jira/browse/ZOOKEEPER-1159? I never got anywhere with that and if you think you have figured out what the problem is it would be great to know. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105547#comment-13105547 ] Matthias Spycher commented on ZOOKEEPER-961: @Camille, you do see the problem of CLOSED being stomped by startConnect() right? Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105550#comment-13105550 ] Matthias Spycher commented on ZOOKEEPER-961: State transitions in the SendThread are generally not safe. We don't prevent transitions like CLOSED CONNECTING or CLOSED CONNECTED -- that's what I'm addressing in my next patch. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105557#comment-13105557 ] Camille Fournier commented on ZOOKEEPER-961: Mmm I see, at least for calls to close/disconnect. Let's wrap all of this up in the fix for that issue. I suspect it will fix 1159, if you want to comment in there. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104278#comment-13104278 ] Mahadev konar commented on ZOOKEEPER-961: - @Thomas [~thkoch] , I think your patch attachment: https://issues.apache.org/jira/secure/attachment/12494089/ZOOKEEPER-961.patch is definitely worth going into 3.5.0. I like the way you have cleaned up the interaction between ClientCnxn and ZooKeeper. Would you mind filing a seperate jira for that? I'd be happy to review and commit it into trunk. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[
https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104542#comment-13104542
]
Camille Fournier commented on ZOOKEEPER-961:
Why is there a change to the isConnected logic that came in with this patch?
Specifically, why on line 967 do we now have:
if (closing || !state.isAlive()) {
break;
}
? This seems unrelated to the fix.
Watch recovery after disconnection when connection string contains a prefix
---
Key: ZOOKEEPER-961
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961
Project: ZooKeeper
Issue Type: Bug
Components: java client
Affects Versions: 3.3.1
Environment: Windows 32 bits
Reporter: pmpm47
Assignee: Matthias Spycher
Priority: Critical
Fix For: 3.3.4, 3.4.0
Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch,
ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch
Let's say you're using connection string 127.0.0.1:2182/foo.
1) put a childrenchanged watch on relative / (that is, on absolute path /foo)
2) stop the zk server
3) start the zk server
4) at this point, the client recovers the connection, and should have put
back a watch on relative path /, but instead the client puts a watch on the
*absolute* path /
- if some other client adds or removes a node under /foo, nothing will happen
- if some other client adds or removes a node under /, then you will get an
error from the zk client library (string operation error)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104594#comment-13104594 ] Matthias Spycher commented on ZOOKEEPER-961: Agreed, this line isn't related to the fix. It slipped in - I should probably have separated the changes into two separate patches. It has to do with honoring the close() as early as possible. Note that if state.isAlive() returns false, the while loop ends, so we shouldn't issue warnings about attempting to reconnect. I don't see how it changes the isConnected logic. My assumption here is that we shouldn't allow a transition from CLOSE or AUTH_FAILED back to CONNECTING. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104754#comment-13104754 ] Camille Fournier commented on ZOOKEEPER-961: It definitely shouldn't be part of this fix, and deserves a separate checkin (and testing). Mahadev, how do you want to handle this? Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104938#comment-13104938 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-961: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1809/ --- (Updated 2011-09-14 22:16:59.743604) Review request for zookeeper. Summary (updated) --- - chroot is not a property of the ClientCnxn anymore but of the ZooKeeper class - ClientCnxn has no reference to ZooKeeper anymore - The WatchManager stores a reference to the chroot String with every watcher. It's not that much overhead since it's the same String instance all the time. The idea is, to prepare for additional patches that make it possible to use the same ClientCnxn with different ZooKeeper client instances that have different chroots. This addresses bug ZOOKEEPER-961. https://issues.apache.org/jira/browse/ZOOKEEPER-961 Diffs - src/java/main/org/apache/zookeeper/ClientCnxn.java 78b2eb2 src/java/main/org/apache/zookeeper/ClientWatchManager.java d56374d src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0 src/java/main/org/apache/zookeeper/client/WatchManager.java PRE-CREATION src/java/main/org/apache/zookeeper/client/WatchRegistration.java PRE-CREATION src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6 src/java/test/org/apache/zookeeper/test/WatcherTest.java 90ec513 Diff: https://reviews.apache.org/r/1809/diff Testing --- Thanks, Thomas Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104058#comment-13104058 ] Mahadev konar commented on ZOOKEEPER-961: - Matthias, Looks like the patch doesnt apply to 3.3 branch. Can you please create a patch for that? thanks Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104066#comment-13104066 ] Hadoop QA commented on ZOOKEEPER-961: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494339/ZOOKEEPER-961b.patch against trunk revision 1170365. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/530//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/530//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/530//console This message is automatically generated. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104121#comment-13104121 ] Hadoop QA commented on ZOOKEEPER-961: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494355/ZOOKEEPER-961.patch against trunk revision 1170365. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/533//console This message is automatically generated. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104268#comment-13104268 ] Mahadev konar commented on ZOOKEEPER-961: - +1 looks good to me. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Matthias Spycher Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102791#comment-13102791 ] Mahadev konar commented on ZOOKEEPER-961: - @Matthias, Do you have a aptch for 3.3 branch as well? Or does the trunk patch apply? Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102796#comment-13102796 ] Matthias Spycher commented on ZOOKEEPER-961: Patch should work for both 3.3. and trunk. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102794#comment-13102794 ] Hadoop QA commented on ZOOKEEPER-961: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12467353/ZOOKEEPER-961.patch against trunk revision 1166970. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/525//console This message is automatically generated. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102820#comment-13102820 ] Hadoop QA commented on ZOOKEEPER-961: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494062/ZOOKEEPER-961b.patch against trunk revision 1166970. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/526//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/526//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/526//console This message is automatically generated. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102834#comment-13102834 ] Thomas Koch commented on ZOOKEEPER-961: --- Hi Matthias, please be so kind to assign issues to yourself if you work on them. I also spent several hours now for a patch. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102877#comment-13102877 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-961: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1809/ --- Review request for zookeeper. Summary --- - chroot is not a property of the ClientCnxn anymore but of the ZooKeeper class - ClientCnxn has no reference to ZooKeeper anymore - The WatchManager stores a reference to the chroot String with every watcher. It's not that much overhead since it's the same String instance all the time. The idea is, to prepare for additional patches that make it possible to use the same ClientCnxn with different ZooKeeper client instances that have different chroots. This addresses bug ZOOKEEPER-961. https://issues.apache.org/jira/browse/ZOOKEEPER-961 Diffs - src/java/main/org/apache/zookeeper/ClientCnxn.java 78b2eb2 src/java/main/org/apache/zookeeper/ClientWatchManager.java d56374d src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0 src/java/main/org/apache/zookeeper/client/WatchManager.java PRE-CREATION src/java/main/org/apache/zookeeper/client/WatchRegistration.java PRE-CREATION src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6 src/java/test/org/apache/zookeeper/test/WatcherTest.java 90ec513 Diff: https://reviews.apache.org/r/1809/diff Testing --- Thanks, Thomas Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102890#comment-13102890 ] Hadoop QA commented on ZOOKEEPER-961: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494089/ZOOKEEPER-961.patch against trunk revision 1166970. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/528//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/528//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/528//console This message is automatically generated. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13103148#comment-13103148 ] Matthias Spycher commented on ZOOKEEPER-961: Sorry Thomas, didn't mean to step on anyone's toes. I happened to be working on this locally last week, and later discovered this Jira entry. Also, I still think your refactoring/cleanup is worthwhile. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch, ZOOKEEPER-961.patch, ZOOKEEPER-961b.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13101344#comment-13101344 ] Benjamin Reed commented on ZOOKEEPER-961: - ZOOKEEPER-911 isn't going to make it into 3.4.0, so we need to get this patch committed without it. are you going to be able to make the change thomas? or do you want me to submit something? Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-961.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-961) Watch recovery after disconnection when connection string contains a prefix
[ https://issues.apache.org/jira/browse/ZOOKEEPER-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12976923#action_12976923 ] Hadoop QA commented on ZOOKEEPER-961: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12467353/ZOOKEEPER-961.patch against trunk revision 1053497. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/80//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/80//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/80//console This message is automatically generated. Watch recovery after disconnection when connection string contains a prefix --- Key: ZOOKEEPER-961 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-961 Project: ZooKeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: Windows 32 bits Reporter: pmpm47 Assignee: Thomas Koch Priority: Critical Attachments: ZOOKEEPER-961.patch Let's say you're using connection string 127.0.0.1:2182/foo. 1) put a childrenchanged watch on relative / (that is, on absolute path /foo) 2) stop the zk server 3) start the zk server 4) at this point, the client recovers the connection, and should have put back a watch on relative path /, but instead the client puts a watch on the *absolute* path / - if some other client adds or removes a node under /foo, nothing will happen - if some other client adds or removes a node under /, then you will get an error from the zk client library (string operation error) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
