[jira] [Resolved] (ZOOKEEPER-3223) Configure Spotbugs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3223. - Resolution: Fixed Issue resolved by pull request 764 [https://github.com/apache/zookeeper/pull/764] > Configure Spotbugs > -- > > Key: ZOOKEEPER-3223 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3223 > Project: ZooKeeper > Issue Type: Sub-task > Components: build, scripts >Affects Versions: 3.5.4, 3.6.0, 3.4.13 >Reporter: Norbert Kalmar >Assignee: Enrico Olivelli >Priority: Blocker > Labels: pull-request-available > Fix For: 3.6.0, 3.4.14, 3.5.5 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > First, master only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4
anmolnar commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#issuecomment-456109163 Merged. Thanks @eolivelli ! Please close this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2543) Add C API for creating nodes with TTL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2543: Labels: ttl_nodes (was: ) > Add C API for creating nodes with TTL > - > > Key: ZOOKEEPER-2543 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2543 > Project: ZooKeeper > Issue Type: New Feature > Components: c client >Affects Versions: 3.6.0 >Reporter: Michael Han >Priority: Major > Labels: ttl_nodes > Fix For: 3.6.0 > > > ZOOKEEPER-2169 introduces a new feature for creation nodes with TTL, which is > supported by Java client with new Java API. Similar API should be added to C > client as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-1925) Time to Live or auto expiration of zookeeper node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-1925: Labels: ttl_nodes (was: ) > Time to Live or auto expiration of zookeeper node > - > > Key: ZOOKEEPER-1925 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1925 > Project: ZooKeeper > Issue Type: New Feature >Reporter: Omkar Vinit Joshi >Priority: Major > Labels: ttl_nodes > Fix For: 3.6.0 > > > Today whenever a znode is created; it stays there for ever. We all know that > there is a limitation in terms of how many nodes a system can handle. It > would be nice to have a way to specify expiry time for every znode thereby > stale zondes are cleandup automatically after sufficiently large time. any > thoughts? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2609) Add TTL Node APIs to C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2609: Labels: ttl_nodes (was: ) > Add TTL Node APIs to C client > - > > Key: ZOOKEEPER-2609 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2609 > Project: ZooKeeper > Issue Type: Sub-task > Components: c client, java client, jute, server >Reporter: Jordan Zimmerman >Priority: Major > Labels: ttl_nodes > Fix For: 3.6.0 > > > Need to update the C lib to have the TTL node option -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3038) Cleanup some nitpicks in TTL implementation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-3038: Labels: ttl_nodes (was: ) > Cleanup some nitpicks in TTL implementation > --- > > Key: ZOOKEEPER-3038 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3038 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.3 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > Labels: ttl_nodes > Fix For: 3.5.4, 3.6.0 > > > A few nitpicks which needs to be cleaned up: > 1. Rename OldEphemeralType --> EphemeralTypeEmulate353 > 2. Remove unused method: getTTL() > 3. Remove unused import from QuorumPeer > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar commented on a change in pull request #779: ZOOKEEPER-3223: Configure spotbugs - part 2
anmolnar commented on a change in pull request #779: ZOOKEEPER-3223: Configure
spotbugs - part 2
URL: https://github.com/apache/zookeeper/pull/779#discussion_r249511617
##
File path:
zookeeper-recipes/zookeeper-recipes-election/src/main/java/org/apache/zookeeper/recipes/leader/LeaderElectionSupport.java
##
@@ -180,27 +180,36 @@ private void makeOffer() throws KeeperException,
InterruptedException {
state = State.OFFER;
dispatchEvent(EventType.OFFER_START);
-leaderOffer = new LeaderOffer();
-
-leaderOffer.setHostName(hostName);
-leaderOffer.setNodePath(zooKeeper.create(rootNodeName + "/" + "n_",
-hostName.getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE,
+LeaderOffer newLeaderOffer = new LeaderOffer();
+byte[] hostnameBytes;
+synchronized (this) {
+newLeaderOffer.setHostName(hostName);
+hostnameBytes = hostName.getBytes();
+newLeaderOffer.setNodePath(zooKeeper.create(rootNodeName + "/" + "n_",
+hostnameBytes, ZooDefs.Ids.OPEN_ACL_UNSAFE,
CreateMode.EPHEMERAL_SEQUENTIAL));
-
+leaderOffer = newLeaderOffer;
Review comment:
Do you need to synchronize the entire block or the value set would be enough?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-2901:
Labels: ttl_nodes (was: )
> Session ID that is negative causes mis-calculation of Ephemeral Type
>
>
> Key: ZOOKEEPER-2901
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.5.3
> Environment: Running 3.5.3-beta in Docker container
>Reporter: Mark Johnson
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Labels: ttl_nodes
> Fix For: 3.5.4, 3.6.0
>
>
> In the code that determines the EphemeralType it is looking at the owner
> (which is the client ID or connection ID):
> EphemeralType.java:
>public static EphemeralType get(long ephemeralOwner) {
>if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) {
>return CONTAINER;
>}
>if (ephemeralOwner < 0) {
>return TTL;
>}
>return (ephemeralOwner == 0) ? VOID : NORMAL;
>}
> However my connection ID is:
> header.getClientId(): -720548323429908480
> This causes the code to think this is a TTL Ephemeral node instead of a
> NORMAL Ephemeral node.
> This also explains why this is random - if my client ID is non-negative
> then the node gets added correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2169) Enable creation of nodes with TTLs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2169: Labels: ttl_nodes (was: ) > Enable creation of nodes with TTLs > -- > > Key: ZOOKEEPER-2169 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2169 > Project: ZooKeeper > Issue Type: New Feature > Components: c client, java client, jute, server >Affects Versions: 3.6.0 >Reporter: Camille Fournier >Assignee: Jordan Zimmerman >Priority: Major > Labels: ttl_nodes > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2169-2.patch, ZOOKEEPER-2169-3.patch, > ZOOKEEPER-2169-4.patch, ZOOKEEPER-2169-5.patch, ZOOKEEPER-2169-6.patch, > ZOOKEEPER-2169-7.patch, ZOOKEEPER-2169-8.patch, ZOOKEEPER-2169-9.patch, > ZOOKEEPER-2169.patch > > > As a user, I would like to be able to create a node that is NOT tied to a > session but that WILL expire automatically if action is not taken by some > client within a time window. > I propose this to enable clients interacting with ZK via http or other "thin > clients" to create ephemeral-like nodes. > Some ideas for the design, up for discussion: > The node should support all normal ZK node operations including ACLs, > sequential key generation, etc, however, it should not support the ephemeral > flag. The node will be created with a TTL that is updated via a refresh > operation. > The ZK quorum will watch this node similarly to the way that it watches for > session liveness; if the node is not refreshed within the TTL, it will expire. > QUESTIONS: > 1) Should we let the refresh operation set the TTL to a different base value? > 2) If so, should the setting of the TTL to a new base value cause a watch to > fire? > 3) Do we want to allow these nodes to have children or prevent this similar > to ephemeral nodes? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2719) Port ZOOKEEPER-2169 (TTL Nodes) to 3.5 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2719: Labels: ttl_nodes (was: ) > Port ZOOKEEPER-2169 (TTL Nodes) to 3.5 branch > - > > Key: ZOOKEEPER-2719 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2719 > Project: ZooKeeper > Issue Type: New Feature > Components: java client, server >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman >Priority: Major > Labels: ttl_nodes > Fix For: 3.5.3 > > > ZOOKEEPER-2169 is a useful feature that should be deployed sooner than later. > Take the work done in the master branch and port it to the 3.5 branch -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2608) Create CLI option for TTL ephemerals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2608: Labels: ttl_nodes (was: ) > Create CLI option for TTL ephemerals > > > Key: ZOOKEEPER-2608 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2608 > Project: ZooKeeper > Issue Type: Sub-task > Components: c client, java client, jute, server >Reporter: Camille Fournier >Assignee: Jordan Zimmerman >Priority: Major > Labels: ttl_nodes > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-2608-2.patch, ZOOKEEPER-2608-3.patch, > ZOOKEEPER-2608.patch > > > Need to update CreateCommand to have the TTL node option -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2797) Invalid TTL from misbehaving client nukes zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2797: Labels: ttl_nodes (was: ) > Invalid TTL from misbehaving client nukes zookeeper > --- > > Key: ZOOKEEPER-2797 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2797 > Project: ZooKeeper > Issue Type: Bug > Components: security, server >Affects Versions: 3.6.0 >Reporter: Patrick White >Assignee: Patrick White >Priority: Major > Labels: ttl_nodes > Fix For: 3.5.4, 3.6.0 > > > I was adding container and TTL support to kazoo, and managed to screw > something up which set the TTL to a negative value. This invalid TTL blew up > the commit processor, and got written to the log, preventing the zookeepers > from starting back up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-2903) Port ZOOKEEPER-2901 to 3.5.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2903: Labels: pull-request-available ttl_nodes (was: pull-request-available) > Port ZOOKEEPER-2901 to 3.5.4 > > > Key: ZOOKEEPER-2903 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2903 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Affects Versions: 3.5.3 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman >Priority: Blocker > Labels: pull-request-available, ttl_nodes > Fix For: 3.5.4 > > Time Spent: 10m > Remaining Estimate: 0h > > The TTL/Server ID bug is quite serious and should be back-ported to the 3.5.x > branch -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3108) use a new property:myid in the zoo.cfg to substitute for myid file under the dataDir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3108: --- Summary: use a new property:myid in the zoo.cfg to substitute for myid file under the dataDir (was: use a new property server.id in the zoo.cfg to substitute for myid file) > use a new property:myid in the zoo.cfg to substitute for myid file under the > dataDir > > > Key: ZOOKEEPER-3108 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3108 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.0 >Reporter: maoling >Assignee: maoling >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > When use zk in distributional model,we need to touch a myid file in > dataDir.then write a unique number to it.It is inconvenient and not > user-friendly,Look at an example from other distribution system such as > kafka:it just uses broker.id=0 in the server.properties to indentify a unique > server node.This issue is going to abandon the myid file and use a new > property such as server.id=0 in the zoo.cfg. this fix will be applied to > master branch,branch-3.5+, > keep branch-3.4 unchaged. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3113) EphemeralType.get() fails to verify ephemeralOwner when currentElapsedTime() is small enough
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-3113: Labels: pull-request-available ttl_nodes (was: pull-request-available) > EphemeralType.get() fails to verify ephemeralOwner when currentElapsedTime() > is small enough > > > Key: ZOOKEEPER-3113 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3113 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.4, 3.6.0 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Critical > Labels: pull-request-available, ttl_nodes > Fix For: 3.6.0, 3.5.5 > > Time Spent: 4.5h > Remaining Estimate: 0h > > EphemeralTypeTest.testServerIds() unit test fails on some systems that > System.nanoTime() is smaller than a certain value. > The test generates ephemeralOwner in the old way (pre ZOOKEEPER-2901) without > enabling the emulation flag and asserts for exception to be thrown when > serverId == 255. This is right. ZooKeeper should fail on this case, because > serverId cannot be larger than 254 if extended types are enabled. In this > case ephemeralOwner with 0xff in the most significant byte indicates an > extended type. > The logic which does the validation is in EphemeralType.get(). > It checks 2 things: > * the extended type byte is set: 0xff, > * reserved bits (next 2 bytes) corresponds to a valid extended type. > Here is the problem: currently we only have 1 extended type: TTL with value > of 0x in the reserved bits. > Logic expects that if we have anything different from it in the reserved > bits, the ephemeralOwner is invalid and exception should be thrown. That's > what the test asserts for and it works on most systems, because the timestamp > part of the sessionId usually have some bits in the reserved bits as well > which eventually will be larger than 0, so the value is unsupported. > I think the problem is twofold: > * Either if we have more extended types, we'll increase the possibility that > this logic will accept invalid sessionIds (as long as reserved bits indicate > a valid extended type), > * Or (which happens on some systems) if the currentElapsedTime (timestamp > part of sessionId) is small enough and doesn't occupy reserved bits, this > logic will accept the invalid sessionId. > Unfortunately I cannot repro the problem yet: it constantly happens on a > specific Jenkins slave, but even with the same distro and same JDK version I > cannot reproduce the same nanoTime() values. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
ZooKeeper_branch34_openjdk7 - Build # 2187 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2187/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.72 KB...] hudson.plugins.git.GitException: Failed to fetch from git://git.apache.org/zookeeper.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to ubuntu-eu2 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any)
[GitHub] anmolnar commented on a change in pull request #769: ZOOKEEPER-3242: Add server side connecting throttling
anmolnar commented on a change in pull request #769: ZOOKEEPER-3242: Add server
side connecting throttling
URL: https://github.com/apache/zookeeper/pull/769#discussion_r249539145
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/BlueThrottleTest.java
##
@@ -0,0 +1,132 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.server;
+
+import org.apache.zookeeper.ZKTestCase;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BlueThrottleTest extends ZKTestCase {
+private static final Logger LOG =
LoggerFactory.getLogger(BlueThrottleTest.class);
+
+@Test
+public void testThrottleDisabled() {
+BlueThrottle throttler = new BlueThrottle();
+Assert.assertTrue("Throttle should be disabled by default",
throttler.checkLimit(1));
+}
+
+@Test
+public void testThrottleWithoutRefill() {
+BlueThrottle throttler = new BlueThrottle();
+throttler.setMaxTokens(1);
+throttler.setFillTime(2000);
+Assert.assertTrue("First request should be allowed",
throttler.checkLimit(1));
+Assert.assertFalse("Second request should be denied",
throttler.checkLimit(1));
+}
+
+@Test
+public void testThrottleWithRefill() throws InterruptedException {
+BlueThrottle throttler = new BlueThrottle();
+throttler.setMaxTokens(1);
+throttler.setFillTime(500);
+Assert.assertTrue("First request should be allowed",
throttler.checkLimit(1));
+Assert.assertFalse("Second request should be denied",
throttler.checkLimit(1));
+
+//wait for the bucket to be refilled
+Thread.sleep(750);
+Assert.assertTrue("Third request should be allowed since we've got a
new token", throttler.checkLimit(1));
+}
+
+@Test
+public void testThrottleWithoutRandomDropping() throws
InterruptedException {
+int maxTokens = 10;
+BlueThrottle throttler = new BlueThrottle();
+throttler.setMaxTokens(maxTokens);
+throttler.setFillCount(maxTokens);
+throttler.setFillTime(1000);
+
+for (int i=0;i0);
+
+//allow bucket to be refilled
+Thread.sleep(1500);
+
+for (int i=0;i
ZooKeeper_branch34_jdk8 - Build # 1666 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1666/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.46 KB...] [junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.016 sec [junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.862 sec [junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.753 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.018 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.643 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.741 sec [junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.635 sec [junit] Running org.apache.zookeeper.test.SaslClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec [junit] Running org.apache.zookeeper.test.SessionInvalidationTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.75 sec [junit] Running org.apache.zookeeper.test.SessionTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.039 sec [junit] Running org.apache.zookeeper.test.SessionTimeoutTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.939 sec [junit] Running org.apache.zookeeper.test.StandaloneTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.952 sec [junit] Running org.apache.zookeeper.test.StatTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.945 sec [junit] Running org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.032 sec [junit] Running org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.692 sec [junit] Running org.apache.zookeeper.test.TruncateTest [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.568 sec [junit] Running org.apache.zookeeper.test.UpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.956 sec [junit] Running org.apache.zookeeper.test.WatchedEventTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.085 sec [junit] Running org.apache.zookeeper.test.WatcherFuncTest [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.503 sec [junit] Running org.apache.zookeeper.test.WatcherTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.089 sec [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.751 sec [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.75 sec [junit] Running org.apache.jute.BinaryInputArchiveTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec fail.build.on.test.failure: BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1409: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1412: Tests failed! Total time: 39 minutes 53 seconds Build step 'Invoke Ant' marked build as failure Archiving artifacts Recording test results Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics Error Message: Min latency check Expected: a value equal to or greater than <1001L> but: <1000L> was less than <1001L> Stack Trace: junit.framework.AssertionFailedError: Min latency check Expected: a value equal to or greater than <1001L> but: <1000L> was less than <1001L> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics(ServerStatsTest.java:77) at
[GitHub] anmolnar commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot
anmolnar commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot URL: https://github.com/apache/zookeeper/pull/622#issuecomment-456150659 @lvfangmin Looks like you haven't incorporated my suggested refactorings in the testing code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli closed pull request #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4
eolivelli closed pull request #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #779: ZOOKEEPER-3223: Configure spotbugs - part 2
eolivelli commented on a change in pull request #779: ZOOKEEPER-3223: Configure
spotbugs - part 2
URL: https://github.com/apache/zookeeper/pull/779#discussion_r249540449
##
File path:
zookeeper-recipes/zookeeper-recipes-election/src/main/java/org/apache/zookeeper/recipes/leader/LeaderElectionSupport.java
##
@@ -180,27 +180,36 @@ private void makeOffer() throws KeeperException,
InterruptedException {
state = State.OFFER;
dispatchEvent(EventType.OFFER_START);
-leaderOffer = new LeaderOffer();
-
-leaderOffer.setHostName(hostName);
-leaderOffer.setNodePath(zooKeeper.create(rootNodeName + "/" + "n_",
-hostName.getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE,
+LeaderOffer newLeaderOffer = new LeaderOffer();
+byte[] hostnameBytes;
+synchronized (this) {
+newLeaderOffer.setHostName(hostName);
+hostnameBytes = hostName.getBytes();
+newLeaderOffer.setNodePath(zooKeeper.create(rootNodeName + "/" + "n_",
+hostnameBytes, ZooDefs.Ids.OPEN_ACL_UNSAFE,
CreateMode.EPHEMERAL_SEQUENTIAL));
-
+leaderOffer = newLeaderOffer;
Review comment:
@anmolnar we have to synchronize hostname as well
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext
anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-456153520 @arankin-irl Please let me know once you've finished polishing your patch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-974) Configurable listen socket backlog for the client port
[ https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated ZOOKEEPER-974: - Attachment: ZOOKEEPER-974.001.patch > Configurable listen socket backlog for the client port > -- > > Key: ZOOKEEPER-974 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-974 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.3.2 >Reporter: Hoonmin Kim >Priority: Minor > Attachments: ZOOKEEPER-974.001.patch, ZOOKEEPER-974.patch > > > We're running ZooKeeper ensemble(3-node configuration) for production use for > months. > Days ago, we suffered temporary network? problems that caused many > reconnections(about 300) of ephemeral nodes in one ZooKeeper server. > The almost all clients successfully reconnected to the other ZooKeeper > servers, > but one client failed to reconnect in time and got a session expired message > from the server. > (The problem is that our clients died when they got SessionExpired message.) > There were many listenQ overflows/drops and out resets in a minute just > before the problem situation. > --- > So we patched ZooKeeper to increase the backlog size for the client port > socket to avoid unhappy cases like this. > As ZooKeeper uses default backlog size(50) to bind(), we added > "clientPortBacklog" option. > Though the default backlog should be good for common environment, > we believe that configuring the size is also meaningful. > [Note] > On linux, below parameter : > net.core.somaxconn > needs to be larger than above "clientPortBacklog" to correctly configure > listen socket backlog -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Failed: ZOOKEEPER-974 PreCommit Build #3723
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-974 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3723/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.71 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H6 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any)
[jira] [Assigned] (ZOOKEEPER-974) Configurable listen socket backlog for the client port
[ https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser reassigned ZOOKEEPER-974: Assignee: Josh Elser Looks like this one was a little stale, but still relevant. [~gopalv] ran into it over in Hive. I've taken the liberty of rebasing Hoonmin's patch onto branch-3.4. > Configurable listen socket backlog for the client port > -- > > Key: ZOOKEEPER-974 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-974 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.3.2 >Reporter: Hoonmin Kim >Assignee: Josh Elser >Priority: Minor > Attachments: ZOOKEEPER-974.001.patch, ZOOKEEPER-974.patch > > > We're running ZooKeeper ensemble(3-node configuration) for production use for > months. > Days ago, we suffered temporary network? problems that caused many > reconnections(about 300) of ephemeral nodes in one ZooKeeper server. > The almost all clients successfully reconnected to the other ZooKeeper > servers, > but one client failed to reconnect in time and got a session expired message > from the server. > (The problem is that our clients died when they got SessionExpired message.) > There were many listenQ overflows/drops and out resets in a minute just > before the problem situation. > --- > So we patched ZooKeeper to increase the backlog size for the client port > socket to avoid unhappy cases like this. > As ZooKeeper uses default backlog size(50) to bind(), we added > "clientPortBacklog" option. > Though the default backlog should be good for common environment, > we believe that configuring the size is also meaningful. > [Note] > On linux, below parameter : > net.core.somaxconn > needs to be larger than above "clientPortBacklog" to correctly configure > listen socket backlog -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar commented on issue #779: ZOOKEEPER-3223: Configure spotbugs - part 2
anmolnar commented on issue #779: ZOOKEEPER-3223: Configure spotbugs - part 2 URL: https://github.com/apache/zookeeper/pull/779#issuecomment-456278196 Committed to master branch only. Thanks @eolivelli ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #779: ZOOKEEPER-3223: Configure spotbugs - part 2
asfgit closed pull request #779: ZOOKEEPER-3223: Configure spotbugs - part 2 URL: https://github.com/apache/zookeeper/pull/779 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhuan31 commented on a change in pull request #769: ZOOKEEPER-3242: Add server side connecting throttling
jhuan31 commented on a change in pull request #769: ZOOKEEPER-3242: Add server
side connecting throttling
URL: https://github.com/apache/zookeeper/pull/769#discussion_r249649043
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/BlueThrottleTest.java
##
@@ -0,0 +1,132 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.server;
+
+import org.apache.zookeeper.ZKTestCase;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class BlueThrottleTest extends ZKTestCase {
+private static final Logger LOG =
LoggerFactory.getLogger(BlueThrottleTest.class);
+
+@Test
+public void testThrottleDisabled() {
+BlueThrottle throttler = new BlueThrottle();
+Assert.assertTrue("Throttle should be disabled by default",
throttler.checkLimit(1));
+}
+
+@Test
+public void testThrottleWithoutRefill() {
+BlueThrottle throttler = new BlueThrottle();
+throttler.setMaxTokens(1);
+throttler.setFillTime(2000);
+Assert.assertTrue("First request should be allowed",
throttler.checkLimit(1));
+Assert.assertFalse("Second request should be denied",
throttler.checkLimit(1));
+}
+
+@Test
+public void testThrottleWithRefill() throws InterruptedException {
+BlueThrottle throttler = new BlueThrottle();
+throttler.setMaxTokens(1);
+throttler.setFillTime(500);
+Assert.assertTrue("First request should be allowed",
throttler.checkLimit(1));
+Assert.assertFalse("Second request should be denied",
throttler.checkLimit(1));
+
+//wait for the bucket to be refilled
+Thread.sleep(750);
+Assert.assertTrue("Third request should be allowed since we've got a
new token", throttler.checkLimit(1));
+}
+
+@Test
+public void testThrottleWithoutRandomDropping() throws
InterruptedException {
+int maxTokens = 10;
+BlueThrottle throttler = new BlueThrottle();
+throttler.setMaxTokens(maxTokens);
+throttler.setFillCount(maxTokens);
+throttler.setFillTime(1000);
+
+for (int i=0;i0);
+
+//allow bucket to be refilled
+Thread.sleep(1500);
+
+for (int i=0;i
[jira] [Updated] (ZOOKEEPER-974) Configurable listen socket backlog for the client port
[ https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated ZOOKEEPER-974: - Attachment: ZOOKEEPER-974.001.master.patch > Configurable listen socket backlog for the client port > -- > > Key: ZOOKEEPER-974 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-974 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.3.2 >Reporter: Hoonmin Kim >Assignee: Josh Elser >Priority: Minor > Attachments: ZOOKEEPER-974.001.master.patch, ZOOKEEPER-974.001.patch, > ZOOKEEPER-974.patch > > > We're running ZooKeeper ensemble(3-node configuration) for production use for > months. > Days ago, we suffered temporary network? problems that caused many > reconnections(about 300) of ephemeral nodes in one ZooKeeper server. > The almost all clients successfully reconnected to the other ZooKeeper > servers, > but one client failed to reconnect in time and got a session expired message > from the server. > (The problem is that our clients died when they got SessionExpired message.) > There were many listenQ overflows/drops and out resets in a minute just > before the problem situation. > --- > So we patched ZooKeeper to increase the backlog size for the client port > socket to avoid unhappy cases like this. > As ZooKeeper uses default backlog size(50) to bind(), we added > "clientPortBacklog" option. > Though the default backlog should be good for common environment, > we believe that configuring the size is also meaningful. > [Note] > On linux, below parameter : > net.core.somaxconn > needs to be larger than above "clientPortBacklog" to correctly configure > listen socket backlog -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Failed: ZOOKEEPER-974 PreCommit Build #3724
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-974 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3724/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.74 KB...] at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*" returned status code 128: stdout: stderr: fatal: remote error: access denied or repository not exported: /zookeeper.git at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H15 at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741) at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357) at hudson.remoting.Channel.call(Channel.java:955) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146) at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132) at com.sun.proxy.$Proxy115.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186) at hudson.scm.SCM.checkout(SCM.java:504) at hudson.model.AbstractProject.checkout(AbstractProject.java:1208) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1810) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:429) ERROR: Error fetching remote repo 'origin' Archiving artifacts Recording test results ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error? [description-setter] Could not determine description. Email was triggered for: Failure - Any Sending email for trigger: Failure - Any ### ## FAILED TESTS (if any)
[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249659740 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -17,10 +17,28 @@ */ package org.apache.zookeeper.common; +import org.apache.zookeeper.common.X509Exception.KeyManagerException; Review comment: Yep, no problem. Looks like the import order changed in November last year in these classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249659804 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -17,11 +17,30 @@ */ package org.apache.zookeeper.common; +import org.apache.zookeeper.PortAssignment; Review comment: Yep, no problem. Looks like the import order changed in November last year in these classes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r249659841
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
##
@@ -403,6 +407,32 @@ public void
testGetSslHandshakeDetectionTimeoutMillisProperty() {
}
}
+@Test(expected = X509Exception.SSLContextException.class)
+public void testCreateSSLContext_invalidCustomSSLContextClass() throws
Exception {
+ZKConfig zkConfig = new ZKConfig();
+ClientX509Util clientX509Util = new ClientX509Util();
+
zkConfig.setProperty(clientX509Util.getSslContextSupplierClassProperty(),
String.class.getCanonicalName());
+clientX509Util.createSSLContext(zkConfig);
+}
+
+@Test
+public void testCreateSSLContext_validNullCustomSSLContextClass() throws
X509Exception.SSLContextException {
+ZKConfig zkConfig = new ZKConfig();
+ClientX509Util clientX509Util = new ClientX509Util();
+
zkConfig.setProperty(clientX509Util.getSslContextSupplierClassProperty(),
NullSslContextSupplier.class.getName());
+final SSLContext sslContext =
clientX509Util.createSSLContext(zkConfig);
+assertNull(sslContext);
Review comment:
No problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (ZOOKEEPER-974) Configurable listen socket backlog for the client port
[ https://issues.apache.org/jira/browse/ZOOKEEPER-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748377#comment-16748377 ] Josh Elser commented on ZOOKEEPER-974: -- Putting up a patch against master too. I need to re-test both of them to make sure I'm getting reasonable runtime semantics. Your guess is as good as mine as to how this could be effectively tested. > Configurable listen socket backlog for the client port > -- > > Key: ZOOKEEPER-974 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-974 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.3.2 >Reporter: Hoonmin Kim >Assignee: Josh Elser >Priority: Minor > Attachments: ZOOKEEPER-974.001.master.patch, ZOOKEEPER-974.001.patch, > ZOOKEEPER-974.patch > > > We're running ZooKeeper ensemble(3-node configuration) for production use for > months. > Days ago, we suffered temporary network? problems that caused many > reconnections(about 300) of ephemeral nodes in one ZooKeeper server. > The almost all clients successfully reconnected to the other ZooKeeper > servers, > but one client failed to reconnect in time and got a session expired message > from the server. > (The problem is that our clients died when they got SessionExpired message.) > There were many listenQ overflows/drops and out resets in a minute just > before the problem situation. > --- > So we patched ZooKeeper to increase the backlog size for the client port > socket to avoid unhappy cases like this. > As ZooKeeper uses default backlog size(50) to bind(), we added > "clientPortBacklog" option. > Though the default backlog should be good for common environment, > we believe that configuring the size is also meaningful. > [Note] > On linux, below parameter : > net.core.somaxconn > needs to be larger than above "clientPortBacklog" to correctly configure > listen socket backlog -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jhuan31 commented on issue #769: ZOOKEEPER-3242: Add server side connecting throttling
jhuan31 commented on issue #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769#issuecomment-456280633 Ran the unit test 1000 times w/o failure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-3223) Configure Spotbugs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748415#comment-16748415 ] Hudson commented on ZOOKEEPER-3223: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #361 (See [https://builds.apache.org/job/ZooKeeper-trunk/361/]) ZOOKEEPER-3223: Configure spotbugs - part 2 (andor: rev 8b82c2694dc31238b04345a7bd95c6a7fb62c7f8) * (edit) zookeeper-server/pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-election/src/main/java/org/apache/zookeeper/recipes/leader/LeaderElectionSupport.java * (edit) zookeeper-recipes/zookeeper-recipes-election/src/main/java/org/apache/zookeeper/recipes/leader/LeaderOffer.java * (edit) zookeeper-contrib/pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-lock/pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-lock/src/main/java/org/apache/zookeeper/recipes/lock/WriteLock.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) pom.xml * (edit) zookeeper-recipes/pom.xml * (edit) build.xml * (edit) zookeeper-recipes/zookeeper-recipes-queue/src/main/java/org/apache/zookeeper/recipes/queue/DistributedQueue.java > Configure Spotbugs > -- > > Key: ZOOKEEPER-3223 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3223 > Project: ZooKeeper > Issue Type: Sub-task > Components: build, scripts >Affects Versions: 3.5.4, 3.6.0, 3.4.13 >Reporter: Norbert Kalmar >Assignee: Enrico Olivelli >Priority: Blocker > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5, 3.4.14 > > Time Spent: 5h 10m > Remaining Estimate: 0h > > First, master only. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] eolivelli commented on issue #779: ZOOKEEPER-3223: Configure spotbugs - part 2
eolivelli commented on issue #779: ZOOKEEPER-3223: Configure spotbugs - part 2 URL: https://github.com/apache/zookeeper/pull/779#issuecomment-456285710 Great. I will send the same patch for branch 3.5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-456301995 @ivmaykov @anmolnar - PR updated with the requested changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
