[magnolia-dev] [JIRA] Resolved: (MAGNOLIA-3089) DefaultMessagesImpl.keys() throws NPE
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Grilli resolved MAGNOLIA-3089. --- Resolution: Fixed DefaultMessagesImpl.keys() throws NPE - Key: MAGNOLIA-3089 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3089 Project: Magnolia Issue Type: Bug Components: core Affects Versions: 4.3 M1 Reporter: Federico Grilli Assignee: Federico Grilli Fix For: 4.3 Calling the keys(..) method will throw a NPE if the underlying ResourceBundle is not found (e.g. it is null). Just check if the bundle is null and, if so, handle it gracefully by returning an empty iterator. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] Hudson build is still unstable: magnolia_main-trunk » magnolia-templating-ui-c omponents #1375
See http://hudson.magnolia-cms.com/job/magnolia_main-trunk/info.magnolia$magnolia-templating-ui-components/1375/ For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] Hudson build is still unstable: magnolia_main-trunk #1375
See http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1375/changes For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Commented: (MAGNOLIA-3089) DefaultMessagesImpl.keys() throws NPE
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=26592#action_26592 ] Hudson CI server commented on MAGNOLIA-3089: Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/yellow.gif! [magnolia_main-trunk #1375|http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1375/] MAGNOLIA-3089: check for null resource bundle DefaultMessagesImpl.keys() throws NPE - Key: MAGNOLIA-3089 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3089 Project: Magnolia Issue Type: Bug Components: core Affects Versions: 4.3 M1 Reporter: Federico Grilli Assignee: Federico Grilli Fix For: 4.3 Calling the keys(..) method will throw a NPE if the underlying ResourceBundle is not found (e.g. it is null). Just check if the bundle is null and, if so, handle it gracefully by returning an empty iterator. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] Hudson build is back to stable: magnolia_main-trunk » magnolia-templating-ui-c omponents #1376
See http://hudson.magnolia-cms.com/job/magnolia_main-trunk/info.magnolia$magnolia-templating-ui-components/1376/changes For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] Hudson build is back to stable: magnolia_main-trunk #1376
See http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1376/changes For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Resolved: (MGNLSTK- 568) Revert MGNLSTK-533 for 1.3 ?
[ http://jira.magnolia-cms.com/browse/MGNLSTK-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Grilli resolved MGNLSTK-568. - Resolution: Fixed Revert MGNLSTK-533 for 1.3 ? Key: MGNLSTK-568 URL: http://jira.magnolia-cms.com/browse/MGNLSTK-568 Project: Magnolia Standard Templating Kit Issue Type: Sub-task Reporter: Grégory Joseph Assignee: Federico Grilli Fix For: 1.3 Since MAGNOLIA-3037, the changes for MGNLSTK-533 are not necessary anymore. To be discussed/confirmed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Commented: (MAGNOLIA-3037) Handle UnsupportedOperationException for User implementation within the Freemarker model/wrapper
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=26598#action_26598
]
Hudson CI server commented on MAGNOLIA-3037:
Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif!
[standard-templating-kit
#2427|http://hudson.magnolia-cms.com/job/standard-templating-kit/2427/]
MGNLSTK-568: Since MAGNOLIA-3037, these changes are not necessary anymore.
Handle UnsupportedOperationException for User implementation within the
Freemarker model/wrapper
Key: MAGNOLIA-3037
URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3037
Project: Magnolia
Issue Type: Improvement
Components: core
Reporter: Grégory Joseph
Assignee: Grégory Joseph
Fix For: 4.3 M1
When Freemarker templates attempt to output properties out of
{{info.magnolia.cms.security.User}} instances which throw
{{UnsupportedOperationException}}s (typically
{{info.magnolia.cms.security.ExternalUser}}), this results in ugly exceptions
thrown all over the place. Since templates should anyway be aware of this and
provide fallback behaviour, our Freemarker wrapper for User could handle
those exceptions, giving templates the chance to handle absent properties.
They should be able to do {{user.myProperty!'default value'}}, for example.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Assigned: (MAGNOLIA-2810) Dialog node type: change log message to debug level -- or fix all our bootstrap files !
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zdenek Skodik reassigned MAGNOLIA-2810:
---
Assignee: Zdenek Skodik (was: Philipp Bärfuss)
Dialog node type: change log message to debug level -- or fix all our
bootstrap files !
---
Key: MAGNOLIA-2810
URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2810
Project: Magnolia
Issue Type: Improvement
Components: admininterface
Affects Versions: 4.1, 4.0.2
Reporter: Grégory Joseph
Assignee: Zdenek Skodik
Fix For: 4.3
When updating or even installing a clean instance, there are tons of
unnecessary log messages such as:
{noformat}
WARN: Dialog definitions should be of type contentNode but
[/modules/abc/dialogs/paragraphs/xyz] is of type content.
{noformat}
We should either make these debug messages, or fix our own content !
(and consider writing an update task)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Work started: (MAGNOLIA-2810) Dialog node type: change log message to debug level -- or fix all our bootstrap files !
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on MAGNOLIA-2810 started by Zdenek Skodik.
Dialog node type: change log message to debug level -- or fix all our
bootstrap files !
---
Key: MAGNOLIA-2810
URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2810
Project: Magnolia
Issue Type: Improvement
Components: admininterface
Affects Versions: 4.1, 4.0.2
Reporter: Grégory Joseph
Assignee: Zdenek Skodik
Fix For: 4.3
When updating or even installing a clean instance, there are tons of
unnecessary log messages such as:
{noformat}
WARN: Dialog definitions should be of type contentNode but
[/modules/abc/dialogs/paragraphs/xyz] is of type content.
{noformat}
We should either make these debug messages, or fix our own content !
(and consider writing an update task)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Commented: (MGNLSTK -568) Revert MGNLSTK-533 for 1.3 ?
[ http://jira.magnolia-cms.com/browse/MGNLSTK-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=26597#action_26597 ] Hudson CI server commented on MGNLSTK-568: -- Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif! [standard-templating-kit #2427|http://hudson.magnolia-cms.com/job/standard-templating-kit/2427/] MGNLSTK-568: Since MAGNOLIA-3037, these changes are not necessary anymore. Revert MGNLSTK-533 for 1.3 ? Key: MGNLSTK-568 URL: http://jira.magnolia-cms.com/browse/MGNLSTK-568 Project: Magnolia Standard Templating Kit Issue Type: Sub-task Reporter: Grégory Joseph Assignee: Federico Grilli Fix For: 1.3 Since MAGNOLIA-3037, the changes for MGNLSTK-533 are not necessary anymore. To be discussed/confirmed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Commented: (MGNLSTK -568) Revert MGNLSTK-533 for 1.3 ?
[ http://jira.magnolia-cms.com/browse/MGNLSTK-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=26599#action_26599 ] Hudson CI server commented on MGNLSTK-568: -- Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif! [standard-templating-kit #2428|http://hudson.magnolia-cms.com/job/standard-templating-kit/2428/] MGNLSTK-568: restored last update task Revert MGNLSTK-533 for 1.3 ? Key: MGNLSTK-568 URL: http://jira.magnolia-cms.com/browse/MGNLSTK-568 Project: Magnolia Standard Templating Kit Issue Type: Sub-task Reporter: Grégory Joseph Assignee: Federico Grilli Fix For: 1.3 Since MAGNOLIA-3037, the changes for MGNLSTK-533 are not necessary anymore. To be discussed/confirmed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2810) Dialog node type: change log message to debug level -- or fix all our bootstrap files !
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zdenek Skodik updated MAGNOLIA-2810:
Attachment: list of affected dialog definitions
list is attached ~ 42 items/14 modules
Dialog node type: change log message to debug level -- or fix all our
bootstrap files !
---
Key: MAGNOLIA-2810
URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2810
Project: Magnolia
Issue Type: Improvement
Components: admininterface
Affects Versions: 4.1, 4.0.2
Reporter: Grégory Joseph
Assignee: Zdenek Skodik
Fix For: 4.3
Attachments: list of affected dialog definitions
When updating or even installing a clean instance, there are tons of
unnecessary log messages such as:
{noformat}
WARN: Dialog definitions should be of type contentNode but
[/modules/abc/dialogs/paragraphs/xyz] is of type content.
{noformat}
We should either make these debug messages, or fix our own content !
(and consider writing an update task)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Reopened: (MGNLSTK- 568) Revert MGNLSTK-533 for 1.3 ?
[ http://jira.magnolia-cms.com/browse/MGNLSTK-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grégory Joseph reopened MGNLSTK-568: What happens for users having upgrade to 1.2.2 then to 1.3 ? Revert MGNLSTK-533 for 1.3 ? Key: MGNLSTK-568 URL: http://jira.magnolia-cms.com/browse/MGNLSTK-568 Project: Magnolia Standard Templating Kit Issue Type: Sub-task Reporter: Grégory Joseph Assignee: Federico Grilli Fix For: 1.3 Since MAGNOLIA-3037, the changes for MGNLSTK-533 are not necessary anymore. To be discussed/confirmed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Resolved: (MGNLGA-4) Remove redundant basic install tasks from extra install tasks in version handler
[ http://jira.magnolia-cms.com/browse/MGNLGA-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Ringele resolved MGNLGA-4. Fix Version/s: RC-6 Resolution: Fixed Done Remove redundant basic install tasks from extra install tasks in version handler Key: MGNLGA-4 URL: http://jira.magnolia-cms.com/browse/MGNLGA-4 Project: Magnolia Google Analytics Issue Type: Bug Reporter: Nils Breunese Assignee: Christian Ringele Priority: Minor Fix For: RC-6 The getExtraInstallTasks() method has the following call: installTasks.addAll(super.getBasicInstallTasks(ctx)); This is redundant and should be removed. Please see the thread at http://www.nabble.com/Version-handler-install-tasks-td26011961.html for Jan Haderka's comment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Resolved: (MGNLGA-3) Rename GoggleAnalyticsJSResourceModel.java to GoogleAnalyticsJSResourceModel.java
[ http://jira.magnolia-cms.com/browse/MGNLGA-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Ringele resolved MGNLGA-3. Fix Version/s: RC-6 Resolution: Fixed Done Rename GoggleAnalyticsJSResourceModel.java to GoogleAnalyticsJSResourceModel.java - Key: MGNLGA-3 URL: http://jira.magnolia-cms.com/browse/MGNLGA-3 Project: Magnolia Google Analytics Issue Type: Bug Reporter: Nils Breunese Assignee: Christian Ringele Priority: Trivial Fix For: RC-6 Original Estimate: 0.01d Remaining Estimate: 0.01d Please refactor src/main/java/info/magnolia/module/googleanalytics/model/GoggleAnalyticsJSResourceModel.java to src/main/java/info/magnolia/module/googleanalytics/model/GoogleAnalyticsJSResourceModel.java. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3000) Update copyright headers : 2010 !
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grégory Joseph updated MAGNOLIA-3000: - Priority: Blocker (was: Major) Update copyright headers : 2010 ! - Key: MAGNOLIA-3000 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3000 Project: Magnolia Issue Type: Task Components: build Reporter: Grégory Joseph Assignee: Grégory Joseph Priority: Blocker Fix For: 4.0.4, 4.2.x, 4.3 todo on branches, all modules (ce, ee, ...) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3087) Allow configuration of shared variables for FreeMarker
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grégory Joseph updated MAGNOLIA-3087: - Summary: Allow configuration of shared variables for FreeMarker (was: Allow configurable of shared variables for FreeMarker) Allow configuration of shared variables for FreeMarker -- Key: MAGNOLIA-3087 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3087 Project: Magnolia Issue Type: Sub-task Components: freemarker Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3 M2 Shared variables in Freemarker are a recommended way to have objects available to templates which do not change over the life time of the Freemarker configuration object. In the case of Magnolia, the configuration object is bound to Freemarker - which currently is a permanent singleton; it could eventually become an observed one. In any case, adding shared variables is possible. The advantage of shared variables vs regular variables added to the context for each render are: * these variables are wrapped once and only once over the lifetime of the application * they are also (obviously) added to a map only once, thus slightly reducing the complexity/time needed to build the context before rendering. There are probably a few context variable which we could also move to shared variables. ref: http://freemarker.org/docs/pgui_config_sharedvariables.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Created: (MGNLSTK-586) When using AutogeneratedParagraph main are is not optional but extras area is.
When using AutogeneratedParagraph main are is not optional but extras area is.
--
Key: MGNLSTK-586
URL: http://jira.magnolia-cms.com/browse/MGNLSTK-586
Project: Magnolia Standard Templating Kit
Issue Type: Improvement
Affects Versions: 1.3 M1
Reporter: Teresa Miyar
Assignee: Philipp Bärfuss
Priority: Minor
Fix For: 1.3
Patch
{code}
Index:
magnolia-module-standard-templating-kit/src/main/java/info/magnolia/module/templatingkit/templates/SingletonParagraphTemplateModel.java
===
---
magnolia-module-standard-templating-kit/src/main/java/info/magnolia/module/templatingkit/templates/SingletonParagraphTemplateModel.java
(revision 31608)
+++
magnolia-module-standard-templating-kit/src/main/java/info/magnolia/module/templatingkit/templates/SingletonParagraphTemplateModel.java
(working copy)
@@ -118,20 +118,22 @@
}
private void createMainArea(STKTemplate templateDef) {
-SingletonParagraphMainArea singletonDef =
(SingletonParagraphMainArea)templateDef.getMainArea();
-try {
-Content mainCollection = ContentUtil.getOrCreateContent(content,
main, ItemType.CONTENTNODE, true);
-if (!mainCollection.hasContent(SINGLETON_NODE_NAME)) {
-Content singletonNode =
mainCollection.createContent(SINGLETON_NODE_NAME, ItemType.CONTENTNODE);
-
singletonNode.getMetaData().setTemplate(singletonDef.getAutoGeneratedParagraph().getName());
+if( templateDef.getMainArea() != null templateDef.getMainArea()
instanceof SingletonParagraphMainArea) {
+ SingletonParagraphMainArea singletonDef =
(SingletonParagraphMainArea)templateDef.getMainArea();
+ try {
+ Content mainCollection = ContentUtil.getOrCreateContent(content,
main, ItemType.CONTENTNODE, true);
+ if (!mainCollection.hasContent(SINGLETON_NODE_NAME)) {
+ Content singletonNode =
mainCollection.createContent(SINGLETON_NODE_NAME, ItemType.CONTENTNODE);
+
singletonNode.getMetaData().setTemplate(singletonDef.getAutoGeneratedParagraph().getName());
-setDefaultValues(singletonNode,
singletonDef.getAutoGeneratedParagraph().getDefaultValues());
+ setDefaultValues(singletonNode,
singletonDef.getAutoGeneratedParagraph().getDefaultValues());
-mainCollection.save();
-}
-} catch (Exception e) {
-throw new IllegalStateException(Can't create singleton
paragraph, e);
-}
+ mainCollection.save();
+ }
+ } catch (Exception e) {
+ throw new IllegalStateException(Can't create singleton
paragraph, e);
+ }
+}//end if generate main area
}
protected void setDefaultValues(Content singletonNode, Map defaultValues)
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Commented: (MAGNOLI A-3082) DefaultClassFactory.newInstance(Class T, Class?[], Object...) sho uld not use invokeExactConstructor but invokeConstruct or
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=26608#action_26608
]
Grégory Joseph commented on MAGNOLIA-3082:
--
Now that I read the tests again, I'm not sure about this anymore. I see why we
need it - but it's the second part of
{{testCanInstantiateWithBestMatchingConstructorWhenTheSignatureIsMorePrecise()}}
I don't feel comfortable with. IMO, we should be able to do
{code}
classFactory.newInstance(FooBar.class, arr(Baz.class),
someInstanceOfABazSubclass)
{code} - ie we know the constructor takes exactly 1 Baz instance, and we pass
it whatever we have. If you can't do that, you either
* create an array with the types *of your arguments* with defaults to handle
nulls
* use the newInstance(class, args) variation of the method, and can't have null
parameters.
In any case, we should also have a couple of tests using generics to validate
the cases in question.
DefaultClassFactory.newInstance(ClassT, Class?[], Object...) should not
use invokeExactConstructor but invokeConstructor
Key: MAGNOLIA-3082
URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3082
Project: Magnolia
Issue Type: Improvement
Affects Versions: 4.3 M1
Reporter: Philipp Bärfuss
Assignee: Philipp Bärfuss
Fix For: 4.3
The method DefaultClassFactory.newInstance(ClassT, Object...) calls
ConstructorUtils.invokeConstructor(Class, Object[]) while this is not the
case for DefaultClassFactory.newInstance(ClassT, Class?[], Object...).
This is especially a problem if you have more precise constructors in
subclasses (especially if you use generics).
Example: after introducing generics for models (MAGNOLIA-3081) the method
AbstractRenderable.newModel(...) fails to find the correct constructor.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Commented: (MAGNOLIA-2927) Introduce generics in various classes
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=26609#action_26609
]
Hudson CI server commented on MAGNOLIA-2927:
Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif!
[magnolia_main-trunk
#1377|http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1377/]
MAGNOLIA-2927 some more generics in MultipartForm
Introduce generics in various classes
-
Key: MAGNOLIA-2927
URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2927
Project: Magnolia
Issue Type: Improvement
Components: core
Affects Versions: 4.1.1
Reporter: Jan Haderka
Assignee: Jan Haderka
Fix For: 4.3
Attachments: core-generics.patch
such as for example
* {{QueryUtil}} or
* {{FactoryUtil}}
See comments for change log / status !
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Created: (MAGNOLIA-3090) SSL and TLS can only be configured in mail smtp config, for consistency with all other parameters should be configurable at template level as well
SSL and TLS can only be configured in mail smtp config, for consistency with all other parameters should be configurable at template level as well --- Key: MAGNOLIA-3090 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3090 Project: Magnolia Issue Type: Bug Components: mail Reporter: Teresa Miyar Assignee: Boris Kraft -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Resolved: (MAGNOLIA-3090) SSL and TLS can only be configured in mail smtp config, for consistency with all other parameters should be configurable at template level as well
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Teresa Miyar resolved MAGNOLIA-3090. Fix Version/s: 4.3 M2 Resolution: Fixed SSL and TLS can only be configured in mail smtp config, for consistency with all other parameters should be configurable at template level as well --- Key: MAGNOLIA-3090 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3090 Project: Magnolia Issue Type: Bug Components: mail Reporter: Teresa Miyar Assignee: Teresa Miyar Fix For: 4.3 M2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] Hudson build is back to normal: magnolia-module-groovy #211
See http://hudson.magnolia-cms.com/job/magnolia-module-groovy/211/changes For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] Hudson build is back to normal: magnolia_main-trunk #1382
See http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1382/ For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
