[magnolia-dev] [JIRA] Commented: (MGNLSTK-623) Review all places where links are generated in STK
[ http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=28572#action_28572 ] Hudson CI server commented on MGNLSTK-623: -- Integrated in !http://hudson.magnolia-cms.com/images/16x16/blue.gif! [standard-templating-kit #2632|http://hudson.magnolia-cms.com/job/standard-templating-kit/2632/] MGNLSTK-623 Use MagnoliaTemplatingUtilities to create links. Review all places where links are generated in STK -- Key: MGNLSTK-623 URL: http://jira.magnolia-cms.com/browse/MGNLSTK-623 Project: Magnolia Standard Templating Kit Issue Type: Task Components: base system, paragraphs Affects Versions: 1.3 Reporter: Jan Haderka Assignee: Philipp Bärfuss Fix For: 1.3.x Quite few models in STK generate links to content directly instead of using {{LinkUtil}}/{{LinkManager}}. This is then cause of issues when URLs are altered by system (e.g. when using multisite support). All the links in models should be generated only using appropriate {{LinkUtil}} methods. This is specially true for overview paragraphs such as {{NewsOverview}} and {{EventsOverview}}, but also for pagination ( {{pager.ftl}} macro and related {{pager}} objects). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Issue Comment Edited: (MGNLSTK-623) Review all places where links are generated in STK
[ http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=28562#action_28562 ] Jan Haderka edited comment on MGNLSTK-623 at 6/4/10 8:57 AM: - Reviewed all templates and associated models. Reviewed items listed below. {panel} stk.getAssetLink() = mgnl.createLink() || imaging.createLink() stk.getImageLink() = mgnl.createLink() || imaging.createLink() stk.getAssetVariation.link = variation.createLink() imaging.createLink = mgnl.createLink() || variation.createLink() {color:red}variation.createLink = VariationImpl, ImageOperationProvidingVariation .createLink() is not site aware!{color} {color:red}mgnl.createLink = LinkUtil.createAbsoluteLink(){color} flash.model.link = stk.getAssetLink calendar.item.link = model.eventLink || model.dateEventLink {color:blue}calendar.model.getEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} {color:blue}calendar.model.getDateEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} eventOverview.model.prevLink = eventOverview.model.link.href eventOverview.model.nextLink = eventOverview.model.link.href {color:red}eventOverview.model.link.href = mgnl.createLink() !! expects links to end with .html!!{color} searchResult.item.link = mgnl.createLink() searchResult.model.searchPageLink = STKTemplateModel.getSearchPageLink() STKTemplateModel.getSearchPageLink() = mgnl.createLink() image.link=STK.getAsset().getLink() downloadLink.model.link = mgnl.createLink() externalLink.model.link = STKUtil.getExternalLink() internalLink.model.link = mgnl.createLink() pagination.pager.getPageLink() = parses current page link AbstractItemListModel.pager = mgnl.createLink {color:red}CategoryOverviewModel.pager = manually combine link from context path and currentURI{color} stageXL.model.teaserLink = AbstractTeaserModel.teaserLink AbstractTeaserModel.teaserLink = mgnl.createLink() stageXL.model.image.link = ImageModel.image = stk.getImageLink() carouselItem.teaserLink = AbstractTeaserModel.teaserLink downloadFile.model.teaserLink = AbstractTeaserModel.teaserLink eventList.model.allEventsLink = mgnl.createLink() externalPage.model.teaserLink = stk.externalLink() fingerTabbedItem.model.teaserLink = AbstractTeaserModel.teaserLink internalPage.model.teaserLink = AbstractTeaserModel.teaserLink newsList.model.allNewsLink = mgnl.createLink() stkTeaserSingleFeed.item.link = link from the feed {color:blue}syndicate.model.link=manually assemble virtual URI, which is OK since the Virtual URI will be the same no matter which site and domain is used.{color} infoblock.model.externalLink = mgnl.createLink() branding.model.logoImageLink = stk.assetLink branding.model.printLogoImageLink = stk.assetLink branding.model.searchPageLink = mgnl.createLink() branding.model.homeLink = mgnl.createLink() htmlHeader.cssFile.link = Resource.getLink() htmlHeader.jsFile.link = Resource.getLink() {color:red}Resource.getLink() = manually combine context path with stk-resources prefix with site name and link{color} mainAreaIntro.model.getCategoryLink = CategorizationSupport.categoryLink CategorizationSupport.categoryLink = CategoryUtil.categoryLink {color:red}CategoryUtil.categoryLink = manualy combine context path and handle to category with name{color} mainAreaIntro.imageModel.image.link = imaging.createLink() @cms.links = manually assembles path from context and path to the script {panel} Items in read are either questionable or wrong. In general most of the links (those in black) end up using {{MagnoliaTemplatingUtils.createLink}} method that will create absolute link which might not be correct in the multisite setup. However those can be replaced by changing the output of {{LinkTransformerManager.getAbsolute()}} and therefore can be customized to suit the special setups. was (Author: had): Reviewed all templates and associated models. Reviewed items listed below. {panel} stk.getAssetLink() = mgnl.createLink() || imaging.createLink() stk.getImageLink() = mgnl.createLink() || imaging.createLink() stk.getAssetVariation.link = variation.createLink() imaging.createLink = mgnl.createLink() || variation.createLink() {color:red}variation.createLink = VariationImpl, ImageOperationProvidingVariation .createLink() is not site aware!{color} {color:red}mgnl.createLink = LinkUtil.createAbsoluteLink(){color} flash.model.link = stk.getAssetLink calendar.item.link = model.eventLink || model.dateEventLink {color:red}calendar.model.getEventLink = LinkUtil.createAbsoluteLink(){color} {color:red}calendar.model.getDateEventLink = LinkUtil.createAbsoluteLink(){color} eventOverview.model.prevLink = eventOverview.model.link.href eventOverview.model.nextLink = eventOverview.model.link.href {color:red}eventOverview.model.link.href = mgnl.createLink() !! expects links to end with .html!!{color} searchResult.item.link = mgnl.createLink()
[magnolia-dev] [JIRA] Issue Comment Edited: (MGNLSTK-623) Review all places where links are generated in STK
[ http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=28562#action_28562 ] Jan Haderka edited comment on MGNLSTK-623 at 6/4/10 9:24 AM: - Reviewed all templates and associated models. Reviewed items listed below. {panel} stk.getAssetLink() = mgnl.createLink() || imaging.createLink() stk.getImageLink() = mgnl.createLink() || imaging.createLink() stk.getAssetVariation.link = variation.createLink() imaging.createLink = mgnl.createLink() || variation.createLink() {color:blue}variation.createLink = VariationImpl, ImageOperationProvidingVariation .createLink(){color} {color:blue}mgnl.createLink = LinkUtil.createLink(){color} flash.model.link = stk.getAssetLink calendar.item.link = model.eventLink || model.dateEventLink {color:blue}calendar.model.getEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} {color:blue}calendar.model.getDateEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} eventOverview.model.prevLink = eventOverview.model.link.href eventOverview.model.nextLink = eventOverview.model.link.href {color:red}eventOverview.model.link.href = mgnl.createLink() !! expects links to end with .html!!{color} searchResult.item.link = mgnl.createLink() searchResult.model.searchPageLink = STKTemplateModel.getSearchPageLink() STKTemplateModel.getSearchPageLink() = mgnl.createLink() image.link=STK.getAsset().getLink() downloadLink.model.link = mgnl.createLink() externalLink.model.link = STKUtil.getExternalLink() internalLink.model.link = mgnl.createLink() pagination.pager.getPageLink() = parses current page link AbstractItemListModel.pager = mgnl.createLink {color:red}CategoryOverviewModel.pager = manually combine link from context path and currentURI{color} stageXL.model.teaserLink = AbstractTeaserModel.teaserLink AbstractTeaserModel.teaserLink = mgnl.createLink() stageXL.model.image.link = ImageModel.image = stk.getImageLink() carouselItem.teaserLink = AbstractTeaserModel.teaserLink downloadFile.model.teaserLink = AbstractTeaserModel.teaserLink eventList.model.allEventsLink = mgnl.createLink() externalPage.model.teaserLink = stk.externalLink() fingerTabbedItem.model.teaserLink = AbstractTeaserModel.teaserLink internalPage.model.teaserLink = AbstractTeaserModel.teaserLink newsList.model.allNewsLink = mgnl.createLink() stkTeaserSingleFeed.item.link = link from the feed {color:blue}syndicate.model.link=manually assemble virtual URI, which is OK since the Virtual URI will be the same no matter which site and domain is used.{color} infoblock.model.externalLink = mgnl.createLink() branding.model.logoImageLink = stk.assetLink branding.model.printLogoImageLink = stk.assetLink branding.model.searchPageLink = mgnl.createLink() branding.model.homeLink = mgnl.createLink() htmlHeader.cssFile.link = Resource.getLink() htmlHeader.jsFile.link = Resource.getLink() {color:red}Resource.getLink() = manually combine context path with stk-resources prefix with site name and link{color} mainAreaIntro.model.getCategoryLink = CategorizationSupport.categoryLink CategorizationSupport.categoryLink = CategoryUtil.categoryLink {color:red}CategoryUtil.categoryLink = manualy combine context path and handle to category with name{color} mainAreaIntro.imageModel.image.link = imaging.createLink() @cms.links = manually assembles path from context and path to the script {panel} Items in read are either questionable or wrong. In general most of the links (those in black) end up using {{MagnoliaTemplatingUtils.createLink}} method that will create absolute link which might not be correct in the multisite setup. However those can be replaced by changing the output of {{LinkTransformerManager.getAbsolute()}} and therefore can be customized to suit the special setups. was (Author: had): Reviewed all templates and associated models. Reviewed items listed below. {panel} stk.getAssetLink() = mgnl.createLink() || imaging.createLink() stk.getImageLink() = mgnl.createLink() || imaging.createLink() stk.getAssetVariation.link = variation.createLink() imaging.createLink = mgnl.createLink() || variation.createLink() {color:red}variation.createLink = VariationImpl, ImageOperationProvidingVariation .createLink() is not site aware!{color} {color:red}mgnl.createLink = LinkUtil.createAbsoluteLink(){color} flash.model.link = stk.getAssetLink calendar.item.link = model.eventLink || model.dateEventLink {color:blue}calendar.model.getEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} {color:blue}calendar.model.getDateEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} eventOverview.model.prevLink = eventOverview.model.link.href eventOverview.model.nextLink = eventOverview.model.link.href {color:red}eventOverview.model.link.href = mgnl.createLink() !! expects links to end with .html!!{color} searchResult.item.link =
[magnolia-dev] [JIRA] Issue Comment Edited: (MGNLSTK-623) Review all places where links are generated in STK
[ http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=28562#action_28562 ] Jan Haderka edited comment on MGNLSTK-623 at 6/4/10 9:26 AM: - Reviewed all templates and associated models. Reviewed items listed below. {panel} stk.getAssetLink() = mgnl.createLink() || imaging.createLink() stk.getImageLink() = mgnl.createLink() || imaging.createLink() stk.getAssetVariation.link = variation.createLink() imaging.createLink = mgnl.createLink() || variation.createLink() {color:blue}variation.createLink = VariationImpl, ImageOperationProvidingVariation .createLink(){color} {color:blue}mgnl.createLink = LinkUtil.createLink(){color} flash.model.link = stk.getAssetLink calendar.item.link = model.eventLink || model.dateEventLink {color:blue}calendar.model.getEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} {color:blue}calendar.model.getDateEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} eventOverview.model.prevLink = eventOverview.model.link.href eventOverview.model.nextLink = eventOverview.model.link.href {color:red}eventOverview.model.link.href = mgnl.createLink() !! expects links to end with .html!!{color} searchResult.item.link = mgnl.createLink() searchResult.model.searchPageLink = STKTemplateModel.getSearchPageLink() STKTemplateModel.getSearchPageLink() = mgnl.createLink() image.link=STK.getAsset().getLink() downloadLink.model.link = mgnl.createLink() externalLink.model.link = STKUtil.getExternalLink() internalLink.model.link = mgnl.createLink() pagination.pager.getPageLink() = parses current page link AbstractItemListModel.pager = mgnl.createLink {color:red}CategoryOverviewModel.pager = manually combine link from context path and currentURI{color} stageXL.model.teaserLink = AbstractTeaserModel.teaserLink AbstractTeaserModel.teaserLink = mgnl.createLink() stageXL.model.image.link = ImageModel.image = stk.getImageLink() carouselItem.teaserLink = AbstractTeaserModel.teaserLink downloadFile.model.teaserLink = AbstractTeaserModel.teaserLink eventList.model.allEventsLink = mgnl.createLink() externalPage.model.teaserLink = stk.externalLink() fingerTabbedItem.model.teaserLink = AbstractTeaserModel.teaserLink internalPage.model.teaserLink = AbstractTeaserModel.teaserLink newsList.model.allNewsLink = mgnl.createLink() stkTeaserSingleFeed.item.link = link from the feed {color:blue}syndicate.model.link=manually assemble virtual URI, which is OK since the Virtual URI will be the same no matter which site and domain is used.{color} infoblock.model.externalLink = mgnl.createLink() branding.model.logoImageLink = stk.assetLink branding.model.printLogoImageLink = stk.assetLink branding.model.searchPageLink = mgnl.createLink() branding.model.homeLink = mgnl.createLink() htmlHeader.cssFile.link = Resource.getLink() htmlHeader.jsFile.link = Resource.getLink() {color:red}Resource.getLink() = manually combine context path with stk-resources prefix with site name and link{color} mainAreaIntro.model.getCategoryLink = CategorizationSupport.categoryLink CategorizationSupport.categoryLink = CategoryUtil.categoryLink {color:red}CategoryUtil.categoryLink = manualy combine context path and handle to category with name{color} mainAreaIntro.imageModel.image.link = imaging.createLink() @cms.links = manually assembles path from context and path to the script {panel} Items in read are either questionable or wrong. was (Author: had): Reviewed all templates and associated models. Reviewed items listed below. {panel} stk.getAssetLink() = mgnl.createLink() || imaging.createLink() stk.getImageLink() = mgnl.createLink() || imaging.createLink() stk.getAssetVariation.link = variation.createLink() imaging.createLink = mgnl.createLink() || variation.createLink() {color:blue}variation.createLink = VariationImpl, ImageOperationProvidingVariation .createLink(){color} {color:blue}mgnl.createLink = LinkUtil.createLink(){color} flash.model.link = stk.getAssetLink calendar.item.link = model.eventLink || model.dateEventLink {color:blue}calendar.model.getEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} {color:blue}calendar.model.getDateEventLink = -LinkUtil.createAbsoluteLink()- mgnl.createLink(){color} eventOverview.model.prevLink = eventOverview.model.link.href eventOverview.model.nextLink = eventOverview.model.link.href {color:red}eventOverview.model.link.href = mgnl.createLink() !! expects links to end with .html!!{color} searchResult.item.link = mgnl.createLink() searchResult.model.searchPageLink = STKTemplateModel.getSearchPageLink() STKTemplateModel.getSearchPageLink() = mgnl.createLink() image.link=STK.getAsset().getLink() downloadLink.model.link = mgnl.createLink() externalLink.model.link = STKUtil.getExternalLink() internalLink.model.link = mgnl.createLink() pagination.pager.getPageLink() = parses
[magnolia-dev] [JIRA] Updated: (MAGNOLIA- 3032) content API cleanup: extract common abstract class for HierarchyManager ?
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3032: -- Fix Version/s: 4.3.x (was: 4.3.2) content API cleanup: extract common abstract class for HierarchyManager ? - Key: MAGNOLIA-3032 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3032 Project: Magnolia Issue Type: Sub-task Components: core, testing Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x One example: the save() method on MockHM would need to be reimplemented; it currently makes tests crash. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3059) Unable to replace implementation of the dynamically loaded class with its super class
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3059: -- Fix Version/s: 4.3.x (was: 4.3.2) Unable to replace implementation of the dynamically loaded class with its super class - Key: MAGNOLIA-3059 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3059 Project: Magnolia Issue Type: Bug Components: core Affects Versions: 4.3 Reporter: Jan Haderka Assignee: Philipp Bärfuss Priority: Critical Fix For: 4.3.x Since the changes made to {{FactoryUtil}} and mechanism of class instantiation it is no longer possible to replace class implementation with its superclass at runtime. To reproduce the issue: # extend some existing class, e.g. {{URI2RepositoryManager}} # configure Magnolia to use extending class (in this case set {{/server/URI2RepositoryMapping/class}} to {{full.name.of.ExtendedURI2RepositoryManager}}) # check that everything works fine with the extending class (e.g. try to display some page from website) # restart Magnolia to make to have it started with extending class # repeat step 3) (to see that everything still works) # change {{URI2RepositoryManager}} configuration back to use the original {{URI2RepositoryManager}} implementation # try to repeat step 3) == page loading fails with {{ClassCastException}} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3172) Change node type definition from XML to CND
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3172: -- Fix Version/s: 4.3.x (was: 4.3.2) Change node type definition from XML to CND --- Key: MAGNOLIA-3172 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3172 Project: Magnolia Issue Type: Improvement Components: core Affects Versions: 4.3.1 Reporter: Jan Haderka Assignee: Philipp Bärfuss Fix For: 4.3.x just to summarize discussion from #modeshape: - structure of {{magnolia-nodetypes.xml}} is JR specific and not JCR compliant. There are few things that need to be fixed such as according to JCR multivalue properties such supertypes should be encoded in single value or can be ignored by repo (which is what MS does). (see JCR 1.0.1 6.4.2.5/Export) - CND notation is supported by both JR and MS and doesn't suffer from such issue - Our node type structure also exposed some bugs in MS, so their dev team converted our definition in CND (http://jackrabbit.apache.org/node-type-notation.html) notation supported by both JR and MS and included it in their test cases http://anonsvn.jboss.org/repos/modeshape/trunk/modeshape-jcr/src/test/resources/magnolia.cnd ... since the CND is more readable then xml I would be in favor to abandon the xml and use CND from now on. Reference to the spec for CND: http://www.day.com/specs/jcr/2.0/3_Repository_Model.html (section 3.7.9) http://www.day.com/specs/jcr/2.0/25_Appendix.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3057) DefaultHierarchyManager produces excessive amount of error messages
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3057: -- Fix Version/s: 4.3.x (was: 4.3.2) DefaultHierarchyManager produces excessive amount of error messages --- Key: MAGNOLIA-3057 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3057 Project: Magnolia Issue Type: Bug Components: core Affects Versions: 4.3 Reporter: Jan Haderka Assignee: Philipp Bärfuss Fix For: 4.3.x The {{AbstractNodeData.getReferencedContent()}} at some point calls {{hm.isExists()}} method passing in possibly uuid. The uuid is then evaluated as path by hierarchy manager and access permissions are checked, which leads to the error message like {noformat} 2010-02-03 10:56:01,182 ERROR info.magnolia.cms.core.DefaultHierarchyManager : User not allowed to Read path [c820b390-2f19-43e9-915a-c544bda13a78] {noformat} being logged. This is quite obtrusive in the log files, specially so since {{STKUtil.getReferencedContent()}}, that invokes the above mentioned method in {{NodeData}}, is called quite often from templates. The possible solutions are either to lower severity of the mentioned error message in {{DefaultHierarchyManager}} or to make sure that AbstractNodeData determines whether the string contains path or uuid by other means then calling {{hm.isExists()}}. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2819) UUIDLink control doesn't work if extension is configured
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2819: -- Fix Version/s: 4.3.x (was: 4.3.2) UUIDLink control doesn't work if extension is configured Key: MAGNOLIA-2819 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2819 Project: Magnolia Issue Type: Bug Components: admininterface, core, gui Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x If the control specifies the extension parameter, the path passed to ContentUtil.getContent by {{info.magnolia.module.admininterface.UUIDSaveHandler#getUUID}} contains the html, which in turn fails to retrieve the corresponding node. The combination of uuidLink and extension probably does not make much sense? Maybe the control should still either behave nicely by ignoring it, OR it should be handled differently (ie not passed back by the tree popup?), or output some form of warning. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3050) Add missing methods to BinaryNodeData for getting/setting attributes
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3050: -- Fix Version/s: 4.3.x (was: 4.3.2) Add missing methods to BinaryNodeData for getting/setting attributes Key: MAGNOLIA-3050 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3050 Project: Magnolia Issue Type: Improvement Reporter: Fabrizio Giustina Assignee: Boris Kraft Fix For: 4.3.x I noticed only recently that BinaryNodeData has methods for setting attributes like: {code} setAttribute(String name, String value) setAttribute(String name, Calendar value) {code} but it misses the method for setting Longs or Doubles (I was wondering why the image size is set as a string and not as a long in jcr, this is probably the reason). Also for getting attributes it only has: {code} public String getAttribute(String name) { {code} which is already strange since the setter already supports also Calendars. What about cleaning it up in order to allow all the available types? we could maybe just add a getNodeData(String name) method similar to the one in Content (making clear that a binary node data can have other node data nested)? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3091) Avoid logging unnecessary error messages during activation
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3091: -- Fix Version/s: 4.3.x (was: 4.3.2) Avoid logging unnecessary error messages during activation -- Key: MAGNOLIA-3091 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3091 Project: Magnolia Issue Type: Improvement Affects Versions: 4.2.3 Reporter: Jan Haderka Assignee: Jan Haderka Fix For: 4.3.x in two cases: - when attempting deactivation of the content that doesn't exist on the public, ugly stacktrace appears in the public log file - when attempting to activate node without uuid (still possible, by path), the author logs bunch of errors on attempt to retrieve content uuid -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2769) Misplaced json dependencies
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2769: -- Fix Version/s: 4.3.x (was: 4.3.2) Misplaced json dependencies --- Key: MAGNOLIA-2769 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2769 Project: Magnolia Issue Type: Task Components: build Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x templating and data modules currently have an unused and unnecessary dependency to json-lib. Otoh, rssaggregator explicitely uses json code and has no dependency on it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2517) Cleaner refactoring for previewMode
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2517: -- Fix Version/s: 4.3.x (was: 4.3.2) Cleaner refactoring for previewMode --- Key: MAGNOLIA-2517 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2517 Project: Magnolia Issue Type: Improvement Components: admininterface, core, gui Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x While working on MAGNOLIA-2245, previewMode is being moved from info.magnolia.cms.util.Resource to AggregationState. Given the InterceptFilter is setting this flag, and uses the session to do so, it seems we could use a cleaner implementation. Using the session is somehow still needed, for instance to serve resources / images appropriately. One of the things that bother me with the current implementation is that gui components access the aggregation state freely (global state) - this c/should instead be passed to the output methods. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3205) Full name column in user tree renders full html
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3205: -- Fix Version/s: 4.3.x (was: 4.3.2) Full name column in user tree renders full html --- Key: MAGNOLIA-3205 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3205 Project: Magnolia Issue Type: Bug Components: security Affects Versions: 4.3.1 Reporter: Jan Haderka Assignee: Philipp Bärfuss Priority: Critical Fix For: 4.3.x If user enters html in his Full name while changing preferences, the html is rendered in the tree for admin while browsing the users allowing malicious user to mount an attack on admin session. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2124) I18nContentSupport for dialogs
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2124: -- Fix Version/s: 4.3.x (was: 4.3.2) I18nContentSupport for dialogs -- Key: MAGNOLIA-2124 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2124 Project: Magnolia Issue Type: Improvement Components: gui Affects Versions: 3.6 Environment: Irrelevant Reporter: Stojan Peshov Assignee: Philipp Bärfuss Fix For: 4.3.x Attachments: i18n.patch, i18supportForDialogs.patch In MAGNOLIA-1431 it is stated that we should make copies of dialog controls (or even locale tabs) with locale extensions if we want to have i18n aware dialog. This solution leads as to many copies (tabs) if we want to cover many languages. Therefore, we've modified the initialization of dialogs in order to have one dialog for all languages. The solution works like this: When a page is displayed i18nContentSupportFilter sets the current locale and when a dialog is opened all the control's names are suffixed with the locale (if the locale is different than the fallback locale) ex. a dialog with edit control named text will become text_[locale]. The rest of the job remains to the Save handler which creates the localized content (nodeDatas). If you edit the dialog then the content of the current language is filled in the controls. This way we have only one dialog and unlimited number of languages, without the need of creating additional tabs (or controls). Note: This way there is no possibility to edit more than one language at once. For this functionality we modified the following: - DialogControlImpl.initializeConfig - I18nContentSupportFilter - DefaultI18nContentSupport - I18nContentSupport All of the classes have minor changes, that don't affect other functionalities. We attached the patch and hope that you'll like it. :) p.s. we also have created a language chooser (changer) tag that successfully implements the suggested solution -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2082) Module descriptor files: trim whitespace in text content (e.g. for versionHandler)
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2082: -- Fix Version/s: 4.3.x (was: 4.3.2) Module descriptor files: trim whitespace in text content (e.g. for versionHandler) - Key: MAGNOLIA-2082 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2082 Project: Magnolia Issue Type: Task Components: core, updatemechanism Affects Versions: 3.5.4 Reporter: Vivian Steller Assignee: Grégory Joseph Fix For: 4.3.x having tabs in versionHandler breaks installation of that module. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3079) ComponentProvider should lookup superclasses and interfaces of the required component
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3079: -- Fix Version/s: 4.3.x (was: 4.3.2) ComponentProvider should lookup superclasses and interfaces of the required component - Key: MAGNOLIA-3079 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3079 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x If {{ComponentProvider.getSingleton(com.foo.SomeSubInterface.class)}} is called, and no component is registered specifically for {{com.foo.SomeSubInterface}}, the ComponentProvider should look up registration for parents of {{com.foo.SomeSubInterface}} (i.e {{com.foo.SomeInterface}}, if {{SomeSubInterface extends SomeInterface}}) This should: * remove the need for casting when depending on a specific implementation: {code} // instead of: SomeSubInterface z = (SomeSubInterface) Components.getSingleton(SomeInterface.class); // you should be able to do: SomeSubInterface z = Components.getSingleton(SomeSubInterface.class); // even if only SomeInterface was configured (i.e if there's only a property for com.foo.SomeInterface) {code} * likewise, this should fix MAGNOLIA-3059 -- TODO: insert details as to how/why ;) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2531) SystemContext.locale duplicates MessagesManager's default locale
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2531: -- Fix Version/s: 4.3.x (was: 4.3.2) SystemContext.locale duplicates MessagesManager's default locale Key: MAGNOLIA-2531 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2531 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Currently, both these places are used to get AND set the default system locale. It should at least only be set in one place. Maybe MessagesManager could be split in two - one component that manages all the i18n configuration (enable locales, default locale etc, for both system/admin and content), and another component, which only manages message bundles. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2938) Migration to DataStore
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2938: -- Fix Version/s: 4.3.x (was: 4.3.2) Migration to DataStore -- Key: MAGNOLIA-2938 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2938 Project: Magnolia Issue Type: Task Components: core Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x With Magnolia 4.2, we updated to Jackrabbit 1.6; we should ideally offer a tool to migrate to the new DataStore (or see the status of Jackrabbit's) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2930) Remove leftover usages of RequestFormUtil
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2930: -- Fix Version/s: 4.3.x (was: 4.3.2) Remove leftover usages of RequestFormUtil - Key: MAGNOLIA-2930 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2930 Project: Magnolia Issue Type: Task Reporter: Grégory Joseph Assignee: Boris Kraft Fix For: 4.3.x Since MAGNOLIA-2449, RequestFormUtil shouldn't be needed anymore. It's been deprecated since 4.0, time to remove it completely! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3034) Replace default from email address in template emails
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3034: -- Fix Version/s: 4.3.x (was: 4.3.2) Replace default from email address in template emails --- Key: MAGNOLIA-3034 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3034 Project: Magnolia Issue Type: Task Components: mail Reporter: Grégory Joseph Assignee: Boris Kraft Priority: Critical Fix For: 4.3.x All default/sample emails come from hellon...@gmail.com - we should replace that by something more neutral. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2992) Content2Bean/ClassUtil should trim class names before attempting to load them
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2992: -- Fix Version/s: 4.3.x (was: 4.3.2) Content2Bean/ClassUtil should trim class names before attempting to load them - Key: MAGNOLIA-2992 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2992 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Grégory Joseph Priority: Trivial Fix For: 4.3.x For the same reason as for MAGNOLIA-2991, to avoid this: {code} at info.magnolia.cms.util.ClassUtil.classForName(ClassUtil.java:78) at info.magnolia.content2bean.impl.Content2BeanTransformerImpl.resolveType(Content2BeanTransformerImpl.java:106) at info.magnolia.content2bean.impl.Content2BeanProcessorImpl.toBean(Content2BeanProcessorImpl.java:78) {code} (I don't see a good reason why a classname should/could have whitespace characters in it;)) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3134) User with same User Name can be created
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3134: -- Fix Version/s: 4.3.x (was: 4.3.2) User with same User Name can be created --- Key: MAGNOLIA-3134 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3134 Project: Magnolia Issue Type: Bug Components: admininterface Affects Versions: 4.2, 4.2.1, 4.2.2, 4.2.3 Reporter: Benoît Segaert Assignee: Philipp Bärfuss Fix For: 4.3.x With the current folder structure, it is now possible to create a user with same User Name. Consequent, it will not be possible to login anymore with these users. The check is only done in the current folder. How to reproduce: - Create a folder A - Create a user test on this folder - Create a new folder B - create a user test on this folder. The user can be created and should be test0. - Create a user test in root. The user can be created and should be test0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2866) Ordering issue with copied/renamed nodes
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2866: -- Fix Version/s: 4.3.x (was: 4.3.2) Ordering issue with copied/renamed nodes Key: MAGNOLIA-2866 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2866 Project: Magnolia Issue Type: Bug Components: activation Affects Versions: 4.1, 4.0.2, 3.6.7, 3.6.8, 4.0.3 Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x # copy a {{test}} page (previously activated) # rename the original to {{test-old}} # rename the copy to {{test}} (the former name) # activate the parent of both The resulting order on the public instance(s) is wrong. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3152) Move mgnl (MagnoliaTemplatingUtilities) into FreeMarker shared variables
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3152: -- Fix Version/s: 4.3.x (was: 4.3.2) Move mgnl (MagnoliaTemplatingUtilities) into FreeMarker shared variables -- Key: MAGNOLIA-3152 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3152 Project: Magnolia Issue Type: Improvement Components: templating Affects Versions: 4.3 Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Since MAGNOLIA-3087, objects can be configured to be in FreeMarker shared variables; this removes the need to add these to the context of each and every template and paragraph rendering. We could do this for {{mgnl}} ({{MagnoliaTemplatingUtilities}}). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2528) Remove dependency to admincentral messages in MessagesManager
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2528: -- Fix Version/s: 4.3.x (was: 4.3.2) Remove dependency to admincentral messages in MessagesManager - Key: MAGNOLIA-2528 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2528 Project: Magnolia Issue Type: Improvement Components: admininterface, core Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x MessagesManager.DEFAULT_BASENAME currently refers to a file which is in fact in the admincentral module. This a completely soft dependency, so the worse that could happen is that those messages aren't found - however, for isolation, cleanliness and testability, this shouldn't be the case. We probably don't even need a default messages at all - or maybe a very limited one with just a couple of messages about Magnolia (version, build and so on? - although these informations are also provided by LicenseFileExtractor) Since I'm adding tests for MessagesManager, I'll add a fake resource file in the core/test folders to work around this for now. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3194) css: rect() needs comma-separated value
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3194: -- Fix Version/s: 4.3.x (was: 4.3.2) css: rect() needs comma-separated value --- Key: MAGNOLIA-3194 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3194 Project: Magnolia Issue Type: Bug Components: admininterface, gui, integration tests Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x Attachments: clip-rect-comma.patch, enablecss_in_tests.patch While browsers seem to be happy about the following css snippet: {code} clip: rect(0 0 100px 0); {code} .. the cssparser used by HtmlUnit isn't; it's following the spec a little closer, and enforce those values to be comma separated. This would be the correct syntax {code} clip:rect(0, 0, 100px, 0); {code} Attached is a patch that fixes the issue for magnolia-gui and m-m-admininterface. (hoping there are no other places where this property is set that weren't found with {{find . ! -path */target/* ! -name *.java ! -path */.svn/* -exec grep -H rect\( {} \;}}) Additional patch updates the version of HtmlUnit used in integration tests to 2.7, enables css parsing, and consequently fixes the issues we've had with integration tests since MAGNOLIA-3180 (MAGNOLIA-3180 did not break anything per se, since the tests were not checking the rendered results; the real issue is that we were disabling css in those tests, thus preventing the tree javascript to do its job; now that HtmlUnit supports css @import, we were able to enable css parsing) http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-Rect http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#value-def-shape -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3014) call to response.getOutputStream() during the rendering process fails
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3014: -- Fix Version/s: 4.3.x (was: 4.3.2) call to response.getOutputStream() during the rendering process fails - Key: MAGNOLIA-3014 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3014 Project: Magnolia Issue Type: Bug Affects Versions: 4.2 Reporter: Philipp Bärfuss Assignee: Boris Kraft Fix For: 4.3.x After the refactoring of the renderers in 4.0 we pass now the writer directly to the renderer. Which is done by calling response.getWriter(). This is very useful as this makes the rendering in general independent of the servlet API and allows direct calls to the rendering engine by Java code (for instance servlets or tests). Unfortunately a later call to response.getOutputStream() will fail as this violates the Servlet API specifications. There are several solutions possible. Workaround: registering your custom servlet (at the servlets filter) and let the request be rendered by the servlet and not by the rendering filter A) Pass a lazy wrapper instead of the writer instead of passing the writer we pass a lazy wrapper which will call response.getWriter() only once the first operation is performed on the writer - not very transparent + no changes in the API needed B) Change the API Support both variations of renderers. This can be achieved by various ways B.1) pass a object (magnolia response?) providing both methods which delegate to the response B.2) have two methods render(.., writer) and render(.. stream) (most likely by having two interfaces) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3173) Removing cache entries by key doesn't work reliably when using multiple caches
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3173: -- Fix Version/s: 4.3.x (was: 4.3.2) Removing cache entries by key doesn't work reliably when using multiple caches -- Key: MAGNOLIA-3173 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3173 Project: Magnolia Issue Type: Bug Components: cache Affects Versions: 4.3.1 Reporter: Jan Haderka Assignee: Jan Haderka Fix For: 4.3.x Since the first instance of cache flush policy that gets the uuid=cacheKey mapping also removes such mapping other instances will no longer find the mapping and will leave stale entries in the cache. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3148) Deprecation cleanup
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3148: -- Fix Version/s: 4.3.x (was: 4.3.2) Deprecation cleanup --- Key: MAGNOLIA-3148 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3148 Project: Magnolia Issue Type: Task Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Cleanup deprecated code - remove usages of deprecated code, drop code that's been deprecated since 4.0 or even 3.6 or earlier. {{find . -name *.java -exec grep -H @deprecated {} \;}} Some {...@deprecated}} tags don't have a since note, let's be careful with those and update them if necessary. {{find . -name *.java -exec grep -H @deprecated {} \; | grep -v -E since|from}} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3147) MgnlUser, MgnlGroup, MgnlRole and their managers should not save implicitely OR it should be possible to give them a specific hierarchy manager OR
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3147: -- Fix Version/s: 4.3.x (was: 4.3.2) MgnlUser, MgnlGroup, MgnlRole and their managers should not save implicitely OR it should be possible to give them a specific hierarchy manager OR --- Key: MAGNOLIA-3147 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3147 Project: Magnolia Issue Type: Improvement Components: core, modulemechanism, security Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x Attachments: user_task_does_not_save.patch Several approaches to consider, not all of them necessarily exclusive * module mechanism could swap the context for the entire process such that only read-only HierarchyManager are available * InstallContext.getHierarchyManager and .get*Node() should provide read-only HMs and nodes * MgnlGroup and associate classes could use the current context (they currently use, in part the system context, see notes below) * the various addRole*, addGroup, addPermission tasks could also work around this (see attached patch for a draft/idea) The classes of i.m.cms.security use a mixture of system and current context. They currently use this for 2 reasons: 1) bypass security; it's probably ok for reading, but not such a good idea for write method. In cases where this is needed, we now have the {{doInSystemContext}} approach which could help. 2) checking for duplicates: when adding roles to groups or users, we do {{ String newName = Path.getUniqueLabel(sysHM, node.getHandle(), 0);}} to name the property into which the added group or role's uuid is saved and avoid confict. One possibility for this would be to simply use the uuid as the property name as well (would definitely avoid conflicts). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1375) SimpleSearch allows search for template-creators
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1375: -- Fix Version/s: 4.3.x (was: 4.3.2) SimpleSearch allows search for template-creators Key: MAGNOLIA-1375 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1375 Project: Magnolia Issue Type: Bug Components: taglibs Affects Versions: 3.0.1 Reporter: Sebastian Frick Assignee: Fabrizio Giustina Priority: Minor Fix For: 4.3.x if you search for a username, e.g. superuser, it seems that simplesearch returns all templates that have been created with that account. a possibility to exclude such metadata would be fine -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1304) Proper handling of PropertyType.NAME in MgnlNode.setProperty
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1304: -- Fix Version/s: 4.3.x (was: 4.3.2) Proper handling of PropertyType.NAME in MgnlNode.setProperty Key: MAGNOLIA-1304 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1304 Project: Magnolia Issue Type: Task Components: core, workflow Affects Versions: 3.0.1 Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x For some unknown reason, the JcrBeanCoder uses PropertyType.NAME when storing Null values - I've only seen this happening with the openwfe.org.jcr.beancoder.JcrBeanCoder__instance_class property. As a result, the related beans can't be deserialized. I've applied to following fix for now, but it's far from elegant: if (type == PropertyType.NAME) { log.warn(setProperty( + propertyName + , + valueStr + with type PropertyType.NAME, will switch to PropertyType.STRING ...); type = PropertyType.STRING; } We should: 1) understand why/how PropertyType.NAME was used in the first place 2) if PropertyType.NAME is a valid choice, make it so that the bean can be deserialized anyhow. if not, then fix JcrBeanCoder. This was working before MAGNOLIA-1303 because the type parameter was ignored and all properties stored as Strings. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1396) Workflow module api/code cleanup
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1396: -- Fix Version/s: 4.3.x (was: 4.3.2) Workflow module api/code cleanup Key: MAGNOLIA-1396 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1396 Project: Magnolia Issue Type: Task Components: workflow Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x There are a number of todos and improvements to be done in this module (not saying there aren't any elsewhere ;-) ). Just opening a task because I'd like to clean this up a little bit. Some thoughts: * improvable class/method names * unused parameters to be removed * logging to be cleaned up * MgnlParticipant could be refactored : one impl specific for commands and one for users/groups/roles * change signature of WorkflowUtil. getWorkItems() to take a User instance instead of a String username. (implement (1) and (2) as described in MAGNOLIA-1296) * Is WorkflowUtilPage still needed / in use ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3094) Also use contextPath when resolving magnolia.properties files at startup
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3094: -- Fix Version/s: 4.3.x (was: 4.3.2) Also use contextPath when resolving magnolia.properties files at startup Key: MAGNOLIA-3094 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3094 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x Attachments: contextPath_in_PropertiesInitializer.patch, use-contextPath.patch When looking up {{magnolia.properties}} [1] files, we're using the current host name, as well as the webapp folder name (i.e the last element of the path in which the webapp is deployed) - which is not necessarily the servlet context path for the webapp. Using the webapp's context path might help in a bunch of situations (while developing I often have a context path differing from the webapp's name. same goes when deploying multiple apps under different vhosts of a single tomcat, for instance; some appservers deploy their webapps in folder whose name doesn't correspond to the contextPath either) Unfortunately, {{javax.servlet.ServletContext#getContextPath}} is only available since the 2.5 version of the Servlet API. Can we update ? (marking this as fix-for 4.3, only in the case we can quickly decide on upgrading the servlet api dependency, in which case adding this should be trivial) [1] http://documentation.magnolia-cms.com/cookbook/using-a-single-war-file-with-multiple-configurations.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3029) Use generics for ObservedManager
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3029: -- Fix Version/s: 4.3.x (was: 4.3.2) Use generics for ObservedManager Key: MAGNOLIA-3029 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3029 Project: Magnolia Issue Type: Task Components: core Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x It looks like most subclasses of {{info.magnolia.cms.beans.config.ObservedManager}} are close to identical except for the type of manager that they handle. Generics could probably come in handy to reduce redundancy in the code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1156) FCKEditor : expose new features
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1156: -- Fix Version/s: 4.3.x (was: 4.3.2) FCKEditor : expose new features --- Key: MAGNOLIA-1156 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1156 Project: Magnolia Issue Type: New Feature Components: admininterface Affects Versions: 3.0 RC4 Reporter: Grégory Joseph Assignee: Philipp Bärfuss Priority: Minor Fix For: 4.3.x There are a couple of new features in fckeditor, like the spell checker, which we could expose to magnolia. Maybe this is already possible, and we just need to document it somehow :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3086) Module instances could be proxies too
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3086: -- Fix Version/s: 4.3.x (was: 4.3.2) Module instances could be proxies too - Key: MAGNOLIA-3086 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3086 Project: Magnolia Issue Type: Improvement Components: core, updatemechanism Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Since MAGNOLIA-2553, we realize how useful it would be for module instances to also be proxies. They could be kept around (and/or injected) without worrying about whether the configuration was changed/replaced. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1356) javascript: support other messages files
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1356: -- Fix Version/s: 4.3.x (was: 4.3.2) javascript: support other messages files Key: MAGNOLIA-1356 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1356 Project: Magnolia Issue Type: Improvement Affects Versions: 3.0.1 Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss Fix For: 4.3.x Currently one needs to provide the messages by doing custom coding: out.println(MessagesUtil.generateJavaScript(MessagesManager.getMessages(mybundle.bli.bla))); But the JavascriptIncludePage should do that for all files with pattern messages*.properties -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2982) security: find a better solution than using the /$ permission if a user can only see parts of the content
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2982: -- Fix Version/s: 4.3.x (was: 4.3.2) security: find a better solution than using the /$ permission if a user can only see parts of the content - Key: MAGNOLIA-2982 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2982 Project: Magnolia Issue Type: Improvement Components: security Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss Fix For: 4.3.x If one wants to give access only to one of the subtrees, like /demo-project, one has also to give access to the root which can be done but then the user can read everything. The main problem is that one can't give access to one single page only (it always includes the subpages). Today we solve that by using /$ which uses the fact that the AccessManager uses regular expressions. But this is also ugly because the system then creates the very weird permission /$/*. Either the tree should be able to handle this implicitly (list all the children the user can see no matter if he has access to the root node) or find a solution for MAGNOLIA-1555. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2557) Cache configuration should be simplified
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2557: -- Fix Version/s: 4.3.x (was: 4.3.2) Cache configuration should be simplified Key: MAGNOLIA-2557 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2557 Project: Magnolia Issue Type: Improvement Components: cache Reporter: Grégory Joseph Assignee: Boris Kraft Fix For: 4.3.x It is generally too complex. Will gather feedback on this issue before doing anything about it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3160) content2bean should allow to specify implementations for Collections
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3160: -- Fix Version/s: 4.3.x (was: 4.3.2) content2bean should allow to specify implementations for Collections Key: MAGNOLIA-3160 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3160 Project: Magnolia Issue Type: Bug Components: content2bean Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Currently, all Map and Collection properties are populated via a {{LinkedHashMap}}. While this is a good default, content2bean should respect the cases where a specific implementation is mandated by the configuration. (i.e specifying a property {{class=MyCollectionImplementation}}) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2794) Register some sort of RecoveryFilter for when the filter chain is not correctly configured
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2794: -- Fix Version/s: 4.3.x (was: 4.3.2) Register some sort of RecoveryFilter for when the filter chain is not correctly configured -- Key: MAGNOLIA-2794 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2794 Project: Magnolia Issue Type: Improvement Components: core Affects Versions: 4.1 Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x Currently, if no filter chain is available, we end up with ugly NPEs. If the {{/server/filters}} node is not available at all, we could for instance instanciate {{rootFilter}} as some sort of filter that lets Magnolia start and give the user a chance to fix the installation. Another issue is that activation is obviously broken if the filter configuration is broken. The following scenario needs to be taken into account: * filters broken on author * user decides to delete the filter nodes and reimport a backup. If not careful (and if we still have the deletion=immediate deactivation), the filters are also removed from the public instance. * if the import succeeds (which will probably need a restart anyway for the filters to be reinitialized), the imported configuration still can't be activated to the public instance(s), since those have no filters - thus no activation filter. TODO - there are related issues, link and/or fix them ! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3199) Avoid error logs for invalid jcr paths in AggregatorFilter
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3199: -- Fix Version/s: 4.3.x (was: 4.3.2) Avoid error logs for invalid jcr paths in AggregatorFilter --- Key: MAGNOLIA-3199 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3199 Project: Magnolia Issue Type: Bug Affects Versions: 4.3.1 Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina Priority: Minor Fix For: 4.3.x Since we now allow extended chars for any url, Aggregator filter may now check the esistence in the jcr repository of a path containing invalid chars. Although this doesn't cause any problem to the user (an invalid path is translated to a 404, which is the expected result), this may generate some annoying logs. Requesting a URL with: - an invalid char like '*', ':' (e.g. http://mysite/test*a:b.html ) - a trailing slash (e.g. http://mysite/test /a.html ) - an single / (e.g. http://mysite// ) generates a MalformedPath/IllegalName exception wrapped into a RepositoryException and logged (with error level). Since there is no specific exception thrown we can't add an appropriate silent catch, so we should avoid calling isExist() for invalid handles. Unfortunately it seems there is nothing available for validating a path in Jcr... Jackrabbit has something similar but only in version 2.0 and using jackrabbit-specific APIs, so it's not an option. The only simple solution is to explicitly check for common chars/rules like the ones before in the Aggregator filter. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2993) Extract logic out of taglibs - reusability, testability, ...
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2993: -- Fix Version/s: 4.3.x (was: 4.3.2) Extract logic out of taglibs - reusability, testability, ... Key: MAGNOLIA-2993 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2993 Project: Magnolia Issue Type: New Feature Components: taglibs, templating Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Some of our tags are extremely complex; testing them, fixing them, has become very tedious. Many of them have fuzzy logic that isn't well defined. Extracting this will also allow us to reuse them in Freemarker templates (amongst others) without depending on the taglib itself; a macro library or {{${mgnl}}} methods might provide a simpler/cleaner/lighter syntax. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3181) Saving content with missing mandatory values
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3181: -- Fix Version/s: 4.3.x (was: 4.3.2) Saving content with missing mandatory values Key: MAGNOLIA-3181 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3181 Project: Magnolia Issue Type: Bug Components: admininterface, i18n Affects Versions: 4.3.1 Reporter: Jan Haderka Assignee: Philipp Bärfuss Fix For: 4.3.x Since new i18n, it is possible to create paragraphs with missing mandatory values. To reproduce: - open any page and switch language to other then default lang. - create new paragraph and enter all mandatory values in given language and save. - change page language to default (or any other then previously used). Result: - default mandatory values are missing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3204) aggregation state looses all information on forwards
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3204: -- Fix Version/s: 4.3.x (was: 4.3.2) aggregation state looses all information on forwards Key: MAGNOLIA-3204 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3204 Project: Magnolia Issue Type: Bug Affects Versions: 4.3.1 Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss Priority: Critical Fix For: 4.3.x Attachments: MAGNOLIA-3204.patch h4. The Problem The aggregation state is set to null on each forward. This is problematic as we also store the locale and site in the aggregation state. As a consequence all this information is lost after a virtual uri mapping which forwards. Example: # request to /de/page/param.html #- locale is set to de #- current uri is /page/param.html # virtual uri mapping #- forward to /page.html?param # re-execution #- ContentTypeFilter resets the aggregation state #- locale is now the default locale:en h4. Solution We could simply not reset the aggregation state but this conflicts with MAGNOLIA-3203 (resetting original URI on forward). So we can either fix MAGNOLIA-3203 or reset the aggregation state partially. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-85) Module: blog module
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-85: Fix Version/s: 4.3.x (was: 4.3.2) Module: blog module --- Key: MAGNOLIA-85 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-85 Project: Magnolia Issue Type: New Feature Reporter: Boris Kraft Assignee: Boris Kraft Fix For: 4.3.x It would be cool to have a blog module for magnolia -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2422) Extract ContentUtil.Visitor and Content.ContentFilter
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2422: -- Fix Version/s: 4.3.x (was: 4.3.2) Extract ContentUtil.Visitor and Content.ContentFilter - Key: MAGNOLIA-2422 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2422 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x These interfaces and associated utilities are so useful that imo they deserve their own class :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1483) Scriptable paragraph actions
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1483: -- Fix Version/s: 4.3.x (was: 4.3.2) Scriptable paragraph actions Key: MAGNOLIA-1483 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1483 Project: Magnolia Issue Type: Improvement Components: templating Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x Since we added the possibility to execute actions with paragraphs (currently only with freemarker paragraphs, see MAGNOLIA-1462 and MAGNOLIA-1383), it would seem useful and nice if those actions would be scriptable. We could store these scripts in the repository, and like for storing templates in the repository, and like for MAGNOLIA-1482, this would allow their edition within Magnolia and their activation too. Using JSR-223 seems like the most reasonable approach since that would give us pluggable scripting engines, thus leaving the langage choice to the script author. http://jcp.org/en/jsr/detail?id=223 https://scripting.dev.java.net/ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2354) Show Paragraph path in edit bar or dialog
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2354: -- Fix Version/s: 4.3.x (was: 4.3.2) Show Paragraph path in edit bar or dialog - Key: MAGNOLIA-2354 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2354 Project: Magnolia Issue Type: Improvement Reporter: Dawn Messier Assignee: Grégory Joseph Priority: Minor Fix For: 4.3.x It is useful for developers to see sometimes path to the paragraph that is currently used specially when there are many paragraphs defined in the system. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2343) Replace current implementation for selectors by a more flexible mechanism
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2343: -- Fix Version/s: 4.3.x (was: 4.3.2) Replace current implementation for selectors by a more flexible mechanism - Key: MAGNOLIA-2343 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2343 Project: Magnolia Issue Type: Task Components: core, templating Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Attachments: Picture 1.png {panel:title=Warning} This issue has been updated. Its title used to be selectors can be deprecated, virtual uri mappings can do a better job, and this was a very misleading title, which led to the comments below. We hear your concerns, they are totally valid, so we'll try to come up with something better :) As from 2008-09-11, we've renamed, re-described and postponed this issue. {panel} The current implementation of selectors is unsatisfying in many levels: * it is redundant with what can be (at least partly) achieved with virtual uri mappings ({{/foo.bar.html}} --forward-- {{/foo.html?selector=bar}}, and does not allow other elegant solutions for nice urls ({{/archives/2008/09}}) * it is does not allow naming of parameters or generally more flexible mappings: the knowledge of how to treat the complete selector string is coded in the template. (For a URI like /archives.2008.09.html, the template gets a 2008.09 string, and he has to know the exact order of these 2 elements in the string) * there are many possible places where a template could get its dynamic information from (request parameters, request attributes, context attributes, uri in itself, ...) and this is just adding to the confusion. * it is completely hard-wired in the filter chain and the API of Magnolia: it can't be disabled, and it adds complexity to the API for something that should not be imposed on users. (it *is* useful, but people should be free to use it or not and/or to use other mechanisms for similar purposes) For these reasons, we'd like to replace it. Replacing it with the current implemenation of virtual uri mappings isn't exactly the best solution, which is why we're postponing this. I'll try to come up with a small document describing a possible solution shortly. note: The original link of this issue to the dots in user names issue remains, because they are indeed related, but the fixes for both issues will not be. (i.e. we do not necessarily need to change the selectors implementation to fix the dots in user names issue and vice-versa; it's just by investigating the latter that we started discussing the selector issue) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2399) Make acl nodes read only for user
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2399: -- Fix Version/s: 4.3.x (was: 4.3.2) Make acl nodes read only for user - Key: MAGNOLIA-2399 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2399 Project: Magnolia Issue Type: Improvement Components: admininterface, security Reporter: Jan Haderka Assignee: Philipp Bärfuss Fix For: 4.3.x While this is not exposed via UI anywhere, it would be definitively safer to have user rights to their own ACLs limited. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2300) ModuleManagerImpl.checkForUpdateOrInstall breaks its stated contract
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2300: -- Fix Version/s: 4.3.x (was: 4.3.2) ModuleManagerImpl.checkForUpdateOrInstall breaks its stated contract Key: MAGNOLIA-2300 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2300 Project: Magnolia Issue Type: Improvement Components: core, updatemechanism Affects Versions: 3.6.1 Reporter: Jan Haderka Assignee: Grégory Joseph Priority: Minor Fix For: 4.3.x Javadoc for {{ModuleManager.checkForInstallOrUpdates()}} states the method implementation is supposed to check for existence of install or update tasks that needs to be executed. However implementation of the method in {{ModuleManagerImpl}} also loads repositories when there are not install/update tasks to execute. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1404) workflow translations to be moved to workflow module
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1404: -- Fix Version/s: 4.3.x (was: 4.3.2) workflow translations to be moved to workflow module Key: MAGNOLIA-1404 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1404 Project: Magnolia Issue Type: Task Components: admininterface, workflow Affects Versions: 3.0.1 Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x Currently only the english translations have been moved -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2258) Remove dependency on exchange-simple from cache (filter ordering)
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2258: -- Fix Version/s: 4.3.x (was: 4.3.2) Remove dependency on exchange-simple from cache (filter ordering) - Key: MAGNOLIA-2258 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2258 Project: Magnolia Issue Type: Improvement Components: cache Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x This was needed for MAGNOLIA-2023 in order to set the filters order correctly, but isn't the best option since the cache module thus can't order its filters correctly if the exchange-simple module is not present. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2423) streamline api: Content.getNodeType, getNodeTypeName and getItemType
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2423: -- Fix Version/s: 4.3.x (was: 4.3.2) streamline api: Content.getNodeType, getNodeTypeName and getItemType Key: MAGNOLIA-2423 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2423 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x These 3 methods essentially do the same thing (but not *exactly*) but return different types. Streamlining these would make our API cleaner/clearer. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2193) FckEditor : insert image : the link tab is confusing
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2193: -- Fix Version/s: 4.3.x (was: 4.3.2) FckEditor : insert image : the link tab is confusing Key: MAGNOLIA-2193 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2193 Project: Magnolia Issue Type: Improvement Components: admininterface, gui Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x When inserting an image in fckeditor, one can browse the repositories to create an hyperlink *on* the inserted image *to* a page or document. Users seem confused by this link tab and its browse server button - it seems they expect the image they select there, in dms, to actually *be* the image they're inserting in their paragraph. 1) We should add the possibility to browse server on the image info tab to allow users to browse for images in their dms for example. (MAGNOLIA-2192) 2) We should probably get rid of the link tab: creating a link out of an image can be achieved by first inserting the image and then selecting it and using the link button. It would probably be less confusing and more straightforward. (MAGNOLIA-2193) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1562) deprecate contentNodeCollection-- support nested paragraphs
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1562: -- Fix Version/s: 4.3.x (was: 4.3.2) deprecate contentNodeCollection-- support nested paragraphs Key: MAGNOLIA-1562 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1562 Project: Magnolia Issue Type: Improvement Components: templating Affects Versions: Ideas Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss Fix For: 4.3.x In my opinion we should drop the concept of having contentNodeCollections. Since we have nested paragraphs we should not use it anymore. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2691) Blank properties are not editable once inserted.
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2691: -- Fix Version/s: 4.3.x (was: 4.3.2) Blank properties are not editable once inserted. Key: MAGNOLIA-2691 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2691 Project: Magnolia Issue Type: Bug Components: admininterface Affects Versions: 4.0.1, 3.6.5 Reporter: Danilo Ghirardelli Assignee: Philipp Bärfuss Priority: Minor Fix For: 4.3.x - Create a new node data, anywhere in the config tree. - Set a name of the node data if you want - Set the value of the node data as (a simple blank space, not an empty string) - Save and try editing the value again... A blank value is not editable anymore. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2192) FckEditor: add possibilty to browse server when inserting an image
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2192: -- Fix Version/s: 4.3.x (was: 4.3.2) FckEditor: add possibilty to browse server when inserting an image Key: MAGNOLIA-2192 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2192 Project: Magnolia Issue Type: Improvement Components: admininterface, gui Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x When inserting an image in fckeditor, one can browse the repositories to create an hyperlink *on* the inserted image *to* a page or document. Users seem confused by this link tab and its browse server button - it seems they expect the image they select there, in dms, to actually *be* the image they're inserting in their paragraph. 1) We should add the possibility to browse server on the image info tab to allow users to browse for images in their dms for example. (MAGNOLIA-2192) 2) We should probably get rid of the link tab: creating a link out of an image can be achieved by first inserting the image and then selecting it and using the link button. It would probably be less confusing and more straightforward. (MAGNOLIA-2193) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2097) i18n: MgnlContext.setLocale() is never used while FreemarkerHelper depends on it
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2097: -- Fix Version/s: 4.3.x (was: 4.3.2) i18n: MgnlContext.setLocale() is never used while FreemarkerHelper depends on it Key: MAGNOLIA-2097 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2097 Project: Magnolia Issue Type: Bug Components: core Affects Versions: 3.5.4 Reporter: Grégory Joseph Assignee: Boris Kraft Fix For: 4.3.x In the DefaultI18nContentSupport, we get/set the locale on the AggregationState. FreemarkerHelper determines the Locale based on the MgnlContext.getLocale(). As a consequence, emails sent with freemarker when no user is logged in are always sent with the anonymous' user's locale instead of whatever the current locale is, as determined by the I18nContentSupport. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1788) Simplify / remove FreemarkerUtil, handling of AlertUtil/message in FreemarkerHelper and other improvements.
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1788: -- Fix Version/s: 4.3.x (was: 4.3.2) Simplify / remove FreemarkerUtil, handling of AlertUtil/message in FreemarkerHelper and other improvements. --- Key: MAGNOLIA-1788 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1788 Project: Magnolia Issue Type: Improvement Components: core Affects Versions: 3.5 RC1 Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x AlertUtil's message is currently added to the freemarker context only in FreemarkerUtil (contrary to other default values which are added by FreemarkerHelper. Not sure how to handle this, for two reasons: - message seems a too generic key name (ie it might accidentally be used by the template for another purpose) - we're having more and more default values added to the freemarker context, and maybe they just all belong to the magnolia context, which is already exposed to the template as ctx. The feature where we passed a template stream/reader to FreeMarker templates inline also needs a review/cleanup. It is used by the mail module and we could probably be using a TemplateLoader to achieve this. In fact, Freemarker provides an abstract URLTemplateLoader, and it would be fairly trivial to implement it so that it fetches a page from a given Magnolia instance pretty much the same way the mail module does it at the moment. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1806) Refactoring / cleanup of the bootstrap classes methods
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1806: -- Fix Version/s: 4.3.x (was: 4.3.2) Refactoring / cleanup of the bootstrap classes methods -- Key: MAGNOLIA-1806 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1806 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x The whole Bootstrap mechanism should be reviewed. There are currently multiple places where bootstrap is used: - Bootstrapper (used to bootstrap data when installing webapp) - BootstrapTasks (they use the deprecated ModuleUtil methods) - DataImporter All of them here and there do the same thing but do not use a common API, e.g. to: - resolve the target node out of the filename - not all support tar.gz files instead of xml files - etc. Also the usage of the ImportUUIDBehavior is sometime inconsistent used. We should probably use ImportUUIDBehavior.IMPORT_UUID_COLLISION_THROW as a default behaviour. In general we should introduce a main BootstrapUtil class that is commonly used by all classes mentioned above. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2645) review GUI localization texts for 4.0
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2645: -- Fix Version/s: 4.3.x (was: 4.3.2) review GUI localization texts for 4.0 - Key: MAGNOLIA-2645 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2645 Project: Magnolia Issue Type: Task Reporter: Boris Kraft Assignee: Boris Kraft Fix For: 4.3.x We need to review/translate the 4.0 messages into the various languages we support -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2628) Activation doesn't work with commons-beanutils 1.8
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2628: -- Fix Version/s: 4.3.x (was: 4.3.2) Activation doesn't work with commons-beanutils 1.8 -- Key: MAGNOLIA-2628 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2628 Project: Magnolia Issue Type: Bug Components: activation, core Affects Versions: 4.0 Reporter: Jan Haderka Assignee: Philipp Bärfuss Fix For: 4.3.x Setting of values from prototype is broken during pool creation with beanutils 1.8 Issue is possibly related to changes in list handling [1] or property transformation [2] in version 1.8 or some other issue fix for version 1.8 [3] While identified with activation command instantiation, this issue might possibly affect other part of magnolia using C2B transformations. [1] http://issues.apache.org/jira/browse/BEANUTILS-168 [2] http://issues.apache.org/jira/browse/BEANUTILS-199 [3] http://issues.apache.org/jira/browse/BEANUTILS/fixforversion/12311949 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1830) Update: overhaul delta class: remove title but populate version
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1830: -- Fix Version/s: 4.3.x (was: 4.3.2) Update: overhaul delta class: remove title but populate version --- Key: MAGNOLIA-1830 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1830 Project: Magnolia Issue Type: Task Components: core Affects Versions: 3.1 M3 Reporter: Vivian Steller Assignee: Grégory Joseph Fix For: 4.3.x in the ModuleManagerWebUI templates we should get rid of the delta.title but include something like delta.version print the changes in a more generic way. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1751) Remove dependency from xerces
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1751: -- Fix Version/s: 4.3.x (was: 4.3.2) Remove dependency from xerces - Key: MAGNOLIA-1751 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1751 Project: Magnolia Issue Type: Improvement Components: core Affects Versions: 3.1 M3 Reporter: Fabrizio Giustina Assignee: Sameer Charles Priority: Minor Fix For: 4.3.x It would be nice to remove any dependency from xerces (it often causes conflicts with xml libraries available in the jdk). Also jackrabbit did remove this dependency for future releases. DataTransporter at this moment uses xerces directly, we need to check if we can avoid it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2595) Update tasks : streamline class names, functionality and provide a couple more useful abstractions
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2595: -- Fix Version/s: 4.3.x (was: 4.3.2) Update tasks : streamline class names, functionality and provide a couple more useful abstractions -- Key: MAGNOLIA-2595 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2595 Project: Magnolia Issue Type: Improvement Components: core, updatemechanism Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x * current naming is very inconsistent, makes it hard to find the appropriate task to use * the way some tasks work is inconsistent with others: some are very safe (check current values, etc), some aren't (just add a property no matter what the current status is) - we should add consistency and/or document the few inconsistency and why the safety is needed in most cases * we've often had the need for : ** tasks which recurse through subnodes - an abstract task using a Visitor would be very helpful. ** tasks which perform an operation over a given set of nodes - an abstract takes that operates on the nodes returned by a jcr query would help. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2598) Module dependency issue should be displayed in update ui
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2598: -- Fix Version/s: 4.3.x (was: 4.3.2) Module dependency issue should be displayed in update ui Key: MAGNOLIA-2598 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2598 Project: Magnolia Issue Type: Improvement Components: core, updatemechanism Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x At the moment, if we have a module dependency issue, Magnolia can't be started. Exceptions are reported in the logs. Since the UI is nice enough to report install / update issues, it could just as well handle setup (wrong dependency) issues. This, like a couple of other improvements, calls for delegating the exception handling to a separate component, possible the ModManUI. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2926) Refactor/move/repackage the info.magnolia.cms.util
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2926: -- Fix Version/s: 4.3.x (was: 4.3.2) Refactor/move/repackage the info.magnolia.cms.util -- Key: MAGNOLIA-2926 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2926 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x This package (and others) need to be reviewed/restructured. * Some classes are general utility classes (BooleanUtil, ClassUtil, ExceptionUtil) and belong in a package such as {{info.magnolia.util}} * Some classes are content utility classes (NodeDataUtil, ContentUtil and their inner classes, Visitor, ...) - these belong to a package such as {{info.magnolia.content(.util)}} (along with their related classes, which should be restructured too) * Some others are specific to, say, installation tasks, security, etc, and should also be moved appropriately (i.e next to their usage) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2618) MagnoliaTemplatingUtilities: should use browser link transformer instead of the absolute link transformer
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2618: -- Fix Version/s: 4.3.x (was: 4.3.2) MagnoliaTemplatingUtilities: should use browser link transformer instead of the absolute link transformer - Key: MAGNOLIA-2618 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2618 Project: Magnolia Issue Type: Bug Components: templating Affects Versions: 4.0 Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss Fix For: 4.3.x Attachments: browserLink.patch This is mainly essentiel if the server is configured to make relative links. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2834) Login screen should show Magnolia License and Version of the System
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2834: -- Fix Version/s: 4.3.x (was: 4.3.2) Login screen should show Magnolia License and Version of the System --- Key: MAGNOLIA-2834 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2834 Project: Magnolia Issue Type: Improvement Components: admininterface Reporter: Christian Ringele Assignee: Philipp Bärfuss Priority: Critical Fix For: 4.3.x Attachments: Picture 1.png This is a request by Pascal: The login screen should show: - The used Magnolia license - The used Magnolia version Comparable to on how its shown within the adminCentral (see attachment). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2599) Make audit logging fully configurable
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2599: -- Fix Version/s: 4.3.x (was: 4.3.2) Make audit logging fully configurable - Key: MAGNOLIA-2599 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2599 Project: Magnolia Issue Type: Improvement Affects Versions: 4.0 Reporter: Jan Haderka Assignee: Boris Kraft Fix For: 4.3.x Currently only after all data is gathered, AuditLoggingManager is called. It should be possible to instrument all the aspects of logging even obtaining user name as in some situations (startup, installation) such data might not be available and attempt to obtain them causes chain of failures (nice example is recent update of node types in user workspace ... can't really read user names while manipulating the nodes representing users themselves). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2626) Extend AbsoluteLinkTransformer to allow generating links with arbitrary context path
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2626: -- Fix Version/s: 4.3.x (was: 4.3.2) Extend AbsoluteLinkTransformer to allow generating links with arbitrary context path Key: MAGNOLIA-2626 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2626 Project: Magnolia Issue Type: Improvement Affects Versions: 4.0 Reporter: Jan Haderka Assignee: Boris Kraft Fix For: 4.3.x To generate mail with link back to content one need to create absolute link, but since I'm executing template from within mail command there is no web context defined so AbsoluteLinkTransformer fails. We need a way to allow setting of the context path for the transformer directly and use WebContext to retrieve it only when not set. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1855) Update mechanism : better feedback to user
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1855: -- Fix Version/s: 4.3.x (was: 4.3.2) Update mechanism : better feedback to user -- Key: MAGNOLIA-1855 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1855 Project: Magnolia Issue Type: Improvement Components: core, updatemechanism Affects Versions: 3.5 Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x At the moment, the only feedback the user gets, is the number of tasks that have been executed, along with the eventual info, warn or error messages tasks would yield, and that's refreshed every 3 seconds. One of the frustrating things is that sometimes a save() operation (which happens after each successful module install/update) can take more than a few seconds, thus no progress is seen. Would be nice to send some feedback to the user about this, either through the form a message (currently saving...) or some progress bar (eventhough afaik we have no way of knowing the actual progress of a save operation) Another thing which we need to handle properly are failing tasks and exceptions. At the moment, the page keeps on refreshing itself, even if the actual update mechanism has been interrupted. This should also help with having tasks which fail on purpose, for instance if a restart is needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2730) Reimplement audit and security using HierarchyManagerWrapper, ContentWrapper, etc.
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2730: -- Fix Version/s: 4.3.x (was: 4.3.2) Reimplement audit and security using HierarchyManagerWrapper, ContentWrapper, etc. -- Key: MAGNOLIA-2730 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2730 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x This would simplify: * the code itself (less redundancy, less error-prone - an AuditingHM would do one single thing (audit logging) and delegate) * turning these features on/off * replacing/customizing them * tests (because I don't want to have audit log in my tests, nor have to configure them) We already have RepositoryAcquiringStrategy, which is where the appropriate wrappers w/c/ould be constructed. It would also serve as a proof of concept for more advanced uses of wrappers (which I will dutifully note here once I remember them) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2790) Samples: should be 100% valid
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2790: -- Fix Version/s: 4.3.x (was: 4.3.2) Samples: should be 100% valid - Key: MAGNOLIA-2790 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2790 Project: Magnolia Issue Type: Bug Components: samples Reporter: Grégory Joseph Assignee: Teresa Miyar Fix For: 4.3.x The samples templates and content are currently not 100% valid html. Couple fixes should be fairly easy to do. Also ideally the doctype line should be the very first. If the comments on the top of each file are only there for when the sources are displayed through the samples, the source's path and filename could be added by the component that does render those sources instead ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2820) Backend with HTTPS - warning in IE7
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2820: -- Fix Version/s: 4.3.x (was: 4.3.2) Backend with HTTPS - warning in IE7 --- Key: MAGNOLIA-2820 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2820 Project: Magnolia Issue Type: Bug Components: admininterface Affects Versions: 3.6.3 Reporter: Rainer Blumenthal Assignee: Philipp Bärfuss Fix For: 4.3.x Attachments: Navigation.java, Navigation.js, Navigation.patch If you access the Magnolia Backend with HTTPS using an IE Browser: u get this warning: This page containsd secure and non-secure items... http://farm3.static.flickr.com/2263/2330340408_63a47989da.jpg?v=0 If you look here: http://weblogs.asp.net/rchartier/archive/2008/03/12/ie7-this-page-contains-both-secure-and-nonsecure-items.aspx somebody seems to have found the cause. The Magnolia Backend seems to use an iframe without src attribute - the src attribute is then set by JS. But on page-load the IE interpretes this as unsecure. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2869) taglibs: inheritance in iterator and out tag should use InheritanceContentWrapper
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2869: -- Fix Version/s: 4.3.x (was: 4.3.2) taglibs: inheritance in iterator and out tag should use InheritanceContentWrapper -- Key: MAGNOLIA-2869 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2869 Project: Magnolia Issue Type: Improvement Components: taglibs Reporter: Philipp Bärfuss Assignee: Fabrizio Giustina Fix For: 4.3.x All inheritance features should use the same mechanism. The wrapper is currently the most mature mechanism we have and is used in STK. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2683) FCK with spell check functionality
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2683: -- Fix Version/s: 4.3.x (was: 4.3.2) FCK with spell check functionality -- Key: MAGNOLIA-2683 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2683 Project: Magnolia Issue Type: New Feature Components: fckeditor Affects Versions: 4.0.1, 3.6.5 Reporter: Matteo Pelucco Assignee: Boris Kraft Priority: Minor Fix For: 4.3.x A nice-to-have feature is the FCK spell checking capability, native on fck 2.6.4 with support of online service SpellChecker http://dev.fckeditor.net/ticket/2685 (It is free, but the free version displays a banner space while the spell check dialog is open). Maybe with EE edition can be found commercial agreements to remove the banner, I don't know... There are other possibilities to integrate spell checking with FCK: see http://docs.fckeditor.net/FCKeditor_2.x/Developers_Guide/Configuration/Spell_Checker. I suggest also to consider the new FCK 3.0, near to stable release (Beta 2 out at time of writing). It is not on 2.6.x series, but as far as I know there won't be huge limitation on porting Magnolia FCK integration over 3.0 release of FCK. Sure native spell check can be a good feature for marketing! ;-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1968) MgnlUserManager.getAllUsers doesn't return any users
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1968: -- Fix Version/s: 4.3.x (was: 4.3.2) MgnlUserManager.getAllUsers doesn't return any users Key: MAGNOLIA-1968 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1968 Project: Magnolia Issue Type: Bug Components: security Reporter: Capitaine Harold Assignee: Grégory Joseph Fix For: 4.3.x Attachments: patch.txt I think that the function MgnlUserManager.getAllUsers was created before realm and hasn't been refreshed since this time. See the the patch in attachment for the new method that returns all users from all realms. HTH -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2586) Cleanup default log configuration
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2586: -- Fix Version/s: 4.3.x (was: 4.3.2) Cleanup default log configuration - Key: MAGNOLIA-2586 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2586 Project: Magnolia Issue Type: Task Components: build, core Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x While working on MAGNOLIA-1760, I noticed and would like to understand why we need so many different files (appenders) and custom categories - I suspect the current configuration doesn't fulfill the actual use-cases. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1789) freemarker: remove usage of ${contextPath}
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1789: -- Fix Version/s: 4.3.x (was: 4.3.2) freemarker: remove usage of ${contextPath} -- Key: MAGNOLIA-1789 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1789 Project: Magnolia Issue Type: Task Components: admininterface Affects Versions: 3.5 RC1 Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x .. since the whole Context instance is now available, we should replace this by ${ctx.contextPath} in templates, and remove contextPath from the freemarker data model. Maybe we should also move defaultBaseUrl to the Context (to avoid having too maybe different variables in the freemarker context; making it simpler to document: the Context instance is available as ${ctx}) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2718) Configuration for uriSecurityFilter and contentSecurityFilter is redundant
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2718: -- Fix Version/s: 4.3.x (was: 4.3.2) Configuration for uriSecurityFilter and contentSecurityFilter is redundant -- Key: MAGNOLIA-2718 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2718 Project: Magnolia Issue Type: Improvement Components: core, security Reporter: Grégory Joseph Assignee: Philipp Bärfuss Fix For: 4.3.x I suppose there isn't a usecase where those two filters should have different clientCallbacks. I'm not sure what the best way to go around this would be; either moving the clientCallbacks somewhere else, outside the filters, or at least by default have one of the two reference the other ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2589) Remap different possible url to the same while accessing the page
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2589: -- Fix Version/s: 4.3.x (was: 4.3.2) Remap different possible url to the same while accessing the page - Key: MAGNOLIA-2589 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2589 Project: Magnolia Issue Type: Improvement Affects Versions: 4.0 Reporter: Jan Haderka Assignee: Boris Kraft Fix For: 4.3.x Currently one page can be accessed in multiple different ways, i.e.: * http://www.magnolia.info/en/products/enterprise * http://www.magnolia.info/en/products/enterprise/ * http://www.magnolia.info/en/products/enterprise.html For SEO it would be better if first two cases are re-mapped to the third. The second case can be mapped using VirtualURIMapping {code} class=i.m.cms.beans.config.RegexpVirtualURIMapping fromURI=/(.*)/$ toURI=redirect:/#1.html {code} Solving the first case using VirtualURIMapping would require mapper inteligent enough to parse the url, figure out if there are any query params. Something along lines of {code} class=i.m.cms.beans.config.RegexpVirtualURIMapping fromURI=/(.*[^'.html'])(\\?)(.*) toURI=redirect:/$1.html$2$3 {code} and for requests without any query params: {code} class=i.m.cms.beans.config.RegexpVirtualURIMapping fromURI=/([^\\?]*)$ toURI=redirect:/$1.html {code} Or possibly combination of the two patterns above into one covering both cases - w/ and w/o query params. However since default extension can be configured in admin interface, this mapping should be smart enough to use the default extension rather then blindly mapping everything to html. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1947) MgnlUserManager does not take realm into account in method getAllUsers()
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1947: -- Fix Version/s: 4.3.x (was: 4.3.2) MgnlUserManager does not take realm into account in method getAllUsers() Key: MAGNOLIA-1947 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1947 Project: Magnolia Issue Type: Bug Components: core, security Affects Versions: 3.5 RC3 Reporter: Vivian Steller Assignee: Grégory Joseph Fix For: 4.3.x current implementation only loops over root node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2629) message for username / PW failure should be corrected
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2629: -- Fix Version/s: 4.3.x (was: 4.3.2) message for username / PW failure should be corrected - Key: MAGNOLIA-2629 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2629 Project: Magnolia Issue Type: Bug Reporter: Boris Kraft Assignee: Boris Kraft Fix For: 4.3.x Attachments: Picture 15.png Currently if you mistype your password when logging into Magnolia, a message is displayed saying: username and password do not match. Of course the username and password should not be the same, in other words, they *should not match*. Please correct the message to simply say Wrong username and password combination -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1631) Warn user when installing snapshot versions
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1631: -- Fix Version/s: 4.3.x (was: 4.3.2) Warn user when installing snapshot versions --- Key: MAGNOLIA-1631 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1631 Project: Magnolia Issue Type: Sub-task Components: updatemechanism Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x Need to check how updating from 3.1-SNAPSHOT or 3.1-M2 to 3.1 (final) behaves. Ideally, it should allow doing some updatings or checks... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2891) Sub Templates configuration needs to be reviewed
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2891: -- Fix Version/s: 4.3.x (was: 4.3.2) Sub Templates configuration needs to be reviewed Key: MAGNOLIA-2891 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2891 Project: Magnolia Issue Type: Bug Components: templating Affects Versions: 4.1.1 Environment: Mac OS X 10.5.8, FF 3, Tomcat 5.5.27 Reporter: Giancarlo Berner Assignee: Philipp Bärfuss Fix For: 4.3.x The sub template configuration works only under very specific conditions. The way it is described in http://documentation.magnolia-cms.com/templating-guide.html it will not work and if it does, it's more of a coincident then a logical configuration. To make the sub template configuration work, you have to follow these rules: a) The sub template child node identifier has to have exactly the same name as the value in the extension property. /subTemplates /testing extension -- testing templatePath -- /templates/myproject/templates/sub/somescript.jsp a different node name than extension will not work. In fact, Magnolia does not even recognize there is a sub template. b) You are obliged to add the type property. Without the type property the rendering will not work, even if you have the same sub template node identifier as the extension value. If type is not set, you will get a status 500 error: java.lang.RuntimeException: java.lang.RuntimeException: No renderer found for type null info.magnolia.module.templating.RenderingFilter.doFilter(RenderingFilter.java:119) info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:70) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) info.magnolia.cms.filters.BackwardCompatibilityFilter.doFilter(BackwardCompatibilityFilter.java:72) info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:62) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) info.magnolia.cms.filters.InterceptFilter.doFilter(InterceptFilter.java:121) info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:70) info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) info.magnolia.cms.filters.AggregatorFilter.doFilter(AggregatorFilter.java:103) So the correct sub template is: /subTemplates /testing extension -- testing templatePath -- /templates/myproject/templates/sub/somescript.jsp type -- jsp I don't think this is a wanted functionality, since it is not an intuitive configuration. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2668) CE startup - success message should be shown without logging in
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2668: -- Fix Version/s: 4.3.x (was: 4.3.2) CE startup - success message should be shown without logging in --- Key: MAGNOLIA-2668 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2668 Project: Magnolia Issue Type: Improvement Affects Versions: 4.0.1 Reporter: Boris Kraft Assignee: Boris Kraft Fix For: 4.3.x Currently, if you install Magnolia CE, then go to http://localhost:8080/magnoliaAuthor/ you need to login, and then the success screen is displayed with the options to download STK. I suggest to change that process such that the success message is shown instead of the login screen. From a user perspective it makes no sense that a user has to login to see that he needs to install templates (at which point he has to restart the app anyways, which means the login was in vain). If it makes sense, add a link to the success screen that allows to login (in case someone needs to add users before he adds templates; or uses the DMS only?) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1554) 'Current user indicator not refreshed after logging in to AdminCentral
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1554: -- Fix Version/s: 4.3.x (was: 4.3.2) 'Current user indicator not refreshed after logging in to AdminCentral --- Key: MAGNOLIA-1554 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1554 Project: Magnolia Issue Type: Bug Reporter: Amir Mistric Assignee: Boris Kraft Fix For: 4.3.x If you let your AdminCentral session expire and then log in as a different user AdminCentral still shows previous user's id next to the logout link. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1948) Use UserManager to send mails to groups/roles with MgnlMailFactory
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1948: -- Fix Version/s: 4.3.x (was: 4.3.2) Use UserManager to send mails to groups/roles with MgnlMailFactory -- Key: MAGNOLIA-1948 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1948 Project: Magnolia Issue Type: Bug Components: mail, workflow Affects Versions: 3.5 RC3 Reporter: Vivian Steller Assignee: Grégory Joseph Fix For: 4.3.x see MgnlMailFactory line 378+. Note that it should use UserManager. This is the case since we introduced realms. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2600) Check exception handling in AuditLoggingUtil
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2600: -- Fix Version/s: 4.3.x (was: 4.3.2) Check exception handling in AuditLoggingUtil Key: MAGNOLIA-2600 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2600 Project: Magnolia Issue Type: Task Affects Versions: 4.0 Reporter: Jan Haderka Assignee: Boris Kraft Fix For: 4.3.x Currently when attempting to obtain user name, if exception occurs, it is assumed system user is in charge. Check why exception should/can be thrown there and document such cases if they can't be avoided otherwise. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-1564) Accessing a page without proper extension should return 404 error
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-1564: -- Fix Version/s: 4.3.x (was: 4.3.2) Accessing a page without proper extension should return 404 error - Key: MAGNOLIA-1564 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-1564 Project: Magnolia Issue Type: Improvement Components: core, templating Environment: 3.1-SNAPSHOT JBoss 4.0.5GA Reporter: Amir Mistric Assignee: Boris Kraft Priority: Minor Fix For: 4.3.x Since there was some discussion on the dev list regarding this (see http://webmail.magnolia.info/Lists/dev-list/Message/10155.html) I thought it would be prudent to report it. Problem: Accessing a page without proper extension does not return a 404 - Page not found error http://server.company.org/magnoliaPublic/www/doesnotexist/page1.html (404 - not found) http://server.company.org/magnoliaPublic/www/page1 (found !) http://server.company.org/magnoliaPublic/www/page1.doesnotexist (found !) http://server.company.org/magnoliaPublic/www/page1.whatever (found !) The behaviour should be consistent and only cetrain extensions should be valid (perhaps default server extension and defined subtemplates) As you can see in the list thread this may not be easy to accomplish... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2711) Failure to resolve class when finishing installation leads to 404 page being displayed after installation
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2711: -- Fix Version/s: 4.3.x (was: 4.3.2) Failure to resolve class when finishing installation leads to 404 page being displayed after installation - Key: MAGNOLIA-2711 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2711 Project: Magnolia Issue Type: Bug Components: updatemechanism Affects Versions: 4.0.1 Reporter: Jan Haderka Assignee: Grégory Joseph Fix For: 4.3.x Attachments: stacktrace.txt Stacktrace attached. Hitting the back button and clicking on Start Magnolia button again leads to admin interface being displayed (on author) as expected. The exception in UI appears most likely because initialization is not finished yet. We should either postpone those or make sure some better page is displayed then default tomcat's 404. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2609) new style for buttons
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2609: -- Fix Version/s: 4.3.x (was: 4.3.2) new style for buttons - Key: MAGNOLIA-2609 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2609 Project: Magnolia Issue Type: Improvement Components: admininterface Affects Versions: 4.0 Reporter: Fabrizio Giustina Assignee: Fabrizio Giustina Priority: Trivial Fix For: 4.3.x Attachments: buttons.png new css for rounded buttons, as shown in the attached screenshot -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2929) Enhance unicode support
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2929: -- Fix Version/s: 4.3.x (was: 4.3.2) Enhance unicode support --- Key: MAGNOLIA-2929 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2929 Project: Magnolia Issue Type: Improvement Components: core Reporter: Grégory Joseph Assignee: Grégory Joseph Fix For: 4.3.x In light of MGNLWEBDAV-15, we need Magnolia to be a little more lax with unicode names. There are two sides to this issue: * the current {{SimpleUrlPattern}} implementation chokes on paths with unicode characters in the decomposed form. * Jackrabbit does no unicode normalization for node names, thus a node created with a name in the composed form can not be retrieved by using the decomposed form of the exact same name. Since clients tend to use one or the other form arbitrarily (Firefox 3.0 on MacOSX sends GET parameters in the NFD form, Safari in NFC; while the Linux OS tends to favor NFC and OSX tends to favor NFD, for instance). Node name normalization unfortunately requires using either Java 6 ([{{java.text.Normalizer}}|http://java.sun.com/javase/6/docs/api/java/text/Normalizer.html]), the [ICU4J library|http://www.icu-project.org/]; there might be other implementations out there, so we should leave the option open to swap for another one. See http://en.wikipedia.org/wiki/Unicode_equivalence#Normal_forms for background information. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2585) Improve config info page
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2585: -- Fix Version/s: 4.3.x (was: 4.3.2) Improve config info page Key: MAGNOLIA-2585 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2585 Project: Magnolia Issue Type: Improvement Components: admininterface, core Reporter: Grégory Joseph Assignee: Philipp Bärfuss Priority: Minor Fix For: 4.3.x The config info page could use some improvements: * ordering of properties * displaying some more relevant information (installed modules, versions, etc) * a minimally better layout ... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-2565) Support multiple lines content in Tree
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-2565: -- Fix Version/s: 4.3.x (was: 4.3.2) Support multiple lines content in Tree -- Key: MAGNOLIA-2565 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2565 Project: Magnolia Issue Type: Improvement Components: admininterface, gui Reporter: Grégory Joseph Assignee: Boris Kraft Fix For: 4.3.x Currently, our tree edition only displays one single line of text, and looses subsequent lines when saving. In the case of multiple lines of text, we could maybe popup a textarea element instead. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com