[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ilgun Ilgun updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Ilgun Ilgun h3. Description When validation of a field placed inside a composite field fails notifications are not working correctly. * Use-case 1 * - field with validator configured under composite field:- when validation fails dialog is not saved and displays the generic error on top but user is not notified at concrete field with the specific error message. * Use-case 2 * - required field without validator configured under composite field:- correct message is displayed ("This field is required.") but is tied to the composite field, not the concrete inner field. * Use-case 3 * - required field with validator configured under composite field:- if the field was blank before and validation failed, error message for required field missing ("This field is required.") is displayed. Same as in use-case 2 it's tied to whole composite field.- if the field was not blank the same behavior as in use-case 1 will occur.Correct behavior - error messages should be displayed under concrete fields and not be covered by required files missing message. * Use-case 4 * - making changes on the select field (which is part of composite field) caused the below exceptionSee more in video: https://jira.magnolia-cms.com/secure/attachment/32694/SelectFieldValidation.webm{code}2016-03-17 10:59:08,524 ERROR .magnolia.ui.admincentral.AdmincentralErrorHandler: AdmincentralUI has encountered an unhandled exception.com.vaadin.data.Validator$InvalidValueException: Country is requiredat com.vaadin.data.validator.AbstractValidator.validate(AbstractValidator.java:103)at com.vaadin.ui.AbstractField.validate(AbstractField.java:969)at com.vaadin.ui.AbstractField.setValue(AbstractField.java:499)at com.vaadin.ui.AbstractSelect.setValue(AbstractSelect.java:709)at com.vaadin.ui.ComboBox.changeVariables(ComboBox.java:674)at com.vaadin.server.communication.ServerRpcHandler.changeVariables(ServerRpcHandler.java:486)at com.vaadin.server.communication.ServerRpcHandler.handleInvocations(ServerRpcHandler.java:305)at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:184)at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:92)at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:41)at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1408)at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:350)at info.magnolia.ui.admincentral.AdmincentralVaadinServlet.service(AdmincentralVaadinServlet.java:131)at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:148)at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85)at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79){code}Included file contains simple composite field configuration. * Use-case 5 * - switchable field with two inner required fields - the error is thrown dialog wide, hiding what's missing actually. Only rerendering the dialog causes the error message to be propagated to given field. h3. Findings
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ilgun Ilgun updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Ilgun Ilgun h3. DescriptionWhen validation of a field placed inside a composite field fails notifications are not working correctly.*Use-case 1* - field with validator configured under composite field:- when validation fails dialog is not saved and displays the generic error on top but user is not notified at concrete field with the specific error message.*Use-case 2* - required field without validator configured under composite field:- correct message is displayed ("This field is required.") but is tied to the composite field, not the concrete inner field.*Use-case 3 *- required field with validator configured under composite field:- if the field was blank before and validation failed, error message for required field missing ("This field is required.") is displayed. Same as in use-case 2 it's tied to whole composite field.- if the field was not blank the same behavior as in use-case 1 will occur.Correct behavior - error messages should be displayed under concrete fields and not be covered by required files missing message.*Use-case 4* - making changes on the select field (which is part of composite field) caused the below exceptionSee more in video: https://jira.magnolia-cms.com/secure/attachment/32694/SelectFieldValidation.webm{code}2016-03-17 10:59:08,524 ERROR .magnolia.ui.admincentral.AdmincentralErrorHandler: AdmincentralUI has encountered an unhandled exception.com.vaadin.data.Validator$InvalidValueException: Country is requiredat com.vaadin.data.validator.AbstractValidator.validate(AbstractValidator.java:103)at com.vaadin.ui.AbstractField.validate(AbstractField.java:969)at com.vaadin.ui.AbstractField.setValue(AbstractField.java:499)at com.vaadin.ui.AbstractSelect.setValue(AbstractSelect.java:709)at com.vaadin.ui.ComboBox.changeVariables(ComboBox.java:674)at com.vaadin.server.communication.ServerRpcHandler.changeVariables(ServerRpcHandler.java:486)at com.vaadin.server.communication.ServerRpcHandler.handleInvocations(ServerRpcHandler.java:305)at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:184)at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:92)at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:41)at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1408)at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:350)at info.magnolia.ui.admincentral.AdmincentralVaadinServlet.service(AdmincentralVaadinServlet.java:131)at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:148)at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85)at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79){code}Included file contains simple composite field configuration.*Use-case 5 *- switchable field with two inner required fields - the error is thrown dialog wide, hiding what's missing actually. Only rerendering the dialog causes the error message to be propagated to given field.h3. Findings
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ilgun Ilgun updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Ilgun Ilgun Assignee: Aleksandr Pchelintcev Ilgun Ilgun Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Michael Mühlebach updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Michael Mühlebach Assignee: Aleksandr Pchelintcev Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Antti Hietala updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Antti Hietala Affects Version/s: 5.3.14 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Michael Mühlebach updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Michael Mühlebach Sprint: Basel 38 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Michael Mühlebach updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Michael Mühlebach Sprint: Basel 37 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Michael Mühlebach updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Michael Mühlebach Sprint: Basel 37 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Zdenek Skodik updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Zdenek Skodik Support Score: Account: When validation of a field placed inside a composite field fails notifications are not working correctly.Use-case 1 - field with validator configured under composite field:- when validation fails dialog is not saved and displays the generic error on top but user is not notified at concrete field with the specific error message.Use-case 2 - required field without validator configured under composite field:- correct message is displayed ("This field is required.") but is tied to the composite field, not the concrete inner field.Use-case 3 - required field with validator configured under composite field:- if the field was blank before and validation failed, error message for required field missing ("This field is required.") is displayed. Same as in use-case 2 it's tied to whole composite field.- if the field was not blank the same behavior as in use-case 1 will occur.Correct behavior - error messages should be displayed under concrete fields and not be covered by required files missing message.Use-case 4 - making changes on the select field (which is part of composite field) caused the below exceptionSee more in video: https://jira.magnolia-cms.com/secure/attachment/32694/SelectFieldValidation.webm{code}2016-03-17 10:59:08,524 ERROR .magnolia.ui.admincentral.AdmincentralErrorHandler: AdmincentralUI has encountered an unhandled exception.com.vaadin.data.Validator$InvalidValueException: Country is requiredat com.vaadin.data.validator.AbstractValidator.validate(AbstractValidator.java:103)at com.vaadin.ui.AbstractField.validate(AbstractField.java:969)at com.vaadin.ui.AbstractField.setValue(AbstractField.java:499)at com.vaadin.ui.AbstractSelect.setValue(AbstractSelect.java:709)at com.vaadin.ui.ComboBox.changeVariables(ComboBox.java:674)at com.vaadin.server.communication.ServerRpcHandler.changeVariables(ServerRpcHandler.java:486)at com.vaadin.server.communication.ServerRpcHandler.handleInvocations(ServerRpcHandler.java:305)at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:184)at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:92)at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:41)at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1408)at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:350)at info.magnolia.ui.admincentral.AdmincentralVaadinServlet.service(AdmincentralVaadinServlet.java:131)at
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ervín Výstup updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Ervín Výstup Support Score: Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ervín Výstup updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Ervín Výstup When validation of a field placed inside a composite field fails notifications are not working correctly.Use-case 1 - field with validator configured under composite field:- when validation fails dialog is not saved and displays the generic error on top but user is not notified at concrete field with the specific error message.Use-case 2 - required field without validator configured under composite field:- correct message is displayed ("This field is required.") but is tied to the composite field, not the concrete inner field.Use-case 3 - required field with validator configured under composite field:- if the field was blank before and validation failed, error message for required field missing ("This field is required.") is displayed. Same as in use-case 2 it's tied to whole composite field.- if the field was not blank the same behavior as in use-case 1 will occur.Correct behavior - error messages should be displayed under concrete fields and not be covered by required files missing message. Use-case 4 - making changes on the select field (which is part of composite field) caused the below exceptionSee more in video: https://jira.magnolia-cms.com/secure/attachment/32694/SelectFieldValidation.webm{code}2016-03-17 10:59:08,524 ERROR .magnolia.ui.admincentral.AdmincentralErrorHandler: AdmincentralUI has encountered an unhandled exception.com.vaadin.data.Validator$InvalidValueException: Country is requiredat com.vaadin.data.validator.AbstractValidator.validate(AbstractValidator.java:103)at com.vaadin.ui.AbstractField.validate(AbstractField.java:969)at com.vaadin.ui.AbstractField.setValue(AbstractField.java:499)at com.vaadin.ui.AbstractSelect.setValue(AbstractSelect.java:709)at com.vaadin.ui.ComboBox.changeVariables(ComboBox.java:674)at com.vaadin.server.communication.ServerRpcHandler.changeVariables(ServerRpcHandler.java:486)at com.vaadin.server.communication.ServerRpcHandler.handleInvocations(ServerRpcHandler.java:305)at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:184)at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:92)at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:41)at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1408)at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:350)at info.magnolia.ui.admincentral.AdmincentralVaadinServlet.service(AdmincentralVaadinServlet.java:131)at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:148)at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:85)at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:79){code} Included file contains simple composite field configuration.
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Michael Mühlebach updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Michael Mühlebach Sprint: Basel 36 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Michael Mühlebach updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Michael Mühlebach Story Points: 2 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Michael Mühlebach updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Michael Mühlebach Sprint: Basel 36 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ondrej Chytil updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Ondrej Chytil Support Score: Labels: support Account: Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ondrej Chytil updated an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Change By: Ondrej Chytil When validation of a field placed inside a composite field fails notifications are not working correctly. Use-case 1 - field with validator configured under composite field:- when validation fails dialog is not saved and displays the generic error on top but user is not notified at concrete field with the specific error message.Use-case 2 - required field without validator configured under composite field:- correct message is displayed ("This field is required.") but is tied to the composite field, not the concrete inner field.Use-case 3 - required field with validator configured under composite field:- if the field was blank before and validation failed, error message for required field missing ("This field is required.") is displayed. Same as in use-case 2 it's tied to whole composite field.- if the field was not blank the same behavior as in use-case 1 will occur.Correct behavior - error messages should be displayed under concrete fields and not be covered by required files missing message.Included file contains simple composite field configuration. Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3793) Improve notification of validation errors in composite fields
Title: Message Title Ondrej Chytil created an issue Magnolia UI / MGNLUI-3793 Improve notification of validation errors in composite fields Issue Type: Bug Affects Versions: 5.4.4 Assignee: Unassigned Attachments: config.modules.contacts.apps.contacts.subApps.detail.editor.form.tabs.personal.fields.rewardUrl.xml Components: dialogs Created: 01/Mar/16 10:38 PM Priority: Neutral Reporter: Ondrej Chytil Security Level: Public When validation of a field placed inside a composite field fails notifications are not working correctly. Use-case 1 - field with validator configured under composite field: