[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Jan Haderka)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Jan Haderka updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Jan Haderka 
 
 
 
 
 
 
 
 
 
 Commercial at (@) is  currently  forbidden character in node name.  Forbidden by Magnolia that is, for historical reasons, see more at  https://documentation.magnolia-cms.com/display/DOCS/Managing+pages#Managingpages-Invalidcharacters .   Apps should not allow to create nodes with @ in name except the {{user}} subapp.* AddNodeAction action should validate label name and not create node with invalid name* SaveRoleDialogAction should create roles with valid node names* JcrContentConnector should not fail on NPE when node contains @* JcrContentConnector duplicates method from JcrItemUtil 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[on behalf of Mikaël Geljić]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Mikaël Geljić reopened an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
Hi Milan, 
I agree, users can still be created with @ in node name. I was mislead by the change in AddNodeActionTest, see for yourself: 

 

@Test
public void doesNotCreateNodeWithInvalidName() throws Exception {
...
definition.setBaseName("p...@pepa.cz");
AddNodeAction action = "" class="code-keyword" style="color: #91">new AddNodeAction(definition, new JcrNodeAdapter(root), eventBus);
...
assertAddedNewNode(root, "pepa-pepa.cz", NodeTypes.Content.NAME, nodeCountBefore + 1);
}
 

 
However, few things which do still bother me: 
1. I have no idea what the above *concretely* fixes. 
 

Using an email address as baseName sounds hardly realistic
 

We never configure the baseName either, as far as demo can tell (and fallback is "untitled"); yet even if some silly guys want to do that, why shouldn't they? (more on that below)
 
 
2. Claim that @ is "invalid" is invalid 
 

gotta love self-referencing our own docu without the rationale
 

this was only done for pages, or any content eventually mapped to URIs, just as Zdenek originally pointed out
 

as per that famous URL RFC 3986, an @ may be used in the authority component of the URI: [user-info@]host[:port]. Disclaimer: as this doesn't even apply to the path component, I'm even beginning to question why do it, but nevermind this one.
 

Yet NO, it does not apply to fragments either.
 
 
Quoting Zdenek again: 
 
commercial at is a reserved char by URL specification
 
—This is correct per se. However terminology of character categories is highly important; reserved does not mean invalid, it simply defines an arbitrary range of characters, for reference in other component definitions. The reserved category is not part of the definition of the fragment URI component.  
If you doubt this, here's the relevant chunk of the URI ABNF, mind the @ within the pchar def: 

 
unreserved= ALPHA / DIGIT / "-" / "." / "_" / "~"
pct-encoded   = "%" HEXDIG HEXDIG
sub-delims= "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "="
pchar = unreserved / pct-encoded / sub-delims / ":" / "@"
fragment  = *( pchar / "/" / "?" )
 

 
3. I agree 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Milan Divilek)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Milan Divilek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Milan Divilek 
 
 
 
 
 
 
 
 
 
 Commercial at (@) is forbidden character in node name. https://documentation.magnolia-cms.com/display/DOCS/Managing+pages#Managingpages-InvalidcharactersApps should not allow to create nodes with @ in name except the {{user}} subapp.* AddNodeAction action should validate label name and not create node with invalid name*  Save role dialog action  SaveRoleDialogAction  should  create roles with valid node names* JcrContentConnector should  not  abuse   fail on NPE when node contains @* JcrContentConnector duplicates method from JcrItemUtil 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Milan Divilek)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Milan Divilek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Milan Divilek 
 
 
 
 
 
 
 
 
 
 Commercial at (@) is forbidden character in node name. https://documentation.magnolia-cms.com/display/DOCS/Managing+pages#Managingpages-InvalidcharactersApps should not allow to create nodes with @ in name except the {{user}} subapp. * AddNodeAction action should validate label name and not create node with invalid name* Save role dialog action should not abuse  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Milan Divilek)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Milan Divilek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Milan Divilek 
 
 
 
 
 
 
 
 
 
 Commercial at (@) is forbidden character in node name. https://documentation.magnolia-cms.com/display/DOCS/Managing+pages#Managingpages-InvalidcharactersApps should not allow to create nodes with @ in name except the {{user}} subapp.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[on behalf of Mikaël Geljić]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Mikaël Geljić reopened an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Mikaël Geljić 
 
 
 

Resolution:
 
 Fixed 
 
 
 

Status:
 
 Resolved Reopened 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Milan Divilek)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Milan Divilek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Milan Divilek 
 
 
 
 
 
 
 
 
 
 E Commercial at (@) is forbidden character in node name . g  https://documentation .  security app which brings various consequences, e magnolia-cms . g. Pulse can't present a message sent com/display/DOCS/Managing+pages#Managingpages-InvalidcharactersApps should not allow  to  user  create nodes  with  such a char  @  in name  except the {{user}} subapp . 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Milan Divilek)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Milan Divilek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Milan Divilek 
 
 
 
 
 
 
 
 
 
  E.g. security app which brings various consequences, e.g. Pulse can't present a message sent to user with such a char in name. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[on behalf of Roman Kovařík]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Roman Kovařík updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Roman Kovařík 
 
 
 

Sprint:
 
 Kromeriz  50  51 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Milan Divilek)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Milan Divilek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Milan Divilek 
 
 
 

Labels:
 
 blocked  devwl support 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[on behalf of Roman Kovařík]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Roman Kovařík updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Roman Kovařík 
 
 
 

Sprint:
 
 Kromeriz  49  50 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Milan Divilek)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Milan Divilek updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Milan Divilek 
 
 
 

Labels:
 
 blocked devwl support 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Jan Haderka)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Jan Haderka updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Jan Haderka 
 
 
 

Assignee:
 
 Milan Divilek 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Jan Haderka)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Jan Haderka updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Jan Haderka 
 
 
 

Story Points:
 
 8 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[on behalf of Michael Mühlebach]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Michael Mühlebach updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Michael Mühlebach 
 
 
 

Sprint:
 
 Kromeriz 49 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[on behalf of Michael Mühlebach]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Michael Mühlebach updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Change By:
 
 Michael Mühlebach 
 
 
 

Fix Version/s:
 
 5.4.8 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-3863) Most apps allow you to create nodes with invalid characters, such as commercial at (@)

[JIRA (on behalf of Zdenek Skodik)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Zdenek Skodik created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3863 
 
 
 
  Most apps allow you to create nodes with invalid characters, such as commercial at (@)  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 27/Apr/16 11:56 AM 
 
 
 

Labels:
 

 support 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Zdenek Skodik 
 
 
 

Security Level:
 

 Public 
 
 
 
 
 
 
 
 
 
 
E.g. security app which brings various consequences, e.g. Pulse can't present a message sent to user with such a char in name. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment