Re: About static analyzers on some various projects

[Ehsan Akhgari]

On 2015-09-25 7:35 PM, Robert O'Callahan wrote:

On Sat, Sep 26, 2015 at 7:34 AM, Ehsan Akhgari > wrote:

On 2015-09-25 12:01 PM, Justin Dolske wrote:

At Mozilla, it seems like previous discussions on this kind of thing
(style and warnings come to mind) have dealt with this at a
file/directory/module level... Someone fixes up a thing
completely, adds
it to a whitelist, and then it's a simple pass/fail. Could that work
here too?


Yes, that is another option for checks that tons of existing code
don't pass.


That'll help some.

The problem of attributing new errors to the correct part of the diff
remains, and is quite interesting.


FWIW based on an in-person discussion with gps last week, it seems like 
MozReview's static analysis support is built for cheap analyses that do 
not need to invoke the build system, so C++ analysis will probably not 
be integrated with MozReview (at least not any time soon), so we're 
going to need to rely on try pushes any way.


I'm working on extending our C++ static analysis coverage so I hope to 
make it much more difficult for something to get past the checks on 
various platforms in the future.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: About static analyzers on some various projects

[Ehsan Akhgari]

Thanks!  I submitted fixes for a number of these.

On 2015-09-27 2:29 PM, Jörg Knobloch wrote:

This showed up on the Thunderbird development mailing list:


Hi.
I want to inform you that Thunderbird was checked by PVS-Studio (static
analyzer of C/C++ code). You can find summary of the check here
. There is one false alarm as well as
author's mistake (getenv warning), it will be fixed.
Best regards, Igor Shtukarev.


Click the link and you'll be surprised.
Some (or most) of the errors are actually in M-C code.
I didn't check them all, but here are some beauties:

http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/nsHTMLEditRules.cpp#7392

http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/src/mozSpellI18NManager.cpp#31

http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/nsWindowsRegKey.cpp#313

http://mxr.mozilla.org/mozilla-central/source/accessible/windows/sdn/sdnAccessible.cpp#223


Jorg K.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform