Re: Linux builds now default to -O2 instead of -Os

[jmaher]

On Tuesday, June 6, 2017 at 3:17:20 PM UTC-4, Ben Kelly wrote:
> On Tue, Jun 6, 2017 at 3:07 PM, Chris Peterson 
> wrote:
> 
> > On 6/6/17 10:33 AM, Boris Zbarsky wrote:
> >
> >> On 6/1/17 9:04 PM, Mike Hommey wrote:
> >>
> >>> Ah, forgot to mention that. No, it doesn't affect *our* shipped builds
> >>> (because PGO uses a different set of optimization flags).
> >>>
> >>> But it does affect downstream builds that don't PGO.
> >>>
> >>
> >> Based on the jump I see on June 2 at https://treeherder.mozilla.org
> >> /perf.html#/graphs?timerange=2592000&series=%5Bmozilla-
> >> central,80984697abf1f1ff2b058e2d9f0b351fd9d12ad9,1,1%5D&
> >> series=%5Bmozilla-central,ae68c64ef8bfa104fded89971f1c2c6c90
> >> 926dca,1,1%5D&series=%5Bmozilla-central,dd55da63ebce86ee3867
> >> aa3b39975c2a90869ce2,1,1%5D it affects some of our talos tests too (the
> >> ones running on non-pgo).
> >>
> >
> > We stopped Talos testing of non-e10s builds on May 14, but it looks like
> > we also stopped testing Linux PGO builds on May 15. Is that expected?
> >
> 
> Why did we stop talos testing non-e10s?  Firefox for android is a tier 1
> platform (right?) and uses non-e10s.  Do we have separate fennec talos
> tests somewhere?

We disabled non-e10s talos as we needed bandwidth on our physical hardware to 
standup new tests (web extensions, quantum pageload with https/mitmproxy).

Android is done on Autophone, that is 100% separate and we log the data to 
perfherder (2 regressions were triaged today!)

As for linux64-pgo not having talos data, that was an accident and I filed: 
https://bugzilla.mozilla.org/show_bug.cgi?id=1370663.  Hopefully we can have 
that resolved.  Our focus has been on Windows, so linux/osx has been neglected 
when it comes to the fine tooth comb.  Thanks for bringing this up.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Linux builds now default to -O2 instead of -Os

[Ben Kelly]

On Tue, Jun 6, 2017 at 3:07 PM, Chris Peterson 
wrote:

> On 6/6/17 10:33 AM, Boris Zbarsky wrote:
>
>> On 6/1/17 9:04 PM, Mike Hommey wrote:
>>
>>> Ah, forgot to mention that. No, it doesn't affect *our* shipped builds
>>> (because PGO uses a different set of optimization flags).
>>>
>>> But it does affect downstream builds that don't PGO.
>>>
>>
>> Based on the jump I see on June 2 at https://treeherder.mozilla.org
>> /perf.html#/graphs?timerange=2592000&series=%5Bmozilla-
>> central,80984697abf1f1ff2b058e2d9f0b351fd9d12ad9,1,1%5D&
>> series=%5Bmozilla-central,ae68c64ef8bfa104fded89971f1c2c6c90
>> 926dca,1,1%5D&series=%5Bmozilla-central,dd55da63ebce86ee3867
>> aa3b39975c2a90869ce2,1,1%5D it affects some of our talos tests too (the
>> ones running on non-pgo).
>>
>
> We stopped Talos testing of non-e10s builds on May 14, but it looks like
> we also stopped testing Linux PGO builds on May 15. Is that expected?
>

Why did we stop talos testing non-e10s?  Firefox for android is a tier 1
platform (right?) and uses non-e10s.  Do we have separate fennec talos
tests somewhere?
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Linux builds now default to -O2 instead of -Os

[Chris Peterson]

On 6/6/17 10:33 AM, Boris Zbarsky wrote:

On 6/1/17 9:04 PM, Mike Hommey wrote:

Ah, forgot to mention that. No, it doesn't affect *our* shipped builds
(because PGO uses a different set of optimization flags).

But it does affect downstream builds that don't PGO.


Based on the jump I see on June 2 at 
https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=%5Bmozilla-central,80984697abf1f1ff2b058e2d9f0b351fd9d12ad9,1,1%5D&series=%5Bmozilla-central,ae68c64ef8bfa104fded89971f1c2c6c90926dca,1,1%5D&series=%5Bmozilla-central,dd55da63ebce86ee3867aa3b39975c2a90869ce2,1,1%5D 
it affects some of our talos tests too (the ones running on non-pgo).


We stopped Talos testing of non-e10s builds on May 14, but it looks like 
we also stopped testing Linux PGO builds on May 15. Is that expected?


https://treeherder.mozilla.org/perf.html#/graphs?timerange=5184000&series=%5Bmozilla-central,80984697abf1f1ff2b058e2d9f0b351fd9d12ad9,1,1%5D&series=%5Bmozilla-central,f9422672456ec36723cc69e64c10e02cda9dd30f,1,1%5D&series=%5Bmozilla-central,ff2723032e6bee08807c0d0b082c8c6af3dca6f5,1,1%5D&series=%5Bmozilla-central,00ab9f9f9241a67f9bfc376910ff8beb2fc0f8d1,1,1%5D&selected=%5Bmozilla-central,f9422672456ec36723cc69e64c10e02cda9dd30f,204160,273383568,1%5D
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Linux builds now default to -O2 instead of -Os

[William Lachance]

On 2017-06-06 1:33 PM, Boris Zbarsky wrote:

On 6/1/17 9:04 PM, Mike Hommey wrote:

Ah, forgot to mention that. No, it doesn't affect *our* shipped builds
(because PGO uses a different set of optimization flags).

But it does affect downstream builds that don't PGO.


Based on the jump I see on June 2 at
https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=%5Bmozilla-central,80984697abf1f1ff2b058e2d9f0b351fd9d12ad9,1,1%5D&series=%5Bmozilla-central,ae68c64ef8bfa104fded89971f1c2c6c90926dca,1,1%5D&series=%5Bmozilla-central,dd55da63ebce86ee3867aa3b39975c2a90869ce2,1,1%5D
it affects some of our talos tests too (the ones running on non-pgo).


You can see the full set of talos changes here:

https://treeherder.mozilla.org/perf.html#/alerts?id=7009

Will

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Linux builds now default to -O2 instead of -Os

[Boris Zbarsky]

On 6/1/17 9:04 PM, Mike Hommey wrote:

Ah, forgot to mention that. No, it doesn't affect *our* shipped builds
(because PGO uses a different set of optimization flags).

But it does affect downstream builds that don't PGO.


Based on the jump I see on June 2 at 
https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=%5Bmozilla-central,80984697abf1f1ff2b058e2d9f0b351fd9d12ad9,1,1%5D&series=%5Bmozilla-central,ae68c64ef8bfa104fded89971f1c2c6c90926dca,1,1%5D&series=%5Bmozilla-central,dd55da63ebce86ee3867aa3b39975c2a90869ce2,1,1%5D 
it affects some of our talos tests too (the ones running on non-pgo).


-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Errors found by cppcheck

[Andrew Halberstadt]

I was doing a bit of research into cppcheck [1] to see if it might be worth
running as a linter (alongside eslint, flake8 etc). More discussion in bug
1370292 [2]. I ran it against the entire tree [3] and got these results:
https://bug1370292.bmoattachments.org/attachment.cgi?id=8874498

So far it looks like the false positive rate is too high to warrant
standing up a job in CI. It seems it would cause more frustration than it's
worth. But there are likely some legit errors in there, so please take a
quick look to see if any apply to your module. Feel free to comment over in
bug 1370292 if you have opinions one way or the other on standing this up
as a task. Barring a claim that it would be useful, I'll be WONTFIXing that
bug in a bit.

-Andrew


[1] http://cppcheck.sourceforge.net/
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1370292
[3] cppcheck $(sed -e 's/^/-i/' tools/rewriting/ThirdPartyPaths.txt)
-ithird_party . 2> errors.txt
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

[Firefox Desktop] Issues found: May 29th to June 2nd

[Cornel Ionce]

Hi everyone,

Here's the list of new issues found and filed by the Desktop Release QA 
Team last week, *May 29 - June 2*(week 22).


Additional details on the team's priorities last week, as well as the 
plans for the current week are available at:


   https://public.etherpad-mozilla.org/p/DesktopManualQAWeeklyStatus



*RELEASE CHANNEL*
none

*BETA CHANNEL*

ID  Summary Product Component   Is a regression 
Assigned to
1369728 
Firefox Crashes while uploading a .pgm file on yahoo mail
Core
Drag and Drop
TBD NOBODY


*NIGHTLY CHANNEL*
ID  Summary Product Component   Is a regression 
Assigned to
1369670 
	Blank pages are printed with security.sandbox.content.level set to 3 
when Users folder is a junction point

Core
Security: Process Sandboxing
TBD Bob Owen 
1369730 
Animated canvas item is draggable
Core
Graphics
TBD NOBODY
1369039 
	Firefox layout is disturbed when “Report Site Issue” button is moved to 
the Tab Bar

Web Compatibility
General
	YES 
 
	NOBODY

1369046 
	Toggling the pref (extensions.webcompat-reporter.enabled) not correctly 
enables the "Report Site Issue" button when two windows are open

Web Compatibility
General
NO  NOBODY
1369056 
	"Report Site Issue" button shouldn't be enabled on page 
https://webcompat.com/

Web Compatibility
General
NO  NOBODY
1369097 
	After terminating a GPU process youtube videos remain in an infinite 
loading state

Core
Graphics: Layers
TBD NOBODY
1369088 
	Social media videos and games stop working when the GPU Process is 
terminated

Core
Graphics: Layers
TBD NOBODY

*

ESR CHANNEL*
none


Regards,
Cornel Ionce.


___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform