Re: Containers graduation from Test Pilot - we still care about 57+

2017-09-27 Thread Ben Kelly 
It disables multi-e10s.  Forced to one content process.

On Sep 27, 2017 12:58 PM, "Andrew McKay"  wrote:

Sorry, it disables e10s even though it has
true in the
install.rdf? That shouldn't be the case.

On 27 September 2017 at 07:14, Ben Kelly  wrote:
> On Mon, Sep 25, 2017 at 9:28 AM, Ben Kelly  wrote:
>
>> Thanks Jonathan.
>>
>> Also, it seems the link to the web extension version of the container
>> addon is broken above.  This one works for me:
>>
>> https://github.com/mozilla/multi-account-containers/releases/latest
>>
>
> Sorry, I guess this isn't a web extension yet.  Its a legacy addon and
> therefore disables multi-e10s.
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Containers graduation from Test Pilot - we still care about 57+

2017-09-27 Thread Andrew McKay 
Sorry, it disables e10s even though it has
true in the
install.rdf? That shouldn't be the case.

On 27 September 2017 at 07:14, Ben Kelly  wrote:
> On Mon, Sep 25, 2017 at 9:28 AM, Ben Kelly  wrote:
>
>> Thanks Jonathan.
>>
>> Also, it seems the link to the web extension version of the container
>> addon is broken above.  This one works for me:
>>
>> https://github.com/mozilla/multi-account-containers/releases/latest
>>
>
> Sorry, I guess this isn't a web extension yet.  Its a legacy addon and
> therefore disables multi-e10s.
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Containers graduation from Test Pilot - we still care about 57+

2017-09-27 Thread Ben Kelly 
On Mon, Sep 25, 2017 at 9:28 AM, Ben Kelly  wrote:

> Thanks Jonathan.
>
> Also, it seems the link to the web extension version of the container
> addon is broken above.  This one works for me:
>
> https://github.com/mozilla/multi-account-containers/releases/latest
>

Sorry, I guess this isn't a web extension yet.  Its a legacy addon and
therefore disables multi-e10s.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Coding style: Argument alignment

2017-09-27 Thread Gregory Szorc 
On Tue, Sep 26, 2017 at 6:45 PM, Nicholas Hurley  wrote:

> So I'm going to chime in on a formatting discussion for probably the second
> time in my life as a mozillian. (It's apparently that important to me.)
>
> On Tue, Sep 26, 2017 at 9:25 AM, Mats Palmgren  wrote:
>
> > 2. touching more lines than necessary when adding/removing params,
> >making it harder to follow blame links
> >
> > Judging from my personal use of blame links, it's very rare that
> > I want to find when a specific param was added to a signature.
> > This is also something that tooling could solve (skip blame on
> > lines that differ only by whitespace).
> >
>
> This is probably half the time I annotate something (I refuse to use the b
> word here). Use cases differ, and for a lot of what I find myself doing,
> this would make it demonstrably worse.
>

Mercurial and Git both support a -w argument to ignore whitespace with
annotate/blame.

In addition, modern versions of Mercurial have `hg annotate --skip
` which allows you to specify a revset used to select revisions to
skip over when annotating. The Chromium developer tools have
git-hyper-blame (
https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html),
which is similar.

What both tools seem to lack is the ability to toggle whitespace and
revision skipping via the web interface. This can certainly be implemented.
Also, revision skipping is not an exact science and the results may not
match expectations, so it shouldn't be seen as a cure-all.


>
>
> > I think improved readability trumps all of the minor issues above.
> >
>
> Readability is (to an extent) in the eye of the beholder. For example, I
> have a difficult time following long gaps in things... so vertically
> aligned parameters, where one of them has an extra-long type name (which
> also seems to happen a lot in things I'm working with) become exceedingly
> difficult for me to match type and name quickly. (Yes, there are editor
> tricks to help with this, and yes I use them, but they still only get me so
> far when I'm quickly scanning code).
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform