Re: Code Review bot new reporting style

[Gerald Squelart]

On Friday, March 27, 2020 at 11:11:46 PM UTC+11, Bastien Abadie wrote:
> The code review bot has been updated today and now publishes all issues
> found on your patches as Phabricator lint results (Diff Detail section)
> instead of inline comments.
> 
> Here is a sample revision showcasing the new style.
>  (on phabricator staging)
> 
> 
> The main difference for developers is that lint results are tied to a
> specific patch; so when you update your revision, the lint results are
> automatically removed and only new ones are displayed (if any).
> 
> Please be aware that any Error found by the bot must be fixed before
> landing, or your patch will break the CI. Warnings can still be ignored and
> should not break the build.
> 
> The summary comment remains the same, and will always appear in the
> revision to keep track of the revision evolution.
> 
> Thanks a lot to all the developers
>  who suggested this
> styling change, we hope you’ll enjoy this enhancement.
> 
> If you have any questions regarding this change or the code review bot, you
> can reach us on Matrix #code-review-bot
> .
> 
> 
> Bastien Abadie

It looks nice, thank you! Not seeing expired issues will be great.

> ... Error must be fixed ... Warnings can be ignored ...

Reviewbot used to prefix messages with "Warning" or "Error", but I don't see it 
in Lint messages. How can we make the distinction?

Also Reviewbot comments could be replied to, but I don't see a way to do that 
with Lint messages, is that intended?

Cheers,
Gerald
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Code Review bot new reporting style

[Bastien Abadie]

The code review bot has been updated today and now publishes all issues
found on your patches as Phabricator lint results (Diff Detail section)
instead of inline comments.

Here is a sample revision showcasing the new style.
 (on phabricator staging)


The main difference for developers is that lint results are tied to a
specific patch; so when you update your revision, the lint results are
automatically removed and only new ones are displayed (if any).

Please be aware that any Error found by the bot must be fixed before
landing, or your patch will break the CI. Warnings can still be ignored and
should not break the build.

The summary comment remains the same, and will always appear in the
revision to keep track of the revision evolution.

Thanks a lot to all the developers
 who suggested this
styling change, we hope you’ll enjoy this enhancement.

If you have any questions regarding this change or the code review bot, you
can reach us on Matrix #code-review-bot
.


Bastien Abadie
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform