Re: How do we land `./mach vendor rust` patches, these days?
It's worth noting that pulling in code from crates.io has different trust properties than NSS. In general, it's the developer and reviewer's responsibility to ensure that any newly-vendored Rust code is not malicious. This usually doesn't necessitate a painstaking line-by-line review, but needs something more than "rs=me on whatever gets pulled in when you cargo update". If Phabricator is choking on large diffs, that seems like a very high-priority bug for the Engineering Workflow team to fix, so you should file a bug if you haven't already. In the mean time, phlay might work. On Sun, Jan 20, 2019 at 7:47 PM Martin Thomson wrote: > On Sat, Jan 19, 2019 at 7:42 AM Emilio Cobos Álvarez > wrote: > > > For others (assuming you're hitting the max_post_size limit) I think > > you're out of luck and need to submit them via splinter[2]. > > > > When vendoring NSS, which we do often, we've sometimes resorted to asking > for review for a script, or one-line command. As long as that identifies > the thing that is being vendored precisely, then you can go and review the > changes based on the command. > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: How do we land `./mach vendor rust` patches, these days?
On Sat, Jan 19, 2019 at 7:42 AM Emilio Cobos Álvarez wrote: > For others (assuming you're hitting the max_post_size limit) I think > you're out of luck and need to submit them via splinter[2]. > When vendoring NSS, which we do often, we've sometimes resorted to asking for review for a script, or one-line command. As long as that identifies the thing that is being vendored precisely, then you can go and review the changes based on the command. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: How do we land `./mach vendor rust` patches, these days?
On 1/18/19 4:19 PM, David Teller wrote: > Hi everybody, > > My last two attempts to update our crates with `./mach vendor rust` > failed, not during vendoring, but when I attempted to upload the patch. > Both times, moz-phab/arcanist or phabricator simply choked during the > call and I gave up after waiting 24h for the patch to be uploaded. > > Do we have a better way to do this? Or should I use splinter for such > patches? Some large patches you can upload passing --less-context to arc directly[1]. For others (assuming you're hitting the max_post_size limit) I think you're out of luck and need to submit them via splinter[2]. Hope it helps, -- Emilio [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1517247#c3 [2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1492214 > Cheers, > Yoric > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
How do we land `./mach vendor rust` patches, these days?
Hi everybody, My last two attempts to update our crates with `./mach vendor rust` failed, not during vendoring, but when I attempted to upload the patch. Both times, moz-phab/arcanist or phabricator simply choked during the call and I gave up after waiting 24h for the patch to be uploaded. Do we have a better way to do this? Or should I use splinter for such patches? Cheers, Yoric ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
