Re: IPCError-browser | ShutDownKill signatures are about to change

2020-02-14 Thread William Kahn-Greene
Hi!

There was some confusion around signatures that suddenly showed up a
week ago that used to have a ShutDownKill signature, but since I only
reprocessed a week of them, everything was complicated.

I went through and reprocessed all 660k crash reports with
ShutDownKill signature today.

Now there are none:

https://crash-stats.mozilla.org/search/?signature=%3DIPCError-browser%20%7C%20ShutDownKill=%3E%3D2019-08-11T00%3A00%3A00.000Z=%3C2020-02-11T23%3A59%3A00.000Z&_facets=signature=1&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

/will

On Thu, Feb 6, 2020 at 4:18 PM William Kahn-Greene  wrote:
>
> Hi!
>
> I landed and deployed the change today. Previously, we'd get
> signatures like this:
>
> IPCError-browser | ShutDownKill
>
> Now that text gets prepended to whatever the signature was.
>
> After deploying the change, I went and reprocessed the last week of
> signatures. You can see the differences here:
>
> https://crash-stats.mozilla.org/search/?signature=~ShutDownKill=Firefox=%3E%3D2020-01-30T00%3A00%3A00.000Z=%3C2020-02-06T23%3A57%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature
>
> One thing to note is that I changed a signature generation rule that
> isn't specific to ShutDownKill crash reports--it's general to all
> IPCError crash reports. If there are cases of IPCError crash reports
> where this change doesn't make sense, chime in on bug #1612569 and I
> can adjust the changes accordingly.
>
> /will
>
> On Thu, Feb 6, 2020 at 6:16 AM Gabriele Svelto  wrote:
> >
> > [cross-posting to dev-platform]
> >
> > IPCError-browser | ShutDownKill crashes are the second most common ones
> > after OOMs and generally not actionable because we've been lumping
> > together a bunch of different stacks under the same signature.
> >
> > These crashes represent a snapshot of a content process taking too long
> > to shut down. The affected content process is killed right after the
> > crash report is generated.
> >
> > Bug 1612569 [1] will change those signatures soon. The new signatures
> > will include one or more function names after `IPCError-browser |
> > ShutDownKill` coming from the stack of the content process.
> >
> > This will allow us to find common causes of slowness (or deadlocks) that
> > prevent content processes from shutting down rapidly and hopefully act
> > on them.
> >
> >  Gabriele
> >
> > [1] Improve IPCError-browser | ShutDownKill signatures
> > https://bugzilla.mozilla.org/show_bug.cgi?id=1612569
> >
> > ___
> > Stability mailing list
> > stabil...@mozilla.org
> > https://mail.mozilla.org/listinfo/stability
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: IPCError-browser | ShutDownKill signatures are about to change

2020-02-10 Thread William Kahn-Greene
Hi!

I landed and deployed the change today. Previously, we'd get
signatures like this:

IPCError-browser | ShutDownKill

Now that text gets prepended to whatever the signature was.

After deploying the change, I went and reprocessed the last week of
signatures. You can see the differences here:

https://crash-stats.mozilla.org/search/?signature=~ShutDownKill=Firefox=%3E%3D2020-01-30T00%3A00%3A00.000Z=%3C2020-02-06T23%3A57%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

One thing to note is that I changed a signature generation rule that
isn't specific to ShutDownKill crash reports--it's general to all
IPCError crash reports. If there are cases of IPCError crash reports
where this change doesn't make sense, chime in on bug #1612569 and I
can adjust the changes accordingly.

/will

On Thu, Feb 6, 2020 at 6:16 AM Gabriele Svelto  wrote:
>
> [cross-posting to dev-platform]
>
> IPCError-browser | ShutDownKill crashes are the second most common ones
> after OOMs and generally not actionable because we've been lumping
> together a bunch of different stacks under the same signature.
>
> These crashes represent a snapshot of a content process taking too long
> to shut down. The affected content process is killed right after the
> crash report is generated.
>
> Bug 1612569 [1] will change those signatures soon. The new signatures
> will include one or more function names after `IPCError-browser |
> ShutDownKill` coming from the stack of the content process.
>
> This will allow us to find common causes of slowness (or deadlocks) that
> prevent content processes from shutting down rapidly and hopefully act
> on them.
>
>  Gabriele
>
> [1] Improve IPCError-browser | ShutDownKill signatures
> https://bugzilla.mozilla.org/show_bug.cgi?id=1612569
>
> ___
> Stability mailing list
> stabil...@mozilla.org
> https://mail.mozilla.org/listinfo/stability
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


IPCError-browser | ShutDownKill signatures are about to change

2020-02-06 Thread Gabriele Svelto
[cross-posting to dev-platform]

IPCError-browser | ShutDownKill crashes are the second most common ones
after OOMs and generally not actionable because we've been lumping
together a bunch of different stacks under the same signature.

These crashes represent a snapshot of a content process taking too long
to shut down. The affected content process is killed right after the
crash report is generated.

Bug 1612569 [1] will change those signatures soon. The new signatures
will include one or more function names after `IPCError-browser |
ShutDownKill` coming from the stack of the content process.

This will allow us to find common causes of slowness (or deadlocks) that
prevent content processes from shutting down rapidly and hopefully act
on them.

 Gabriele

[1] Improve IPCError-browser | ShutDownKill signatures
https://bugzilla.mozilla.org/show_bug.cgi?id=1612569



signature.asc
Description: OpenPGP digital signature
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform