Re: Migrating defaults from other browsers
On 1/19/15 4:58 AM, Henri Sivonen wrote: I think this leads to a more general question: Is it really a good idea that our profile migrators migrate settings from other browsers when those settings have been left to the defaults of those browsers? My assumption was that we're only migrating customized prefs, since otherwise we can't tell the difference between something a user made an explicit choice about vs didn't care. But more broadly, I think we should be pretty conservative with what's migrated. A quick skim shows that we're migrating lots of stuff that seems low-value (eg browser.underline_anchors), or things that could be outright broken (eg permissions.default.image, the UI for which was removed!). So I think it's worth revisiting what prefs we migrate. Justin ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Migrating defaults from other browsers
+firefox-dev (more relevant to that list than dev-platform, IMO) I would certainly support an audit of what we're migrating, I bet a lot could be cleaned up. Gavin On Tue, Jan 20, 2015 at 2:40 PM, Justin Dolske dol...@mozilla.com wrote: On 1/19/15 4:58 AM, Henri Sivonen wrote: I think this leads to a more general question: Is it really a good idea that our profile migrators migrate settings from other browsers when those settings have been left to the defaults of those browsers? My assumption was that we're only migrating customized prefs, since otherwise we can't tell the difference between something a user made an explicit choice about vs didn't care. But more broadly, I think we should be pretty conservative with what's migrated. A quick skim shows that we're migrating lots of stuff that seems low-value (eg browser.underline_anchors), or things that could be outright broken (eg permissions.default.image, the UI for which was removed!). So I think it's worth revisiting what prefs we migrate. Justin ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Migrating defaults from other browsers
https://bugzilla.mozilla.org/show_bug.cgi?id=1005863 got stalled for some time, because it wasn't clear if it was OK to stop migrating font settings from Safari. I think this leads to a more general question: Is it really a good idea that our profile migrators migrate settings from other browsers when those settings have been left to the defaults of those browsers? By migrating settings that the user hasn't changed from other browsers basically outsources the decisions on what the defaults should be from us to our competitors. This might mean default fonts, but this most visibly also means Windows users ending up with an MSN home page if they just click through the installation process. (At least last I checked, which was a good while ago.) Do we *really* want to delegate decisions about the defaults to competitors like this? -- Henri Sivonen hsivo...@hsivonen.fi https://hsivonen.fi/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Migrating defaults from other browsers
On 19/01/2015 13:58, Henri Sivonen wrote: I think this leads to a more general question: Is it really a good idea that our profile migrators migrate settings from other browsers when those settings have been left to the defaults of those browsers? Note that we don't migrate IE prefs if they have not been changed (when we can detect that), and we don't migrate the homepage if it's the system default one as well (provided the registry information didn't change recently). The only prefs that are migrated regardless (cause there's no way to check if they are at the default value afaik) is Safaris'. I think most of the prefs we are migrating are somehow related to the user browsing habits (load tabs in background, smoothscroll, underline anchors, spell check and so on...). When we converted the migrators from cpp to js, we filterd most of the prefs out, exactly to avoid creating an unacceptable downgrade of the Firefox experience (for example we don't migrate anymore the location bar prefs cause the awesomebar _is_ better!) We could probably do better and remove some more prefs (formfill, block images and cookie behavior for example), but we didn't ignore the problem. Font prefs for example could be important to some users, for locale or visual issues, not migrating them in those cases could create more issues to the user than migrating a system font setting that is optimized to work on that system (so it's unlikely to be problematic). Keeping track of the system defaults could be expensive, someone should periodically check the default values and keep the code up-to-date. Considered I'm not even sure how often we run manual browser migration tests, that doesn't seem like something achievable. -m ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
