Re: PSA: The profiling branch has shut down

2013-11-12 Thread Benoit Girard
That's correct. It means that benchmarking on nighties isn't really
accurate so beware when running web/js benchmarks. Also it is wrong to
assume an average performance cost and scale the nightly results by a
factor.

We made this decision with the hope that we could better gather performance
data that would in the end translate to shipping performance improvements
to release users faster. This come as a slight cost to Nightly users.


On Sun, Nov 10, 2013 at 6:01 PM, Ehsan Akhgari ehsan.akhg...@gmail.comwrote:

 On 2013-11-09 6:30 PM, Boris Zbarsky wrote:

 On 11/9/13 12:53 PM, Philip Chee wrote:

 Not directly related but. Some time back I wanted to turn on profiling
 for SeaMonkey on our trunk builds but was vetoed because turning on
 profiling (I was told) causes a pref hit.


 It does, but a pretty small one, and only on x86-32 (because there is
 one less register to work with).


 Also note that we only enable profiling by default on Nightly and not the
 channels that matter to our users.  But that does mean that performance
 comparisons between Nightly and Aurora on Windows for example are not
 possible unless you do your own non-profiling Nightly builds.

 Cheers,
 Ehsan


 ___
 dev-platform mailing list
 dev-platform@lists.mozilla.org
 https://lists.mozilla.org/listinfo/dev-platform

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: PSA: The profiling branch has shut down

2013-11-10 Thread Ehsan Akhgari

On 2013-11-09 6:30 PM, Boris Zbarsky wrote:

On 11/9/13 12:53 PM, Philip Chee wrote:

Not directly related but. Some time back I wanted to turn on profiling
for SeaMonkey on our trunk builds but was vetoed because turning on
profiling (I was told) causes a pref hit.


It does, but a pretty small one, and only on x86-32 (because there is
one less register to work with).


Also note that we only enable profiling by default on Nightly and not 
the channels that matter to our users.  But that does mean that 
performance comparisons between Nightly and Aurora on Windows for 
example are not possible unless you do your own non-profiling Nightly 
builds.


Cheers,
Ehsan

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: PSA: The profiling branch has shut down

2013-11-09 Thread Boris Zbarsky

On 11/9/13 12:53 PM, Philip Chee wrote:

Not directly related but. Some time back I wanted to turn on profiling
for SeaMonkey on our trunk builds but was vetoed because turning on
profiling (I was told) causes a pref hit.


It does, but a pretty small one, and only on x86-32 (because there is 
one less register to work with).


-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


PSA: The profiling branch has shut down

2013-11-08 Thread Ehsan Akhgari
Hi everyone,

I set up the profiling branch a long time ago to build mozilla-central
without the --enable-profiling option to catch any regressions that happen
in those builds to minimize the chance of things blowing up after an uplift
to Aurora (which is always built without --enable-profiling.)  Philor has
been doing occasional try pushes with that option reverted plus the Aurora
branding changes and the version number changes to replicate the exact
built configuration we have on Aurora and he told me that given those try
pushes, the profiling branch is no longer going to be useful.  Therefore,
as of a few minutes ago, I have disabled the cron job which used to push to
the profiling branch, and have filed bugs 936582 and 936584 to remove the
profiling branch completely.

Please let me know if you have any questions.

Cheers,
--
Ehsan
http://ehsanakhgari.org/
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform