Re: PSA: increased chance of new leaks due to delayed shutdown issue
Actually this was backed out from m-c for a single failing android test this morning. So please be aware we are at risk of introducing leaks again. On Sat, Dec 2, 2017 at 9:27 PM, Ben Kelly wrote: > Both fixes have stuck and are in the latest nightly. Sorry for the > headaches here. > > On Dec 1, 2017 1:15 PM, "Ben Kelly" wrote: > >> FYI, we have a fix identified for the late shutdown leak as well. I will >> push them to inbound once the trees re-open. >> >> On Thu, Nov 30, 2017 at 11:18 PM, Ben Kelly wrote: >> >>> Hi all, >>> >>> I just wanted to send a note about a bug in nightly which is leading to >>> delayed shutdowns. Currently nightly is taking 5 to 10 seconds to shutdown. >>> >>> Bisection has shown this was introduced by my landing in: >>> >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1419536 >>> >>> I have a fix here: >>> >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1420594 >>> >>> But I discovered upon pushing the fix that at least one new leak has >>> crept in while shutdowns have been delayed. I'm currently bisecting on try >>> to figure out what happened. I am, however, worried about more leaks >>> appearing while I figure this out. >>> >>> If you are touching anything that might live until shutdown, please >>> include the patches from bug 1420594 to avoid the delayed shutdown issue. >>> >>> I'll send another mail once the fix lands and sticks. >>> >>> Thanks for your help. Sorry for the trouble. >>> >>> Ben >>> >> >> ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: increased chance of new leaks due to delayed shutdown issue
Both fixes have stuck and are in the latest nightly. Sorry for the headaches here. On Dec 1, 2017 1:15 PM, "Ben Kelly" wrote: > FYI, we have a fix identified for the late shutdown leak as well. I will > push them to inbound once the trees re-open. > > On Thu, Nov 30, 2017 at 11:18 PM, Ben Kelly wrote: > >> Hi all, >> >> I just wanted to send a note about a bug in nightly which is leading to >> delayed shutdowns. Currently nightly is taking 5 to 10 seconds to shutdown. >> >> Bisection has shown this was introduced by my landing in: >> >> https://bugzilla.mozilla.org/show_bug.cgi?id=1419536 >> >> I have a fix here: >> >> https://bugzilla.mozilla.org/show_bug.cgi?id=1420594 >> >> But I discovered upon pushing the fix that at least one new leak has >> crept in while shutdowns have been delayed. I'm currently bisecting on try >> to figure out what happened. I am, however, worried about more leaks >> appearing while I figure this out. >> >> If you are touching anything that might live until shutdown, please >> include the patches from bug 1420594 to avoid the delayed shutdown issue. >> >> I'll send another mail once the fix lands and sticks. >> >> Thanks for your help. Sorry for the trouble. >> >> Ben >> > > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: increased chance of new leaks due to delayed shutdown issue
FYI, we have a fix identified for the late shutdown leak as well. I will push them to inbound once the trees re-open. On Thu, Nov 30, 2017 at 11:18 PM, Ben Kelly wrote: > Hi all, > > I just wanted to send a note about a bug in nightly which is leading to > delayed shutdowns. Currently nightly is taking 5 to 10 seconds to shutdown. > > Bisection has shown this was introduced by my landing in: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1419536 > > I have a fix here: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1420594 > > But I discovered upon pushing the fix that at least one new leak has crept > in while shutdowns have been delayed. I'm currently bisecting on try to > figure out what happened. I am, however, worried about more leaks > appearing while I figure this out. > > If you are touching anything that might live until shutdown, please > include the patches from bug 1420594 to avoid the delayed shutdown issue. > > I'll send another mail once the fix lands and sticks. > > Thanks for your help. Sorry for the trouble. > > Ben > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
PSA: increased chance of new leaks due to delayed shutdown issue
Hi all, I just wanted to send a note about a bug in nightly which is leading to delayed shutdowns. Currently nightly is taking 5 to 10 seconds to shutdown. Bisection has shown this was introduced by my landing in: https://bugzilla.mozilla.org/show_bug.cgi?id=1419536 I have a fix here: https://bugzilla.mozilla.org/show_bug.cgi?id=1420594 But I discovered upon pushing the fix that at least one new leak has crept in while shutdowns have been delayed. I'm currently bisecting on try to figure out what happened. I am, however, worried about more leaks appearing while I figure this out. If you are touching anything that might live until shutdown, please include the patches from bug 1420594 to avoid the delayed shutdown issue. I'll send another mail once the fix lands and sticks. Thanks for your help. Sorry for the trouble. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
