Re: Are crashtests allowed to access chrome (e.g. set preferences)?

2012-10-15 Thread Bobby Holley
Now that bug 792029 has landed, you should be able to use
SpecialPowers in crashtests.

On Mon, Oct 15, 2012 at 2:09 PM, Henrik Skupin hsku...@gmail.com wrote:
 Hi all,

 I want to start with crashtests for webrtc crashes which have been fixed
 recently. Sadly this feature is disabled on mozilla-central and
 mozilla-aurora. So I would have to set two preferences to get access to
 all the features. Now I see that crashtests are getting run through the
 reftest framework and wonder if there is a way to modify preferences
 before the test, or is that forbidden?

 In either way, what would be the best way to get those tests into the
 tree? I assume a place like /dom/media/tests/crashtests/ is a good location?

 Thanks!
 Henrik
 ___
 dev-platform mailing list
 dev-platform@lists.mozilla.org
 https://lists.mozilla.org/listinfo/dev-platform
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Are crashtests allowed to access chrome (e.g. set preferences)?

2012-10-15 Thread Henrik Skupin
Bobby Holley wrote on 10/15/12 2:12 PM:
 Now that bug 792029 has landed, you should be able to use
 SpecialPowers in crashtests.

Wow, great response time and great answer! Thank you a lot Bobby!

-- 
Henrik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Are crashtests allowed to access chrome (e.g. set preferences)?

2012-10-15 Thread Henrik Skupin
Ted Mielczarek wrote on 10/15/12 2:16 PM:

 The reftest manifest format (which crashtest uses, since crashtests
 run in the reftest harness) has explicit support for setting
 preferences per-test:
 http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/README.txt#160

Sounds good. I will make use of it. Sadly it cannot set the preference
globally for all the tests referenced by that crashtests.list file.

-- 
Henrik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Are crashtests allowed to access chrome (e.g. set preferences)?

2012-10-15 Thread L. David Baron
On Monday 2012-10-15 15:00 +0200, Henrik Skupin wrote:
 Ted Mielczarek wrote on 10/15/12 2:16 PM:
 
  The reftest manifest format (which crashtest uses, since crashtests
  run in the reftest harness) has explicit support for setting
  preferences per-test:
  http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/README.txt#160
 
 Sounds good. I will make use of it. Sadly it cannot set the preference
 globally for all the tests referenced by that crashtests.list file.

There's a reviewed patch in
https://bugzilla.mozilla.org/show_bug.cgi?id=788967 that adds
support for this, but apparently it had failures on try.

-David

-- 
턞   L. David Baron http://dbaron.org/   턂
턢   Mozilla   http://www.mozilla.org/   턂
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Are crashtests allowed to access chrome (e.g. set preferences)?

2012-10-15 Thread Henrik Skupin
L. David Baron wrote on 10/15/12 4:31 PM:

 There's a reviewed patch in
 https://bugzilla.mozilla.org/show_bug.cgi?id=788967 that adds
 support for this, but apparently it had failures on try.

Exactly what I need. Will watch when it lands. Thanks!

-- 
Henrik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform