Re: Getting the current UI locale from C++

2013-08-29 Thread Henri Sivonen
On Thu, Aug 29, 2013 at 10:12 AM, Henri Sivonen hsivo...@hsivonen.fi wrote:
 How do I get the language code for the currently active UI language
 pack from within Gecko C++ code in a way that works across desktop,
 Android, B2G and Metro?

On IRC, I was pointed to
https://mxr.mozilla.org/comm-central/source/mozilla/editor/composer/src/nsEditorSpellCheck.cpp#762

Does that mechanism work on B2G and Android?

-- 
Henri Sivonen
hsivo...@hsivonen.fi
http://hsivonen.iki.fi/
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Getting the current UI locale from C++

2013-08-29 Thread Axel Hecht

On 8/29/13 12:03 PM, Henri Sivonen wrote:

On Thu, Aug 29, 2013 at 10:12 AM, Henri Sivonen hsivo...@hsivonen.fi wrote:

How do I get the language code for the currently active UI language
pack from within Gecko C++ code in a way that works across desktop,
Android, B2G and Metro?


On IRC, I was pointed to
https://mxr.mozilla.org/comm-central/source/mozilla/editor/composer/src/nsEditorSpellCheck.cpp#762

Does that mechanism work on B2G and Android?



I'll read up on the other thread, and I still think the approach is 
wrong here, sorry.


But yes, getting the selected locale for the global package is what I 
try to keep working at cost, notably on Android, where we're already 
doing stunts to do that.


Axel
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Getting the current UI locale from C++

2013-08-29 Thread Anne van Kesteren
On Thu, Aug 29, 2013 at 1:48 PM, Axel Hecht l...@mozilla.com wrote:
 I'll read up on the other thread, and I still think the approach is wrong
 here, sorry.

You'll have to explain that more fully I think.

This is the current approach. However the current approach leads to
all kinds of bugs because localization teams don't have expertise in
this area. So we improve the status quo by reducing this source of
bugs (that are still there and deployed to users).

This is also the approach other browsers take.

There might be a better approach (we'll have to research that, can't
do it based on gut), but until that is there improving the status quo
is a very good thing for our users.


-- 
http://annevankesteren.nl/
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Getting the current UI locale from C++

2013-08-29 Thread Axel Hecht

On 8/29/13 3:17 PM, Anne van Kesteren wrote:

On Thu, Aug 29, 2013 at 1:48 PM, Axel Hecht l...@mozilla.com wrote:

I'll read up on the other thread, and I still think the approach is wrong
here, sorry.


You'll have to explain that more fully I think.

This is the current approach. However the current approach leads to
all kinds of bugs because localization teams don't have expertise in
this area. So we improve the status quo by reducing this source of
bugs (that are still there and deployed to users).

This is also the approach other browsers take.

There might be a better approach (we'll have to research that, can't
do it based on gut), but until that is there improving the status quo
is a very good thing for our users.




I followed up in https://bugzilla.mozilla.org/show_bug.cgi?id=910192

Axel
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform