Re: No more Makefile.in boilerplate
Hi, out of curiousity, I recall that relativesrcdir was actually the trigger to switch on and off some l10n functionality in jar packaging. Is that now on everywhere? Axel On 9/5/13 2:34 AM, Mike Hommey wrote: Hi, Assuming it sticks, bug 912293 made it unnecessary to start Makefile.in files with the usual boilerplate: DEPTH = @DEPTH@ topsrcdir = @top_srcdir@ srcdir = @srcdir@ VPATH = @srcdir@ relativesrcdir = @relativesrcdir@ include $(DEPTH)/config/autoconf.mk All of the above can now be skipped. Directories that do require a different value for e.g. VPATH or relativesrcdir can still place a value that will be taken instead of the default. It is not recommended to do that in new Makefile.in files, or to change existing files to do that, but the existing files that did require such different values still do use those different values. Also, if the last line of a Makefile.in is: include $(topsrcdir)/config/rules.mk That can be skipped as well. Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: No more Makefile.in boilerplate
On Thu, Sep 05, 2013 at 12:24:11PM +0200, Axel Hecht wrote: Hi, out of curiousity, I recall that relativesrcdir was actually the trigger to switch on and off some l10n functionality in jar packaging. Is that now on everywhere? I didn't find any l10n jar.mn without a relativesrcdir in the corresponding Makefile.in. But maybe I didn't look properly? Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: No more Makefile.in boilerplate
On Thu, Sep 05, 2013 at 04:08:50PM +0200, Axel Hecht wrote: On 9/5/13 1:17 PM, Mike Hommey wrote: On Thu, Sep 05, 2013 at 12:24:11PM +0200, Axel Hecht wrote: Hi, out of curiousity, I recall that relativesrcdir was actually the trigger to switch on and off some l10n functionality in jar packaging. Is that now on everywhere? I didn't find any l10n jar.mn without a relativesrcdir in the corresponding Makefile.in. But maybe I didn't look properly? There shouldn't have been. But https://hg.mozilla.org/mozilla-central/file/45097bc3a578/config/config.mk#l681 seems to be always on now? (also 685) Indeed. Although it's also possible to set relativesrcdir to nothing in Makefile.in to get back to the case without relativesrcdir. Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: No more Makefile.in boilerplate
On 9/5/2013 10:25 AM, Mike Hommey wrote: There shouldn't have been. But https://hg.mozilla.org/mozilla-central/file/45097bc3a578/config/config.mk#l681 seems to be always on now? (also 685) Indeed. Although it's also possible to set relativesrcdir to nothing in Makefile.in to get back to the case without relativesrcdir. I think we should fix anything that depends on relativesrcdir being unset. This has become a standard part of our Makefiles. -Ted ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: No more Makefile.in boilerplate
Can you delete this boilerplate from existing makefiles if not already done? That will prevent people from adding it since people look at examples when adding new makefiles. Andreas Mike Hommey wrote: Hi, Assuming it sticks, bug 912293 made it unnecessary to start Makefile.in files with the usual boilerplate: DEPTH = @DEPTH@ topsrcdir = @top_srcdir@ srcdir = @srcdir@ VPATH = @srcdir@ relativesrcdir = @relativesrcdir@ include $(DEPTH)/config/autoconf.mk All of the above can now be skipped. Directories that do require a different value for e.g. VPATH or relativesrcdir can still place a value that will be taken instead of the default. It is not recommended to do that in new Makefile.in files, or to change existing files to do that, but the existing files that did require such different values still do use those different values. Also, if the last line of a Makefile.in is: include $(topsrcdir)/config/rules.mk That can be skipped as well. Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: No more Makefile.in boilerplate
This was done. My eyes are still bleeding from the review. On 9/4/13 5:36 PM, Andreas Gal wrote: Can you delete this boilerplate from existing makefiles if not already done? That will prevent people from adding it since people look at examples when adding new makefiles. Andreas Mike Hommey wrote: Hi, Assuming it sticks, bug 912293 made it unnecessary to start Makefile.in files with the usual boilerplate: DEPTH = @DEPTH@ topsrcdir = @top_srcdir@ srcdir = @srcdir@ VPATH = @srcdir@ relativesrcdir = @relativesrcdir@ include $(DEPTH)/config/autoconf.mk All of the above can now be skipped. Directories that do require a different value for e.g. VPATH or relativesrcdir can still place a value that will be taken instead of the default. It is not recommended to do that in new Makefile.in files, or to change existing files to do that, but the existing files that did require such different values still do use those different values. Also, if the last line of a Makefile.in is: include $(topsrcdir)/config/rules.mk That can be skipped as well. Mike ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
