Re: PSA: nsIDocument is now mozilla::dom::Document.

2019-01-05 Thread Jeff Muizelaar
"I" stands for Interface. It's a convention borrowed from COM. e.g.
COM's IUnknown corresponds to our nsISupports

-Jeff

On Sat, Jan 5, 2019 at 8:03 PM Tim Guan-tin Chien  wrote:
>
> That's great! Definitely lower the barrier of entry for people new to Gecko
> C++.
>
> Just curious — what's the historical significance between nsIDocument and
> nsDocument? I know "ns" stood for Netscape but what did "I" mean?
>
> On Thu, Jan 3, 2019 at 3:56 PM Bobby Holley  wrote:
>
> > This is awesome - thanks Emilio!
> >
> > On Thu, Jan 3, 2019 at 3:27 PM Emilio Cobos Álvarez 
> > wrote:
> >
> > > I've always been slightly annoyed at the fact that Gecko used to have
> > > multiple classes for the same concept of a document node without any
> > > clear separation these days (nsIDocument and nsDocument).
> > >
> > > Over the last week I decided to change that by first merging both in:
> > >
> > >https://bugzilla.mozilla.org/show_bug.cgi?id=1516366
> > >https://bugzilla.mozilla.org/show_bug.cgi?id=1516853
> > >
> > > And finally renaming nsIDocument to the more usual naming convention for
> > > DOM objects / WebIDL-exposed things these days in:
> > >
> > >https://bugzilla.mozilla.org/show_bug.cgi?id=1517241
> > >
> > > So the end result is that now nsIDocument and nsDocument are the same
> > > thing and are called mozilla::dom::Document.
> > >
> > > It was quite a big patch (thanks Olli for all the reviews!), but
> > > over-all I think the end result is nicer.
> > >
> > > Anyhow, this is just a PSA since it's such a common type to be used, in
> > > case you don't find something that used to live there :)
> > >
> > >-- Emilio
> > > ___
> > > dev-platform mailing list
> > > dev-platform@lists.mozilla.org
> > > https://lists.mozilla.org/listinfo/dev-platform
> > >
> > ___
> > dev-platform mailing list
> > dev-platform@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-platform
> >
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: PSA: nsIDocument is now mozilla::dom::Document.

2019-01-05 Thread Tim Guan-tin Chien
That's great! Definitely lower the barrier of entry for people new to Gecko
C++.

Just curious — what's the historical significance between nsIDocument and
nsDocument? I know "ns" stood for Netscape but what did "I" mean?

On Thu, Jan 3, 2019 at 3:56 PM Bobby Holley  wrote:

> This is awesome - thanks Emilio!
>
> On Thu, Jan 3, 2019 at 3:27 PM Emilio Cobos Álvarez 
> wrote:
>
> > I've always been slightly annoyed at the fact that Gecko used to have
> > multiple classes for the same concept of a document node without any
> > clear separation these days (nsIDocument and nsDocument).
> >
> > Over the last week I decided to change that by first merging both in:
> >
> >https://bugzilla.mozilla.org/show_bug.cgi?id=1516366
> >https://bugzilla.mozilla.org/show_bug.cgi?id=1516853
> >
> > And finally renaming nsIDocument to the more usual naming convention for
> > DOM objects / WebIDL-exposed things these days in:
> >
> >https://bugzilla.mozilla.org/show_bug.cgi?id=1517241
> >
> > So the end result is that now nsIDocument and nsDocument are the same
> > thing and are called mozilla::dom::Document.
> >
> > It was quite a big patch (thanks Olli for all the reviews!), but
> > over-all I think the end result is nicer.
> >
> > Anyhow, this is just a PSA since it's such a common type to be used, in
> > case you don't find something that used to live there :)
> >
> >-- Emilio
> > ___
> > dev-platform mailing list
> > dev-platform@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-platform
> >
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: PSA: nsIDocument is now mozilla::dom::Document.

2019-01-03 Thread Bobby Holley
This is awesome - thanks Emilio!

On Thu, Jan 3, 2019 at 3:27 PM Emilio Cobos Álvarez 
wrote:

> I've always been slightly annoyed at the fact that Gecko used to have
> multiple classes for the same concept of a document node without any
> clear separation these days (nsIDocument and nsDocument).
>
> Over the last week I decided to change that by first merging both in:
>
>https://bugzilla.mozilla.org/show_bug.cgi?id=1516366
>https://bugzilla.mozilla.org/show_bug.cgi?id=1516853
>
> And finally renaming nsIDocument to the more usual naming convention for
> DOM objects / WebIDL-exposed things these days in:
>
>https://bugzilla.mozilla.org/show_bug.cgi?id=1517241
>
> So the end result is that now nsIDocument and nsDocument are the same
> thing and are called mozilla::dom::Document.
>
> It was quite a big patch (thanks Olli for all the reviews!), but
> over-all I think the end result is nicer.
>
> Anyhow, this is just a PSA since it's such a common type to be used, in
> case you don't find something that used to live there :)
>
>-- Emilio
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform