Removing unused Perl scripts from the tree
Hi, In https://bugzilla.mozilla.org/show_bug.cgi?id=1089446 I'm removing some old, unused Perl scripts from the tree. I'm giving notice here just in case any of the scripts I'm planning to remove are still being used, and also to find out if more scripts can be removed. My working list and notes are below. Everything in the REMOVING section is on track to be removed. Assistance on the UNSURE section would be helpful. Thank you. Nick REMOVING ./config/make-atom-strings.pl - patch to remove is r=bz ./gfx/tests/process-textruns.pl - patch to remove is r=roc ./build/unix/uniq.pl - patch to replace it with uniq.py is r=gps ./config/module2dir.pl - not touched meaningfully since 2003; lots of touches before that - glandium says it has been broken since 2008, and hence unused - patch to remove it is r?glandium ./netwerk/test/neckoTiming.pl - landed in 2001, hasn't been touched since - patch to remove is r?mcmanus ./xpcom/tools/analyze-xpcom-log.pl - unchanged since 2001, unmentioned in the repo - patch to remove is r?froydnj ./build/unix/abs2rel.pl - landed in April 2002, no non-trivial changes since then - no other references in the repo - patch to remove is r?mshal (in bug 1089832) UNSURE -- ./layout/tools/reftest/clean-reftest-output.pl ./layout/tools/reftest/reftest-to-html.pl - mentioned in layout/tools/reftest/README.txt - dbaron says probably not useful ./dom/xslt/tests/buster/helper/generate-rdf.pl - no other references in the repo - bz thinks it's unused; peterv might know better ./layout/mathml/updateOperatorDictionary.pl - appears to be in fairly recent use ./layout/reftests/fonts/generate-bitpattern-font.pl - mentioned by bidiMirroring.svg ./xpcom/reflect/xptcall/genstubs.pl - has moderately recent use - mentioned in porting.html ./gfx/thebes/genLanguageTagList.pl - seems like it might still be useful - used to generate gfxLanguageTagList.{cpp,h} ./security/manager/ssl/tests/unit/test_certificate_usages/generate.pl - mentioned in comments in security/manager/ssl/tests/unit/test_certificate_usages.js DEFINITELY USEFUL - ./toolkit/locales/compare-locales.pl - Callek says it's still used for some SeaMonkey extensions ./tools/memory/bloattable.pl - still works with bloat logs from XPCOM_MEM_BLOAT_LOG ./tools/rb/find-comptr-leakers.pl ./tools/rb/find-leakers.pl ./tools/rb/filter-log.pl ./tools/rb/make-tree.pl ./tools/rb/bloatdiff.pl - all(?) still work with refcnt tracing ./tools/trace-malloc/blame.pl ./tools/trace-malloc/diffbloatdump.pl ./tools/trace-malloc/merge.pl ./tools/trace-malloc/histogram.pl ./tools/trace-malloc/leak-soup.pl ./tools/trace-malloc/uncategorized.pl - all(?) still work with trace-malloc logs ./tools/update-packaging/unwrap_full_update.pl - used in tools/update-packaging/Makefile.in ./tools/leak-gauge/leak-gauge.pl - still works ./config/milestone.pl - used in configure.in and other places ./config/version_win.pl - used in config/version.mk ./docshell/test/chrome/gen_template.pl ./testing/mochitest/gen_template.pl - useful when creating new tests ./testing/web-platform/tests/tools/pywebsocket/src/test/testdata/hello.pl - used in a test ./build/win32/dumpenv4python.pl - used in build/autoconf/hooks.m4 THIRD-PARTY --- ./gfx/cairo/libpixman/src/make-combine.pl ./intl/lwbrk/tools/anzx4051.pl ./intl/uconv/tools/genimpldefine.pl ./intl/uconv/tools/jamap.pl ./intl/uconv/tools/parse-mozilla-encoding-table.pl ./intl/uconv/tools/gen-big5hkscs-2001-mozilla.pl ./intl/uconv/tools/cp936tocdx.pl ./intl/uconv/tools/jis0212tojdx.pl ./intl/uconv/tools/unihan2cns.pl ./intl/uconv/tools/mkjpconv.pl ./intl/uconv/tools/adobe.pl ./intl/uconv/tools/gengb18030tables.pl ./intl/uconv/tests/stressgb.pl ./intl/chardet/tools/charfreqtostat.pl ./intl/chardet/tools/geniso2022cn.pl ./intl/chardet/tools/genhz.pl ./intl/chardet/tools/genbig5.pl ./intl/chardet/tools/charfreq.pl ./intl/chardet/tools/gengb18030.pl ./intl/chardet/tools/geniso2022jp.pl ./intl/chardet/tools/geneuctw.pl ./intl/chardet/tools/gensjis.pl ./intl/chardet/tools/geneuckr.pl ./intl/chardet/tools/geneucjp.pl ./intl/chardet/tools/gencyrillic.pl ./intl/chardet/tools/gencp1252.pl ./intl/chardet/tools/gengb2312.pl ./intl/chardet/tools/genutf8.pl ./intl/chardet/tools/geniso2022kr.pl ./intl/unicharutil/tools/genSpecialCasingData.pl ./intl/unicharutil/tools/gentransliterate.pl ./intl/unicharutil/tools/genUnicodePropertyData.pl ./intl/unicharutil/tests/genNormalizationData.pl ./intl/icu/source/common/rbbicst.pl ./intl/icu/source/tools/genren/genren.pl ./intl/icu/source/tools/memcheck/ICUMemCheck.pl ./intl/icu/source/tools/gensprep/filterRFC3454.pl ./intl/icu/source/i18n/regexcst.pl ./nsprpub/pr/src/misc/compile-et.pl ./nsprpub/pr/tests/runtests.pl ./nsprpub/config/make-system-wrappers.pl ./nsprpub/config/nfspwd.pl ./nsprpub/admin/explode.pl ./media/libopus/celt/arm/arm2gnu.pl ./media/libvpx/build/make/ads2gas.pl ./media/libtheora/lib/arm/arm2gnu.pl
Re: Removing unused Perl scripts from the tree
Thanks for doing this! On 10/27/2014 03:18 PM, Nicholas Nethercote wrote: ./security/manager/ssl/tests/unit/test_certificate_usages/generate.pl - mentioned in comments in security/manager/ssl/tests/unit/test_certificate_usages.js We probably still need this until bug 969985[0] is fixed (in which we want to convert it to a python script). [0] https://bugzilla.mozilla.org/show_bug.cgi?id=969985 ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Removing unused Perl scripts from the tree
On Monday 2014-10-27 15:18 -0700, Nicholas Nethercote wrote: ./layout/reftests/fonts/generate-bitpattern-font.pl - mentioned by bidiMirroring.svg I believe this is code that was used to generate a file checked in to the tree (BitPattern.woff, in the same directory, although there was presumably another conversion step after the script). It's generally good practice to have the source code that generated a generated file checked in along with it, when generated files need to be checked in. (It may even be required by some software licenses.) -David -- 턞 L. David Baron http://dbaron.org/ 턂 턢 Mozilla https://www.mozilla.org/ 턂 Before I built a wall I'd ask to know What I was walling in or walling out, And to whom I was like to give offense. - Robert Frost, Mending Wall (1914) signature.asc Description: Digital signature ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Removing unused Perl scripts from the tree
On 2014-10-27 3:18 PM, Nicholas Nethercote wrote: ./media/libopus/celt/arm/arm2gnu.pl ./media/libvpx/build/make/ads2gas.pl ./media/libtheora/lib/arm/arm2gnu.pl These come from upstream, and are used to convert syntax of assembler source files so they can work with various toolchains. Upstream is unlikely to accept python conversions (perl is more widely deployed) so I don't think it makes sense to remove or replace these. -r ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Removing unused Perl scripts from the tree
A clarification: I'm not planning to do anything with the scripts in the THIRD-PARTY section, unless somebody tells me foo.pl is not third-party and can be safely removed. Nick On Mon, Oct 27, 2014 at 3:18 PM, Nicholas Nethercote n.netherc...@gmail.com wrote: Hi, In https://bugzilla.mozilla.org/show_bug.cgi?id=1089446 I'm removing some old, unused Perl scripts from the tree. I'm giving notice here just in case any of the scripts I'm planning to remove are still being used, and also to find out if more scripts can be removed. My working list and notes are below. Everything in the REMOVING section is on track to be removed. Assistance on the UNSURE section would be helpful. Thank you. Nick REMOVING ./config/make-atom-strings.pl - patch to remove is r=bz ./gfx/tests/process-textruns.pl - patch to remove is r=roc ./build/unix/uniq.pl - patch to replace it with uniq.py is r=gps ./config/module2dir.pl - not touched meaningfully since 2003; lots of touches before that - glandium says it has been broken since 2008, and hence unused - patch to remove it is r?glandium ./netwerk/test/neckoTiming.pl - landed in 2001, hasn't been touched since - patch to remove is r?mcmanus ./xpcom/tools/analyze-xpcom-log.pl - unchanged since 2001, unmentioned in the repo - patch to remove is r?froydnj ./build/unix/abs2rel.pl - landed in April 2002, no non-trivial changes since then - no other references in the repo - patch to remove is r?mshal (in bug 1089832) UNSURE -- ./layout/tools/reftest/clean-reftest-output.pl ./layout/tools/reftest/reftest-to-html.pl - mentioned in layout/tools/reftest/README.txt - dbaron says probably not useful ./dom/xslt/tests/buster/helper/generate-rdf.pl - no other references in the repo - bz thinks it's unused; peterv might know better ./layout/mathml/updateOperatorDictionary.pl - appears to be in fairly recent use ./layout/reftests/fonts/generate-bitpattern-font.pl - mentioned by bidiMirroring.svg ./xpcom/reflect/xptcall/genstubs.pl - has moderately recent use - mentioned in porting.html ./gfx/thebes/genLanguageTagList.pl - seems like it might still be useful - used to generate gfxLanguageTagList.{cpp,h} ./security/manager/ssl/tests/unit/test_certificate_usages/generate.pl - mentioned in comments in security/manager/ssl/tests/unit/test_certificate_usages.js DEFINITELY USEFUL - ./toolkit/locales/compare-locales.pl - Callek says it's still used for some SeaMonkey extensions ./tools/memory/bloattable.pl - still works with bloat logs from XPCOM_MEM_BLOAT_LOG ./tools/rb/find-comptr-leakers.pl ./tools/rb/find-leakers.pl ./tools/rb/filter-log.pl ./tools/rb/make-tree.pl ./tools/rb/bloatdiff.pl - all(?) still work with refcnt tracing ./tools/trace-malloc/blame.pl ./tools/trace-malloc/diffbloatdump.pl ./tools/trace-malloc/merge.pl ./tools/trace-malloc/histogram.pl ./tools/trace-malloc/leak-soup.pl ./tools/trace-malloc/uncategorized.pl - all(?) still work with trace-malloc logs ./tools/update-packaging/unwrap_full_update.pl - used in tools/update-packaging/Makefile.in ./tools/leak-gauge/leak-gauge.pl - still works ./config/milestone.pl - used in configure.in and other places ./config/version_win.pl - used in config/version.mk ./docshell/test/chrome/gen_template.pl ./testing/mochitest/gen_template.pl - useful when creating new tests ./testing/web-platform/tests/tools/pywebsocket/src/test/testdata/hello.pl - used in a test ./build/win32/dumpenv4python.pl - used in build/autoconf/hooks.m4 THIRD-PARTY --- ./gfx/cairo/libpixman/src/make-combine.pl ./intl/lwbrk/tools/anzx4051.pl ./intl/uconv/tools/genimpldefine.pl ./intl/uconv/tools/jamap.pl ./intl/uconv/tools/parse-mozilla-encoding-table.pl ./intl/uconv/tools/gen-big5hkscs-2001-mozilla.pl ./intl/uconv/tools/cp936tocdx.pl ./intl/uconv/tools/jis0212tojdx.pl ./intl/uconv/tools/unihan2cns.pl ./intl/uconv/tools/mkjpconv.pl ./intl/uconv/tools/adobe.pl ./intl/uconv/tools/gengb18030tables.pl ./intl/uconv/tests/stressgb.pl ./intl/chardet/tools/charfreqtostat.pl ./intl/chardet/tools/geniso2022cn.pl ./intl/chardet/tools/genhz.pl ./intl/chardet/tools/genbig5.pl ./intl/chardet/tools/charfreq.pl ./intl/chardet/tools/gengb18030.pl ./intl/chardet/tools/geniso2022jp.pl ./intl/chardet/tools/geneuctw.pl ./intl/chardet/tools/gensjis.pl ./intl/chardet/tools/geneuckr.pl ./intl/chardet/tools/geneucjp.pl ./intl/chardet/tools/gencyrillic.pl ./intl/chardet/tools/gencp1252.pl ./intl/chardet/tools/gengb2312.pl ./intl/chardet/tools/genutf8.pl ./intl/chardet/tools/geniso2022kr.pl ./intl/unicharutil/tools/genSpecialCasingData.pl ./intl/unicharutil/tools/gentransliterate.pl ./intl/unicharutil/tools/genUnicodePropertyData.pl ./intl/unicharutil/tests/genNormalizationData.pl ./intl/icu/source/common/rbbicst.pl ./intl/icu/source/tools/genren/genren.pl ./intl/icu/source/tools/memcheck/ICUMemCheck.pl
Re: Removing unused Perl scripts from the tree
Nicholas Nethercote writes: UNSURE -- ./layout/mathml/updateOperatorDictionary.pl - appears to be in fairly recent use This was used to generate an in-tree file from an external spec. It is reasonably likely that there will be future changes to the spec, in which case the script will again be useful. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform