mach lint -l l10n coming your way
Hi, I just landed a new linter into mach, and thus into treeherder and phabricator. It's called `l10n`, and `l1nt` on treeherder. It checks for common errors in localizable files, like duplicate strings and parsing errors, but also runs some more detailed checks. On phabricator, it also reports warnings, which might be missed string ID changes. So if a patch doesn't show the strings you're hoping for, a good first step is to run ./mach lint -w now. Together with l10n jobs on try and pseudo localization [1], this should make your life easier. On string changes: The rules remain the same, if you change the semantics of a string, you need a new ID. If you just fix a typo or grammar, please don't create a new ID. Anything inbetween, feel free to ask, often the best choice depends on what's actually in the localizations. Technical detail: The test works by maintaining a local clone of https://hg.mozilla.org/l10n/gecko-strings/ in your ~/.mozbuild, updating it after two days. So if you see something cloning while you mach lint, that's intended. This comes with the benefit that we're only checking against strings we actually expose to localizers. It also checks for string IDs we might not use in central, but in beta or release. Which also makes this test the right thing to check for landings on beta or release branches. Thanks to Andrew Halberstadt for bearing with me through all the refactors while he was trying to help me land this. There are a few next steps I already know about: For one, run this more widely across mozilla projects, for example on our newer Android apps [2]. I also have a local branch for ' vs ’, but it's still in its infancy. If you find issues and/or want enhancements, please file a bug in linting and CC me. Axel [1] https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_tutorial.html#pseudolocalization [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1548500 ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Intent to unship: hasFeature() method on some SVG elements
The hasFeature() method on some SVG elements comes from SVG 1.0 and was intended to be used as part of SVG's extension mechanisms. This function never returned anything other than false in browser implementations, and was removed in SVG 2. Chrome no longer supports this, although WebKit still does. I don't anticipate any issue removing this. The removal is being done in https://bugzilla.mozilla.org/show_bug.cgi?id=1133175. Thanks, Cameron ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
nsIPresShell has gone
Hi, everybody. Finally, I completely got rid of nsIPresShell from our tree. https://bugzilla.mozilla.org/show_bug.cgi?id=253889 If you need to access presentation shell, treat mozilla::PresShell directly (note that in some classes like nsIFrame and its subclasses, `mozilla::` prefix is necessary due to the class has a method `PresShell()`). If you need to public `enum` or `struct` of `nsIPresShell`, they have been moved to `mozilla` namespace in `PresShellForwards.h`. https://searchfox.org/mozilla-central/source/layout/base/PresShellForwards.h I guess that this fix does not devirtualize the methods of them newly, they perhaps have already been done by compiler. -- Masayuki Nakano Working on DOM, Events, editor and IME handling at Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
e10s tooling (Was Re: Lack of browser mochitests in non-e10s configuration and support for turning off e10s on desktop going forward)
On Wed, Apr 24, 2019 at 11:40 PM Jean-Yves Avenard wrote: > > Before non-e10s support is removed, I'd love to see better > development/debugging tools, particularly on Windows added to help our > workflow. Was there anything in particular that you had in mind? - Aaron > > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: nsIPresShell has gone
At long last - thank you! On Thu, May 2, 2019 at 7:20 PM Cameron McCormack wrote: > On Fri, May 3, 2019, at 11:44 AM, Masayuki Nakano wrote: > > Finally, I completely got rid of nsIPresShell from our tree. > > https://bugzilla.mozilla.org/show_bug.cgi?id=253889 > > Thank you for doing this, Masayuki! > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: nsIPresShell has gone
On Fri, May 3, 2019, at 11:44 AM, Masayuki Nakano wrote: > Finally, I completely got rid of nsIPresShell from our tree. > https://bugzilla.mozilla.org/show_bug.cgi?id=253889 Thank you for doing this, Masayuki! ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
