Re: [dev-servo] Rustfmt now checked on CI
Directly run rustfmt on the file, with `rustfmt foo.rs`. you may need to install it with `rustup component add rustfmt` On Thu, Nov 8, 2018, 6:50 PM Avanthikaa Ravichandran We are working on the media crate for servo and we were asked to run the > rustfmt to format the code. However, in the servo/media repo that we worked > on, we cannot run the ./mach command. Are we expected to integrate it with > the main servo repository? How do we run rustfmt on our file otherwise? > > Thank you > > On Wed, Nov 7, 2018, 2:25 PM Keith Yeung > > Woohoo! Great work everyone! > > On Wed, Nov 7, 2018 at 11:22 AM Josh Bowman-Matthews > > wrote: > > > > > > Thank you for all your help in formatting the existing code and > enabling > > > rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we > > > now have consistent formatting with the rest of the Rust ecosystem. > > > > > > Cheers, > > > Josh > > > > > > On 11/7/18 1:51 PM, Pyfisch wrote: > > > > Hi Everyone, > > > > > > > > Servo source code is now formatted with rustfmt [1]. Style checking > is > > > > part of ./mach test-tidy and enforced on CI. To automatically format > > > > your code run ./mach fmt before commiting. Import order was changed > but > > > > ./mach fmt will fix > > > > any issues. Please ask any questions you may have. > > > > > > > > Regards > > > > Pyfisch > > > > > > > > [1]: https://github.com/servo/servo/pull/22126 > > > > > > > > > > > > > > ___ > > > dev-servo mailing list > > > dev-servo@lists.mozilla.org > > > https://lists.mozilla.org/listinfo/dev-servo > > ___ > > dev-servo mailing list > > dev-servo@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-servo > > > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Rustfmt now checked on CI
We are working on the media crate for servo and we were asked to run the rustfmt to format the code. However, in the servo/media repo that we worked on, we cannot run the ./mach command. Are we expected to integrate it with the main servo repository? How do we run rustfmt on our file otherwise? Thank you On Wed, Nov 7, 2018, 2:25 PM Keith Yeung Woohoo! Great work everyone! > On Wed, Nov 7, 2018 at 11:22 AM Josh Bowman-Matthews > wrote: > > > > Thank you for all your help in formatting the existing code and enabling > > rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we > > now have consistent formatting with the rest of the Rust ecosystem. > > > > Cheers, > > Josh > > > > On 11/7/18 1:51 PM, Pyfisch wrote: > > > Hi Everyone, > > > > > > Servo source code is now formatted with rustfmt [1]. Style checking is > > > part of ./mach test-tidy and enforced on CI. To automatically format > > > your code run ./mach fmt before commiting. Import order was changed but > > > ./mach fmt will fix > > > any issues. Please ask any questions you may have. > > > > > > Regards > > > Pyfisch > > > > > > [1]: https://github.com/servo/servo/pull/22126 > > > > > > > > > > ___ > > dev-servo mailing list > > dev-servo@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-servo > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Rustfmt now checked on CI
Woohoo! Great work everyone! On Wed, Nov 7, 2018 at 11:22 AM Josh Bowman-Matthews wrote: > > Thank you for all your help in formatting the existing code and enabling > rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we > now have consistent formatting with the rest of the Rust ecosystem. > > Cheers, > Josh > > On 11/7/18 1:51 PM, Pyfisch wrote: > > Hi Everyone, > > > > Servo source code is now formatted with rustfmt [1]. Style checking is > > part of ./mach test-tidy and enforced on CI. To automatically format > > your code run ./mach fmt before commiting. Import order was changed but > > ./mach fmt will fix > > any issues. Please ask any questions you may have. > > > > Regards > > Pyfisch > > > > [1]: https://github.com/servo/servo/pull/22126 > > > > > > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Rustfmt now checked on CI
Thank you for all your help in formatting the existing code and enabling rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we now have consistent formatting with the rest of the Rust ecosystem. Cheers, Josh On 11/7/18 1:51 PM, Pyfisch wrote: Hi Everyone, Servo source code is now formatted with rustfmt [1]. Style checking is part of ./mach test-tidy and enforced on CI. To automatically format your code run ./mach fmt before commiting. Import order was changed but ./mach fmt will fix any issues. Please ask any questions you may have. Regards Pyfisch [1]: https://github.com/servo/servo/pull/22126 ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
